Fix creation of composite union type predicates by ahejlsberg · Pull Request #54169 · microsoft/TypeScript

Anders Hejlsberg (ahejlsberg) · 2023-05-07T15:33:12Z

Anders Hejlsberg (ahejlsberg) · 2023-05-07T15:34:53Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this inline
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test faster
TypeScript Bot (@typescript-bot) test top100

TypeScript Bot (typescript-bot) · 2023-05-07T15:34:56Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at 98c0460. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-05-07T15:34:56Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the abridged perf test suite on this PR at 98c0460. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-05-07T15:34:56Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based user code test suite on this PR at 98c0460. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-05-07T15:34:56Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at 98c0460. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-05-07T15:34:56Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based top-repos suite on this PR at 98c0460. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-05-07T16:03:53Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the user test suite comparing main and refs/pull/54169/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-05-07T17:23:06Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the top-repos suite comparing main and refs/pull/54169/merge:

Something interesting changed - please have a look.

Details

microsoft/vscode

4 of 53 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

error TS2322: Type 'ITextModel | null' is not assignable to type 'ITextModel | undefined'.
- src/vs/workbench/services/textfile/browser/textFileService.ts#L510

TypeScript Bot (typescript-bot) · 2023-05-07T17:42:06Z

Hey Anders Hejlsberg (@ahejlsberg), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

Anders Hejlsberg (ahejlsberg) · 2023-05-08T22:37:15Z

The new error in the vscode project is precisely an example of relying on the issue we're fixing: A union of two function types where one is a type predicate and the other is just a boolean returning function. It definitely isn't sound to rely on the boolean function proving or disproving anything, so the new error is correct.

TypeScript Bot (typescript-bot) · 2023-05-09T05:57:23Z

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..54169

_Metric	_main	₅₄₁₆₉	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,352k (± 0.01%)}	_{365,349k (± 0.00%)}	_~	_365,329k	_365,379k	_{p=0.810 n=6}
_{Parse Time}	_{3.55s (± 0.48%)}	_{3.55s (± 0.49%)}	_~	_3.54s	_3.58s	_{p=0.737 n=6}
_{Bind Time}	_{1.17s (± 0.54%)}	_{1.17s (± 0.54%)}	_~	_1.16s	_1.18s	_{p=1.000 n=6}
_{Check Time}	_{9.56s (± 0.37%)}	_{9.58s (± 0.40%)}	_~	_9.54s	_9.62s	_{p=0.418 n=6}
_{Emit Time}	_{7.91s (± 0.34%)}	_{7.94s (± 0.38%)}	_~	_7.91s	_7.98s	_{p=0.077 n=6}
_{Total Time}	_{22.19s (± 0.26%)}	_{22.25s (± 0.28%)}	_~	_22.19s	_22.35s	_{p=0.227 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,810k (± 0.02%)}	_{192,710k (± 0.08%)}	_~	_192,416k	_192,853k	_{p=0.093 n=6}
_{Parse Time}	_{1.61s (± 0.96%)}	_{1.59s (± 1.75%)}	_~	_1.54s	_1.62s	_{p=0.220 n=6}
_{Bind Time}	_{0.82s (± 0.63%)}	_{0.83s (± 0.91%)}	_~	_0.82s	_0.84s	_{p=0.247 n=6}
_{Check Time}	_{10.29s (± 0.43%)}	_{10.28s (± 0.39%)}	_~	_10.24s	_10.33s	_{p=0.748 n=6}
_{Emit Time}	_{3.02s (± 0.65%)}	_{3.02s (± 0.92%)}	_~	_3.00s	_3.07s	_{p=0.803 n=6}
_{Total Time}	_{15.74s (± 0.21%)}	_{15.72s (± 0.46%)}	_~	_15.61s	_15.82s	_{p=0.809 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,862k (± 0.00%)}	_{345,863k (± 0.01%)}	_~	_345,839k	_345,893k	_{p=0.810 n=6}
_{Parse Time}	_{2.72s (± 0.44%)}	_{2.73s (± 0.54%)}	_~	_2.71s	_2.75s	_{p=0.623 n=6}
_{Bind Time}	_{1.08s (± 0.77%)}	_{1.08s (± 0.70%)}	_~	_1.07s	_1.09s	_{p=0.432 n=6}
_{Check Time}	_{7.88s (± 0.72%)}	_{7.87s (± 0.42%)}	_~	_7.82s	_7.91s	_{p=0.808 n=6}
_{Emit Time}	_{4.47s (± 0.59%)}	_{4.45s (± 0.49%)}	_~	_4.41s	_4.47s	_{p=0.090 n=6}
_{Total Time}	_{16.15s (± 0.38%)}	_{16.13s (± 0.25%)}	_~	_16.09s	_16.19s	_{p=0.421 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,105k (± 0.01%)}	_{300,100k (± 0.01%)}	_~	_300,078k	_300,126k	_{p=0.689 n=6}
_{Parse Time}	_{2.16s (± 0.64%)}	_{2.16s (± 0.72%)}	_~	_2.14s	_2.18s	_{p=0.676 n=6}
_{Bind Time}	_{1.23s (± 0.66%)}	_{1.24s (± 0.79%)}	_~	_1.23s	_1.25s	_{p=0.498 n=6}
_{Check Time}	_{7.27s (± 0.45%)}	_{7.29s (± 0.48%)}	_~	_7.23s	_7.33s	_{p=0.421 n=6}
_{Emit Time}	_{4.34s (± 0.89%)}	_{4.38s (± 0.91%)}	_~	_4.33s	_4.42s	_{p=0.334 n=6}
_{Total Time}	_{15.00s (± 0.51%)}	_{15.06s (± 0.34%)}	_~	_14.97s	_15.11s	_{p=0.196 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,623k (± 0.01%)}	_{481,595k (± 0.01%)}	_~	_481,534k	_481,636k	_{p=0.336 n=6}
_{Parse Time}	_{3.24s (± 0.28%)}	_{3.23s (± 0.47%)}	_~	_3.22s	_3.26s	_{p=0.458 n=6}
_{Bind Time}	_{0.94s (± 0.80%)}	_{0.94s (± 0.55%)}	_~	_0.93s	_0.94s	_{p=0.784 n=6}
_{Check Time}	_{17.86s (± 0.47%)}	_{17.85s (± 0.53%)}	_~	_17.71s	_17.96s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.04s (± 0.40%)}	_{22.02s (± 0.47%)}	_~	_21.86s	_22.12s	_{p=0.872 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{560,369k (± 0.02%)}	_{560,377k (± 0.02%)}	_~	_560,279k	_560,519k	_{p=0.810 n=6}
_{Parse Time}	_{4.00s (± 0.31%)}	_{4.00s (± 0.16%)}	_~	_3.99s	_4.01s	_{p=0.591 n=6}
_{Bind Time}	_{1.76s (± 0.51%)}	_{1.76s (± 0.66%)}	_~	_1.75s	_1.78s	_{p=0.933 n=6}
_{Check Time}	_{3.06s (± 0.67%)}	_{3.06s (± 0.34%)}	_~	_3.04s	_3.07s	_{p=0.802 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 4.45%)}	_~	_0.09s	_0.10s	_{p=0.405 n=6}
_{Total Time}	_{8.92s (± 0.31%)}	_{8.91s (± 0.27%)}	_~	_8.88s	_8.94s	_{p=0.624 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₁₆₉	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

Daniel Rosenwasser (DanielRosenwasser) · 2023-05-26T17:28:38Z

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.1

TypeScript Bot (typescript-bot) · 2023-05-26T17:28:42Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the task to cherry-pick this into release-5.1 on this PR at 98c0460. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-05-26T17:35:40Z

Hey Daniel Rosenwasser (@DanielRosenwasser), I've opened #54412 for you.

Component commits: a54709c Revise creation of composite union/intersection type predicates 98c0460 Add tests

…e-5.1 (#54412) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

Anders Hejlsberg (ahejlsberg) added 2 commits May 7, 2023 08:07

Revise creation of composite union/intersection type predicates
a54709c

Add tests
98c0460

TypeScript Bot (typescript-bot) assigned Anders Hejlsberg (ahejlsberg)May 7, 2023

TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 7, 2023

Anders Hejlsberg (ahejlsberg) requested a review from Ryan Cavanaugh (RyanCavanaugh)May 7, 2023 15:34

Anders Hejlsberg (ahejlsberg) requested review from Daniel Rosenwasser (DanielRosenwasser) and Jake Bailey (jakebailey)May 8, 2023 22:37

Jake Bailey (jakebailey) approved these changes May 9, 2023
View reviewed changes

Anders Hejlsberg (ahejlsberg) merged commit 215fe6e into mainMay 19, 2023

Anders Hejlsberg (ahejlsberg) deleted the fix54143 branch May 19, 2023 20:15

TypeScript Bot (typescript-bot) mentioned this pull request May 26, 2023
🤖 Pick PR #54169 (Fix creation of composite union typ...) into release-5.1 #54412
Merged

TypeScript Bot (typescript-bot) pushed a commit to typescript-bot/TypeScript that referenced this pull request May 26, 2023
Cherry-pick PRmicrosoft#54169into release-5.1
0bed9fe
Component commits: a54709c Revise creation of composite union/intersection type predicates 98c0460 Add tests

Daniel Rosenwasser (DanielRosenwasser) pushed a commit that referenced this pull request May 29, 2023
🤖 Pick PR#54169(Fix creation of composite union typ...) into releas…
a38e4f5
…e-5.1 (#54412) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

Noel Kim (nnnnoel) mentioned this pull request Sep 30, 2025
Cannot assert about union type of assertions #62513
Closed

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Uh oh!

Conversation

Anders Hejlsberg (ahejlsberg) commented May 7, 2023

Uh oh!

Anders Hejlsberg (ahejlsberg) commented May 7, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented May 7, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 7, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 7, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 7, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 7, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 7, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented May 7, 2023

microsoft/vscode

src/tsconfig.tsec.json

Uh oh!

TypeScript Bot (typescript-bot) commented May 7, 2023

Uh oh!

Anders Hejlsberg (ahejlsberg) commented May 8, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented May 9, 2023

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented May 26, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented May 26, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TypeScript Bot (typescript-bot) commented May 7, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented May 7, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented May 7, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented May 7, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented May 7, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented May 26, 2023•
edited
Loading