Skip to content

Improve error for unclosed imports and exports - #54634

Merged
Nathan Shively-Sanders (sandersn) merged 3 commits into
microsoft:mainfrom
Jack-Works:improve-error-for-unclosed-import-export
Jun 29, 2023
Merged

Improve error for unclosed imports and exports#54634
Nathan Shively-Sanders (sandersn) merged 3 commits into
microsoft:mainfrom
Jack-Works:improve-error-for-unclosed-import-export

Conversation

@Jack-Works

@Jack-WorksJack Works (Jack-Works) commented Jun 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

this fix is picked from #49297
before:
image

after:
image

@typescript-botTypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 13, 2023
@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@sandersn

Nathan Shively-Sanders (sandersn) commented Jun 28, 2023

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 28, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Nathan Shively-Sanders (@sandersn), I've started to run the perf test suite on this PR at 27d107e. You can monitor the build here.

Update: The results are in!

sandersn
Nathan Shively-Sanders (sandersn) approved these changes Jun 28, 2023
View reviewed changes

@sandersnNathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as long as the lookahead doesn't hurt performance (and I doubt it will since ParsingContext.ImportOrExportSpecifiers doesn't come up much)

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 28, 2023

Copy link
Copy Markdown
Contributor

Nathan Shively-Sanders (@sandersn)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..54634
Metricmain54634DeltaBestWorstp-value
Angular - node (v18.10.0, x64)
Memory used366,753k (± 0.01%)366,748k (± 0.01%)~366,710k366,777kp=0.810 n=6
Parse Time3.46s (± 0.60%)3.40s (± 0.51%)-0.06s (- 1.69%)3.38s3.43sp=0.008 n=6
Bind Time1.12s (± 0.67%)1.11s (± 0.75%)~1.11s1.13sp=0.172 n=6
Check Time8.88s (± 0.44%)8.82s (± 0.19%)-0.06s (- 0.73%)8.80s8.84sp=0.013 n=6
Emit Time7.54s (± 0.90%)7.50s (± 0.35%)~7.47s7.53sp=0.335 n=6
Total Time21.00s (± 0.52%)20.83s (± 0.19%)-0.17s (- 0.81%)20.77s20.88sp=0.013 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used193,823k (± 1.63%)190,965k (± 0.02%)~190,930k191,000kp=0.378 n=6
Parse Time1.50s (± 0.91%)1.49s (± 0.55%)-0.02s (- 1.22%)1.48s1.50sp=0.032 n=6
Bind Time0.77s (± 0.00%)0.77s (± 0.72%)~0.76s0.77sp=0.071 n=6
Check Time9.49s (± 0.82%)9.46s (± 0.85%)~9.39s9.60sp=0.373 n=6
Emit Time2.76s (± 0.68%)2.77s (± 1.31%)~2.73s2.83sp=0.747 n=6
Total Time14.52s (± 0.45%)14.48s (± 0.65%)~14.38s14.64sp=0.418 n=6
Monaco - node (v18.10.0, x64)
Memory used346,806k (± 0.01%)346,793k (± 0.01%)~346,773k346,827kp=0.689 n=6
Parse Time2.60s (± 0.97%)2.57s (± 0.58%)~2.55s2.59sp=0.086 n=6
Bind Time1.01s (± 1.25%)1.00s (± 0.63%)~0.99s1.01sp=0.090 n=6
Check Time7.22s (± 0.48%)7.16s (± 0.26%)-0.06s (- 0.85%)7.14s7.19sp=0.010 n=6
Emit Time4.26s (± 1.01%)4.26s (± 0.58%)~4.23s4.30sp=1.000 n=6
Total Time15.10s (± 0.64%)15.00s (± 0.24%)~14.96s15.06sp=0.092 n=6
TFS - node (v18.10.0, x64)
Memory used300,881k (± 0.01%)300,877k (± 0.00%)~300,865k300,889kp=0.748 n=6
Parse Time2.09s (± 1.16%)2.06s (± 0.89%)~2.04s2.09sp=0.051 n=6
Bind Time1.14s (± 0.73%)1.13s (± 0.67%)-0.02s (- 1.46%)1.12s1.14sp=0.009 n=6
Check Time6.68s (± 0.21%)6.67s (± 0.47%)~6.65s6.73sp=0.145 n=6
Emit Time3.86s (± 0.69%)3.85s (± 1.11%)~3.81s3.93sp=0.460 n=6
Total Time13.78s (± 0.20%)13.71s (± 0.32%)-0.08s (- 0.54%)13.63s13.76sp=0.010 n=6
material-ui - node (v18.10.0, x64)
Memory used482,455k (± 0.01%)482,438k (± 0.01%)~482,326k482,511kp=1.000 n=6
Parse Time3.13s (± 0.44%)3.11s (± 0.44%)-0.02s (- 0.64%)3.10s3.14sp=0.042 n=6
Bind Time0.92s (± 1.44%)0.91s (± 1.32%)~0.90s0.93sp=0.240 n=6
Check Time17.44s (± 0.43%)17.25s (± 0.42%)-0.19s (- 1.09%)17.19s17.38sp=0.010 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time21.50s (± 0.38%)21.28s (± 0.28%)-0.22s (- 1.02%)21.21s21.38sp=0.005 n=6
xstate - node (v18.10.0, x64)
Memory used563,567k (± 0.02%)563,534k (± 0.02%)~563,484k563,703kp=0.378 n=6
Parse Time3.85s (± 0.75%)3.84s (± 0.48%)~3.82s3.87sp=0.870 n=6
Bind Time1.64s (± 0.50%)1.63s (± 0.60%)-0.02s (- 0.91%)1.62s1.64sp=0.022 n=6
Check Time2.80s (± 0.93%)2.80s (± 0.95%)~2.75s2.83sp=0.808 n=6
Emit Time0.08s (± 0.00%)0.08s (± 0.00%)~0.08s0.08sp=1.000 n=6
Total Time8.37s (± 0.42%)8.34s (± 0.28%)~8.31s8.37sp=0.108 n=6
Angular - node (v16.17.1, x64)
Memory used366,124k (± 0.01%)366,136k (± 0.01%)~366,103k366,196kp=0.810 n=6
Parse Time3.58s (± 0.23%)3.57s (± 0.25%)-0.01s (- 0.42%)3.56s3.58sp=0.021 n=6
Bind Time1.18s (± 0.44%)1.18s (± 0.44%)~1.17s1.18sp=0.069 n=6
Check Time9.65s (± 0.57%)9.64s (± 0.59%)~9.57s9.73sp=0.809 n=6
Emit Time8.01s (± 0.83%)7.96s (± 0.15%)~7.95s7.98sp=0.244 n=6
Total Time22.42s (± 0.55%)22.34s (± 0.28%)~22.28s22.44sp=0.296 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used192,825k (± 0.02%)192,801k (± 0.02%)~192,713k192,836kp=0.296 n=6
Parse Time1.60s (± 1.07%)1.57s (± 1.51%)-0.03s (- 1.98%)1.54s1.60sp=0.043 n=6
Bind Time0.83s (± 0.62%)0.81s (± 0.63%)-0.01s (- 1.61%)0.81s0.82sp=0.009 n=6
Check Time10.17s (± 0.56%)10.13s (± 0.36%)~10.09s10.17sp=0.687 n=6
Emit Time3.04s (± 1.18%)3.01s (± 0.59%)~2.98s3.03sp=0.064 n=6
Total Time15.63s (± 0.54%)15.53s (± 0.39%)-0.10s (- 0.67%)15.44s15.59sp=0.020 n=6
Monaco - node (v16.17.1, x64)
Memory used346,064k (± 0.01%)346,069k (± 0.00%)~346,051k346,096kp=1.000 n=6
Parse Time2.74s (± 0.45%)2.72s (± 0.00%)-0.02s (- 0.91%)2.72s2.72sp=0.003 n=6
Bind Time1.09s (± 0.00%)1.09s (± 0.75%)~1.08s1.10sp=0.290 n=6
Check Time7.89s (± 0.38%)7.86s (± 0.33%)-0.04s (- 0.51%)7.82s7.88sp=0.030 n=6
Emit Time4.48s (± 0.61%)4.45s (± 0.83%)~4.41s4.52sp=0.104 n=6
Total Time16.21s (± 0.27%)16.11s (± 0.32%)-0.09s (- 0.59%)16.06s16.20sp=0.020 n=6
TFS - node (v16.17.1, x64)
Memory used300,215k (± 0.01%)300,213k (± 0.01%)~300,195k300,232kp=0.689 n=6
Parse Time2.19s (± 0.75%)2.17s (± 0.63%)-0.02s (- 0.91%)2.16s2.20sp=0.042 n=6
Bind Time1.24s (± 0.83%)1.24s (± 0.66%)~1.23s1.25sp=0.270 n=6
Check Time7.35s (± 0.61%)7.31s (± 0.35%)~7.27s7.34sp=0.106 n=6
Emit Time4.35s (± 0.51%)4.34s (± 0.27%)~4.32s4.35sp=0.326 n=6
Total Time15.14s (± 0.59%)15.05s (± 0.21%)~15.02s15.10sp=0.064 n=6
material-ui - node (v16.17.1, x64)
Memory used481,706k (± 0.01%)481,688k (± 0.01%)~481,641k481,746kp=0.378 n=6
Parse Time3.27s (± 0.27%)3.26s (± 0.19%)~3.25s3.27sp=0.070 n=6
Bind Time0.96s (± 0.54%)0.95s (± 0.54%)-0.01s (- 1.05%)0.94s0.95sp=0.018 n=6
Check Time18.34s (± 0.65%)18.21s (± 0.46%)-0.12s (- 0.67%)18.08s18.34sp=0.037 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time22.56s (± 0.56%)22.43s (± 0.36%)-0.14s (- 0.61%)22.31s22.56sp=0.030 n=6
xstate - node (v16.17.1, x64)
Memory used561,181k (± 0.02%)561,216k (± 0.02%)~561,059k561,383kp=0.810 n=6
Parse Time4.03s (± 0.44%)3.99s (± 0.27%)-0.04s (- 0.99%)3.98s4.01sp=0.008 n=6
Bind Time1.75s (± 0.60%)1.74s (± 1.07%)~1.72s1.77sp=0.251 n=6
Check Time3.06s (± 0.48%)3.05s (± 0.45%)~3.02s3.06sp=0.304 n=6
Emit Time0.09s (± 4.45%)0.09s (± 5.53%)~0.09s0.10sp=1.000 n=6
Total Time8.93s (± 0.15%)8.86s (± 0.31%)-0.07s (- 0.77%)8.83s8.90sp=0.005 n=6
Angular - node (v14.21.3, x64)
Memory used360,100k (± 0.01%)360,106k (± 0.01%)~360,074k360,155kp=0.873 n=6
Parse Time3.68s (± 0.53%)3.69s (± 0.63%)~3.66s3.72sp=0.328 n=6
Bind Time1.23s (± 0.98%)1.22s (± 0.62%)-0.02s (- 1.22%)1.21s1.23sp=0.045 n=6
Check Time10.11s (± 0.38%)10.08s (± 0.52%)~10.01s10.14sp=0.466 n=6
Emit Time8.42s (± 0.68%)8.33s (± 0.31%)-0.09s (- 1.05%)8.29s8.36sp=0.037 n=6
Total Time23.43s (± 0.33%)23.31s (± 0.32%)-0.12s (- 0.52%)23.20s23.43sp=0.020 n=6
Compiler-Unions - node (v14.21.3, x64)
Memory used188,155k (± 0.01%)188,126k (± 0.03%)~188,035k188,180kp=0.377 n=6
Parse Time1.63s (± 0.50%)1.62s (± 0.65%)~1.60s1.63sp=0.078 n=6
Bind Time0.85s (± 0.00%)0.84s (± 0.48%)-0.01s (- 0.98%)0.84s0.85sp=0.007 n=6
Check Time10.34s (± 0.45%)10.24s (± 0.56%)-0.09s (- 0.89%)10.16s10.31sp=0.016 n=6
Emit Time3.14s (± 0.81%)3.14s (± 1.03%)~3.11s3.19sp=0.935 n=6
Total Time15.95s (± 0.33%)15.85s (± 0.51%)-0.11s (- 0.68%)15.72s15.91sp=0.030 n=6
Monaco - node (v14.21.3, x64)
Memory used341,191k (± 0.01%)341,182k (± 0.00%)~341,167k341,193kp=0.936 n=6
Parse Time2.83s (± 0.55%)2.81s (± 0.27%)~2.80s2.82sp=0.050 n=6
Bind Time1.11s (± 0.73%)1.12s (± 0.67%)~1.11s1.13sp=0.082 n=6
Check Time8.25s (± 0.37%)8.19s (± 0.58%)~8.14s8.27sp=0.077 n=6
Emit Time4.71s (± 0.78%)4.70s (± 0.99%)~4.65s4.78sp=0.573 n=6
Total Time16.90s (± 0.34%)16.82s (± 0.47%)~16.71s16.94sp=0.075 n=6
TFS - node (v14.21.3, x64)
Memory used295,306k (± 0.00%)295,309k (± 0.00%)~295,303k295,313kp=0.422 n=6
Parse Time2.41s (± 0.93%)2.38s (± 0.93%)~2.36s2.41sp=0.062 n=6
Bind Time1.07s (± 0.48%)1.07s (± 0.48%)~1.06s1.07sp=1.000 n=6
Check Time7.65s (± 0.36%)7.63s (± 0.49%)~7.58s7.69sp=0.469 n=6
Emit Time4.31s (± 0.78%)4.29s (± 0.50%)~4.26s4.32sp=0.295 n=6
Total Time15.43s (± 0.46%)15.37s (± 0.39%)~15.31s15.48sp=0.260 n=6
material-ui - node (v14.21.3, x64)
Memory used477,166k (± 0.00%)477,165k (± 0.00%)~477,143k477,188kp=1.000 n=6
Parse Time3.36s (± 0.42%)3.32s (± 0.25%)-0.04s (- 1.09%)3.31s3.33sp=0.005 n=6
Bind Time1.01s (± 0.00%)1.00s (± 0.00%)-0.01s (- 0.99%)1.00s1.00sp=0.001 n=6
Check Time19.40s (± 0.72%)19.16s (± 0.35%)-0.24s (- 1.25%)19.06s19.24sp=0.008 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time23.77s (± 0.60%)23.48s (± 0.33%)-0.29s (- 1.23%)23.37s23.57sp=0.005 n=6
xstate - node (v14.21.3, x64)
Memory used550,174k (± 0.01%)550,179k (± 0.00%)~550,155k550,192kp=0.298 n=6
Parse Time4.25s (± 0.18%)4.22s (± 0.38%)-0.03s (- 0.71%)4.20s4.24sp=0.007 n=6
Bind Time1.68s (± 1.15%)1.67s (± 0.59%)~1.65s1.68sp=0.156 n=6
Check Time3.14s (± 0.66%)3.13s (± 0.47%)~3.10s3.14sp=0.871 n=6
Emit Time0.09s (± 0.00%)0.09s (± 0.00%)~0.09s0.09sp=1.000 n=6
Total Time9.15s (± 0.32%)9.11s (± 0.27%)-0.05s (- 0.51%)9.07s9.14sp=0.030 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.21.3, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.21.3, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.21.3, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.21.3, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.21.3, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.21.3, x64)
BenchmarkNameIterations
Current546346
Baselinemain6

TSServer

Comparison Report - main..54634
Metricmain54634DeltaBestWorstp-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,575ms (± 0.93%)2,542ms (± 0.47%)-33ms (- 1.27%)2,527ms2,556msp=0.020 n=6
Req 2 - geterr5,373ms (± 0.79%)5,352ms (± 0.70%)~5,311ms5,416msp=0.298 n=6
Req 3 - references342ms (± 1.15%)342ms (± 0.86%)~337ms346msp=0.628 n=6
Req 4 - navto288ms (± 0.42%)286ms (± 0.36%)~285ms288msp=0.084 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo82ms (± 3.73%)83ms (± 2.15%)~81ms85msp=0.934 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,655ms (± 1.15%)2,654ms (± 0.98%)~2,609ms2,678msp=0.575 n=6
Req 2 - geterr4,136ms (± 1.98%)4,098ms (± 0.32%)~4,085ms4,117msp=0.295 n=6
Req 3 - references349ms (± 0.97%)349ms (± 0.47%)~346ms350msp=0.747 n=6
Req 4 - navto287ms (± 0.41%)287ms (± 0.51%)~286ms290msp=0.666 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo71ms (± 1.26%)70ms (± 0.73%)~70ms71msp=0.190 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen3,112ms (± 0.40%)3,100ms (± 0.44%)~3,080ms3,118msp=0.148 n=6
Req 2 - geterr1,604ms (± 0.64%)1,593ms (± 0.78%)~1,578ms1,610msp=0.172 n=6
Req 3 - references112ms (± 0.92%)113ms (± 1.07%)~111ms114msp=0.675 n=6
Req 4 - navto370ms (± 0.44%)370ms (± 0.91%)~368ms377msp=0.514 n=6
Req 5 - completionInfo count2,872 (± 0.00%)2,872 (± 0.00%)~2,8722,872p=1.000 n=6
Req 5 - completionInfo378ms (± 1.50%)376ms (± 2.10%)~363ms383msp=0.571 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,669ms (± 1.42%)2,637ms (± 0.66%)~2,619ms2,664msp=0.092 n=6
Req 2 - geterr5,988ms (± 1.75%)6,023ms (± 0.30%)~6,004ms6,054msp=1.000 n=6
Req 3 - references354ms (± 0.43%)354ms (± 0.59%)~351ms356msp=0.807 n=6
Req 4 - navto285ms (± 0.69%)288ms (± 1.75%)~281ms294msp=0.465 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo89ms (± 8.89%)93ms (± 0.59%)~92ms93msp=0.476 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,853ms (± 0.69%)2,826ms (± 0.44%)-27ms (- 0.96%)2,813ms2,849msp=0.045 n=6
Req 2 - geterr4,680ms (± 0.37%)4,675ms (± 0.36%)~4,661ms4,703msp=0.572 n=6
Req 3 - references365ms (± 0.48%)364ms (± 0.68%)~361ms368msp=0.373 n=6
Req 4 - navto285ms (± 0.52%)283ms (± 0.99%)~278ms286msp=0.088 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo75ms (± 1.19%)75ms (± 0.54%)~75ms76msp=0.787 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen3,266ms (± 0.73%)3,230ms (± 0.20%)-35ms (- 1.08%)3,221ms3,238msp=0.045 n=6
Req 2 - geterr1,751ms (± 1.13%)1,734ms (± 1.49%)~1,693ms1,757msp=0.630 n=6
Req 3 - references127ms (± 6.77%)126ms (± 6.65%)~121ms143msp=0.655 n=6
Req 4 - navto357ms (± 0.72%)353ms (± 0.34%)-4ms (- 1.17%)351ms354msp=0.015 n=6
Req 5 - completionInfo count2,872 (± 0.00%)2,872 (± 0.00%)~2,8722,872p=1.000 n=6
Req 5 - completionInfo410ms (± 1.80%)409ms (± 1.48%)~401ms418msp=1.000 n=6
Compiler-UnionsTSServer - node (v14.21.3, x64)
Req 1 - updateOpen2,822ms (± 0.59%)2,791ms (± 0.68%)-31ms (- 1.09%)2,766ms2,816msp=0.025 n=6
Req 2 - geterr6,211ms (± 0.45%)6,187ms (± 0.35%)~6,155ms6,212msp=0.128 n=6
Req 3 - references361ms (± 0.67%)362ms (± 0.87%)~357ms366msp=0.685 n=6
Req 4 - navto292ms (± 0.40%)291ms (± 0.19%)-1ms (- 0.46%)290ms291msp=0.025 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo102ms (± 6.17%)104ms (± 0.50%)~103ms104msp=0.928 n=6
CompilerTSServer - node (v14.21.3, x64)
Req 1 - updateOpen2,990ms (± 0.45%)2,972ms (± 0.41%)-19ms (- 0.62%)2,951ms2,986msp=0.031 n=6
Req 2 - geterr4,556ms (± 0.61%)4,539ms (± 0.85%)~4,487ms4,585msp=0.575 n=6
Req 3 - references377ms (± 0.52%)377ms (± 0.36%)~375ms379msp=1.000 n=6
Req 4 - navto300ms (± 0.49%)298ms (± 0.46%)~296ms300msp=0.073 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo77ms (± 0.53%)77ms (± 2.54%)~74ms80msp=0.245 n=6
xstateTSServer - node (v14.21.3, x64)
Req 1 - updateOpen3,491ms (± 0.72%)3,475ms (± 0.91%)~3,425ms3,505msp=0.298 n=6
Req 2 - geterr1,856ms (± 1.09%)1,853ms (± 1.31%)~1,816ms1,886msp=0.936 n=6
Req 3 - references152ms (± 6.75%)151ms (± 8.53%)~132ms160msp=0.571 n=6
Req 4 - navto397ms (± 0.37%)396ms (± 0.80%)~392ms401msp=0.629 n=6
Req 5 - completionInfo count2,872 (± 0.00%)2,872 (± 0.00%)~2,8722,872p=1.000 n=6
Req 5 - completionInfo432ms (± 2.81%)436ms (± 1.26%)~427ms443msp=0.297 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.21.3, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.21.3, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.21.3, x64)
BenchmarkNameIterations
Current546346
Baselinemain6

Startup

Comparison Report - main..54634
Metricmain54634DeltaBestWorstp-value
tsc-startup - node (v16.17.1, x64)
Execution time143.72ms (± 0.39%)142.81ms (± 0.21%)-0.90ms (- 0.63%)141.86ms146.12msp=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time225.73ms (± 0.51%)223.39ms (± 0.44%)-2.34ms (- 1.04%)220.88ms230.71msp=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time226.13ms (± 0.40%)227.39ms (± 0.24%)+1.26ms (+ 0.56%)223.20ms232.36msp=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time207.95ms (± 0.41%)207.13ms (± 0.41%)-0.82ms (- 0.39%)204.54ms215.71msp=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
BenchmarkNameIterations
Current546346
Baselinemain6

Developer Information:

Download Benchmark

@sandersn
Nathan Shively-Sanders (sandersn) merged commit ed5008d into microsoft:mainJun 29, 2023
@Jack-Works
Jack Works (Jack-Works) deleted the improve-error-for-unclosed-import-export branch June 30, 2023 08:48
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersnNathan Shively-Sanders (sandersn)sandersn approved these changes
@gabrittoGabriela Araujo Britto (gabritto)Awaiting requested review from gabritto

Assignees

@sandersnNathan Shively-Sanders (sandersn)

Labels

For Uncommitted BugPR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jack-Works@typescript-bot@sandersn