refactor: let exportMapKey accepts bad symbol name by Jack-Works · Pull Request #54678 · microsoft/TypeScript

Jack Works (Jack-Works) · 2023-06-16T16:22:00Z

this is required for #49297 because a symbol may can contains | in its name

TypeScript Bot (typescript-bot) · 2023-06-16T16:22:06Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Nathan Shively-Sanders (sandersn) · 2023-06-27T22:53:34Z

Ron Buckton (@rbuckton) are you familiar with this spec change?

Jack Works (Jack-Works) · 2023-06-28T01:53:39Z

Ron Buckton (@rbuckton) are you familiar with this spec change?

this basically allows any string (valid Unicode maybe?) to be the export name, so you can export { x as "a|b" } and then break the compiler.

But I doubt this already happens in CommonJS module in form of exports["a|b"] = 0

TypeScript Bot (typescript-bot) · 2023-08-09T04:23:40Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure Daniel Rosenwasser (@DanielRosenwasser) and Ryan Cavanaugh (@RyanCavanaugh) are aware of the changes, just as a heads up.

Daniel Rosenwasser (DanielRosenwasser) · 2023-08-09T18:52:15Z

TypeScript Bot (@typescript-bot) pack this
TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) user test tsserver
TypeScript Bot (@typescript-bot) test tsserver top100
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2023-08-09T18:52:18Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based user code test suite (tsserver) on this PR at 1002594. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-08-09T18:52:18Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the tarball bundle task on this PR at 1002594. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-08-09T18:52:18Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the perf test suite on this PR at 1002594. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-08-09T18:52:18Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based top-repos suite on this PR at 1002594. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-08-09T18:52:18Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based user code test suite on this PR at 1002594. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-08-09T18:52:18Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the parallelized Definitely Typed test suite on this PR at 1002594. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-08-09T18:52:18Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based top-repos suite (tsserver) on this PR at 1002594. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-08-09T18:54:19Z

Hey Daniel Rosenwasser (@DanielRosenwasser), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/156417/artifacts?artifactName=tgz&fileId=52D280978FFAE4DF6D2B1CBA61BB2029F424FB1A5E55553F5FC7CFFADF12A53502&fileName=/typescript-5.3.0-insiders.20230809.tgz"
}
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.3.0-pr-54678-12".;

TypeScript Bot (typescript-bot) · 2023-08-09T19:18:09Z

Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the user test suite comparing main and refs/pull/54678/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

[NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-54678/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54678/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54678/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-54678/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54678/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54678/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-54678/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54678/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54678/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-54678/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54678/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54678/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-54678/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54678/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54678/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
[MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

TypeScript Bot (typescript-bot) · 2023-08-09T19:25:54Z

Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the user test suite comparing main and refs/pull/54678/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-08-09T19:48:42Z

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..54678

_Metric	_main	₅₄₆₇₈	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{368,873k (± 0.01%)}	_{368,855k (± 0.01%)}	_~	_368,789k	_368,909k	_{p=0.575 n=6}
_{Parse Time}	_{3.40s (± 1.00%)}	_{3.38s (± 0.78%)}	_~	_3.34s	_3.42s	_{p=0.744 n=6}
_{Bind Time}	_{1.12s (± 0.36%)}	_{1.12s (± 0.67%)}	_~	_1.11s	_1.13s	_{p=1.000 n=6}
_{Check Time}	_{9.05s (± 0.42%)}	_{9.04s (± 0.51%)}	_~	_8.99s	_9.10s	_{p=0.809 n=6}
_{Emit Time}	_{7.50s (± 0.55%)}	_{7.52s (± 0.89%)}	_~	_7.44s	_7.61s	_{p=0.517 n=6}
_{Total Time}	_{21.07s (± 0.44%)}	_{21.07s (± 0.36%)}	_~	_20.94s	_21.16s	_{p=1.000 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{192,120k (± 0.01%)}	_{192,095k (± 0.04%)}	_~	_191,940k	_192,176k	_{p=0.378 n=6}
_{Parse Time}	_{1.51s (± 0.77%)}	_{1.50s (± 0.36%)}	_~	_1.50s	_1.51s	_{p=0.498 n=6}
_{Bind Time}	_{0.77s (± 0.67%)}	_{0.77s (± 0.67%)}	_~	_0.77s	_0.78s	_{p=0.069 n=6}
_{Check Time}	_{9.56s (± 0.56%)}	_{9.58s (± 0.45%)}	_~	_9.50s	_9.62s	_{p=0.570 n=6}
_{Emit Time}	_{2.74s (± 0.55%)}	_{2.76s (± 1.18%)}	_~	_2.72s	_2.81s	_{p=0.806 n=6}
_{Total Time}	_{14.59s (± 0.46%)}	_{14.61s (± 0.19%)}	_~	_14.58s	_14.65s	_{p=0.570 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{347,779k (± 0.01%)}	_{347,790k (± 0.01%)}	_~	_347,741k	_347,867k	_{p=0.873 n=6}
_{Parse Time}	_{2.62s (± 1.40%)}	_{2.62s (± 0.71%)}	_~	_2.59s	_2.64s	_{p=0.871 n=6}
_{Bind Time}	_{1.01s (± 0.80%)}	_{1.01s (± 0.74%)}	_~	_1.00s	_1.02s	_{p=0.729 n=6}
_{Check Time}	_{7.39s (± 0.44%)}	_{7.38s (± 0.60%)}	_~	_7.31s	_7.43s	_{p=0.630 n=6}
_{Emit Time}	_{4.27s (± 0.91%)}	_{4.23s (± 0.82%)}	_~	_4.19s	_4.29s	_{p=0.063 n=6}
_{Total Time}	_{15.30s (± 0.56%)}	_{15.24s (± 0.44%)}	_~	_15.15s	_15.34s	_{p=0.296 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{301,833k (± 0.00%)}	_{301,835k (± 0.01%)}	_~	_301,819k	_301,872k	_{p=0.630 n=6}
_{Parse Time}	_{2.09s (± 1.27%)}	_{2.08s (± 1.81%)}	_~	_2.02s	_2.12s	_{p=0.872 n=6}
_{Bind Time}	_{1.12s (± 0.67%)}	_{1.13s (± 0.36%)}	_{+0.01s (+ 0.89%)}	_1.13s	_1.14s	_{p=0.024 n=6}
_{Check Time}	_{6.70s (± 0.29%)}	_{6.71s (± 0.22%)}	_~	_6.68s	_6.72s	_{p=0.458 n=6}
_{Emit Time}	_{3.84s (± 0.83%)}	_{3.88s (± 0.42%)}	_{+0.04s (+ 1.04%)}	_3.86s	_3.90s	_{p=0.036 n=6}
_{Total Time}	_{13.75s (± 0.47%)}	_{13.81s (± 0.22%)}	_~	_13.76s	_13.84s	_{p=0.148 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{482,619k (± 0.01%)}	_{482,625k (± 0.02%)}	_~	_482,535k	_482,772k	_{p=0.575 n=6}
_{Parse Time}	_{3.13s (± 0.51%)}	_{3.05s (± 2.92%)}	_~	_2.95s	_3.14s	_{p=0.142 n=6}
_{Bind Time}	_{0.92s (± 1.19%)}	_{0.96s (± 5.39%)}	_~	_0.92s	_1.03s	_{p=0.087 n=6}
_{Check Time}	_{17.43s (± 0.81%)}	_{17.46s (± 0.91%)}	_~	_17.26s	_17.72s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.48s (± 0.70%)}	_{21.46s (± 0.74%)}	_~	_21.28s	_21.70s	_{p=1.000 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{563,798k (± 0.01%)}	_{563,946k (± 0.02%)}	_{+148k (+ 0.03%)}	_563,856k	_564,102k	_{p=0.031 n=6}
_{Parse Time}	_{3.83s (± 0.54%)}	_{3.84s (± 0.51%)}	_~	_3.81s	_3.86s	_{p=0.806 n=6}
_{Bind Time}	_{1.64s (± 1.05%)}	_{1.63s (± 0.75%)}	_~	_1.62s	_1.65s	_{p=0.867 n=6}
_{Check Time}	_{2.82s (± 0.86%)}	_{2.81s (± 1.62%)}	_~	_2.75s	_2.86s	_{p=0.629 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.38s (± 0.44%)}	_{8.36s (± 0.57%)}	_~	_8.28s	_8.41s	_{p=0.571 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{368,262k (± 0.00%)}	_{368,267k (± 0.00%)}	_~	_368,241k	_368,287k	_{p=0.470 n=6}
_{Parse Time}	_{3.57s (± 0.65%)}	_{3.55s (± 0.81%)}	_~	_3.52s	_3.60s	_{p=0.329 n=6}
_{Bind Time}	_{1.19s (± 0.34%)}	_{1.19s (± 0.34%)}	_~	_1.18s	_1.19s	_{p=1.000 n=6}
_{Check Time}	_{9.86s (± 0.41%)}	_{9.86s (± 0.28%)}	_~	_9.82s	_9.90s	_{p=0.746 n=6}
_{Emit Time}	_{8.02s (± 0.54%)}	_{8.03s (± 0.58%)}	_~	_7.99s	_8.09s	_{p=0.806 n=6}
_{Total Time}	_{22.64s (± 0.31%)}	_{22.63s (± 0.39%)}	_~	_22.54s	_22.74s	_{p=1.000 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,851k (± 0.02%)}	_{193,801k (± 0.02%)}	_~	_193,736k	_193,870k	_{p=0.128 n=6}
_{Parse Time}	_{1.59s (± 0.65%)}	_{1.59s (± 0.89%)}	_~	_1.57s	_1.61s	_{p=0.738 n=6}
_{Bind Time}	_{0.82s (± 1.25%)}	_{0.82s (± 0.63%)}	_~	_0.82s	_0.83s	_{p=0.928 n=6}
_{Check Time}	_{10.29s (± 0.42%)}	_{10.24s (± 0.50%)}	_~	_10.18s	_10.29s	_{p=0.090 n=6}
_{Emit Time}	_{2.99s (± 0.98%)}	_{2.98s (± 1.12%)}	_~	_2.96s	_3.05s	_{p=0.936 n=6}
_{Total Time}	_{15.70s (± 0.36%)}	_{15.63s (± 0.55%)}	_~	_15.56s	_15.77s	_{p=0.147 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{347,102k (± 0.01%)}	_{347,102k (± 0.00%)}	_~	_347,088k	_347,122k	_{p=0.936 n=6}
_{Parse Time}	_{2.77s (± 0.84%)}	_{2.76s (± 0.42%)}	_~	_2.75s	_2.78s	_{p=0.934 n=6}
_{Bind Time}	_{1.07s (± 0.00%)}	_{1.08s (± 0.76%)}	_~	_1.07s	_1.09s	_{p=0.073 n=6}
_{Check Time}	_{8.06s (± 0.49%)}	_{8.06s (± 0.31%)}	_~	_8.03s	_8.09s	_{p=0.936 n=6}
_{Emit Time}	_{4.44s (± 0.75%)}	_{4.44s (± 0.78%)}	_~	_4.39s	_4.48s	_{p=1.000 n=6}
_{Total Time}	_{16.34s (± 0.48%)}	_{16.34s (± 0.39%)}	_~	_16.27s	_16.41s	_{p=0.936 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{301,127k (± 0.01%)}	_{301,160k (± 0.00%)}	_~	_301,139k	_301,177k	_{p=0.066 n=6}
_{Parse Time}	_{2.19s (± 0.63%)}	_{2.20s (± 0.53%)}	_~	_2.19s	_2.22s	_{p=0.461 n=6}
_{Bind Time}	_{1.21s (± 1.22%)}	_{1.21s (± 1.10%)}	_~	_1.19s	_1.23s	_{p=0.681 n=6}
_{Check Time}	_{7.34s (± 0.50%)}	_{7.36s (± 0.67%)}	_~	_7.28s	_7.42s	_{p=0.521 n=6}
_{Emit Time}	_{4.29s (± 0.77%)}	_{4.33s (± 0.52%)}	_{+0.03s (+ 0.74%)}	_4.28s	_4.34s	_{p=0.033 n=6}
_{Total Time}	_{15.03s (± 0.36%)}	_{15.10s (± 0.37%)}	_~	_15.00s	_15.15s	_{p=0.054 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,909k (± 0.00%)}	_{481,887k (± 0.01%)}	_~	_481,822k	_481,922k	_{p=0.378 n=6}
_{Parse Time}	_{3.24s (± 0.41%)}	_{3.23s (± 0.30%)}	_~	_3.22s	_3.25s	_{p=0.177 n=6}
_{Bind Time}	_{0.95s (± 0.79%)}	_{0.95s (± 0.88%)}	_~	_0.94s	_0.96s	_{p=0.432 n=6}
_{Check Time}	_{18.48s (± 0.81%)}	_{18.43s (± 1.00%)}	_~	_18.30s	_18.79s	_{p=0.229 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.68s (± 0.69%)}	_{22.62s (± 0.86%)}	_~	_22.48s	_23.00s	_{p=0.261 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{561,499k (± 0.02%)}	_{561,515k (± 0.03%)}	_~	_561,323k	_561,685k	_{p=0.810 n=6}
_{Parse Time}	_{4.03s (± 0.59%)}	_{4.01s (± 0.30%)}	_~	_3.99s	_4.02s	_{p=0.084 n=6}
_{Bind Time}	_{1.73s (± 1.48%)}	_{1.75s (± 1.32%)}	_~	_1.71s	_1.78s	_{p=0.192 n=6}
_{Check Time}	_{3.05s (± 0.48%)}	_{3.04s (± 0.94%)}	_~	_3.00s	_3.08s	_{p=0.572 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.92s (± 0.43%)}	_{8.88s (± 0.44%)}	_~	_8.83s	_8.94s	_{p=0.258 n=6}
_{Angular - node (v14.21.3, x64)}
_{Memory used}	_{362,191k (± 0.01%)}	_{362,177k (± 0.01%)}	_~	_362,102k	_362,226k	_{p=0.810 n=6}
_{Parse Time}	_{3.73s (± 0.38%)}	_{3.73s (± 0.53%)}	_~	_3.72s	_3.77s	_{p=1.000 n=6}
_{Bind Time}	_{1.22s (± 0.33%)}	_{1.22s (± 0.68%)}	_~	_1.21s	_1.23s	_{p=0.285 n=6}
_{Check Time}	_{10.24s (± 0.45%)}	_{10.25s (± 0.33%)}	_~	_10.22s	_10.31s	_{p=1.000 n=6}
_{Emit Time}	_{8.35s (± 0.48%)}	_{8.33s (± 0.55%)}	_~	_8.27s	_8.37s	_{p=0.419 n=6}
_{Total Time}	_{23.54s (± 0.23%)}	_{23.54s (± 0.35%)}	_~	_23.43s	_23.67s	_{p=1.000 n=6}
_{Compiler-Unions - node (v14.21.3, x64)}
_{Memory used}	_{189,104k (± 0.01%)}	_{189,131k (± 0.01%)}	_{+27k (+ 0.01%)}	_189,107k	_189,163k	_{p=0.020 n=6}
_{Parse Time}	_{1.61s (± 0.85%)}	_{1.61s (± 0.99%)}	_~	_1.60s	_1.64s	_{p=0.672 n=6}
_{Bind Time}	_{0.85s (± 0.96%)}	_{0.84s (± 0.65%)}	_~	_0.84s	_0.85s	_{p=0.859 n=6}
_{Check Time}	_{10.41s (± 0.33%)}	_{10.40s (± 0.39%)}	_~	_10.36s	_10.47s	_{p=0.872 n=6}
_{Emit Time}	_{3.11s (± 0.83%)}	_{3.10s (± 0.59%)}	_~	_3.08s	_3.13s	_{p=0.329 n=6}
_{Total Time}	_{15.99s (± 0.29%)}	_{15.96s (± 0.33%)}	_~	_15.89s	_16.04s	_{p=0.318 n=6}
_{Monaco - node (v14.21.3, x64)}
_{Memory used}	_{342,097k (± 0.00%)}	_{342,113k (± 0.01%)}	_~	_342,087k	_342,137k	_{p=0.173 n=6}
_{Parse Time}	_{2.81s (± 0.35%)}	_{2.80s (± 0.27%)}	_~	_2.79s	_2.81s	_{p=0.077 n=6}
_{Bind Time}	_{1.10s (± 0.57%)}	_{1.10s (± 0.47%)}	_~	_1.09s	_1.10s	_{p=0.386 n=6}
_{Check Time}	_{8.39s (± 0.39%)}	_{8.38s (± 0.28%)}	_~	_8.35s	_8.41s	_{p=1.000 n=6}
_{Emit Time}	_{4.67s (± 0.95%)}	_{4.66s (± 0.40%)}	_~	_4.64s	_4.69s	_{p=0.625 n=6}
_{Total Time}	_{16.96s (± 0.30%)}	_{16.94s (± 0.24%)}	_~	_16.88s	_16.98s	_{p=0.467 n=6}
_{TFS - node (v14.21.3, x64)}
_{Memory used}	_{296,217k (± 0.00%)}	_{296,215k (± 0.00%)}	_~	_296,201k	_296,222k	_{p=0.686 n=6}
_{Parse Time}	_{2.42s (± 0.80%)}	_{2.44s (± 0.92%)}	_~	_2.42s	_2.48s	_{p=0.167 n=6}
_{Bind Time}	_{1.08s (± 0.48%)}	_{1.09s (± 1.22%)}	_{+0.01s (+ 1.39%)}	_1.07s	_1.11s	_{p=0.039 n=6}
_{Check Time}	_{7.69s (± 0.33%)}	_{7.72s (± 0.48%)}	_~	_7.68s	_7.77s	_{p=0.158 n=6}
_{Emit Time}	_{4.29s (± 0.56%)}	_{4.34s (± 0.77%)}	_{+0.05s (+ 1.13%)}	_4.29s	_4.39s	_{p=0.024 n=6}
_{Total Time}	_{15.48s (± 0.19%)}	_{15.58s (± 0.39%)}	_{+0.10s (+ 0.68%)}	_15.51s	_15.69s	_{p=0.008 n=6}
_{material-ui - node (v14.21.3, x64)}
_{Memory used}	_{477,370k (± 0.00%)}	_{477,380k (± 0.00%)}	_~	_477,362k	_477,396k	_{p=0.378 n=6}
_{Parse Time}	_{3.30s (± 0.19%)}	_{3.30s (± 0.32%)}	_~	_3.29s	_3.32s	_{p=0.388 n=6}
_{Bind Time}	_{0.99s (± 0.82%)}	_{0.99s (± 0.76%)}	_~	_0.98s	_1.00s	_{p=0.340 n=6}
_{Check Time}	_{19.30s (± 0.76%)}	_{19.36s (± 0.71%)}	_~	_19.15s	_19.48s	_{p=0.423 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.59s (± 0.62%)}	_{23.65s (± 0.59%)}	_~	_23.44s	_23.77s	_{p=0.470 n=6}
_{xstate - node (v14.21.3, x64)}
_{Memory used}	_{550,243k (± 0.01%)}	_{550,237k (± 0.01%)}	_~	_550,180k	_550,268k	_{p=1.000 n=6}
_{Parse Time}	_{4.21s (± 0.58%)}	_{4.21s (± 0.51%)}	_~	_4.19s	_4.25s	_{p=0.677 n=6}
_{Bind Time}	_{1.70s (± 0.64%)}	_{1.64s (± 2.60%)}	_{🟩-0.06s (- 3.63%)}	_1.60s	_1.69s	_{p=0.012 n=6}
_{Check Time}	_{3.12s (± 0.78%)}	_{3.13s (± 0.53%)}	_~	_3.10s	_3.15s	_{p=0.326 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.12s (± 0.38%)}	_{9.06s (± 0.55%)}	_~	_9.01s	_9.13s	_{p=0.127 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.21.3, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.21.3, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.21.3, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.21.3, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.21.3, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₆₇₈	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..54678

_Metric	_main	₅₄₆₇₈	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,529ms (± 1.09%)}	_{2,550ms (± 0.89%)}	_~	_2,528ms	_2,586ms	_{p=0.378 n=6}
_{Req 2 - geterr}	_{5,436ms (± 0.57%)}	_{5,442ms (± 0.69%)}	_~	_5,384ms	_5,479ms	_{p=0.873 n=6}
_{Req 3 - references}	_{345ms (± 1.23%)}	_{341ms (± 0.40%)}	_~	_339ms	_343ms	_{p=0.226 n=6}
_{Req 4 - navto}	_{288ms (± 0.26%)}	_{288ms (± 0.52%)}	_~	_285ms	_289ms	_{p=0.734 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{87ms (± 1.03%)}	_{88ms (± 3.76%)}	_~	_85ms	_93ms	_{p=0.934 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,618ms (± 1.02%)}	_{2,619ms (± 1.14%)}	_~	_2,582ms	_2,656ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{4,161ms (± 0.60%)}	_{4,160ms (± 0.56%)}	_~	_4,128ms	_4,188ms	_{p=1.000 n=6}
_{Req 3 - references}	_{357ms (± 0.99%)}	_{354ms (± 0.66%)}	_~	_352ms	_358ms	_{p=0.147 n=6}
_{Req 4 - navto}	_{290ms (± 0.28%)}	_{290ms (± 0.47%)}	_~	_288ms	_292ms	_{p=0.282 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{88ms (± 1.32%)}	_{87ms (± 1.90%)}	_~	_84ms	_88ms	_{p=0.115 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,086ms (± 0.60%)}	_{3,098ms (± 0.73%)}	_~	_3,070ms	_3,125ms	_{p=0.230 n=6}
_{Req 2 - geterr}	_{1,631ms (± 7.45%)}	_{1,673ms (± 7.56%)}	_~	_1,538ms	_1,810ms	_{p=0.575 n=6}
_{Req 3 - references}	_{110ms (± 2.04%)}	_{111ms (± 2.85%)}	_~	_107ms	_116ms	_{p=0.747 n=6}
_{Req 4 - navto}	_{374ms (± 0.52%)}	_{374ms (± 0.40%)}	_~	_373ms	_377ms	_{p=0.935 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{386ms (± 2.87%)}	_{387ms (± 2.22%)}	_~	_377ms	_399ms	_{p=0.873 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,625ms (± 0.45%)}	_{2,619ms (± 0.44%)}	_~	_2,610ms	_2,639ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{6,110ms (± 0.34%)}	_{6,068ms (± 0.65%)}	_~	_6,022ms	_6,122ms	_{p=0.093 n=6}
_{Req 3 - references}	_{355ms (± 0.61%)}	_{355ms (± 0.53%)}	_~	_352ms	_357ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{284ms (± 0.36%)}	_{283ms (± 0.62%)}	_~	_280ms	_285ms	_{p=0.323 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{87ms (±11.05%)}	_{88ms (± 8.97%)}	_~	_80ms	_96ms	_{p=0.742 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,790ms (± 0.65%)}	_{2,796ms (± 0.47%)}	_~	_2,784ms	_2,821ms	_{p=0.335 n=6}
_{Req 2 - geterr}	_{4,712ms (± 0.32%)}	_{4,685ms (± 0.34%)}	_{-27ms (- 0.57%)}	_4,670ms	_4,715ms	_{p=0.019 n=6}
_{Req 3 - references}	_{364ms (± 0.75%)}	_{363ms (± 0.71%)}	_~	_361ms	_367ms	_{p=0.745 n=6}
_{Req 4 - navto}	_{280ms (± 0.66%)}	_{282ms (± 0.72%)}	_~	_280ms	_286ms	_{p=0.073 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{77ms (± 1.37%)}	_{80ms (± 4.48%)}	_~	_76ms	_84ms	_{p=0.085 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,230ms (± 0.42%)}	_{3,220ms (± 0.35%)}	_~	_3,206ms	_3,231ms	_{p=0.128 n=6}
_{Req 2 - geterr}	_{1,704ms (± 0.38%)}	_{1,704ms (± 0.83%)}	_~	_1,687ms	_1,719ms	_{p=0.936 n=6}
_{Req 3 - references}	_{128ms (± 6.77%)}	_{131ms (± 8.40%)}	_~	_123ms	_146ms	_{p=0.676 n=6}
_{Req 4 - navto}	_{351ms (± 0.38%)}	_{351ms (± 0.59%)}	_~	_349ms	_355ms	_{p=0.802 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{411ms (± 1.71%)}	_{405ms (± 1.70%)}	_~	_393ms	_412ms	_{p=0.228 n=6}
_{Compiler-UnionsTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,776ms (± 0.58%)}	_{2,768ms (± 0.20%)}	_~	_2,761ms	_2,774ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{6,245ms (± 0.47%)}	_{6,250ms (± 0.45%)}	_~	_6,213ms	_6,294ms	_{p=1.000 n=6}
_{Req 3 - references}	_{365ms (± 0.92%)}	_{363ms (± 1.33%)}	_~	_357ms	_371ms	_{p=0.295 n=6}
_{Req 4 - navto}	_{290ms (± 0.49%)}	_{290ms (± 0.53%)}	_~	_289ms	_293ms	_{p=0.868 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{103ms (± 8.08%)}	_{101ms (± 7.56%)}	_~	_91ms	_110ms	_{p=0.466 n=6}
_{CompilerTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,934ms (± 0.76%)}	_{2,935ms (± 0.62%)}	_~	_2,917ms	_2,970ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{4,610ms (± 0.44%)}	_{4,614ms (± 0.33%)}	_~	_4,596ms	_4,642ms	_{p=0.873 n=6}
_{Req 3 - references}	_{376ms (± 0.29%)}	_{376ms (± 0.39%)}	_~	_375ms	_378ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{297ms (± 1.01%)}	_{298ms (± 0.49%)}	_~	_297ms	_300ms	_{p=0.616 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{83ms (± 1.52%)}	_{84ms (± 0.90%)}	_~	_83ms	_85ms	_{p=0.301 n=6}
_{xstateTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{3,501ms (± 1.58%)}	_{3,518ms (± 0.44%)}	_~	_3,500ms	_3,544ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{1,822ms (± 0.45%)}	_{1,812ms (± 0.35%)}	_{-9ms (- 0.51%)}	_1,807ms	_1,824ms	_{p=0.037 n=6}
_{Req 3 - references}	_{150ms (± 5.91%)}	_{151ms (± 6.32%)}	_~	_132ms	_159ms	_{p=0.413 n=6}
_{Req 4 - navto}	_{390ms (± 1.33%)}	_{388ms (± 0.21%)}	_~	_387ms	_389ms	_{p=0.315 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{418ms (± 0.70%)}	_{416ms (± 1.39%)}	_~	_409ms	_425ms	_{p=0.378 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.21.3, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.21.3, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₆₇₈	₆
_Baseline	_main	₆

Startup

Comparison Report - main..54678

_Metric	_main	₅₄₆₇₈	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{142.15ms (± 0.20%)}	_{141.96ms (± 0.22%)}	_{-0.19ms (- 0.14%)}	_141.21ms	_145.39ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{221.50ms (± 0.15%)}	_{221.34ms (± 0.21%)}	_{-0.16ms (- 0.07%)}	_220.09ms	_230.16ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{223.06ms (± 0.16%)}	_{222.99ms (± 0.22%)}	_{-0.07ms (- 0.03%)}	_221.72ms	_229.18ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{205.02ms (± 0.16%)}	_{204.88ms (± 0.19%)}	_{-0.14ms (- 0.07%)}	_203.85ms	_213.73ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₆₇₈	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

TypeScript Bot (typescript-bot) · 2023-08-09T20:22:25Z

Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the top-repos suite comparing main and refs/pull/54678/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-08-09T21:00:16Z

Hey Daniel Rosenwasser (@DanielRosenwasser), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

TypeScript Bot (typescript-bot) · 2023-08-09T21:23:50Z

Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the top-repos suite comparing main and refs/pull/54678/merge:

Everything looks good!

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 16, 2023

Nathan Shively-Sanders (sandersn) assigned Ron Buckton (rbuckton)Jun 27, 2023

Nathan Shively-Sanders (sandersn) requested review from Ron Buckton (rbuckton) and Sheetal Nandi (sheetalkamat)June 27, 2023 22:52

Jack Works (Jack-Works)force-pushed the refactor-export-map-bad-symbol-name branch from 07d746c to 1002594Compare August 9, 2023 04:23

Daniel Rosenwasser (DanielRosenwasser) requested a review from Andrew Branch (andrewbranch)August 9, 2023 05:22

Andrew Branch (andrewbranch) approved these changes Aug 9, 2023
View reviewed changes

Jack Works (Jack-Works)force-pushed the refactor-export-map-bad-symbol-name branch from 1002594 to 2391c6cCompare September 13, 2023 03:44

refactor: let exportMapKey accepts bad symbol name
bbbf441

Jack Works (Jack-Works)force-pushed the refactor-export-map-bad-symbol-name branch from 6b9ace2 to bbbf441Compare September 13, 2023 04:59

fix: dprint
7eb5eed

fix: baseline
266b2c2

Andrew Branch (andrewbranch) merged commit e7bb0eb into microsoft:mainSep 13, 2023

Marcus Ording (snovader) pushed a commit to EG-A-S/TypeScript that referenced this pull request Sep 23, 2023
refactor: let exportMapKey accepts bad symbol name (microsoft#54678)
3e0df44

Jack Works (Jack-Works) deleted the refactor-export-map-bad-symbol-name branch December 30, 2023 13:05

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Uh oh!

Conversation

Jack Works (Jack-Works) commented Jun 16, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 16, 2023

Uh oh!

Nathan Shively-Sanders (sandersn) commented Jun 27, 2023

Uh oh!

Jack Works (Jack-Works) commented Jun 28, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 9, 2023

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Aug 9, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 9, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 9, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 9, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 9, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 9, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 9, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 9, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 9, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 9, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 9, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 9, 2023

Compiler

TSServer

Startup

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 9, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 9, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

TypeScript Bot (typescript-bot) commented Aug 9, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Aug 9, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Aug 9, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Aug 9, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Aug 9, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Aug 9, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Aug 9, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Aug 9, 2023•
edited
Loading