Uh oh!
There was an error while loading. Please reload this page.
Use function that doesn't return unknown type - #54713
Merged
Merged
Conversation
MemberAuthor
TypeScript Bot (@typescript-bot) test this |
Contributor
Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based user code test suite on this PR at eba78e4. You can monitor the build here. Update: The results are in! |
Contributor
Heya Gabriela Araujo Britto (@gabritto), I've started to run the perf test suite on this PR at eba78e4. You can monitor the build here. Update: The results are in! |
Contributor
Heya Gabriela Araujo Britto (@gabritto), I've started to run the parallelized Definitely Typed test suite on this PR at eba78e4. You can monitor the build here. Update: The results are in! |
Contributor
Heya Gabriela Araujo Britto (@gabritto), I've started to run the extended test suite on this PR at eba78e4. You can monitor the build here. |
Contributor
Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based top-repos suite on this PR at eba78e4. You can monitor the build here. Update: The results are in! |
Gabriela Araujo Britto (gabritto)
requested a review
from Nathan Shively-Sanders (sandersn)June 20, 2023 00:34
TypeScript Bot (typescript-bot)
commented
Jun 20, 2023
Contributor
Gabriela Araujo Britto (@gabritto) Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
TypeScript Bot (typescript-bot)
commented
Jun 20, 2023
Contributor
Gabriela Araujo Britto (@gabritto) Here they are:CompilerComparison Report - main..54713
System
Hosts
Scenarios
TSServerComparison Report - main..54713
System
Hosts
Scenarios
StartupComparison Report - main..54713
System
Hosts
Scenarios
Developer Information: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
TypeScript Bot (typescript-bot)
commented
Jun 20, 2023
Contributor
Gabriela Araujo Britto (@gabritto) Here are the results of running the top-repos suite comparing Everything looks good! |
TypeScript Bot (typescript-bot)
commented
Jun 20, 2023
Contributor
Hey Gabriela Araujo Britto (@gabritto), the results of running the DT tests are ready. Main only errors:Package: qrcode |
Nathan Shively-Sanders (sandersn)
approved these changes
Jun 20, 2023
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
Looks good although I'd recommend moving the new function next to the existing one.
| const filtered = contains(include, Ternary.False) ? getUnionType(types.filter((_, i) => include[i])) : target; | ||
| return filtered.flags & TypeFlags.Never ? target : filtered; | ||
| function getTypeOfPropertyOrIndexSignatureOfType(type: Type, name: __String): Type | undefined { |
There was a problem hiding this comment.
It might be less confusing to have this next to getTypeOfPropertyOrIndexSignatureOfType.
Well, initially more confusing for the reader, because they'll have to ask "Why are there two here?". But they'll be aware that there are two nearly identical things that need to be used in different situations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When refactoring #54596, I introduced a bug by using a function that returns
unknownTypewhen a property or index signature is missing. Instead, we need to use a function that returnsundefinedwhen the property or index signature is missing.Fixes the failing package
qrcodeon the nightly DT run (https://typescript.visualstudio.com/TypeScript/_build/results?buildId=155426&view=logs&j=71179031-6417-5a2f-3d87-af6fce2011e4&t=69c46c41-df19-593d-5ed2-0b9c514993a3).