Uh oh!
There was an error while loading. Please reload this page.
Fix self-name input linking for --allowJs --declaration projects - #54819
Conversation
Uh oh!
There was an error while loading. Please reload this page.
| // to ensure that self-name imports of their own package can resolve back to their | ||
| // input JS files via `tryLoadInputFileForPath` at a higher priority than their output | ||
| // declaration files, so we need to do a single pass with all extensions for that case. | ||
| if (getAllowJSCompilerOption(state.compilerOptions) && !pathContainsNodeModules(directory)) { |
There was a problem hiding this comment.
I think with this we need to add affectsModuleResolution to "checkJs" in commandline options declaration.
There was a problem hiding this comment.
Ooh, yikes. I can do that for now, but maybe it would be better to update getCompilerOptionValue (called by optionsHaveChanges functions) to use all the computed compiler option getter functions sometime in the future.
There was a problem hiding this comment.
checkJs doesn’t even have affectsSemanticDiagnostics. Does it need it?
There was a problem hiding this comment.
it does. #53403 never made it in i guess.
There was a problem hiding this comment.
I’ll leave it off of this one and then we should revisit #53403
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Fixes#54299
Related: #52185