Skip to content

Correctly error on enum member values referring to identifiers shadowing Infinity and NaN - #55018

Merged
Gabriela Araujo Britto (gabritto) merged 1 commit into
microsoft:mainfrom
Andarist:fix/enum-member-values-using-shadowing-infinity-nan
Aug 2, 2023
Merged

Correctly error on enum member values referring to identifiers shadowing Infinity and NaN#55018
Gabriela Araujo Britto (gabritto) merged 1 commit into
microsoft:mainfrom
Andarist:fix/enum-member-values-using-shadowing-infinity-nan

Conversation

@Andarist

@AndaristMateusz Burzyński (Andarist) commented Jul 14, 2023

Copy link
Copy Markdown
Contributor

fixes#54981

@typescript-botTypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 14, 2023
@jakebaileyJake Bailey (jakebailey) mentioned this pull request Jul 18, 2023
Closed
@typescript-botTypeScript Bot (typescript-bot) removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 28, 2023
@typescript-botTypeScript Bot (typescript-bot) added the For Backlog Bug PRs that fix a backlog bug label Jul 28, 2023
@gabritto

This comment was marked as duplicate.

Sign in to view
@gabritto

Gabriela Araujo Britto (gabritto) commented Aug 2, 2023

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) run DT
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) test top100

@typescript-bot

TypeScript Bot (typescript-bot) commented Aug 2, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the parallelized Definitely Typed test suite on this PR at 5488642. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Aug 2, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based user code test suite on this PR at 5488642. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Aug 2, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based top-repos suite on this PR at 5488642. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto) Here are the results of running the user test suite comparing main and refs/pull/55018/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Unknown failure"
  • 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

  • [NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • [MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

@typescript-bot

TypeScript Bot (typescript-bot) commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto) Here are the results of running the top-repos suite comparing main and refs/pull/55018/merge:

Everything looks good!

@gabritto

Gabriela Araujo Britto (gabritto) commented Aug 2, 2023

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) run DT

@typescript-bot

TypeScript Bot (typescript-bot) commented Aug 2, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the parallelized Definitely Typed test suite on this PR at 5488642. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

Hey Gabriela Araujo Britto (@gabritto), it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

Hey Gabriela Araujo Britto (@gabritto), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@gabritto
Gabriela Araujo Britto (gabritto) merged commit 1481750 into microsoft:mainAug 2, 2023
@AndaristMateusz Burzyński (Andarist) mentioned this pull request Aug 12, 2023
Closed
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gabrittoGabriela Araujo Britto (gabritto)gabritto approved these changes
@iisaduanIsabel Duan (iisaduan)Awaiting requested review from iisaduan

Assignees

@gabrittoGabriela Araujo Britto (gabritto)

Labels

For Backlog BugPRs that fix a backlog bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing error for enum using non-number variables named Infinity/NaN

4 participants

@Andarist@gabritto@typescript-bot@sandersn