Uh oh!
There was an error while loading. Please reload this page.
Enable eslint rule no-useless-escape - #55138
Merged
Jake Bailey (jakebailey) merged 4 commits intoJul 28, 2023
Merged
Conversation
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Jul 28, 2023
Daniel Rosenwasser (DanielRosenwasser)
left a comment
Member
There was a problem hiding this comment.
I hated reviewing this.
Jake Bailey (jakebailey)
commented
Jul 28, 2023
MemberAuthor
Sending it was slightly better; at least I had a quick fix but no |
Sheetal Nandi (sheetalkamat)
approved these changes
Jul 28, 2023
Uh oh!
There was an error while loading. Please reload this page.
| "🐱", | ||
| "\x00\x01", | ||
| "\t\n\r\\\"\'\u0062", | ||
| "\t\n\r\\\"'\u0062", |
MemberAuthor
There was a problem hiding this comment.
On second look, I'm not sure if this intended to write ' or \\'. But, I'm not sure what "escaping" there is to check when roundtripping base64 anyway...
| it("Converts escape sequences correctly", () => { | ||
| runTest("\t\n\r\\\"\'\u0062"); | ||
| runTest("\t\n\r\\\"'\u0062"); |
MemberAuthor
There was a problem hiding this comment.
Similarly here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #54693.
This actually caught a small number of oopsies where we wrote
\r\pbut meant\r\np