Uh oh!
There was an error while loading. Please reload this page.
Fixed hasInvalidEscape implementation - #55373
Merged
Jake Bailey (jakebailey) merged 2 commits intoAug 14, 2023
Merged
Conversation
Co-authored-by: Damien Engels <engels@google.com>
Uh oh!
There was an error while loading. Please reload this page.
Contributor
Oh, great that you spotted it – I overlooked that method. |
Jake Bailey (jakebailey)
commented
Aug 14, 2023
Member
I'm thinking this one deserves a backport; Daniel Rosenwasser (@DanielRosenwasser) thoughts? |
Member
Hm, no, this was broken in 5.1; I misremembered which release we're currently on. Though, maybe it's worth doing anyway. |
Jake Bailey (jakebailey)
approved these changes
Aug 14, 2023
Jake Bailey (jakebailey)
commented
Aug 14, 2023
Member
I'm also silly and didn't realize that the result of this bug is just "the generated code is worse", so, nevermind altogether then 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#55369
regression from #51837 , cc graphemecluster (@graphemecluster)