Uh oh!
There was an error while loading. Please reload this page.
Fixed contravariant inferences from annotated optional parameters - #55397
Merged
Wesley Wigham (weswigham) merged 2 commits intoAug 16, 2023
Merged
Conversation
Wesley Wigham (weswigham)
requested changes
Aug 16, 2023
| const typeNode = getEffectiveTypeAnnotationNode(declaration); | ||
| if (typeNode) { | ||
| inferTypes(inferenceContext.inferences, getTypeFromTypeNode(typeNode), getTypeAtPosition(context, i)); | ||
| const source = addOptionality(getTypeFromTypeNode(typeNode), /*isProperty*/ false, hasQuestionToken(declaration)); |
There was a problem hiding this comment.
hasQuestionToken(declaration) isn't going to do the right thing for jsdoc optional parameters - instead, use the catch-all isOptionalDeclaration.
ContributorAuthor
There was a problem hiding this comment.
👍 pushed out the appropriate change (and a test case)
Wesley Wigham (weswigham)
approved these changes
Aug 16, 2023
Mateusz Burzyński (Andarist)
deleted the
fix/infer-from-annotated-optional-params
branch
August 16, 2023 21:51
Marcus Ording (snovader) pushed a commit
to EG-A-S/TypeScript
that referenced
this pull request
Sep 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#55394