Uh oh!
There was an error while loading. Please reload this page.
Make sure emitted d.ts files are LF, not CRLF - #55407
Merged
Merged
Conversation
Jake Bailey (jakebailey)
requested review from
Andrew Branch (andrewbranch) and Nathan Shively-Sanders (sandersn)August 16, 2023 22:43
Nathan Shively-Sanders (sandersn)
approved these changes
Aug 16, 2023
Marcus Ording (snovader) pushed a commit
to EG-A-S/TypeScript
that referenced
this pull request
Sep 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embarrassingly I forgot that #55403 meant that the dprint'd d.ts bundler output are now getting the wrong newlines, which was not intentional. Make sure we actually write out the right contents...
(The reason that we dprint the bundler outputs is that they are input formatting sensitive as the bundler is very very dumb, so when we change
src, we may spuriously change the bundler output. Not ideal, but now that we have a formatter I could fix that.)