Prefer non-partial signature match in non-generic case by Andarist · Pull Request #55447 · microsoft/TypeScript

Mateusz Burzyński (Andarist) · 2023-08-21T13:33:13Z

Wesley Wigham (weswigham) · 2023-09-13T18:36:46Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2023-09-13T18:36:48Z

Heya Wesley Wigham (@weswigham), I've started to run the regular perf test suite on this PR at 54b5ad0. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-09-13T18:36:48Z

Heya Wesley Wigham (@weswigham), I've started to run the parallelized Definitely Typed test suite on this PR at 54b5ad0. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-09-13T18:36:48Z

Heya Wesley Wigham (@weswigham), I've started to run the diff-based top-repos suite on this PR at 54b5ad0. You can monitor the build here.

Update: The results are in!

Wesley Wigham (weswigham)

I think this is good, but since it affects overload resolution (admittedly in an edge case when we're talking about union overloads), it might have knock-on effects in the wild, so we'll have to make sure the extended test suites come back OK.

TypeScript Bot (typescript-bot) · 2023-09-13T19:11:27Z

Wesley Wigham (@weswigham)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{300,257k (± 0.01%)}	_{300,273k (± 0.01%)}	_~	_300,263k	_300,308k	_{p=0.373 n=6}
_{Parse Time}	_{3.00s (± 0.17%)}	_{3.01s (± 0.18%)}	_~	_3.00s	_3.01s	_{p=0.640 n=6}
_{Bind Time}	_{0.93s (± 0.00%)}	_{0.93s (± 0.00%)}	_~	_0.93s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{9.30s (± 0.09%)}	_{9.33s (± 0.36%)}	_~	_9.29s	_9.37s	_{p=0.289 n=6}
_{Emit Time}	_{7.61s (± 0.43%)}	_{7.64s (± 0.30%)}	_~	_7.60s	_7.66s	_{p=0.169 n=6}
_{Total Time}	_{20.85s (± 0.15%)}	_{20.90s (± 0.21%)}	_~	_20.83s	_20.94s	_{p=0.064 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{194,362k (± 0.53%)}	_{194,474k (± 0.67%)}	_~	_193,923k	_197,118k	_{p=1.000 n=6}
_{Parse Time}	_{1.58s (± 0.00%)}	_{1.58s (± 0.00%)}	_~	_1.58s	_1.58s	_{p=1.000 n=6}
_{Bind Time}	_{0.79s (± 0.69%)}	_{0.80s (± 0.51%)}	_~	_0.79s	_0.80s	_{p=0.282 n=6}
_{Check Time}	_{9.96s (± 0.48%)}	_{9.95s (± 0.23%)}	_~	_9.93s	_9.99s	_{p=0.871 n=6}
_{Emit Time}	_{2.74s (± 0.33%)}	_{2.74s (± 0.15%)}	_~	_2.73s	_2.74s	_{p=0.787 n=6}
_{Total Time}	_{15.07s (± 0.30%)}	_{15.07s (± 0.16%)}	_~	_15.04s	_15.10s	_{p=0.936 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{347,201k (± 0.01%)}	_{347,172k (± 0.01%)}	_~	_347,130k	_347,218k	_{p=0.173 n=6}
_{Parse Time}	_{2.68s (± 0.30%)}	_{2.69s (± 0.45%)}	_~	_2.67s	_2.70s	_{p=0.652 n=6}
_{Bind Time}	_{0.99s (± 0.41%)}	_{0.99s (± 0.00%)}	_~	_0.99s	_0.99s	_{p=0.405 n=6}
_{Check Time}	_{7.93s (± 0.10%)}	_{7.93s (± 0.26%)}	_~	_7.91s	_7.96s	_{p=0.805 n=6}
_{Emit Time}	_{4.26s (± 0.35%)}	_{4.27s (± 0.41%)}	_~	_4.25s	_4.30s	_{p=0.328 n=6}
_{Total Time}	_{15.86s (± 0.13%)}	_{15.88s (± 0.15%)}	_~	_15.84s	_15.91s	_{p=0.222 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{301,188k (± 0.01%)}	_{301,178k (± 0.00%)}	_~	_301,172k	_301,186k	_{p=0.128 n=6}
_{Parse Time}	_{2.19s (± 0.75%)}	_{2.17s (± 0.45%)}	_~	_2.16s	_2.18s	_{p=0.111 n=6}
_{Bind Time}	_{1.08s (± 6.41%)}	_{1.11s (± 0.46%)}	_~	_1.11s	_1.12s	_{p=0.114 n=6}
_{Check Time}	_{7.22s (± 0.35%)}	_{7.21s (± 0.20%)}	_~	_7.19s	_7.23s	_{p=0.514 n=6}
_{Emit Time}	_{3.99s (± 0.54%)}	_{3.99s (± 0.20%)}	_~	_3.97s	_3.99s	_{p=0.932 n=6}
_{Total Time}	_{14.47s (± 0.51%)}	_{14.48s (± 0.14%)}	_~	_14.46s	_14.52s	_{p=0.573 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{479,547k (± 0.00%)}	_{479,555k (± 0.01%)}	_~	_479,483k	_479,589k	_{p=0.297 n=6}
_{Parse Time}	_{3.15s (± 0.24%)}	_{3.15s (± 0.20%)}	_~	_3.14s	_3.16s	_{p=0.718 n=6}
_{Bind Time}	_{0.91s (± 0.00%)}	_{0.91s (± 0.45%)}	_~	_0.90s	_0.91s	_{p=0.405 n=6}
_{Check Time}	_{17.83s (± 0.28%)}	_{17.87s (± 0.26%)}	_~	_17.81s	_17.92s	_{p=0.295 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.89s (± 0.23%)}	_{21.93s (± 0.23%)}	_~	_21.87s	_21.99s	_{p=0.336 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{542,960k (± 0.03%)}	_{542,955k (± 0.01%)}	_~	_542,880k	_543,044k	_{p=0.298 n=6}
_{Parse Time}	_{3.70s (± 0.24%)}	_{3.68s (± 0.33%)}	_{-0.02s (- 0.45%)}	_3.67s	_3.70s	_{p=0.039 n=6}
_{Bind Time}	_{1.38s (± 4.31%)}	_{1.46s (± 0.28%)}	_{+0.08s (+ 5.80%)}	_1.45s	_1.46s	_{p=0.018 n=6}
_{Check Time}	_{3.27s (± 2.62%)}	_{3.18s (± 0.31%)}	_~	_3.17s	_3.19s	_{p=0.169 n=6}
_{Emit Time}	_{0.08s (± 6.19%)}	_{0.09s (± 6.44%)}	_~	_0.08s	_0.09s	_{p=0.640 n=6}
_{Total Time}	_{8.44s (± 0.40%)}	_{8.40s (± 0.18%)}	_~	_8.38s	_8.42s	_{p=0.123 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,488ms (± 0.15%)}	_{2,490ms (± 0.05%)}	_~	_2,488ms	_2,491ms	_{p=0.459 n=6}
_{Req 2 - geterr}	_{5,942ms (± 0.36%)}	_{5,947ms (± 0.24%)}	_~	_5,929ms	_5,962ms	_{p=0.378 n=6}
_{Req 3 - references}	_{344ms (± 0.37%)}	_{344ms (± 0.34%)}	_~	_343ms	_346ms	_{p=0.801 n=6}
_{Req 4 - navto}	_{277ms (± 0.98%)}	_{276ms (± 0.30%)}	_~	_275ms	_277ms	_{p=0.548 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 4.13%)}	_{82ms (± 8.08%)}	_~	_76ms	_94ms	_{p=0.739 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,643ms (± 1.73%)}	_{2,610ms (± 0.61%)}	_~	_2,585ms	_2,631ms	_{p=0.173 n=6}
_{Req 2 - geterr}	_{4,780ms (± 0.18%)}	_{4,769ms (± 0.22%)}	_~	_4,759ms	_4,783ms	_{p=0.109 n=6}
_{Req 3 - references}	_{351ms (± 0.16%)}	_{351ms (± 0.16%)}	_~	_350ms	_351ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{268ms (± 0.51%)}	_{269ms (± 0.00%)}	_~	_269ms	_269ms	_{p=0.293 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 1.04%)}	_{79ms (± 0.52%)}	_~	_78ms	_79ms	_{p=1.000 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,707ms (± 0.20%)}	_{2,708ms (± 0.16%)}	_~	_2,702ms	_2,714ms	_{p=0.747 n=6}
_{Req 2 - geterr}	_{1,968ms (± 1.47%)}	_{1,975ms (± 0.66%)}	_~	_1,952ms	_1,987ms	_{p=0.936 n=6}
_{Req 3 - references}	_{135ms (± 1.87%)}	_{138ms (± 2.73%)}	_~	_131ms	_141ms	_{p=0.107 n=6}
_{Req 4 - navto}	_{358ms (± 0.45%)}	_{361ms (± 0.87%)}	_~	_357ms	_365ms	_{p=0.081 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{320ms (± 1.54%)}	_{328ms (± 1.30%)}	_{+8ms (+ 2.40%)}	_319ms	_330ms	_{p=0.049 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

CompilerTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
xstateTSServer - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{156.55ms (± 0.21%)}	_{156.68ms (± 0.19%)}	_{+0.12ms (+ 0.08%)}	_154.72ms	_160.63ms	_{p=0.006 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{230.91ms (± 0.12%)}	_{231.61ms (± 0.19%)}	_{+0.70ms (+ 0.30%)}	_230.05ms	_245.94ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{235.51ms (± 0.13%)}	_{236.09ms (± 0.15%)}	_{+0.58ms (+ 0.24%)}	_234.72ms	_243.24ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{235.63ms (± 0.14%)}	_{235.71ms (± 0.13%)}	_{+0.08ms (+ 0.03%)}	_234.29ms	_244.51ms	_{p=0.001 n=600}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2023-09-13T19:38:05Z

Wesley Wigham (@weswigham) Here are the results of running the top-repos suite comparing main and refs/pull/55447/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-09-13T20:13:33Z

Hey Wesley Wigham (@weswigham), it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

…-signature

Prefer non-partial signature match in non-generic case
54b5ad0

TypeScript Bot (typescript-bot) added the For Backlog Bug PRs that fix a backlog bug label Aug 21, 2023

Nathan Shively-Sanders (sandersn) requested review from Gabriela Araujo Britto (gabritto) and Wesley Wigham (weswigham)September 7, 2023 22:11

Nathan Shively-Sanders (sandersn) assigned Gabriela Araujo Britto (gabritto)Sep 7, 2023

Wesley Wigham (weswigham) approved these changes Sep 13, 2023
View reviewed changes

Merge branch 'main' into prefer-non-partial-match-when-creating-union…
45b3402
…-signature

Nathan Shively-Sanders (sandersn) merged commit 0a87761 into microsoft:mainNov 30, 2023

Ashley Claymore (acutmore) mentioned this pull request Feb 21, 2024
Bloomberg feedback for 5.4 Beta #57464
Closed
1 task

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Navigation Menu

Uh oh!

Prefer non-partial signature match in non-generic case - #55447

Prefer non-partial signature match in non-generic case#55447
Nathan Shively-Sanders (sandersn) merged 2 commits into
microsoft:mainfrom
Andarist:prefer-non-partial-match-when-creating-union-signature

Mateusz Burzyński (Andarist) commented Aug 21, 2023

Uh oh!

Wesley Wigham (weswigham) commented Sep 13, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 13, 2023•
edited
Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 13, 2023•
edited
Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 13, 2023•
edited
Loading

Uh oh!

Wesley Wigham (weswigham) left a comment

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 13, 2023

Compiler

tsserver

Startup

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 13, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Mateusz Burzyński (Andarist) commented Aug 21, 2023

Uh oh!

Wesley Wigham (weswigham) commented Sep 13, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 13, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 13, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 13, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Wesley Wigham (weswigham) left a comment

Choose a reason for hiding this comment

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 13, 2023

Compiler

tsserver

Startup

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 13, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TypeScript Bot (typescript-bot) commented Sep 13, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Sep 13, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Sep 13, 2023•
edited
Loading