Remove `CheckMode.IsForStringLiteralArgumentCompletions` by Andarist · Pull Request #55867 · microsoft/TypeScript

Mateusz Burzyński (Andarist) · 2023-09-25T22:43:13Z

It's just an internal refactor.

I initially removed this special check mode almost entirely in #53996 . It was brought up in #54121 . I managed to remove it while reviewing this PR (see here) but I concluded then that this change should be proposed as a follow up - so here it is :)

TypeScript Bot (typescript-bot) · 2023-09-25T22:43:17Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Mateusz Burzyński (Andarist) · 2023-09-25T22:46:33Z

 //// const nestedExpression = parse({ prop: "foo|/*ts2*/" })

-verify.completions({ marker: ["ts", "ts2"], exact: ["foo|foo", "foo|bar", "foo|baz"] });
+verify.completions({ marker: ["ts"], exact: ["foo", "bar", "baz", "foo|foo", "foo|bar", "foo|baz"] });


This matches Ron's initial expectations from #54121 .
The other case, ideally, should provide the same completions but currently, the ones based on the contextual types and the ones based on getCandidateSignaturesForStringLiteralCompletions work quite differently (and even more so with changes from #54121 ). I plan to close the gap between both a little bit but I'm leaving that for future PRs.

Jake Bailey (jakebailey)

Seems good to me as a cleanup; I the fewer check modes the better 😄

Daniel Rosenwasser (DanielRosenwasser) · 2023-09-29T19:35:38Z

TypeScript Bot (@typescript-bot) pack this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test tsserver
TypeScript Bot (@typescript-bot) test tsserver top200
TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2023-09-29T19:35:41Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the tarball bundle task on this PR at d1477e0. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-09-29T19:35:41Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based top-repos suite (tsserver) on this PR at d1477e0. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-09-29T19:35:41Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based user code test suite (tsserver) on this PR at d1477e0. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-09-29T19:35:42Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based top-repos suite on this PR at d1477e0. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-09-29T19:35:42Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the regular perf test suite on this PR at d1477e0. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-09-29T19:37:35Z

Hey Daniel Rosenwasser (@DanielRosenwasser), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158016/artifacts?artifactName=tgz&fileId=702CF64F8B3FD4165BC45D1E0BFDFF9180E3E10721483ECE39D2EE338AB3500102&fileName=/typescript-5.3.0-insiders.20230929.tgz"
}
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.3.0-pr-55867-7".;

TypeScript Bot (typescript-bot) · 2023-09-29T19:51:07Z

Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the user test suite comparing main and refs/pull/55867/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-09-29T20:00:27Z

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,080k (± 0.01%)}	_{295,082k (± 0.01%)}	_~	_295,043k	_295,158k	_{p=0.810 n=6}
_{Parse Time}	_{2.64s (± 0.52%)}	_{2.63s (± 0.62%)}	_~	_2.61s	_2.65s	_{p=0.324 n=6}
_{Bind Time}	_{0.84s (± 1.06%)}	_{0.84s (± 0.97%)}	_~	_0.83s	_0.85s	_{p=0.550 n=6}
_{Check Time}	_{8.08s (± 0.13%)}	_{8.05s (± 0.29%)}	_~	_8.03s	_8.08s	_{p=0.120 n=6}
_{Emit Time}	_{7.04s (± 0.22%)}	_{7.05s (± 0.33%)}	_~	_7.02s	_7.08s	_{p=0.223 n=6}
_{Total Time}	_{18.59s (± 0.12%)}	_{18.58s (± 0.22%)}	_~	_18.53s	_18.64s	_{p=0.421 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,638k (± 1.67%)}	_{191,651k (± 1.24%)}	_~	_190,628k	_196,506k	_{p=0.336 n=6}
_{Parse Time}	_{1.35s (± 1.40%)}	_{1.35s (± 1.09%)}	_~	_1.34s	_1.38s	_{p=1.000 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.19s (± 0.84%)}	_{9.15s (± 0.27%)}	_~	_9.12s	_9.19s	_{p=0.295 n=6}
_{Emit Time}	_{2.64s (± 0.81%)}	_{2.63s (± 0.51%)}	_~	_2.61s	_2.65s	_{p=0.279 n=6}
_{Total Time}	_{13.92s (± 0.51%)}	_{13.86s (± 0.23%)}	_~	_13.82s	_13.90s	_{p=0.147 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,306k (± 0.00%)}	_{347,296k (± 0.01%)}	_~	_347,259k	_347,312k	_{p=0.296 n=6}
_{Parse Time}	_{2.46s (± 0.70%)}	_{2.46s (± 0.66%)}	_~	_2.44s	_2.48s	_{p=0.625 n=6}
_{Bind Time}	_{0.94s (± 0.43%)}	_{0.94s (± 0.00%)}	_~	_0.94s	_0.94s	_{p=0.405 n=6}
_{Check Time}	_{6.92s (± 0.51%)}	_{6.90s (± 0.42%)}	_~	_6.86s	_6.94s	_{p=0.626 n=6}
_{Emit Time}	_{4.02s (± 0.30%)}	_{4.02s (± 0.49%)}	_~	_3.98s	_4.03s	_{p=0.737 n=6}
_{Total Time}	_{14.33s (± 0.29%)}	_{14.32s (± 0.26%)}	_~	_14.29s	_14.39s	_{p=0.743 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,587k (± 0.02%)}	_{302,538k (± 0.01%)}	_~	_302,513k	_302,560k	_{p=0.092 n=6}
_{Parse Time}	_{1.98s (± 0.26%)}	_{2.00s (± 0.69%)}	_{+0.02s (+ 1.09%)}	_1.99s	_2.02s	_{p=0.010 n=6}
_{Bind Time}	_{1.01s (± 1.15%)}	_{1.00s (± 1.03%)}	_~	_0.99s	_1.02s	_{p=0.241 n=6}
_{Check Time}	_{6.24s (± 0.30%)}	_{6.25s (± 0.38%)}	_~	_6.21s	_6.28s	_{p=0.418 n=6}
_{Emit Time}	_{3.57s (± 0.35%)}	_{3.56s (± 0.58%)}	_~	_3.54s	_3.60s	_{p=0.622 n=6}
_{Total Time}	_{12.81s (± 0.20%)}	_{12.83s (± 0.30%)}	_~	_12.80s	_12.90s	_{p=1.000 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,495k (± 0.00%)}	_{470,491k (± 0.01%)}	_~	_470,458k	_470,524k	_{p=0.378 n=6}
_{Parse Time}	_{2.58s (± 0.47%)}	_{2.57s (± 0.20%)}	_~	_2.57s	_2.58s	_{p=0.923 n=6}
_{Bind Time}	_{1.00s (± 1.04%)}	_{1.00s (± 1.38%)}	_~	_0.98s	_1.02s	_{p=0.618 n=6}
_{Check Time}	_{16.67s (± 0.52%)}	_{16.61s (± 0.70%)}	_~	_16.43s	_16.76s	_{p=0.470 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.25s (± 0.49%)}	_{20.18s (± 0.59%)}	_~	_20.00s	_20.32s	_{p=0.378 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,610k (± 0.01%)}	_{512,601k (± 0.01%)}	_~	_512,539k	_512,645k	_{p=0.873 n=6}
_{Parse Time}	_{3.27s (± 0.42%)}	_{3.27s (± 0.36%)}	_~	_3.25s	_3.28s	_{p=0.383 n=6}
_{Bind Time}	_{1.55s (± 0.26%)}	_{1.55s (± 0.53%)}	_~	_1.55s	_1.57s	_{p=0.218 n=6}
_{Check Time}	_{2.87s (± 1.09%)}	_{2.86s (± 0.58%)}	_~	_2.84s	_2.88s	_{p=0.332 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 5.21%)}	_~	_0.07s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.76s (± 0.37%)}	_{7.76s (± 0.30%)}	_~	_7.72s	_7.78s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,383ms (± 1.10%)}	_{2,386ms (± 1.43%)}	_~	_2,342ms	_2,419ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{5,330ms (± 1.39%)}	_{5,351ms (± 1.62%)}	_~	_5,273ms	_5,466ms	_{p=1.000 n=6}
_{Req 3 - references}	_{330ms (± 1.62%)}	_{328ms (± 0.71%)}	_~	_326ms	_332ms	_{p=0.627 n=6}
_{Req 4 - navto}	_{277ms (± 0.62%)}	_{277ms (± 0.63%)}	_~	_274ms	_278ms	_{p=0.934 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{77ms (± 8.16%)}	_{80ms (± 9.33%)}	_~	_75ms	_90ms	_{p=0.111 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,473ms (± 1.23%)}	_{2,456ms (± 1.03%)}	_~	_2,423ms	_2,487ms	_{p=0.298 n=6}
_{Req 2 - geterr}	_{4,112ms (± 1.64%)}	_{4,190ms (± 1.47%)}	_{+78ms (+ 1.89%)}	_4,065ms	_4,222ms	_{p=0.031 n=6}
_{Req 3 - references}	_{336ms (± 1.23%)}	_{334ms (± 0.51%)}	_~	_332ms	_337ms	_{p=0.511 n=6}
_{Req 4 - navto}	_{283ms (± 0.18%)}	_{284ms (± 0.29%)}	_~	_283ms	_285ms	_{p=0.523 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (± 5.90%)}	_{76ms (± 0.68%)}	_~	_75ms	_76ms	_{p=0.386 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,590ms (± 0.60%)}	_{2,592ms (± 0.74%)}	_~	_2,561ms	_2,614ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{1,704ms (± 2.65%)}	_{1,693ms (± 1.95%)}	_~	_1,660ms	_1,737ms	_{p=0.630 n=6}
_{Req 3 - references}	_{113ms (± 9.00%)}	_{110ms (± 6.94%)}	_~	_105ms	_124ms	_{p=0.870 n=6}
_{Req 4 - navto}	_{360ms (± 0.23%)}	_{359ms (± 0.14%)}	_{-2ms (- 0.46%)}	_358ms	_359ms	_{p=0.009 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{304ms (± 1.86%)}	_{306ms (± 2.00%)}	_~	_295ms	_314ms	_{p=0.685 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.42ms (± 0.19%)}	_{152.28ms (± 0.18%)}	_{-0.14ms (- 0.09%)}	_151.13ms	_155.03ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.30ms (± 0.14%)}	_{227.24ms (± 0.16%)}	_{-0.06ms (- 0.02%)}	_225.93ms	_232.82ms	_{p=0.013 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.85ms (± 0.16%)}	_{228.99ms (± 0.17%)}	_{+0.14ms (+ 0.06%)}	_227.03ms	_234.74ms	_{p=0.002 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.53ms (± 0.17%)}	_{228.50ms (± 0.17%)}	_~	_227.02ms	_235.86ms	_{p=0.407 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2023-09-29T20:54:07Z

Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the top-repos suite comparing main and refs/pull/55867/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-09-29T22:13:42Z

Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the top-repos suite comparing main and refs/pull/55867/merge:

Everything looks good!

Remove CheckMode.IsForStringLiteralArgumentCompletions
d1477e0

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 25, 2023

Mateusz Burzyński (Andarist) commented Sep 25, 2023
View reviewed changes

Jake Bailey (jakebailey) approved these changes Sep 26, 2023
View reviewed changes

Jake Bailey (jakebailey) requested review from Andrew Branch (andrewbranch) and Ron Buckton (rbuckton)September 26, 2023 19:36

Daniel Rosenwasser (DanielRosenwasser) merged commit efc343a into microsoft:mainSep 29, 2023

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Uh oh!

Conversation

Mateusz Burzyński (Andarist) commented Sep 25, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 25, 2023

Uh oh!

Mateusz Burzyński (Andarist)Sep 25, 2023

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey) left a comment

Choose a reason for hiding this comment

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Sep 29, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 29, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 29, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 29, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 29, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 29, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 29, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 29, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 29, 2023

Compiler

tsserver

Startup

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 29, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TypeScript Bot (typescript-bot) commented Sep 29, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Sep 29, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Sep 29, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Sep 29, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Sep 29, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Sep 29, 2023•
edited
Loading