Bail early in getNarrowedTypeWorker if type is candidate by jakebailey · Pull Request #55926 · microsoft/TypeScript

Jake Bailey (jakebailey) · 2023-09-30T07:55:42Z

This technically handles #52345 (comment) and maybe #55948, bringing it back to <=4.7 levels, but I think it's a little silly to narrow something to itself. But, probably cheap to check anyhow.

Jake Bailey (jakebailey) · 2023-09-30T07:56:17Z

TypeScript Bot (@typescript-bot) perf test this
TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2023-09-30T07:56:20Z

Heya Jake Bailey (@jakebailey), I've started to run the regular perf test suite on this PR at b330fbc. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-09-30T07:56:20Z

Heya Jake Bailey (@jakebailey), I've started to run the tarball bundle task on this PR at b330fbc. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-09-30T07:58:24Z

Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158040/artifacts?artifactName=tgz&fileId=5B641F9BC561DDCDFE93B4E7D8D9581096D3B6BE20D3E0ED9F4417909E1BA7EC02&fileName=/typescript-5.3.0-insiders.20230930.tgz"
}
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.3.0-pr-55926-3".;

TypeScript Bot (typescript-bot) · 2023-09-30T08:14:56Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,051k (± 0.02%)}	_{295,098k (± 0.01%)}	_{+48k (+ 0.02%)}	_295,050k	_295,144k	_{p=0.045 n=6}
_{Parse Time}	_{2.63s (± 0.72%)}	_{2.64s (± 0.52%)}	_~	_2.62s	_2.66s	_{p=0.510 n=6}
_{Bind Time}	_{0.84s (± 0.97%)}	_{0.84s (± 1.30%)}	_~	_0.83s	_0.85s	_{p=0.662 n=6}
_{Check Time}	_{8.07s (± 0.13%)}	_{8.06s (± 0.20%)}	_~	_8.03s	_8.08s	_{p=0.249 n=6}
_{Emit Time}	_{7.03s (± 0.48%)}	_{7.04s (± 0.30%)}	_~	_7.02s	_7.07s	_{p=0.418 n=6}
_{Total Time}	_{18.57s (± 0.13%)}	_{18.57s (± 0.19%)}	_~	_18.53s	_18.62s	_{p=0.872 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{191,640k (± 1.23%)}	_{192,490k (± 1.20%)}	_~	_190,658k	_196,458k	_{p=0.936 n=6}
_{Parse Time}	_{1.34s (± 0.78%)}	_{1.34s (± 0.99%)}	_~	_1.32s	_1.35s	_{p=0.451 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.21s (± 0.88%)}	_{9.27s (± 1.21%)}	_~	_9.13s	_9.38s	_{p=0.378 n=6}
_{Emit Time}	_{2.63s (± 0.47%)}	_{2.63s (± 0.39%)}	_~	_2.62s	_2.65s	_{p=0.101 n=6}
_{Total Time}	_{13.91s (± 0.56%)}	_{13.97s (± 0.87%)}	_~	_13.81s	_14.11s	_{p=0.378 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,296k (± 0.01%)}	_{347,319k (± 0.01%)}	_~	_347,295k	_347,351k	_{p=0.128 n=6}
_{Parse Time}	_{2.46s (± 0.33%)}	_{2.45s (± 0.49%)}	_~	_2.43s	_2.46s	_{p=0.115 n=6}
_{Bind Time}	_{0.94s (± 0.00%)}	_{0.94s (± 0.00%)}	_~	_0.94s	_0.94s	_{p=1.000 n=6}
_{Check Time}	_{6.90s (± 0.28%)}	_{6.91s (± 0.57%)}	_~	_6.84s	_6.95s	_{p=0.418 n=6}
_{Emit Time}	_{4.02s (± 0.26%)}	_{4.01s (± 0.55%)}	_~	_3.99s	_4.05s	_{p=0.100 n=6}
_{Total Time}	_{14.33s (± 0.19%)}	_{14.31s (± 0.25%)}	_~	_14.28s	_14.37s	_{p=0.418 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,549k (± 0.00%)}	_{302,538k (± 0.01%)}	_~	_302,506k	_302,566k	_{p=0.378 n=6}
_{Parse Time}	_{2.00s (± 0.81%)}	_{2.02s (± 0.58%)}	_~	_2.01s	_2.04s	_{p=0.085 n=6}
_{Bind Time}	_{1.01s (± 1.04%)}	_{1.00s (± 0.75%)}	_~	_0.99s	_1.01s	_{p=0.611 n=6}
_{Check Time}	_{6.26s (± 0.47%)}	_{6.27s (± 0.50%)}	_~	_6.23s	_6.31s	_{p=0.418 n=6}
_{Emit Time}	_{3.56s (± 0.70%)}	_{3.56s (± 0.14%)}	_~	_3.56s	_3.57s	_{p=0.360 n=6}
_{Total Time}	_{12.83s (± 0.11%)}	_{12.86s (± 0.23%)}	_~	_12.81s	_12.88s	_{p=0.145 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,488k (± 0.00%)}	_{470,502k (± 0.00%)}	_~	_470,480k	_470,518k	_{p=0.230 n=6}
_{Parse Time}	_{2.57s (± 0.38%)}	_{2.59s (± 0.80%)}	_~	_2.57s	_2.62s	_{p=0.181 n=6}
_{Bind Time}	_{1.00s (± 0.52%)}	_{1.00s (± 1.37%)}	_~	_0.98s	_1.02s	_{p=0.794 n=6}
_{Check Time}	_{16.60s (± 0.37%)}	_{16.58s (± 0.32%)}	_~	_16.53s	_16.66s	_{p=0.572 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.17s (± 0.35%)}	_{20.16s (± 0.20%)}	_~	_20.11s	_20.21s	_{p=0.687 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,600k (± 0.02%)}	_{512,582k (± 0.01%)}	_~	_512,498k	_512,618k	_{p=0.689 n=6}
_{Parse Time}	_{3.27s (± 0.36%)}	_{3.28s (± 0.32%)}	_~	_3.26s	_3.29s	_{p=0.406 n=6}
_{Bind Time}	_{1.55s (± 0.26%)}	_{1.55s (± 0.26%)}	_~	_1.54s	_1.55s	_{p=1.000 n=6}
_{Check Time}	_{2.87s (± 0.56%)}	_{2.89s (± 1.07%)}	_~	_2.85s	_2.93s	_{p=0.225 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{7.76s (± 0.23%)}	_{7.78s (± 0.38%)}	_~	_7.73s	_7.82s	_{p=0.145 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,346ms (± 0.83%)}	_{2,343ms (± 1.10%)}	_~	_2,313ms	_2,387ms	_{p=0.873 n=6}
_{Req 2 - geterr}	_{5,366ms (± 1.40%)}	_{5,385ms (± 1.52%)}	_~	_5,272ms	_5,455ms	_{p=0.873 n=6}
_{Req 3 - references}	_{332ms (± 1.19%)}	_{327ms (± 0.16%)}	_{-5ms (- 1.61%)}	_326ms	_327ms	_{p=0.039 n=6}
_{Req 4 - navto}	_{275ms (± 0.82%)}	_{276ms (± 0.94%)}	_~	_273ms	_280ms	_{p=0.935 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{82ms (±10.20%)}	_{84ms (± 8.27%)}	_~	_75ms	_90ms	_{p=0.802 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,465ms (± 1.21%)}	_{2,482ms (± 0.76%)}	_~	_2,456ms	_2,504ms	_{p=0.423 n=6}
_{Req 2 - geterr}	_{4,155ms (± 1.59%)}	_{4,073ms (± 1.44%)}	_{-82ms (- 1.98%)}	_4,028ms	_4,190ms	_{p=0.045 n=6}
_{Req 3 - references}	_{335ms (± 1.03%)}	_{338ms (± 1.16%)}	_~	_334ms	_343ms	_{p=0.089 n=6}
_{Req 4 - navto}	_{283ms (± 0.27%)}	_{283ms (± 0.48%)}	_~	_282ms	_285ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (± 5.82%)}	_{78ms (± 9.38%)}	_~	_71ms	_87ms	_{p=0.801 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,595ms (± 0.38%)}	_{2,597ms (± 0.53%)}	_~	_2,577ms	_2,618ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{1,704ms (± 2.81%)}	_{1,676ms (± 1.97%)}	_~	_1,631ms	_1,731ms	_{p=0.378 n=6}
_{Req 3 - references}	_{109ms (± 4.57%)}	_{115ms (± 9.24%)}	_~	_105ms	_126ms	_{p=0.468 n=6}
_{Req 4 - navto}	_{360ms (± 0.41%)}	_{359ms (± 0.14%)}	_{-2ms (- 0.42%)}	_358ms	_359ms	_{p=0.039 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{308ms (± 1.47%)}	_{307ms (± 1.61%)}	_~	_303ms	_316ms	_{p=0.572 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.43ms (± 0.17%)}	_{152.45ms (± 0.19%)}	_~	_151.33ms	_156.11ms	_{p=1.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.01ms (± 0.15%)}	_{226.99ms (± 0.17%)}	_~	_225.65ms	_232.33ms	_{p=0.294 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.69ms (± 0.16%)}	_{228.75ms (± 0.17%)}	_~	_227.22ms	_235.65ms	_{p=0.191 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.51ms (± 0.16%)}	_{228.54ms (± 0.13%)}	_~	_227.16ms	_231.65ms	_{p=0.124 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Jake Bailey (jakebailey) · 2023-10-02T03:44:51Z

TypeScript Bot (@typescript-bot) perf test this faster

TypeScript Bot (typescript-bot) · 2023-10-02T03:44:53Z

Heya Jake Bailey (@jakebailey), I've started to run the tsc-only perf test suite on this PR at 1c14f5c. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-10-02T03:56:58Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,067k (± 0.01%)}	_{295,065k (± 0.01%)}	_~	_295,049k	_295,089k	_{p=0.936 n=6}
_{Parse Time}	_{2.63s (± 0.52%)}	_{2.63s (± 0.44%)}	_~	_2.61s	_2.64s	_{p=0.865 n=6}
_{Bind Time}	_{0.83s (± 0.62%)}	_{0.84s (± 0.97%)}	_{+0.01s (+ 1.20%)}	_0.83s	_0.85s	_{p=0.050 n=6}
_{Check Time}	_{8.07s (± 0.38%)}	_{8.07s (± 0.39%)}	_~	_8.03s	_8.12s	_{p=0.627 n=6}
_{Emit Time}	_{7.04s (± 0.33%)}	_{7.06s (± 0.12%)}	_{+0.02s (+ 0.31%)}	_7.05s	_7.07s	_{p=0.026 n=6}
_{Total Time}	_{18.58s (± 0.10%)}	_{18.60s (± 0.18%)}	_~	_18.56s	_18.66s	_{p=0.413 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,048k (± 1.48%)}	_{191,115k (± 0.54%)}	_~	_190,674k	_193,234k	_{p=0.810 n=6}
_{Parse Time}	_{1.35s (± 1.24%)}	_{1.35s (± 0.30%)}	_~	_1.34s	_1.35s	_{p=0.446 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.19s (± 0.70%)}	_{9.19s (± 0.54%)}	_~	_9.14s	_9.26s	_{p=1.000 n=6}
_{Emit Time}	_{2.64s (± 0.65%)}	_{2.63s (± 0.34%)}	_~	_2.62s	_2.64s	_{p=0.458 n=6}
_{Total Time}	_{13.90s (± 0.54%)}	_{13.90s (± 0.38%)}	_~	_13.84s	_13.97s	_{p=1.000 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,300k (± 0.00%)}	_{347,296k (± 0.00%)}	_~	_347,284k	_347,309k	_{p=0.575 n=6}
_{Parse Time}	_{2.46s (± 0.40%)}	_{2.46s (± 0.21%)}	_~	_2.45s	_2.46s	_{p=0.931 n=6}
_{Bind Time}	_{0.94s (± 0.43%)}	_{0.94s (± 0.43%)}	_~	_0.94s	_0.95s	_{p=0.218 n=6}
_{Check Time}	_{6.91s (± 0.53%)}	_{6.91s (± 0.35%)}	_~	_6.88s	_6.95s	_{p=0.629 n=6}
_{Emit Time}	_{4.02s (± 0.38%)}	_{4.01s (± 0.44%)}	_~	_3.98s	_4.03s	_{p=0.103 n=6}
_{Total Time}	_{14.33s (± 0.33%)}	_{14.31s (± 0.25%)}	_~	_14.26s	_14.37s	_{p=0.419 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,560k (± 0.01%)}	_{302,546k (± 0.00%)}	_~	_302,527k	_302,566k	_{p=0.748 n=6}
_{Parse Time}	_{1.99s (± 0.61%)}	_{2.00s (± 0.88%)}	_~	_1.98s	_2.03s	_{p=0.277 n=6}
_{Bind Time}	_{1.01s (± 1.02%)}	_{1.00s (± 1.22%)}	_~	_0.99s	_1.02s	_{p=0.784 n=6}
_{Check Time}	_{6.27s (± 0.17%)}	_{6.27s (± 0.16%)}	_~	_6.26s	_6.28s	_{p=0.931 n=6}
_{Emit Time}	_{3.57s (± 0.52%)}	_{3.55s (± 0.34%)}	_~	_3.54s	_3.57s	_{p=0.061 n=6}
_{Total Time}	_{12.84s (± 0.18%)}	_{12.83s (± 0.15%)}	_~	_12.80s	_12.86s	_{p=0.285 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,512k (± 0.01%)}	_{470,506k (± 0.00%)}	_~	_470,486k	_470,524k	_{p=0.936 n=6}
_{Parse Time}	_{2.58s (± 0.32%)}	_{2.58s (± 0.53%)}	_~	_2.56s	_2.60s	_{p=0.605 n=6}
_{Bind Time}	_{0.99s (± 1.18%)}	_{0.99s (± 0.76%)}	_~	_0.98s	_1.00s	_{p=0.796 n=6}
_{Check Time}	_{16.63s (± 0.26%)}	_{16.62s (± 0.40%)}	_~	_16.54s	_16.69s	_{p=0.688 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.20s (± 0.17%)}	_{20.19s (± 0.28%)}	_~	_20.13s	_20.25s	_{p=0.630 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,583k (± 0.00%)}	_{512,609k (± 0.02%)}	_~	_512,506k	_512,745k	_{p=0.378 n=6}
_{Parse Time}	_{3.27s (± 0.41%)}	_{3.27s (± 0.37%)}	_~	_3.24s	_3.27s	_{p=0.675 n=6}
_{Bind Time}	_{1.55s (± 0.33%)}	_{1.55s (± 0.33%)}	_~	_1.55s	_1.56s	_{p=1.000 n=6}
_{Check Time}	_{2.88s (± 0.64%)}	_{2.88s (± 0.99%)}	_~	_2.84s	_2.92s	_{p=0.871 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{7.78s (± 0.20%)}	_{7.77s (± 0.43%)}	_~	_7.74s	_7.82s	_{p=0.293 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Jake Bailey (jakebailey) · 2023-10-12T21:55:48Z

I still feel like this might be slightly silly, but it seems really cheap and quick to just check for cases where we're trying to narrow something to itself and bail early without doing all of the other work.

Gabriela Araujo Britto (gabritto) · 2023-10-13T00:36:28Z

The change makes sense, but where in type checking the motivating case https://github.com/epmatsw/tsdemo/blob/main/slow.ts do we call getNarrowedType with type and candidate being the same?

Jake Bailey (jakebailey) · 2023-10-13T01:52:29Z

I think the example has been updated; it used to be narrowing something to itself.

Gabriela Araujo Britto (gabritto) · 2023-10-13T03:12:50Z

I think the example has been updated; it used to be narrowing something to itself.

Do you have an example then?

Jake Bailey (jakebailey) · 2023-10-13T04:38:35Z

The repro repo has it if you go back a few commits: https://github.com/epmatsw/tsdemo/tree/b2a2af937e492819045ea4e880a56236494c2147

Something like:

functiontest(base: SpecificString){if(isSpecificString(base)){returnbase;}}

Where SpecificString is a large union of literals.

Gabriela Araujo Britto (gabritto) · 2023-10-13T18:26:18Z

Ah, so it is an explicit narrowing to itself. I don't know how common it is, it doesn't seem like something you want to be doing, but then again you might be programming defensively and you want to validate at run time that something has a type, so I can see a case for writing this kind of code.
I think I agree that, as long as it's cheap to check and doesn't make anything slower, there's not a lot of harm in doing that.

Wesley Wigham (weswigham)

Don't know if you're still waiting on my review for this, but this can be a reminder to merge this at some point~

Jake Bailey (jakebailey) · 2023-11-06T23:36:38Z

I was, kinda; mainly I was trying to decide if this was even worthwhile if it's so rare and silly.

Bail early in getNarrowedTypeWorker if type is candidate
b330fbc

TypeScript Bot (typescript-bot) assigned Jake Bailey (jakebailey)Sep 30, 2023

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 30, 2023

Jake Bailey (jakebailey) mentioned this pull request Sep 30, 2023
Performance regression from #48044 #52345
Closed

And in negative case, use equality
1c14f5c

Jake Bailey (jakebailey) marked this pull request as ready for review October 12, 2023 21:54

Jake Bailey (jakebailey) requested review from Anders Hejlsberg (ahejlsberg), Gabriela Araujo Britto (gabritto) and Wesley Wigham (weswigham)October 12, 2023 21:54

Gabriela Araujo Britto (gabritto) approved these changes Oct 13, 2023
View reviewed changes

Wesley Wigham (weswigham) approved these changes Nov 6, 2023
View reviewed changes

Jake Bailey (jakebailey) merged commit 4b29ab5 into microsoft:mainNov 6, 2023

Jake Bailey (jakebailey) deleted the fix-52345-other branch November 6, 2023 23:50

Will Stamper (epmatsw) mentioned this pull request Nov 27, 2023
Strip tags in placeholders #56458
Closed

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Uh oh!

Conversation

Jake Bailey (jakebailey) commented Sep 30, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Sep 30, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 30, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 30, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 30, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 30, 2023

Compiler

tsserver

Startup

Uh oh!

Jake Bailey (jakebailey) commented Oct 2, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 2, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 2, 2023

Compiler

Uh oh!

Jake Bailey (jakebailey) commented Oct 12, 2023

Uh oh!

Gabriela Araujo Britto (gabritto) commented Oct 13, 2023

Uh oh!

Jake Bailey (jakebailey) commented Oct 13, 2023

Uh oh!

Gabriela Araujo Britto (gabritto) commented Oct 13, 2023

Uh oh!

Jake Bailey (jakebailey) commented Oct 13, 2023

Uh oh!

Gabriela Araujo Britto (gabritto) commented Oct 13, 2023

Uh oh!

Wesley Wigham (weswigham) left a comment

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey) commented Nov 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Jake Bailey (jakebailey) commented Sep 30, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Sep 30, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Sep 30, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Sep 30, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Oct 2, 2023•
edited
Loading