Skip to content

Revert "Disallow numeric literals with negative numbers (#55268)" - #56422

Merged
Jake Bailey (jakebailey) merged 2 commits into
microsoft:mainfrom
jakebailey:revert-55268
Nov 15, 2023
Merged

Revert "Disallow numeric literals with negative numbers (#55268)"#56422
Jake Bailey (jakebailey) merged 2 commits into
microsoft:mainfrom
jakebailey:revert-55268

Conversation

@jakebailey

@jakebaileyJake Bailey (jakebailey) commented Nov 15, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This reverts #55268.

Closes#56301
Updates #56272

For 5.3 it seemed too risky to take this change; there's a lot more inconsistency we've discovered at the last minute and changing it again later seemed bad.

Also #56270 shows that this behavior was being depended on as TS lacks true infinity types.

@typescript-botTypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 15, 2023
@jakebailey
Jake Bailey (jakebailey) merged commit 3333e90 into microsoft:mainNov 15, 2023
@jakebailey

Jake Bailey (jakebailey) commented Nov 15, 2023

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.3

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 15, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the task to cherry-pick this into release-5.3 on this PR at 45371af. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

Hey Jake Bailey (@jakebailey), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-5.3 manually.

@jakebailey

Jake Bailey (jakebailey) commented Nov 15, 2023

Copy link
Copy Markdown
MemberAuthor

sigh

@jakebailey

Jake Bailey (jakebailey) commented Nov 16, 2023

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.3

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 16, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the task to cherry-pick this into release-5.3 on this PR at 45371af. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

Hey Jake Bailey (@jakebailey), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-5.3 manually.

@jakebailey
Jake Bailey (jakebailey) deleted the revert-55268 branch November 16, 2023 00:24
Daniel Rosenwasser (DanielRosenwasser) pushed a commit that referenced this pull request Nov 16, 2023
@jakebailey@DanielRosenwasser
Revert "Disallow numeric literals with negative numbers (#55268)" (#5…
11dbc85
…6422)
Daniel Rosenwasser (DanielRosenwasser) pushed a commit that referenced this pull request Nov 16, 2023
@jakebailey@DanielRosenwasser
Revert "Disallow numeric literals with negative numbers (#55268)" (#5…
64b5c79
…6422)
Mateusz Burzyński (Andarist) added a commit to Andarist/TypeScript that referenced this pull request Nov 28, 2023
@Andarist
Revert "Revert "Disallow numeric literals with negative numbers (micr…
3d7c53d
…osoft#55268)" (microsoft#56422)"
This reverts commit 3333e90.
@AndaristMateusz Burzyński (Andarist) mentioned this pull request Nov 28, 2023
Merged
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranchAndrew Branch (andrewbranch)andrewbranch approved these changes
@DanielRosenwasserDaniel Rosenwasser (DanielRosenwasser)Awaiting requested review from DanielRosenwasser

Assignees

@jakebaileyJake Bailey (jakebailey)

Labels

Author: TeamFor Uncommitted BugPR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakebailey@typescript-bot@andrewbranch