Consistently check assignability to template literal placeholders

[Anders Hejlsberg (ahejlsberg)]

Fixes#56582.

[Anders Hejlsberg (ahejlsberg)]

TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this faster

[TypeScript Bot (typescript-bot)]

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at 0e4c652. You can monitor the build here.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based user code test suite on this PR at 0e4c652. You can monitor the build here.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the tsc-only perf test suite on this PR at 0e4c652. You can monitor the build here.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based top-repos suite on this PR at 0e4c652. You can monitor the build here.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

Metric	baseline	pr	Delta	Best	Worst	p-value
Angular - node (v18.15.0, x64)
Memory used	295,211k (± 0.01%)	295,205k (± 0.01%)	~	295,173k	295,246k	p=0.688 n=6
Parse Time	2.64s (± 0.20%)	2.64s (± 0.20%)	~	2.64s	2.65s	p=1.000 n=6
Bind Time	0.82s (± 0.00%)	0.82s (± 0.00%)	~	0.82s	0.82s	p=1.000 n=6
Check Time	8.04s (± 0.22%)	8.04s (± 0.25%)	~	8.02s	8.08s	p=0.743 n=6
Emit Time	7.08s (± 0.30%)	7.08s (± 0.46%)	~	7.05s	7.14s	p=0.745 n=6
Total Time	18.59s (± 0.09%)	18.58s (± 0.19%)	~	18.53s	18.62s	p=0.870 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used	190,671k (± 0.01%)	195,608k (± 1.24%)	+4,938k (+ 2.59%)	190,641k	196,691k	p=0.045 n=6
Parse Time	1.37s (± 0.85%)	1.36s (± 1.20%)	~	1.34s	1.38s	p=0.680 n=6
Bind Time	0.72s (± 0.00%)	0.72s (± 0.00%)	~	0.72s	0.72s	p=1.000 n=6
Check Time	9.15s (± 0.49%)	9.17s (± 0.48%)	~	9.10s	9.23s	p=0.374 n=6
Emit Time	2.62s (± 0.32%)	2.61s (± 0.51%)	~	2.59s	2.63s	p=0.612 n=6
Total Time	13.85s (± 0.33%)	13.86s (± 0.34%)	~	13.81s	13.93s	p=0.746 n=6
Monaco - node (v18.15.0, x64)
Memory used	347,357k (± 0.00%)	347,345k (± 0.00%)	~	347,322k	347,364k	p=0.230 n=6
Parse Time	2.46s (± 0.60%)	2.46s (± 0.36%)	~	2.45s	2.47s	p=0.804 n=6
Bind Time	0.93s (± 0.56%)	0.93s (± 0.56%)	~	0.92s	0.93s	p=1.000 n=6
Check Time	6.89s (± 0.36%)	6.89s (± 0.35%)	~	6.86s	6.93s	p=0.746 n=6
Emit Time	4.05s (± 0.43%)	4.05s (± 0.40%)	~	4.04s	4.08s	p=1.000 n=6
Total Time	14.32s (± 0.27%)	14.33s (± 0.26%)	~	14.29s	14.40s	p=0.686 n=6
TFS - node (v18.15.0, x64)
Memory used	302,618k (± 0.00%)	302,620k (± 0.01%)	~	302,588k	302,649k	p=0.810 n=6
Parse Time	2.00s (± 0.27%)	2.00s (± 1.03%)	~	1.98s	2.03s	p=1.000 n=6
Bind Time	1.00s (± 0.52%)	1.00s (± 0.98%)	~	0.99s	1.02s	p=0.386 n=6
Check Time	6.26s (± 0.37%)	6.25s (± 0.26%)	~	6.23s	6.28s	p=0.255 n=6
Emit Time	3.57s (± 0.46%)	3.57s (± 0.37%)	~	3.55s	3.59s	p=0.621 n=6
Total Time	12.83s (± 0.22%)	12.83s (± 0.20%)	~	12.80s	12.86s	p=0.872 n=6
material-ui - node (v18.15.0, x64)
Memory used	470,598k (± 0.01%)	470,664k (± 0.02%)	~	470,588k	470,804k	p=0.199 n=6
Parse Time	2.58s (± 0.53%)	2.58s (± 0.32%)	~	2.57s	2.59s	p=0.197 n=6
Bind Time	0.98s (± 0.56%)	0.99s (± 0.83%)	~	0.98s	1.00s	p=0.859 n=6
Check Time	16.76s (± 0.24%)	16.74s (± 0.39%)	~	16.64s	16.83s	p=0.628 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	20.33s (± 0.19%)	20.31s (± 0.34%)	~	20.20s	20.39s	p=0.574 n=6
xstate - node (v18.15.0, x64)
Memory used	512,020k (± 0.01%)	512,030k (± 0.01%)	~	511,969k	512,152k	p=0.936 n=6
Parse Time	3.28s (± 0.26%)	3.28s (± 0.16%)	~	3.27s	3.28s	p=0.923 n=6
Bind Time	1.54s (± 0.26%)	1.53s (± 0.76%)	~	1.51s	1.54s	p=0.056 n=6
Check Time	2.80s (± 0.66%)	2.81s (± 0.59%)	~	2.79s	2.83s	p=0.371 n=6
Emit Time	0.08s (± 4.99%)	0.08s (± 0.00%)	~	0.08s	0.08s	p=0.405 n=6
Total Time	7.69s (± 0.19%)	7.70s (± 0.32%)	~	7.67s	7.72s	p=1.000 n=6

System info unknown

Hosts

• node (v18.15.0, x64)

Scenarios

• Angular - node (v18.15.0, x64)
• Compiler-Unions - node (v18.15.0, x64)
• Monaco - node (v18.15.0, x64)
• TFS - node (v18.15.0, x64)
• material-ui - node (v18.15.0, x64)
• xstate - node (v18.15.0, x64)

Benchmark	Name	Iterations
Current	pr	6
Baseline	baseline	6

Developer Information:

Download Benchmarks

[TypeScript Bot (typescript-bot)]

Anders Hejlsberg (@ahejlsberg) Here are the results of running the user test suite comparing main and refs/pull/56598/merge:

There were infrastructure failures potentially unrelated to your change:

• 2 instances of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

• [MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
  • packages/browsers/test/src/utils.ts#L23 in packages/browsers/test/src/tsconfig.json

[TypeScript Bot (typescript-bot)]

Hey Anders Hejlsberg (@ahejlsberg), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

[TypeScript Bot (typescript-bot)]

Anders Hejlsberg (@ahejlsberg) Here are the results of running the top-repos suite comparing main and refs/pull/56598/merge:

Everything looks good!