Skip to content

Infer between generic mapped types before inferring from apparent type - #56640

Merged
Gabriela Araujo Britto (gabritto) merged 5 commits into
mainfrom
gabritto/issue56133
Jan 2, 2024
Merged

Infer between generic mapped types before inferring from apparent type#56640
Gabriela Araujo Britto (gabritto) merged 5 commits into
mainfrom
gabritto/issue56133

Conversation

@gabritto

@gabrittoGabriela Araujo Britto (gabritto) commented Dec 1, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#56133

@typescript-botTypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 1, 2023
@gabritto

Gabriela Araujo Britto (gabritto) commented Dec 1, 2023

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) run DT
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) perf test this

@gabritto

Gabriela Araujo Britto (gabritto) commented Dec 1, 2023

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) run DT
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the parallelized Definitely Typed test suite on this PR at 88f7f12. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based user code test suite on this PR at 88f7f12. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based top-repos suite on this PR at 88f7f12. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the regular perf test suite on this PR at 88f7f12. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto) Here are the results of running the user test suite comparing main and refs/pull/56640/merge:

There were infrastructure failures potentially unrelated to your change:

  • 2 instances of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
Angular - node (v18.15.0, x64)
Memory used295,379k (± 0.00%)295,416k (± 0.01%)~295,372k295,448kp=0.065 n=6
Parse Time2.64s (± 0.44%)2.65s (± 0.32%)~2.63s2.65sp=0.652 n=6
Bind Time0.82s (± 0.50%)0.82s (± 0.00%)~0.82s0.82sp=0.405 n=6
Check Time8.12s (± 0.16%)8.13s (± 0.32%)~8.09s8.15sp=0.625 n=6
Emit Time7.08s (± 0.36%)7.07s (± 0.21%)~7.04s7.08sp=0.324 n=6
Total Time18.67s (± 0.17%)18.66s (± 0.09%)~18.64s18.68sp=0.737 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used195,311k (± 1.54%)193,761k (± 1.46%)~191,392k197,207kp=0.128 n=6
Parse Time1.36s (± 1.36%)1.35s (± 0.81%)~1.34s1.37sp=0.206 n=6
Bind Time0.72s (± 0.00%)0.72s (± 0.00%)~0.72s0.72sp=1.000 n=6
Check Time9.27s (± 0.40%)9.29s (± 0.31%)~9.25s9.33sp=0.469 n=6
Emit Time2.61s (± 0.67%)2.62s (± 0.52%)~2.60s2.64sp=0.287 n=6
Total Time13.97s (± 0.34%)13.98s (± 0.28%)~13.94s14.05sp=0.568 n=6
Monaco - node (v18.15.0, x64)
Memory used347,378k (± 0.01%)347,390k (± 0.01%)~347,358k347,410kp=0.630 n=6
Parse Time2.45s (± 0.31%)2.46s (± 0.31%)~2.45s2.47sp=0.062 n=6
Bind Time0.92s (± 0.59%)0.93s (± 0.68%)~0.92s0.94sp=0.201 n=6
Check Time6.91s (± 0.18%)6.92s (± 0.33%)~6.88s6.94sp=0.290 n=6
Emit Time4.08s (± 0.83%)4.05s (± 0.48%)~4.02s4.07sp=0.253 n=6
Total Time14.37s (± 0.25%)14.35s (± 0.14%)~14.32s14.38sp=0.746 n=6
TFS - node (v18.15.0, x64)
Memory used302,662k (± 0.01%)302,679k (± 0.01%)~302,653k302,751kp=0.298 n=6
Parse Time1.99s (± 1.58%)2.00s (± 1.07%)~1.98s2.03sp=0.626 n=6
Bind Time1.01s (± 1.49%)1.00s (± 0.98%)~0.99s1.02sp=0.654 n=6
Check Time6.30s (± 0.28%)6.29s (± 0.30%)~6.26s6.31sp=0.511 n=6
Emit Time3.58s (± 0.49%)3.58s (± 0.21%)~3.57s3.59sp=0.620 n=6
Total Time12.88s (± 0.39%)12.87s (± 0.25%)~12.82s12.91sp=0.686 n=6
material-ui - node (v18.15.0, x64)
Memory used506,768k (± 0.00%)506,750k (± 0.01%)~506,724k506,819kp=0.173 n=6
Parse Time2.58s (± 0.57%)2.59s (± 0.76%)~2.57s2.61sp=0.206 n=6
Bind Time0.99s (± 1.11%)1.00s (± 0.82%)~0.99s1.01sp=0.197 n=6
Check Time16.84s (± 0.38%)16.91s (± 0.30%)~16.83s16.96sp=0.126 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time20.41s (± 0.36%)20.49s (± 0.25%)+0.08s (+ 0.39%)20.42s20.56sp=0.042 n=6
xstate - node (v18.15.0, x64)
Memory used512,725k (± 0.01%)512,724k (± 0.01%)~512,682k512,794kp=0.575 n=6
Parse Time3.27s (± 0.36%)3.27s (± 0.12%)~3.27s3.28sp=0.858 n=6
Bind Time1.54s (± 0.49%)1.54s (± 0.49%)~1.53s1.55sp=1.000 n=6
Check Time2.81s (± 0.27%)2.82s (± 0.61%)~2.79s2.84sp=0.087 n=6
Emit Time0.08s (± 4.99%)0.08s (± 4.99%)~0.08s0.09sp=1.000 n=6
Total Time7.69s (± 0.11%)7.71s (± 0.15%)+0.02s (+ 0.19%)7.69s7.72sp=0.037 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • Monaco - node (v18.15.0, x64)
  • TFS - node (v18.15.0, x64)
  • material-ui - node (v18.15.0, x64)
  • xstate - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

tsserver

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen2,347ms (± 0.73%)2,343ms (± 0.69%)~2,321ms2,362msp=0.810 n=6
Req 2 - geterr5,434ms (± 1.74%)5,437ms (± 1.18%)~5,338ms5,492msp=0.689 n=6
Req 3 - references323ms (± 0.71%)327ms (± 1.74%)~320ms334msp=0.295 n=6
Req 4 - navto277ms (± 1.34%)275ms (± 1.18%)~273ms280msp=0.504 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo85ms (± 7.45%)87ms (± 5.22%)~81ms90msp=0.863 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen2,488ms (± 0.83%)2,488ms (± 1.52%)~2,428ms2,530msp=0.936 n=6
Req 2 - geterr4,096ms (± 1.61%)4,123ms (± 1.75%)~4,057ms4,216msp=0.298 n=6
Req 3 - references344ms (± 1.43%)342ms (± 1.48%)~335ms347msp=0.520 n=6
Req 4 - navto285ms (± 0.34%)286ms (± 1.40%)~283ms294msp=0.858 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo87ms (± 5.73%)85ms (± 7.90%)~76ms90msp=1.000 n=6
xstateTSServer - node (v18.15.0, x64)
Req 1 - updateOpen2,591ms (± 0.59%)2,606ms (± 0.49%)~2,587ms2,619msp=0.077 n=6
Req 2 - geterr1,689ms (± 2.19%)1,679ms (± 1.81%)~1,651ms1,719msp=0.575 n=6
Req 3 - references117ms (± 9.37%)104ms (± 5.02%)🟩-12ms (-10.44%)102ms115msp=0.046 n=6
Req 4 - navto364ms (± 0.47%)364ms (± 0.80%)~358ms366msp=0.565 n=6
Req 5 - completionInfo count2,073 (± 0.00%)2,073 (± 0.00%)~2,0732,073p=1.000 n=6
Req 5 - completionInfo312ms (± 2.11%)311ms (± 2.66%)~304ms323msp=0.872 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstateTSServer - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

Startup

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
tsc-startup - node (v18.15.0, x64)
Execution time152.57ms (± 0.19%)152.51ms (± 0.18%)~151.45ms154.74msp=0.062 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time227.95ms (± 0.15%)227.76ms (± 0.22%)-0.20ms (- 0.09%)226.26ms244.38msp=0.000 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time229.31ms (± 0.17%)229.31ms (± 0.19%)~227.60ms234.57msp=0.549 n=600
typescript-startup - node (v18.15.0, x64)
Execution time229.20ms (± 0.17%)229.15ms (± 0.18%)~227.71ms232.28msp=0.120 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

Developer Information:

Download Benchmarks

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

Hey Gabriela Araujo Britto (@gabritto), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto) Here are the results of running the top-repos suite comparing main and refs/pull/56640/merge:

Everything looks good!

@gabritto

Gabriela Araujo Britto (gabritto) commented Dec 1, 2023

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) test top300

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based top-repos suite on this PR at 88f7f12. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 2, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto) Here are the results of running the top-repos suite comparing main and refs/pull/56640/merge:

Everything looks good!

@gabritto

Gabriela Araujo Britto (gabritto) commented Dec 7, 2023

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) pack this

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 7, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the tarball bundle task on this PR at 88f7f12. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 7, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Hey Gabriela Araujo Britto (@gabritto), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/159017/artifacts?artifactName=tgz&fileId=DCA5A96FD292469CC766CCC55F42CE569146C7627ECF2E4447A5C661ADEE920902&fileName=/typescript-5.4.0-insiders.20231207.tgz"
}
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.4.0-pr-56640-15".;

Closed
@typescript-botTypeScript Bot (typescript-bot) added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 14, 2023
@gabritto
Gabriela Araujo Britto (gabritto) marked this pull request as ready for review December 14, 2023 00:37
@gabritto

Gabriela Araujo Britto (gabritto) commented Dec 14, 2023

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) run DT
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) test top300
TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the regular perf test suite on this PR at d867225. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based user code test suite on this PR at d867225. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the parallelized Definitely Typed test suite on this PR at d867225. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based top-repos suite on this PR at d867225. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto) Here are the results of running the user test suite comparing main and refs/pull/56640/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
Angular - node (v18.15.0, x64)
Memory used295,417k (± 0.01%)295,442k (± 0.01%)~295,382k295,486kp=0.229 n=6
Parse Time2.65s (± 0.21%)2.65s (± 0.21%)~2.64s2.65sp=1.000 n=6
Bind Time0.82s (± 0.00%)0.82s (± 0.50%)~0.82s0.83sp=0.405 n=6
Check Time8.15s (± 0.39%)8.14s (± 0.27%)~8.12s8.18sp=0.871 n=6
Emit Time7.10s (± 0.40%)7.09s (± 0.21%)~7.07s7.11sp=0.808 n=6
Total Time18.72s (± 0.23%)18.70s (± 0.12%)~18.66s18.73sp=0.871 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used194,396k (± 1.64%)191,951k (± 0.57%)~191,454k194,200kp=0.521 n=6
Parse Time1.35s (± 1.27%)1.35s (± 1.01%)~1.34s1.38sp=0.932 n=6
Bind Time0.72s (± 0.00%)0.72s (± 0.00%)~0.72s0.72sp=1.000 n=6
Check Time9.24s (± 0.51%)9.24s (± 0.41%)~9.18s9.29sp=1.000 n=6
Emit Time2.63s (± 0.70%)2.63s (± 0.71%)~2.61s2.66sp=0.935 n=6
Total Time13.94s (± 0.32%)13.94s (± 0.37%)~13.86s13.99sp=0.746 n=6
Monaco - node (v18.15.0, x64)
Memory used347,397k (± 0.00%)347,378k (± 0.01%)~347,349k347,405kp=0.149 n=6
Parse Time2.45s (± 0.49%)2.46s (± 0.33%)~2.45s2.47sp=0.157 n=6
Bind Time0.92s (± 0.56%)0.92s (± 0.56%)~0.92s0.93sp=1.000 n=6
Check Time6.87s (± 0.25%)6.88s (± 0.23%)~6.86s6.90sp=0.192 n=6
Emit Time4.06s (± 0.20%)4.04s (± 0.26%)~4.03s4.06sp=0.078 n=6
Total Time14.30s (± 0.12%)14.31s (± 0.15%)~14.28s14.34sp=0.331 n=6
TFS - node (v18.15.0, x64)
Memory used302,660k (± 0.01%)302,662k (± 0.00%)~302,654k302,670kp=0.936 n=6
Parse Time1.99s (± 0.99%)1.99s (± 0.88%)~1.96s2.01sp=0.867 n=6
Bind Time1.01s (± 1.20%)1.00s (± 1.21%)~0.99s1.02sp=0.680 n=6
Check Time6.28s (± 0.27%)6.28s (± 0.33%)~6.25s6.29sp=1.000 n=6
Emit Time3.58s (± 0.14%)3.58s (± 0.39%)~3.56s3.60sp=0.667 n=6
Total Time12.86s (± 0.18%)12.85s (± 0.16%)~12.82s12.88sp=0.463 n=6
material-ui - node (v18.15.0, x64)
Memory used506,788k (± 0.01%)506,806k (± 0.01%)~506,768k506,852kp=0.378 n=6
Parse Time2.59s (± 0.29%)2.59s (± 0.58%)~2.57s2.61sp=0.492 n=6
Bind Time0.99s (± 1.05%)0.99s (± 0.76%)~0.98s1.00sp=0.931 n=6
Check Time16.88s (± 0.29%)16.95s (± 0.49%)~16.82s17.07sp=0.077 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time20.46s (± 0.26%)20.52s (± 0.42%)~20.40s20.66sp=0.127 n=6
xstate - node (v18.15.0, x64)
Memory used512,906k (± 0.02%)512,848k (± 0.01%)~512,795k512,950kp=0.173 n=6
Parse Time3.27s (± 0.23%)3.27s (± 0.17%)~3.26s3.27sp=0.137 n=6
Bind Time1.54s (± 0.41%)1.53s (± 0.36%)~1.53s1.54sp=0.201 n=6
Check Time2.83s (± 0.47%)2.82s (± 0.83%)~2.79s2.86sp=0.413 n=6
Emit Time0.07s (± 0.00%)0.07s (± 7.03%)~0.07s0.08sp=0.174 n=6
Total Time7.71s (± 0.13%)7.70s (± 0.24%)~7.67s7.72sp=0.255 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • Monaco - node (v18.15.0, x64)
  • TFS - node (v18.15.0, x64)
  • material-ui - node (v18.15.0, x64)
  • xstate - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

tsserver

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen2,359ms (± 0.58%)2,349ms (± 1.19%)~2,315ms2,376msp=0.810 n=6
Req 2 - geterr5,373ms (± 0.50%)5,362ms (± 1.11%)~5,308ms5,476msp=0.229 n=6
Req 3 - references325ms (± 0.90%)326ms (± 0.57%)~324ms328msp=0.677 n=6
Req 4 - navto280ms (± 0.69%)279ms (± 0.85%)~276ms281msp=0.550 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo87ms (± 6.67%)86ms (± 5.69%)~82ms94msp=0.801 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen2,470ms (± 1.35%)2,474ms (± 0.85%)~2,436ms2,498msp=1.000 n=6
Req 2 - geterr4,142ms (± 1.90%)4,170ms (± 1.90%)~4,063ms4,237msp=0.423 n=6
Req 3 - references340ms (± 1.07%)338ms (± 0.70%)~335ms341msp=0.295 n=6
Req 4 - navto287ms (± 1.39%)286ms (± 1.19%)~283ms292msp=0.514 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo85ms (± 6.29%)81ms (± 7.52%)~76ms89msp=0.361 n=6
xstateTSServer - node (v18.15.0, x64)
Req 1 - updateOpen2,602ms (± 0.59%)2,600ms (± 0.22%)~2,592ms2,609msp=0.470 n=6
Req 2 - geterr1,719ms (± 1.81%)1,698ms (± 3.28%)~1,637ms1,773msp=0.378 n=6
Req 3 - references109ms (± 9.00%)112ms (± 9.55%)~102ms124msp=0.870 n=6
Req 4 - navto366ms (± 0.47%)364ms (± 0.14%)~364ms365msp=0.051 n=6
Req 5 - completionInfo count2,073 (± 0.00%)2,073 (± 0.00%)~2,0732,073p=1.000 n=6
Req 5 - completionInfo306ms (± 1.97%)304ms (± 1.67%)~298ms311msp=0.520 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstateTSServer - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

Startup

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
tsc-startup - node (v18.15.0, x64)
Execution time153.06ms (± 0.20%)153.05ms (± 0.21%)~151.75ms158.28msp=0.216 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time228.22ms (± 0.14%)228.15ms (± 0.16%)-0.07ms (- 0.03%)226.84ms232.38msp=0.004 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time229.77ms (± 0.20%)229.68ms (± 0.19%)-0.09ms (- 0.04%)228.08ms237.00msp=0.022 n=600
typescript-startup - node (v18.15.0, x64)
Execution time229.36ms (± 0.16%)229.35ms (± 0.17%)~227.86ms233.02msp=0.509 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

Developer Information:

Download Benchmarks

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

Hey Gabriela Araujo Britto (@gabritto), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@gabrittoGabriela Araujo Britto (gabritto) changed the title Gabritto/issue56133Infer between generic mapped types before inferring from apparent typeDec 14, 2023
@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto) Here are the results of running the top-repos suite comparing main and refs/pull/56640/merge:

Everything looks good!

@gabritto
Gabriela Araujo Britto (gabritto) deleted the gabritto/issue56133 branch January 2, 2024 23:35
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswighamWesley Wigham (weswigham)weswigham approved these changes

Assignees

@gabrittoGabriela Araujo Britto (gabritto)

Labels

Author: TeamFor Milestone BugPRs that fix a bug with a specific milestone

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Defining a type predicate breaks inheritance for methods with mapped types

4 participants

@gabritto@typescript-bot@weswigham@sandersn