GeneratorFunction should not be newable by LongTengDao · Pull Request #56646 · microsoft/TypeScript

LongTengDao · 2023-12-02T12:18:04Z

RyanCavanaugh · 2026-03-24T22:00:55Z

typescript-bot · 2026-03-24T22:01:00Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2026-03-24T22:23:22Z

Hey @RyanCavanaugh, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2026-03-24T22:28:16Z

@RyanCavanaugh Here are the results of running the user tests with tsc comparing main and refs/pull/56646/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Git clone failed"

Otherwise...

Everything looks good!

typescript-bot · 2026-03-24T22:57:57Z

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_82,521	_82,521	_~	_~	_~	_{p=1.000 n=6}
_Types	_125,280	_125,280	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{277,173k (± 0.51%)}	_{276,681k (± 0.64%)}	_~	_274,360k	_277,972k	_{p=0.936 n=6}
_{Parse Time}	_{1.61s (± 1.02%)}	_{1.61s (± 0.93%)}	_~	_1.59s	_1.63s	_{p=0.508 n=6}
_{Bind Time}	_{0.92s (± 1.27%)}	_{0.92s (± 1.15%)}	_~	_0.90s	_0.93s	_{p=0.619 n=6}
_{Check Time}	_{17.87s (± 1.88%)}	_{17.69s (± 2.44%)}	_~	_17.05s	_18.40s	_{p=0.688 n=6}
_{Emit Time}	_{3.35s (± 4.94%)}	_{3.26s (± 0.90%)}	_~	_3.22s	_3.30s	_{p=0.106 n=6}
_{Total Time}	_{23.75s (± 1.25%)}	_{23.49s (± 1.96%)}	_~	_22.78s	_24.22s	_{p=0.378 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_959,140	_959,136	_{-4 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_416,033	_416,033	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,261,071k (± 0.00%)}	_{1,261,018k (± 0.00%)}	_{-53k (- 0.00%)}	_1,260,948k	_1,261,054k	_{p=0.045 n=6}
_{Parse Time}	_{8.02s (± 0.79%)}	_{8.07s (± 0.35%)}	_~	_8.02s	_8.09s	_{p=0.223 n=6}
_{Bind Time}	_{2.37s (± 0.64%)}	_{2.37s (± 0.43%)}	_~	_2.36s	_2.39s	_{p=0.440 n=6}
_{Check Time}	_{38.78s (± 0.18%)}	_{38.63s (± 0.32%)}	_{-0.15s (- 0.39%)}	_38.51s	_38.82s	_{p=0.045 n=6}
_{Emit Time}	_{18.00s (± 0.46%)}	_{18.00s (± 0.48%)}	_~	_17.88s	_18.08s	_{p=1.000 n=6}
_{Total Time}	_{67.17s (± 0.19%)}	_{67.07s (± 0.28%)}	_~	_66.83s	_67.36s	_{p=0.298 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	_11,129	_11,129	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,209,050	_2,209,046	_{-4 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_767,921	_767,921	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,656,208k (± 0.00%)}	_{2,656,288k (± 0.00%)}	_~	_2,656,149k	_2,656,401k	_{p=0.378 n=6}
_{Parse Time}	_{9.48s (± 0.50%)}	_{9.45s (± 0.56%)}	_~	_9.37s	_9.52s	_{p=0.377 n=6}
_{Bind Time}	_{2.51s (± 0.92%)}	_{2.54s (± 0.54%)}	_~	_2.52s	_2.55s	_{p=0.089 n=6}
_{Check Time}	_{89.58s (± 2.47%)}	_{87.90s (± 1.38%)}	_~	_86.96s	_89.48s	_{p=0.230 n=6}
_{Emit Time}	_{0.37s (± 2.02%)}	_{0.37s (± 3.96%)}	_~	_0.35s	_0.39s	_{p=0.934 n=6}
_{Total Time}	_{101.94s (± 2.18%)}	_{100.24s (± 1.22%)}	_~	_99.24s	_101.84s	_{p=0.230 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,223,006	_1,222,954	_{-52 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,163	_267,163	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,590,471k (± 7.23%)}	_{2,711,946k (± 0.03%)}	_~	_2,710,548k	_2,712,905k	_{p=0.128 n=6}
_{Parse Time}	_{6.56s (± 1.40%)}	_{6.57s (± 0.57%)}	_~	_6.53s	_6.63s	_{p=0.689 n=6}
_{Bind Time}	_{2.27s (± 0.99%)}	_{2.25s (± 1.14%)}	_~	_2.21s	_2.27s	_{p=0.221 n=6}
_{Check Time}	_{43.08s (± 1.12%)}	_{42.83s (± 0.76%)}	_~	_42.51s	_43.32s	_{p=0.423 n=6}
_{Emit Time}	_{3.60s (± 1.96%)}	_{3.52s (± 3.27%)}	_~	_3.34s	_3.64s	_{p=0.378 n=6}
_{Total Time}	_{55.50s (± 0.72%)}	_{55.19s (± 0.84%)}	_~	_54.63s	_55.86s	_{p=0.173 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,223,006	_1,222,954	_{-52 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,163	_267,163	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,804,534k (± 2.30%)}	_{2,717,338k (± 5.44%)}	_~	_2,415,048k	_2,778,569k	_{p=0.128 n=6}
_{Parse Time}	_{6.71s (± 0.67%)}	_{6.77s (± 0.63%)}	_{+0.06s (+ 0.87%)}	_6.72s	_6.82s	_{p=0.020 n=6}
_{Bind Time}	_{2.26s (± 1.00%)}	_{2.26s (± 1.42%)}	_~	_2.22s	_2.31s	_{p=0.688 n=6}
_{Check Time}	_{42.64s (± 0.24%)}	_{42.82s (± 1.00%)}	_~	_42.53s	_43.65s	_{p=0.575 n=6}
_{Emit Time}	_{3.58s (± 4.77%)}	_{3.54s (± 2.52%)}	_~	_3.43s	_3.70s	_{p=0.630 n=6}
_{Total Time}	_{55.19s (± 0.42%)}	_{55.40s (± 0.73%)}	_~	_55.01s	_56.18s	_{p=0.230 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,151	_261,147	_{-4 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,322	_104,322	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{438,747k (± 0.01%)}	_{438,702k (± 0.01%)}	_~	_438,670k	_438,772k	_{p=0.173 n=6}
_{Parse Time}	_{3.53s (± 1.22%)}	_{3.49s (± 1.16%)}	_~	_3.44s	_3.55s	_{p=0.092 n=6}
_{Bind Time}	_{1.34s (± 0.78%)}	_{1.36s (± 1.04%)}	_~	_1.34s	_1.38s	_{p=0.086 n=6}
_{Check Time}	_{19.27s (± 0.44%)}	_{19.32s (± 0.59%)}	_~	_19.16s	_19.49s	_{p=0.471 n=6}
_{Emit Time}	_{1.54s (± 0.89%)}	_{1.55s (± 0.71%)}	_~	_1.53s	_1.56s	_{p=0.491 n=6}
_{Total Time}	_{25.69s (± 0.29%)}	_{25.72s (± 0.45%)}	_~	_25.58s	_25.90s	_{p=0.809 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₂₇₁	₂₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,897	_225,893	_{-4 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_93,564	_93,564	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,623k (± 0.01%)}	_{371,623k (± 0.03%)}	_~	_371,513k	_371,790k	_{p=0.689 n=6}
_{Parse Time}	_{2.86s (± 1.14%)}	_{2.86s (± 0.96%)}	_~	_2.82s	_2.90s	_{p=0.936 n=6}
_{Bind Time}	_{1.62s (± 1.20%)}	_{1.64s (± 1.94%)}	_~	_1.60s	_1.69s	_{p=0.411 n=6}
_{Check Time}	_{17.45s (± 0.50%)}	_{17.49s (± 0.38%)}	_~	_17.39s	_17.56s	_{p=0.377 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.93s (± 0.43%)}	_{21.99s (± 0.36%)}	_~	_21.89s	_22.09s	_{p=0.378 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=NaN n=0}
_Symbols	₀	₀	_~	_~	_~	_{p=NaN n=0}
_Types	₀	₀	_~	_~	_~	_{p=NaN n=0}
_{Memory used}	_0k	_0k	_~	_~	_~	_{p=NaN n=0}
_{Parse Time}	_0s	_0s	_~	_~	_~	_{p=NaN n=0}
_{Bind Time}	_0s	_0s	_~	_~	_~	_{p=NaN n=0}
_{Check Time}	_0s	_0s	_~	_~	_~	_{p=NaN n=0}
_{Emit Time}	_0s	_0s	_~	_~	_~	_{p=NaN n=0}
_{Total Time}	_0s	_0s	_~	_~	_~	_{p=NaN n=0}
_{webpack - node (v18.15.0, x64)}
_Errors	₈	₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_408,831	_408,827	_{-4 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_186,899	_186,899	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{570,936k (± 0.02%)}	_{570,895k (± 0.01%)}	_~	_570,770k	_570,957k	_{p=0.688 n=6}
_{Parse Time}	_{4.74s (± 0.29%)}	_{4.73s (± 0.59%)}	_~	_4.67s	_4.75s	_{p=0.932 n=6}
_{Bind Time}	_{2.03s (± 1.41%)}	_{2.04s (± 1.18%)}	_~	_2.01s	_2.07s	_{p=0.629 n=6}
_{Check Time}	_{24.44s (± 0.52%)}	_{24.51s (± 0.29%)}	_~	_24.44s	_24.61s	_{p=0.295 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.00s (±154.76%)}	_~	_0.00s	_0.01s	_{p=0.595 n=6}
_{Total Time}	_{31.21s (± 0.41%)}	_{31.29s (± 0.27%)}	_~	_31.19s	_31.38s	_{p=0.470 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_781,035	_781,031	_{-4 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_227,795	_227,795	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{697,228k (± 0.01%)}	_{697,301k (± 0.02%)}	_~	_697,212k	_697,549k	_{p=0.378 n=6}
_{Parse Time}	_{4.93s (± 1.02%)}	_{4.93s (± 0.49%)}	_~	_4.89s	_4.96s	_{p=0.572 n=6}
_{Bind Time}	_{1.58s (± 0.62%)}	_{1.59s (± 0.47%)}	_~	_1.58s	_1.60s	_{p=0.102 n=6}
_{Check Time}	_{23.12s (± 0.43%)}	_{23.09s (± 0.23%)}	_~	_23.01s	_23.16s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{29.63s (± 0.41%)}	_{29.61s (± 0.13%)}	_~	_29.57s	_29.68s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2026-03-24T23:14:04Z

@RyanCavanaugh Here are the results of running the top 400 repos with tsc comparing main and refs/pull/56646/merge:

Everything looks good!

LongTengDao added 2 commits December 2, 2023 20:01

Update es2015.generator.d.ts
c176d43

Update es2018.asyncgenerator.d.ts
54a5b82

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Dec 2, 2023

sandersn requested a review from rbuckton December 12, 2023 17:07

typescript-bot assigned rbuckton Dec 12, 2023

RyanCavanaugh added this to the Post-7.0 lib candidates milestone Mar 24, 2026

RyanCavanaugh removed the request for review from rbuckton March 25, 2026 15:59

Navigation Menu

Uh oh!

GeneratorFunction should not be newable - #56646

GeneratorFunction should not be newable#56646
LongTengDao wants to merge 2 commits into
microsoft:mainfrom
LongTengDao-fork-D:main

LongTengDao commented Dec 2, 2023

Uh oh!

RyanCavanaugh commented Mar 24, 2026

Uh oh!

typescript-bot commented Mar 24, 2026•
edited
Loading

Uh oh!

typescript-bot commented Mar 24, 2026

Uh oh!

typescript-bot commented Mar 24, 2026

Uh oh!

typescript-bot commented Mar 24, 2026

tsc

Uh oh!

typescript-bot commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

LongTengDao commented Dec 2, 2023

Uh oh!

RyanCavanaugh commented Mar 24, 2026

Uh oh!

typescript-bot commented Mar 24, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 24, 2026

Uh oh!

typescript-bot commented Mar 24, 2026

Uh oh!

typescript-bot commented Mar 24, 2026

tsc

Uh oh!

typescript-bot commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

typescript-bot commented Mar 24, 2026•
edited
Loading