Intl.NumberFormat: Add latest options, fix previous library discrepancies by Renegade334 · Pull Request #56902 · microsoft/TypeScript

René (Renegade334) · 2023-12-30T03:10:38Z

Fixes#56269
Fixes#52072
Fixes#43336

A few historic deviations from the relevant versions of the Intl specification have been addressed.
The latest changes are based on ECMA-402 10.0, which accompanied the ECMAScript 2023 language specification. Accordingly, I've created a new es2023.intl to house them. The declarations currently residing in esnext.intl were also from the same version of the spec, so I've moved these across as well.
Properties originally typed as string, but defined in the spec as a union of string literals, have been narrowed accordingly. Where the range of acceptable values for a string literal type have been expanded in subsequent versions of the spec, the types are now defined as keyof <RegistryInterface> in order to make them extensible, as per precedent. This is technically breaking, and will likely need to be tested against high-exposure libraries for side-effects.
useGrouping is a bit of a mess, as the property's primitive type was changed in version 10. The inclusion of "true" and "false" as acceptable values in the es2023 implementation is intentional, as per the specification.

- move properties to correct spec versions - non-optional ResolvedNumberFormatOptions properties

As per ECMA-402 v10 / 15.1.2 microsoft#22-28 Boolean(true), Boolean(false), String("true") and String("false") all have different behaviour, for reasons known unto God

Includes test for conditional useGrouping override in lib.es5.d.ts

Remove redundant/outdated esnext.bigint test CRLF

…tWithLib)

René (Renegade334) · 2024-01-02T11:04:01Z

This should be ready for review.

Context for some less-obvious changes:

lib.es5

NumberFormatOptionsUseGrouping and ResolvedNumberFormatOptionsUseGrouping are typed conditionally. This is to satisfy the following change in the v10 spec:

typeNumberFormatOptionsUseGrouping=/* es5 */boolean;/* es2023 */keyofNumberFormatOptionsUseGroupingRegistry|"true"|"false"|boolean;typeResolvedNumberFormatOptionsUseGrouping=/* es5 */boolean;/* es2023 */keyofNumberFormatOptionsUseGroupingRegistry|false;

Tests under conformance/es2023 confirm these to be working appropriately.

lib.es2018.intl
- The values "code", "symbol" and "name" were previously erroneously included in NumberFormatPartTypes; this was likely a misreading of the specification.
lib.es2020.intl
- Changing the notation and signDisplay properties of ResolvedNumberFormatOptions from optional to required is an intentional change.
tests
- The tests included in formatToPartsBigInt were already included under bigIntWithLib, hence its removal.
- DateTimeFormatAndNumberFormatES2021 tested for NumberFormat methods that didn't exist in ES2021, and the baseline for this test contained errors accordingly. The test scope has been narrowed to DateTimeFormat and moved to conformance/es2021, while testing NumberFormat#formatRange has been moved to conformance/es2023.

I'd be grateful if someone could run top100/dt when convenient.

TypeScript Bot (typescript-bot) · 2024-01-02T11:04:11Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

TypeScript Bot (typescript-bot) · 2024-01-04T19:08:32Z

Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at 90b7d94. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2024-01-04T19:08:32Z

Heya Jake Bailey (@jakebailey), I've started to run the tarball bundle task on this PR at 90b7d94. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2024-01-04T19:10:11Z

Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/159246/artifacts?artifactName=tgz&fileId=576D53D334DC37587E8C3B2DF7A4DA90B4DE69F90ABC032E783942C033EC773D02&fileName=/typescript-5.4.0-insiders.20240104.tgz"
}
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.4.0-pr-56902-8".;

TypeScript Bot (typescript-bot) · 2024-01-04T19:39:50Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,465k (± 0.02%)}	_{295,506k (± 0.01%)}	_~	_295,445k	_295,563k	_{p=0.173 n=6}
_{Parse Time}	_{2.65s (± 0.21%)}	_{2.65s (± 0.15%)}	_~	_2.64s	_2.65s	_{p=0.282 n=6}
_{Bind Time}	_{0.82s (± 0.50%)}	_{0.82s (± 0.50%)}	_~	_0.81s	_0.82s	_{p=0.218 n=6}
_{Check Time}	_{8.17s (± 0.34%)}	_{8.15s (± 0.51%)}	_~	_8.11s	_8.22s	_{p=0.171 n=6}
_{Emit Time}	_{7.11s (± 0.41%)}	_{7.10s (± 0.33%)}	_~	_7.07s	_7.14s	_{p=0.517 n=6}
_{Total Time}	_{18.75s (± 0.29%)}	_{18.71s (± 0.29%)}	_~	_18.66s	_18.78s	_{p=0.195 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,494k (± 1.57%)}	_{193,498k (± 1.56%)}	_~	_191,490k	_197,407k	_{p=0.471 n=6}
_{Parse Time}	_{1.34s (± 0.87%)}	_{1.35s (± 0.94%)}	_~	_1.33s	_1.37s	_{p=0.245 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.26s (± 0.33%)}	_{9.26s (± 0.48%)}	_~	_9.19s	_9.30s	_{p=1.000 n=6}
_{Emit Time}	_{2.61s (± 0.29%)}	_{2.61s (± 0.40%)}	_~	_2.60s	_2.63s	_{p=0.611 n=6}
_{Total Time}	_{13.93s (± 0.20%)}	_{13.95s (± 0.27%)}	_~	_13.90s	_13.98s	_{p=0.517 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,406k (± 0.00%)}	_{347,400k (± 0.01%)}	_~	_347,362k	_347,425k	_{p=0.936 n=6}
_{Parse Time}	_{2.46s (± 0.48%)}	_{2.46s (± 0.51%)}	_~	_2.44s	_2.47s	_{p=0.801 n=6}
_{Bind Time}	_{0.92s (± 0.59%)}	_{0.93s (± 0.44%)}	_~	_0.92s	_0.93s	_{p=0.282 n=6}
_{Check Time}	_{6.87s (± 0.36%)}	_{6.89s (± 0.38%)}	_~	_6.87s	_6.94s	_{p=0.286 n=6}
_{Emit Time}	_{4.06s (± 0.39%)}	_{4.06s (± 0.30%)}	_~	_4.04s	_4.07s	_{p=0.803 n=6}
_{Total Time}	_{14.31s (± 0.23%)}	_{14.33s (± 0.14%)}	_~	_14.31s	_14.36s	_{p=0.220 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,730k (± 0.00%)}	_{302,733k (± 0.01%)}	_~	_302,704k	_302,754k	_{p=0.936 n=6}
_{Parse Time}	_{1.99s (± 0.84%)}	_{2.01s (± 1.16%)}	_~	_1.98s	_2.04s	_{p=0.118 n=6}
_{Bind Time}	_{1.00s (± 0.41%)}	_{1.00s (± 1.17%)}	_~	_0.99s	_1.02s	_{p=0.584 n=6}
_{Check Time}	_{6.32s (± 0.29%)}	_{6.29s (± 0.50%)}	_~	_6.26s	_6.33s	_{p=0.140 n=6}
_{Emit Time}	_{3.58s (± 0.42%)}	_{3.59s (± 0.45%)}	_~	_3.57s	_3.61s	_{p=0.934 n=6}
_{Total Time}	_{12.89s (± 0.14%)}	_{12.89s (± 0.14%)}	_~	_12.86s	_12.91s	_{p=0.685 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{506,833k (± 0.01%)}	_{506,830k (± 0.01%)}	_~	_506,800k	_506,872k	_{p=0.936 n=6}
_{Parse Time}	_{2.58s (± 0.45%)}	_{2.58s (± 0.32%)}	_~	_2.58s	_2.60s	_{p=0.547 n=6}
_{Bind Time}	_{1.00s (± 0.84%)}	_{0.99s (± 0.76%)}	_~	_0.98s	_1.00s	_{p=0.209 n=6}
_{Check Time}	_{16.97s (± 0.51%)}	_{16.95s (± 0.48%)}	_~	_16.83s	_17.03s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.55s (± 0.39%)}	_{20.52s (± 0.39%)}	_~	_20.42s	_20.60s	_{p=0.872 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,867k (± 0.01%)}	_{512,971k (± 0.01%)}	_{+104k (+ 0.02%)}	_512,925k	_513,053k	_{p=0.013 n=6}
_{Parse Time}	_{3.27s (± 0.30%)}	_{3.28s (± 0.31%)}	_~	_3.26s	_3.29s	_{p=0.203 n=6}
_{Bind Time}	_{1.54s (± 0.36%)}	_{1.54s (± 0.27%)}	_~	_1.53s	_1.54s	_{p=0.282 n=6}
_{Check Time}	_{2.81s (± 1.20%)}	_{2.84s (± 0.35%)}	_~	_2.83s	_2.85s	_{p=0.102 n=6}
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 5.69%)}	_~	_0.07s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.70s (± 0.37%)}	_{7.73s (± 0.17%)}	_~	_7.71s	_7.75s	_{p=0.062 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,348ms (± 0.66%)}	_{2,344ms (± 0.74%)}	_~	_2,319ms	_2,367ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{5,393ms (± 0.57%)}	_{5,410ms (± 1.16%)}	_~	_5,364ms	_5,531ms	_{p=1.000 n=6}
_{Req 3 - references}	_{324ms (± 1.14%)}	_{324ms (± 1.15%)}	_~	_320ms	_329ms	_{p=0.746 n=6}
_{Req 4 - navto}	_{277ms (± 0.42%)}	_{275ms (± 1.01%)}	_~	_270ms	_277ms	_{p=0.079 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{86ms (± 3.20%)}	_{86ms (± 6.81%)}	_~	_79ms	_94ms	_{p=0.864 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,471ms (± 0.98%)}	_{2,489ms (± 1.11%)}	_~	_2,445ms	_2,523ms	_{p=0.230 n=6}
_{Req 2 - geterr}	_{4,183ms (± 2.02%)}	_{4,166ms (± 2.15%)}	_~	_4,079ms	_4,262ms	_{p=0.575 n=6}
_{Req 3 - references}	_{335ms (± 1.13%)}	_{337ms (± 1.17%)}	_~	_332ms	_343ms	_{p=0.293 n=6}
_{Req 4 - navto}	_{286ms (± 1.14%)}	_{284ms (± 0.52%)}	_~	_282ms	_286ms	_{p=0.807 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{81ms (± 7.36%)}	_{84ms (± 7.55%)}	_~	_75ms	_90ms	_{p=0.520 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,602ms (± 0.93%)}	_{2,592ms (± 0.75%)}	_~	_2,564ms	_2,610ms	_{p=0.261 n=6}
_{Req 2 - geterr}	_{1,726ms (± 1.87%)}	_{1,707ms (± 2.15%)}	_~	_1,672ms	_1,763ms	_{p=0.575 n=6}
_{Req 3 - references}	_{106ms (± 7.58%)}	_{109ms (± 9.53%)}	_~	_101ms	_123ms	_{p=0.868 n=6}
_{Req 4 - navto}	_{364ms (± 1.02%)}	_{366ms (± 0.14%)}	_~	_365ms	_366ms	_{p=0.070 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{310ms (± 1.72%)}	_{305ms (± 1.83%)}	_~	_296ms	_312ms	_{p=0.170 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.69ms (± 0.21%)}	_{153.59ms (± 0.20%)}	_{-0.10ms (- 0.07%)}	_152.45ms	_156.75ms	_{p=0.005 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.69ms (± 0.16%)}	_{228.46ms (± 0.15%)}	_{-0.23ms (- 0.10%)}	_227.05ms	_231.45ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.23ms (± 0.18%)}	_{230.33ms (± 0.19%)}	_{+0.11ms (+ 0.05%)}	_228.41ms	_233.50ms	_{p=0.024 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.60ms (± 0.19%)}	_{230.49ms (± 0.18%)}	_{-0.10ms (- 0.04%)}	_228.91ms	_234.79ms	_{p=0.011 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-01-04T19:46:55Z

Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing main and refs/pull/56902/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

TypeScript Bot (typescript-bot) · 2024-01-04T19:56:02Z

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

TypeScript Bot (typescript-bot) · 2024-01-04T20:45:30Z

Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing main and refs/pull/56902/merge:

Everything looks good!

Nathan Shively-Sanders (sandersn)

I think this is good to go, although I'd like to wait until after the beta.

The only question I have is about any as the property type for registries. Everything else is notes for myself about the combined members of registries.

Nathan Shively-Sanders (sandersn) · 2024-01-26T21:52:04Z

 const PluralRules: PluralRulesConstructor;

- // We can only have one definition for 'type' in TypeScript, and so you can learn where the keys come from here:
- type ES2018NumberFormatPartType = "literal" | "nan" | "infinity" | "percent" | "integer" | "group" | "decimal" | "fraction" | "plusSign" | "minusSign" | "percentSign" | "currency" | "code" | "symbol" | "name";


NumberFormatPartTypeRegistry
ES2018
literal
nan
infinity
percent
integer
group
decimal
fraction
plusSign
minusSign
percentSign
currency
ES2020
compact
exponentInteger
exponentMinusSign
exponentSeparator
unit
unknown

Nathan Shively-Sanders (sandersn) · 2024-01-29T22:17:08Z

 declare namespace Intl {
 interface NumberFormat {
 format(value: number | bigint): string;
- resolvedOptions(): ResolvedNumberFormatOptions;


duplicated with entry in es5, doesn't need to be here

Nathan Shively-Sanders (sandersn) · 2024-01-29T22:27:48Z

+ exceptZero: any;
+ }
+
+ type NumberFormatOptionsSignDisplay = keyof NumberFormatOptionsSignDisplayRegistry;


ES2020
auto
never
always
exceptZero
ES2023
negative

Nathan Shively-Sanders (sandersn) · 2024-01-29T22:35:32Z

+ currency: any;
+ }
+
+ type NumberFormatOptionsStyle = keyof NumberFormatOptionsStyleRegistry;


ES5
decimal
percent
currency
ES2020
unit

Nathan Shively-Sanders (sandersn) · 2024-01-29T22:36:10Z

+ name: any;
+ }
+
+ type NumberFormatOptionsCurrencyDisplay = keyof NumberFormatOptionsCurrencyDisplayRegistry;


ES5
code
symbol
name
ES2020
narrowSymbol

Nathan Shively-Sanders (sandersn) · 2024-01-29T22:37:32Z

+
+ type NumberFormatOptionsCurrencyDisplay = keyof NumberFormatOptionsCurrencyDisplayRegistry;
+
+ interface NumberFormatOptionsUseGroupingRegistry {}


ES2023
min2
auto
always

René (Renegade334) · 2024-02-02T00:45:17Z

Updated the registry interfaces as discussed.

I've also included one other minor change. The defined behaviour of the resolved options {minimum,maximum}FractionDigits changed subtly in v10: whereas these properties were always included under ResolvedNumberFormatOptions in previous versions, they're now omitted under certain circumstances. For simplicity, these are now typed as optional throughout. Although unlikely to break anything, this probably warrants re-running the test suite.

Nathan Shively-Sanders (sandersn) · 2024-02-16T23:05:17Z

TypeScript Bot (@typescript-bot) test top200
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt

TypeScript Bot (typescript-bot) · 2024-02-16T23:05:20Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the parallelized Definitely Typed test suite on this PR at 254a8ce. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2024-02-16T23:05:20Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the diff-based user code test suite on this PR at 254a8ce. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2024-02-16T23:05:20Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the diff-based top-repos suite on this PR at 254a8ce. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2024-02-16T23:27:29Z

Nathan Shively-Sanders (@sandersn) Here are the results of running the user test suite comparing main and refs/pull/56902/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

TypeScript Bot (typescript-bot) · 2024-02-16T23:49:27Z

Hey Nathan Shively-Sanders (@sandersn), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

TypeScript Bot (typescript-bot) · 2024-02-17T01:07:30Z

Nathan Shively-Sanders (@sandersn) Here are the results of running the top-repos suite comparing main and refs/pull/56902/merge:

Everything looks good!

Felix Becker (felixfbecker) · 2024-03-01T11:45:19Z

Can't wait for this to land!

I forgot to check whether CI had run recently when I merged, and this PR adds a new section to every resolution trace baseline.

René (Renegade334) added 4 commits December 30, 2023 01:42

Intl.NumberFormat: fix previous divergences from spec
df89080
- move properties to correct spec versions - non-optional ResolvedNumberFormatOptions properties

Intl.NumberFormat: add ECMA-402 version 10 changes under es2023.intl
f9612a0

Intl.NumberFormat: narrow to literal union types
50e295d

Intl.NumberFormat: move ES23 methods from esnext.intl to es2023.intl
7a9f949

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Dec 30, 2023

René (Renegade334) changed the title ~~Intl numberformat~~Intl.NumberFormat: Add latest options, fix previous library discrepanciesDec 30, 2023

René (Renegade334) added 2 commits December 30, 2023 03:17

es2023.intl: CRLF
ef87a15

es2023.intl: Fix interface names
8b96367

Jake Bailey (jakebailey) reviewed Dec 30, 2023
View reviewed changes

Comment threadsrc/lib/es5.d.ts Outdated

Intl.NumberFormat: conditional type override for useGrouping
0b137b9

René (Renegade334)force-pushed the intl-numberformat branch from a433b81 to 0b137b9Compare December 30, 2023 15:31

René (Renegade334) added 12 commits December 30, 2023 15:58

Intl.NumberFormat: add false to ResolvedNumberFormatOptionsUseGrouping
bb13158
As per ECMA-402 v10 / 15.1.2 microsoft#22-28 Boolean(true), Boolean(false), String("true") and String("false") all have different behaviour, for reasons known unto God

Intl.NumberFormat: narrow currencyDisplay type
b857806

Intl.NumberFormat: narrow currencySign type
481c244

es2020.intl: make NumberFormatOptions.numberingSystem optional
0734e7a

Update baselines to include lib.es2023.intl.d.ts
d0876e5

Add conformance tests for es2020.intl / es2023.intl
72f7d44
Includes test for conditional useGrouping override in lib.es5.d.ts

Intl.NumberFormat: remove duplicate method override from es2020.bigint
7b73dc7

Intl.NumberFormat: Registry-ise NumberFormatPartType
6ee47d4

Intl.NumberFormatPartType: add tests / update baselines
f8e9dda
Remove redundant/outdated esnext.bigint test CRLF

Restore name of exported type Intl.NumberFormatPartTypes
ca699fc

Move NumberFormat#formatRange tests from ES2021 to ES2023
40cdb05

Remove test formatToPartsBigInt (duplicate of tests included in bigin…
a6261f9
…tWithLib)

René (Renegade334) marked this pull request as ready for review January 2, 2024 11:04

René (Renegade334) mentioned this pull request Jan 2, 2024
Intl.NumberFormat: missing options, and discussion on typing conventions #56269
Closed

TypeScript Bot (typescript-bot) added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 2, 2024

Merge branch 'main' into intl-numberformat
90b7d94

Nathan Shively-Sanders (sandersn) self-requested a review January 24, 2024 21:57

Nathan Shively-Sanders (sandersn) approved these changes Jan 29, 2024
View reviewed changes

Nathan Shively-Sanders (sandersn) self-assigned this Feb 1, 2024

René (Renegade334) added 2 commits February 1, 2024 23:49

Type string registry interfaces as {key: never}
37c5d52

ResolvedNumberFormatOptions: {minimum,maximum}FractionDigits to optional
ff58e75

Merge branch 'main' into intl-numberformat
254a8ce

Nathan Shively-Sanders (sandersn) merged commit 877d9d3 into microsoft:mainMar 1, 2024

Nathan Shively-Sanders (sandersn) added a commit to sandersn/TypeScript that referenced this pull request Mar 1, 2024
Add baselines missed inmicrosoft#56902
dcf3e2b
I forgot to check whether CI had run recently when I merged, and this PR adds a new section to every resolution trace baseline.

Nathan Shively-Sanders (sandersn) added a commit that referenced this pull request Mar 1, 2024
Add baselines missed in#56902(#57598)
5d17aa7

René (Renegade334) deleted the intl-numberformat branch March 2, 2024 18:31

René (Renegade334) mentioned this pull request Apr 5, 2024
intl.d.ts: cleanup, add missing features, fix library discrepancies #58084
Closed

Ryan Cavanaugh (RyanCavanaugh) mentioned this pull request Apr 18, 2024
[NewErrors] 5.5.0-dev.20240414 vs 5.4.5 #58189
Open

René (Renegade334) mentioned this pull request May 4, 2024
Internationalized/NumberParser: fix TS5.5 build errors adobe/react-spectrum#6329
Merged

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025


		type NumberFormatOptionsCurrencyDisplay = keyof NumberFormatOptionsCurrencyDisplayRegistry;

		interface NumberFormatOptionsUseGroupingRegistry {}

Uh oh!

Conversation

René (Renegade334) commented Dec 30, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

René (Renegade334) commented Jan 2, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 2, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 4, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 4, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 4, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 4, 2024

Compiler

tsserver

Startup

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 4, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 4, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 4, 2024

Uh oh!

Nathan Shively-Sanders (sandersn) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

NumberFormatPartTypeRegistry

ES2018

ES2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

ES2020

ES2023

Uh oh!

Choose a reason for hiding this comment

ES5

ES2020

Uh oh!

Choose a reason for hiding this comment

ES5

ES2020

Uh oh!

Choose a reason for hiding this comment

ES2023

Uh oh!

René (Renegade334) commented Feb 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nathan Shively-Sanders (sandersn) commented Feb 16, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 16, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 16, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 17, 2024

Uh oh!

Felix Becker (felixfbecker) commented Mar 1, 2024

Uh oh!

Reviewers

Assignees

René (Renegade334) commented Dec 30, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 4, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 4, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 4, 2024•
edited
Loading

René (Renegade334) commented Feb 2, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 16, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 16, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 16, 2024•
edited
Loading