Resolve apparent mapped types recursively by Andarist · Pull Request #57091 · microsoft/TypeScript

Mateusz Burzyński (Andarist) · 2024-01-18T20:00:33Z

this expands on #56727
I'm opening this as a draft but I'd love it if somebody could run an extended test suite on this PR in the meantime (cc Gabriela Araujo Britto (@gabritto) )

Mateusz Burzyński (Andarist) · 2024-01-18T20:02:09Z

- constraint = getApparentType(modifiersConstraint);
+ const modifiersType = getModifiersTypeFromMappedType(type);
+ if (modifiersType) {
+ constraint = getApparentType(getConstraintOfType(modifiersType) || modifiersType);


I'm not particularly fond of this - maybe there is a better way of doing this. This mainly tries to get the apparent type of the modifiers type when the modifiers type is a mapped type itself (like in Mapped<Mapped2<Foo>>). Mapped types don't return anything from getConstraintOfType.

Mateusz Burzyński (Andarist) · 2024-01-18T20:11:14Z

The test failure doesn't surprise me. It would pass if another problem would get fixed - the one that is being tackled by #50034

The recursive resolution here just uncovers the fact that this other thing doesn't exactly work properly - as far as I was able to investigate so far and I spent 2 nights on this.

Gabriela Araujo Britto (gabritto) · 2024-01-18T20:30:49Z

TypeScript Bot (@typescript-bot) run DT
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2024-01-18T20:30:51Z

Heya Gabriela Araujo Britto (@gabritto), I've started to run the parallelized Definitely Typed test suite on this PR at 342f700. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2024-01-18T20:30:51Z

Heya Gabriela Araujo Britto (@gabritto), I've started to run the regular perf test suite on this PR at 342f700. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2024-01-18T20:30:51Z

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based top-repos suite on this PR at 342f700. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2024-01-18T20:30:51Z

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based user code test suite on this PR at 342f700. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2024-01-18T20:51:00Z

Gabriela Araujo Britto (@gabritto) Here are the results of running the user test suite comparing main and refs/pull/57091/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

TypeScript Bot (typescript-bot) · 2024-01-18T20:51:22Z

Gabriela Araujo Britto (@gabritto)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,619k (± 0.00%)}	_{295,612k (± 0.01%)}	_~	_295,579k	_295,630k	_{p=0.574 n=6}
_{Parse Time}	_{2.65s (± 0.19%)}	_{2.65s (± 0.28%)}	_~	_2.64s	_2.66s	_{p=0.784 n=6}
_{Bind Time}	_{0.83s (± 0.49%)}	_{0.83s (± 1.52%)}	_~	_0.82s	_0.85s	_{p=0.930 n=6}
_{Check Time}	_{8.17s (± 0.38%)}	_{8.15s (± 0.53%)}	_~	_8.08s	_8.19s	_{p=0.747 n=6}
_{Emit Time}	_{7.08s (± 0.35%)}	_{7.08s (± 0.33%)}	_~	_7.05s	_7.11s	_{p=1.000 n=6}
_{Total Time}	_{18.73s (± 0.18%)}	_{18.72s (± 0.24%)}	_~	_18.66s	_18.78s	_{p=0.686 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,342k (± 1.20%)}	_{194,462k (± 1.66%)}	_~	_191,501k	_197,498k	_{p=0.378 n=6}
_{Parse Time}	_{1.36s (± 0.93%)}	_{1.37s (± 1.26%)}	_~	_1.35s	_1.39s	_{p=0.402 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.36s (± 0.21%)}	_{9.38s (± 0.30%)}	_~	_9.33s	_9.41s	_{p=0.332 n=6}
_{Emit Time}	_{2.62s (± 0.75%)}	_{2.61s (± 0.40%)}	_~	_2.60s	_2.63s	_{p=0.289 n=6}
_{Total Time}	_{14.07s (± 0.17%)}	_{14.08s (± 0.26%)}	_~	_14.01s	_14.10s	_{p=0.212 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,395k (± 0.00%)}	_{347,387k (± 0.01%)}	_~	_347,365k	_347,409k	_{p=0.575 n=6}
_{Parse Time}	_{2.47s (± 0.42%)}	_{2.47s (± 0.60%)}	_~	_2.45s	_2.48s	_{p=0.676 n=6}
_{Bind Time}	_{0.93s (± 0.56%)}	_{0.93s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{6.89s (± 0.48%)}	_{6.88s (± 0.37%)}	_~	_6.86s	_6.92s	_{p=0.683 n=6}
_{Emit Time}	_{4.05s (± 0.19%)}	_{4.05s (± 0.16%)}	_~	_4.04s	_4.06s	_{p=0.718 n=6}
_{Total Time}	_{14.33s (± 0.19%)}	_{14.33s (± 0.22%)}	_~	_14.30s	_14.37s	_{p=0.934 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,803k (± 0.01%)}	_{302,779k (± 0.00%)}	_~	_302,762k	_302,794k	_{p=0.092 n=6}
_{Parse Time}	_{2.01s (± 0.68%)}	_{2.01s (± 1.16%)}	_~	_1.98s	_2.04s	_{p=0.935 n=6}
_{Bind Time}	_{1.00s (± 0.41%)}	_{1.00s (± 1.09%)}	_~	_0.99s	_1.02s	_{p=0.445 n=6}
_{Check Time}	_{6.30s (± 0.35%)}	_{6.30s (± 0.34%)}	_~	_6.27s	_6.33s	_{p=0.871 n=6}
_{Emit Time}	_{3.58s (± 0.25%)}	_{3.59s (± 0.33%)}	_~	_3.58s	_3.61s	_{p=0.114 n=6}
_{Total Time}	_{12.90s (± 0.16%)}	_{12.91s (± 0.32%)}	_~	_12.86s	_12.96s	_{p=0.569 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,156k (± 0.00%)}	_{511,167k (± 0.00%)}	_~	_511,129k	_511,187k	_{p=0.298 n=6}
_{Parse Time}	_{2.64s (± 0.28%)}	_{2.64s (± 0.56%)}	_~	_2.61s	_2.65s	_{p=1.000 n=6}
_{Bind Time}	_{1.00s (± 0.98%)}	_{0.99s (± 0.82%)}	_~	_0.99s	_1.01s	_{p=0.235 n=6}
_{Check Time}	_{17.15s (± 0.43%)}	_{17.14s (± 0.52%)}	_~	_17.02s	_17.26s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.79s (± 0.39%)}	_{20.78s (± 0.45%)}	_~	_20.64s	_20.89s	_{p=0.809 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,382k (± 0.01%)}	_{513,420k (± 0.01%)}	_~	_513,313k	_513,486k	_{p=0.378 n=6}
_{Parse Time}	_{3.29s (± 0.25%)}	_{3.29s (± 0.19%)}	_~	_3.28s	_3.30s	_{p=0.599 n=6}
_{Bind Time}	_{1.54s (± 0.33%)}	_{1.54s (± 0.26%)}	_~	_1.54s	_1.55s	_{p=0.595 n=6}
_{Check Time}	_{2.84s (± 0.61%)}	_{2.84s (± 0.66%)}	_~	_2.82s	_2.87s	_{p=0.746 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{7.75s (± 0.21%)}	_{7.75s (± 0.22%)}	_~	_7.72s	_7.77s	_{p=0.453 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,348ms (± 0.69%)}	_{2,352ms (± 0.55%)}	_~	_2,337ms	_2,369ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{5,505ms (± 1.19%)}	_{5,541ms (± 1.72%)}	_~	_5,433ms	_5,646ms	_{p=0.630 n=6}
_{Req 3 - references}	_{325ms (± 1.11%)}	_{326ms (± 1.84%)}	_~	_320ms	_336ms	_{p=0.808 n=6}
_{Req 4 - navto}	_{276ms (± 0.90%)}	_{276ms (± 0.48%)}	_~	_274ms	_278ms	_{p=0.867 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 8.11%)}	_{91ms (± 6.01%)}	_~	_84ms	_95ms	_{p=0.058 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,473ms (± 1.06%)}	_{2,470ms (± 1.16%)}	_~	_2,435ms	_2,522ms	_{p=0.689 n=6}
_{Req 2 - geterr}	_{4,142ms (± 1.47%)}	_{4,183ms (± 1.85%)}	_~	_4,106ms	_4,262ms	_{p=0.689 n=6}
_{Req 3 - references}	_{334ms (± 1.72%)}	_{334ms (± 1.12%)}	_~	_331ms	_341ms	_{p=0.934 n=6}
_{Req 4 - navto}	_{285ms (± 0.42%)}	_{285ms (± 1.01%)}	_~	_283ms	_291ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (±10.60%)}	_{79ms (± 7.58%)}	_~	_74ms	_90ms	_{p=0.744 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,608ms (± 0.42%)}	_{2,606ms (± 0.69%)}	_~	_2,579ms	_2,627ms	_{p=0.747 n=6}
_{Req 2 - geterr}	_{1,720ms (± 2.26%)}	_{1,692ms (± 2.43%)}	_~	_1,651ms	_1,767ms	_{p=0.378 n=6}
_{Req 3 - references}	_{113ms (± 9.53%)}	_{123ms (± 6.60%)}	_~	_106ms	_126ms	_{p=0.317 n=6}
_{Req 4 - navto}	_{364ms (± 0.70%)}	_{365ms (± 0.38%)}	_~	_363ms	_367ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{2,078 (± 0.00%)}	_{2,078 (± 0.00%)}	_~	_2,078	_2,078	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{310ms (± 0.78%)}	_{307ms (± 0.95%)}	_~	_304ms	_312ms	_{p=0.062 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.95ms (± 0.20%)}	_{153.83ms (± 0.20%)}	_{-0.12ms (- 0.08%)}	_152.65ms	_157.49ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.47ms (± 0.18%)}	_{230.32ms (± 0.16%)}	_{-0.15ms (- 0.06%)}	_228.94ms	_233.20ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{231.26ms (± 0.18%)}	_{231.16ms (± 0.22%)}	_{-0.10ms (- 0.04%)}	_229.60ms	_243.34ms	_{p=0.003 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.97ms (± 0.19%)}	_{230.90ms (± 0.20%)}	_{-0.08ms (- 0.03%)}	_229.40ms	_236.22ms	_{p=0.039 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-01-18T21:16:08Z

Hey Gabriela Araujo Britto (@gabritto), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

TypeScript Bot (typescript-bot) · 2024-01-18T21:43:59Z

Gabriela Araujo Britto (@gabritto) Here are the results of running the top-repos suite comparing main and refs/pull/57091/merge:

Something interesting changed - please have a look.

Details

chakra-ui/chakra-ui

4 of 28 projects failed to build with the old tsc and were ignored

packages/components/tsconfig.build.json

error TS5056: Cannot write file '/mnt/ts_downloads/chakra-ui/packages/components/dist/types/menu/menu.stories.d.ts' because it would be overwritten by multiple input files.
- Project Scope

TypeScript Bot (typescript-bot) · 2024-01-18T23:11:23Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Mateusz Burzyński (Andarist) · 2024-01-18T23:16:23Z

I pushed out a test case that shows how this is an improvement. It fixes the VS Code's build failure that Jake Bailey (@jakebailey) reported post-merge here.

It's obviously not perfect right now because ramdaToolsNoInfinite test case fails. As mentioned above, that would get fixed with #50034 (or an alternative fix to the underlying issue).

Mateusz Burzyński (Andarist) · 2024-01-22T14:15:18Z

superseded by #57122

Resolve apparent mapped types recursively
342f700

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jan 18, 2024

Mateusz Burzyński (Andarist) commented Jan 18, 2024
View reviewed changes

Mateusz Burzyński (Andarist) mentioned this pull request Jan 18, 2024
Revise mapped tuple type instantiation logic #57031
Merged

add a test case
fe34eb1

Mateusz Burzyński (Andarist) marked this pull request as ready for review January 18, 2024 23:11

Mateusz Burzyński (Andarist) marked this pull request as draft January 20, 2024 08:01

Mateusz Burzyński (Andarist) closed this Jan 22, 2024

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Uh oh!

Conversation

Mateusz Burzyński (Andarist) commented Jan 18, 2024

Uh oh!

Mateusz Burzyński (Andarist)Jan 18, 2024

Choose a reason for hiding this comment

Uh oh!

Mateusz Burzyński (Andarist) commented Jan 18, 2024

Uh oh!

Gabriela Araujo Britto (gabritto) commented Jan 18, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 18, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 18, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 18, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 18, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 18, 2024

puppeteer

packages/browsers/test/src/tsconfig.json

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 18, 2024

tsc

tsserver

startup

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 18, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 18, 2024

chakra-ui/chakra-ui

packages/components/tsconfig.build.json

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 18, 2024

Uh oh!

Mateusz Burzyński (Andarist) commented Jan 18, 2024

Uh oh!

Mateusz Burzyński (Andarist) commented Jan 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TypeScript Bot (typescript-bot) commented Jan 18, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 18, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 18, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Jan 18, 2024•
edited
Loading