Avoid creating rest elements with `errorType` when `any` is spread by Andarist · Pull Request #57116 · microsoft/TypeScript

Mateusz Burzyński (Andarist) · 2024-01-21T19:48:53Z

This isn't particularly observable as far as I know. However, it turns out that currently [...any] is normalized~ to [...errorType]. errorType is a special any and displays as such, so this went unnoticed. However, since [...any] is legal it doesn't make sense to produce errorType in this situation at all.

EDIT:// this is more observable than what I've described above. I just pushed out a test for this. This PR fixes#55932 that was incorrectly~ attributed to be a duplicate of #29919

fixes#57389

TypeScript Bot (typescript-bot) · 2024-01-21T19:48:58Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Mateusz Burzyński (Andarist) · 2024-01-21T19:54:12Z

 >(function(a, ...rest) {})('', true, ...itNum) : void
->(function(a, ...rest) {}) : (a: string, rest_0: boolean, ...rest_1: any[]) => void
->function(a, ...rest) {} : (a: string, rest_0: boolean, ...rest_1: any[]) => void
+>(function(a, ...rest) {}) : (a: string, rest_0: boolean, ...rest_1: Iterable<number>[]) => void


This test targets es5 where Iterable doesn't exist. This change shows how now an unresolved type continues to be displayed with its alias name~. Just like here:
typeTest={foo: Thing;// even though it's unresolved and errors, it is still displayed as `Thing`};
And actually, this matches the display of those IIFEs above this one. So it turns out that this one was going through createNormalizedTupleType that accidentally lost this display value.

Bruce Pascoe (fatcerberus) · 2024-01-22T19:38:44Z

normalized~

incorrectly~

I still haven’t figured out how to interpret these tildes in your text

Mateusz Burzyński (Andarist) · 2024-01-22T19:40:31Z

😅 I use this as a softener of sorts - when I'm not sure if the used term is 100% precise etc ;p Sorry for making it confusing, I'm not sure where I got it from.

Nathan Shively-Sanders (sandersn) · 2024-02-15T15:04:07Z

Turns out this is a fix for a break introduced in #57031 and reported a few days ago in #57389

Anders Hejlsberg (@ahejlsberg)Mateusz Burzyński (@Andarist) reported this as bug in #57389. Can you confirm and decide whether it's worth taking in 5.4?

Nathan Shively-Sanders (sandersn) · 2024-02-15T15:08:41Z

TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this
TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2024-02-15T15:08:54Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the tarball bundle task on this PR at a08d7d7. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2024-02-15T15:08:54Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the regular perf test suite on this PR at a08d7d7. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2024-02-15T15:08:54Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the diff-based top-repos suite on this PR at a08d7d7. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2024-02-15T15:08:54Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the diff-based user code test suite on this PR at a08d7d7. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2024-02-15T15:08:54Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the parallelized Definitely Typed test suite on this PR at a08d7d7. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2024-02-15T15:10:43Z

Hey Nathan Shively-Sanders (@sandersn), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/159886/artifacts?artifactName=tgz&fileId=C72CA42D20EE93ADA8F6F6CC4DFB188E1B49BF166381F05C30B18C5179E1A6EC02&fileName=/typescript-5.4.0-insiders.20240215.tgz"
}
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.4.0-pr-57116-10".;

TypeScript Bot (typescript-bot) · 2024-02-15T15:43:14Z

Nathan Shively-Sanders (@sandersn) Here are the results of running the user test suite comparing main and refs/pull/57116/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

TypeScript Bot (typescript-bot) · 2024-02-15T15:54:05Z

Hey Nathan Shively-Sanders (@sandersn), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

TypeScript Bot (typescript-bot) · 2024-02-15T16:13:36Z

Nathan Shively-Sanders (@sandersn) Here are the results of running the top-repos suite comparing main and refs/pull/57116/merge:

Everything looks good!

Daniel Rosenwasser (DanielRosenwasser) · 2024-02-15T19:10:55Z

TypeScript Bot (@typescript-bot) test top200

TypeScript Bot (typescript-bot) · 2024-02-15T19:10:58Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based top-repos suite on this PR at a08d7d7. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2024-02-15T21:16:40Z

Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the top-repos suite comparing main and refs/pull/57116/merge:

Everything looks good!

Jake Bailey (jakebailey) · 2024-02-16T16:19:09Z

TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2024-02-16T16:19:12Z

Heya Jake Bailey (@jakebailey), I've started to run the regular perf test suite on this PR at a08d7d7. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2024-02-16T17:44:16Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,668k (± 0.01%)}	_{295,670k (± 0.01%)}	_~	_295,637k	_295,710k	_{p=0.936 n=6}
_{Parse Time}	_{2.66s (± 0.60%)}	_{2.66s (± 0.37%)}	_~	_2.65s	_2.68s	_{p=0.446 n=6}
_{Bind Time}	_{0.83s (± 1.65%)}	_{0.83s (± 1.19%)}	_~	_0.82s	_0.84s	_{p=0.401 n=6}
_{Check Time}	_{8.26s (± 0.21%)}	_{8.23s (± 0.46%)}	_~	_8.19s	_8.28s	_{p=0.170 n=6}
_{Emit Time}	_{7.10s (± 0.34%)}	_{7.12s (± 0.19%)}	_~	_7.10s	_7.13s	_{p=0.411 n=6}
_{Total Time}	_{18.86s (± 0.11%)}	_{18.84s (± 0.15%)}	_~	_18.81s	_18.87s	_{p=0.191 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{191,608k (± 0.02%)}	_{194,008k (± 1.48%)}	_~	_191,591k	_197,527k	_{p=0.066 n=6}
_{Parse Time}	_{1.36s (± 0.98%)}	_{1.36s (± 0.76%)}	_~	_1.35s	_1.38s	_{p=0.492 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.38s (± 0.52%)}	_{9.37s (± 0.27%)}	_~	_9.32s	_9.39s	_{p=0.332 n=6}
_{Emit Time}	_{2.62s (± 0.45%)}	_{2.62s (± 0.80%)}	_~	_2.58s	_2.64s	_{p=0.561 n=6}
_{Total Time}	_{14.08s (± 0.31%)}	_{14.08s (± 0.19%)}	_~	_14.04s	_14.11s	_{p=0.685 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,473k (± 0.00%)}	_{347,487k (± 0.01%)}	_~	_347,454k	_347,502k	_{p=0.128 n=6}
_{Parse Time}	_{2.47s (± 0.55%)}	_{2.48s (± 0.59%)}	_~	_2.46s	_2.50s	_{p=0.742 n=6}
_{Bind Time}	_{0.93s (± 0.44%)}	_{0.93s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=0.595 n=6}
_{Check Time}	_{6.96s (± 0.23%)}	_{6.99s (± 0.36%)}	_~	_6.94s	_7.01s	_{p=0.075 n=6}
_{Emit Time}	_{4.08s (± 0.62%)}	_{4.06s (± 0.44%)}	_~	_4.03s	_4.08s	_{p=0.415 n=6}
_{Total Time}	_{14.44s (± 0.19%)}	_{14.45s (± 0.24%)}	_~	_14.39s	_14.49s	_{p=0.459 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,852k (± 0.00%)}	_{302,851k (± 0.01%)}	_~	_302,826k	_302,876k	_{p=0.810 n=6}
_{Parse Time}	_{1.99s (± 1.13%)}	_{2.01s (± 0.83%)}	_~	_2.00s	_2.04s	_{p=0.413 n=6}
_{Bind Time}	_{1.00s (± 1.03%)}	_{1.00s (± 0.41%)}	_~	_1.00s	_1.01s	_{p=0.924 n=6}
_{Check Time}	_{6.32s (± 0.13%)}	_{6.36s (± 0.41%)}	_{+0.03s (+ 0.53%)}	_6.32s	_6.38s	_{p=0.048 n=6}
_{Emit Time}	_{3.59s (± 0.62%)}	_{3.58s (± 0.52%)}	_~	_3.56s	_3.60s	_{p=0.363 n=6}
_{Total Time}	_{12.91s (± 0.34%)}	_{12.95s (± 0.20%)}	_~	_12.92s	_12.98s	_{p=0.090 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,377k (± 0.00%)}	_{511,370k (± 0.00%)}	_~	_511,359k	_511,377k	_{p=1.000 n=6}
_{Parse Time}	_{2.66s (± 0.51%)}	_{2.65s (± 0.72%)}	_~	_2.63s	_2.68s	_{p=0.357 n=6}
_{Bind Time}	_{1.00s (± 1.04%)}	_{0.99s (± 1.05%)}	_~	_0.98s	_1.01s	_{p=0.801 n=6}
_{Check Time}	_{17.26s (± 0.57%)}	_{17.28s (± 0.27%)}	_~	_17.23s	_17.36s	_{p=0.810 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.91s (± 0.44%)}	_{20.92s (± 0.25%)}	_~	_20.86s	_21.02s	_{p=0.809 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{2,272,170k (± 0.00%)}	_{2,272,171k (± 0.00%)}	_~	_2,272,141k	_2,272,226k	_{p=0.873 n=6}
_{Parse Time}	_{11.97s (± 0.55%)}	_{11.97s (± 0.86%)}	_~	_11.83s	_12.07s	_{p=1.000 n=6}
_{Bind Time}	_{2.62s (± 0.29%)}	_{2.62s (± 0.16%)}	_~	_2.61s	_2.62s	_{p=0.389 n=6}
_{Check Time}	_{102.27s (± 0.65%)}	_{102.35s (± 0.67%)}	_~	_101.32s	_103.08s	_{p=0.936 n=6}
_{Emit Time}	_{0.32s (± 0.00%)}	_{0.32s (± 0.00%)}	_~	_0.32s	_0.32s	_{p=1.000 n=6}
_{Total Time}	_{117.19s (± 0.55%)}	_{117.26s (± 0.64%)}	_~	_116.09s	_118.09s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,412,874k (± 0.03%)}	_{2,412,475k (± 0.03%)}	_~	_2,411,306k	_2,413,399k	_{p=0.298 n=6}
_{Parse Time}	_{4.93s (± 0.94%)}	_{4.91s (± 1.25%)}	_~	_4.87s	_5.03s	_{p=0.374 n=6}
_{Bind Time}	_{1.87s (± 0.66%)}	_{1.88s (± 0.88%)}	_~	_1.86s	_1.90s	_{p=0.453 n=6}
_{Check Time}	_{33.55s (± 0.41%)}	_{33.53s (± 0.32%)}	_~	_33.32s	_33.62s	_{p=0.936 n=6}
_{Emit Time}	_{2.69s (± 1.19%)}	_{2.67s (± 1.45%)}	_~	_2.61s	_2.72s	_{p=0.261 n=6}
_{Total Time}	_{43.08s (± 0.38%)}	_{43.01s (± 0.31%)}	_~	_42.74s	_43.10s	_{p=0.173 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{418,853k (± 0.01%)}	_{418,860k (± 0.01%)}	_~	_418,824k	_418,892k	_{p=0.810 n=6}
_{Parse Time}	_{2.76s (± 3.75%)}	_{2.78s (± 3.52%)}	_~	_2.65s	_2.87s	_{p=0.688 n=6}
_{Bind Time}	_{1.13s (± 6.57%)}	_{1.12s (± 6.10%)}	_~	_1.07s	_1.21s	_{p=0.931 n=6}
_{Check Time}	_{15.16s (± 0.18%)}	_{15.15s (± 0.36%)}	_~	_15.08s	_15.23s	_{p=0.571 n=6}
_{Emit Time}	_{1.13s (± 0.87%)}	_{1.14s (± 2.03%)}	_~	_1.11s	_1.17s	_{p=0.412 n=6}
_{Total Time}	_{20.18s (± 0.27%)}	_{20.19s (± 0.18%)}	_~	_20.14s	_20.22s	_{p=0.871 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,844,126k (± 0.00%)}	_{2,844,056k (± 0.00%)}	_{-70k (- 0.00%)}	_2,844,024k	_2,844,086k	_{p=0.005 n=6}
_{Parse Time}	_{10.76s (± 0.14%)}	_{10.76s (± 0.49%)}	_~	_10.69s	_10.83s	_{p=0.746 n=6}
_{Bind Time}	_{3.44s (± 0.47%)}	_{3.44s (± 0.22%)}	_~	_3.43s	_3.45s	_{p=1.000 n=6}
_{Check Time}	_{60.47s (± 0.37%)}	_{60.72s (± 0.40%)}	_~	_60.46s	_61.04s	_{p=0.109 n=6}
_{Emit Time}	_{16.25s (± 0.60%)}	_{16.25s (± 0.68%)}	_~	_16.13s	_16.40s	_{p=1.000 n=6}
_{Total Time}	_{90.92s (± 0.35%)}	_{91.17s (± 0.30%)}	_~	_90.87s	_91.58s	_{p=0.230 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{394,109k (± 0.02%)}	_{394,162k (± 0.02%)}	_~	_394,050k	_394,257k	_{p=0.297 n=6}
_{Parse Time}	_{3.12s (± 1.01%)}	_{3.12s (± 0.53%)}	_~	_3.10s	_3.14s	_{p=0.685 n=6}
_{Bind Time}	_{1.39s (± 1.34%)}	_{1.39s (± 1.75%)}	_~	_1.36s	_1.41s	_{p=0.868 n=6}
_{Check Time}	_{14.08s (± 0.34%)}	_{14.06s (± 0.42%)}	_~	_13.97s	_14.13s	_{p=0.572 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.58s (± 0.23%)}	_{18.56s (± 0.42%)}	_~	_18.44s	_18.67s	_{p=0.688 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,377k (± 0.01%)}	_{513,359k (± 0.01%)}	_~	_513,312k	_513,435k	_{p=0.423 n=6}
_{Parse Time}	_{3.27s (± 0.25%)}	_{3.27s (± 0.23%)}	_~	_3.26s	_3.28s	_{p=0.729 n=6}
_{Bind Time}	_{1.54s (± 0.64%)}	_{1.54s (± 0.26%)}	_~	_1.54s	_1.55s	_{p=0.673 n=6}
_{Check Time}	_{2.85s (± 0.82%)}	_{2.86s (± 0.65%)}	_~	_2.84s	_2.89s	_{p=0.517 n=6}
_{Emit Time}	_{0.08s (± 5.21%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.75s (± 0.36%)}	_{7.76s (± 0.28%)}	_~	_7.74s	_7.79s	_{p=0.686 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,340ms (± 0.62%)}	_{2,353ms (± 0.72%)}	_~	_2,331ms	_2,372ms	_{p=0.230 n=6}
_{Req 2 - geterr}	_{5,549ms (± 1.29%)}	_{5,531ms (± 1.43%)}	_~	_5,437ms	_5,603ms	_{p=0.687 n=6}
_{Req 3 - references}	_{324ms (± 1.34%)}	_{326ms (± 1.54%)}	_~	_320ms	_331ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{276ms (± 1.12%)}	_{276ms (± 1.01%)}	_~	_273ms	_279ms	_{p=0.625 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 9.67%)}	_{88ms (± 6.65%)}	_~	_80ms	_95ms	_{p=0.464 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,481ms (± 0.54%)}	_{2,494ms (± 0.58%)}	_~	_2,476ms	_2,512ms	_{p=0.092 n=6}
_{Req 2 - geterr}	_{4,142ms (± 1.48%)}	_{4,165ms (± 1.76%)}	_~	_4,114ms	_4,265ms	_{p=0.688 n=6}
_{Req 3 - references}	_{336ms (± 1.56%)}	_{337ms (± 1.44%)}	_~	_331ms	_343ms	_{p=0.682 n=6}
_{Req 4 - navto}	_{285ms (± 0.44%)}	_{284ms (± 0.57%)}	_~	_282ms	_286ms	_{p=0.504 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{88ms (± 5.34%)}	_{87ms (± 5.25%)}	_~	_78ms	_90ms	_{p=0.718 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,612ms (± 0.36%)}	_{2,612ms (± 0.60%)}	_~	_2,596ms	_2,637ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{1,757ms (± 2.54%)}	_{1,739ms (± 3.61%)}	_~	_1,650ms	_1,797ms	_{p=0.688 n=6}
_{Req 3 - references}	_{117ms (± 9.23%)}	_{117ms (± 9.67%)}	_~	_107ms	_129ms	_{p=0.806 n=6}
_{Req 4 - navto}	_{370ms (± 0.85%)}	_{371ms (± 0.26%)}	_~	_370ms	_372ms	_{p=0.558 n=6}
_{Req 5 - completionInfo count}	_{2,078 (± 0.00%)}	_{2,078 (± 0.00%)}	_~	_2,078	_2,078	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{312ms (± 1.11%)}	_{313ms (± 1.41%)}	_~	_307ms	_316ms	_{p=0.367 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.95ms (± 0.21%)}	_{153.61ms (± 0.19%)}	_{-0.35ms (- 0.23%)}	_152.48ms	_157.45ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.84ms (± 0.16%)}	_{229.60ms (± 0.18%)}	_{-0.24ms (- 0.11%)}	_228.11ms	_236.78ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{231.22ms (± 0.19%)}	_{231.17ms (± 0.17%)}	_~	_229.64ms	_234.44ms	_{p=0.518 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{231.00ms (± 0.17%)}	_{231.06ms (± 0.16%)}	_~	_229.73ms	_234.85ms	_{p=0.131 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

David Archibald (DavidArchibald) · 2024-02-22T08:08:56Z

This is also observable with something like this:

typeSomeCallback<Argsextendsreadonlyany[]>=(...args: Args)=>void;functioncall<CallbackextendsSomeCallback<any>>(x: Callback,args: Parameters<Callback>){x(...args);// error, pre-PR: Type 'Parameters<Callback>' must have a '[Symbol.iterator]()' method that returns an iterator.(2488)}

Maybe this is just a simpler #55932 but I only knew how to fix this particular issue (which I actually ran into) because I've been reading the TypeScript issue tracker.

Avoid creating rest elements with errorType when any is spread
669691d

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jan 21, 2024

Mateusz Burzyński (Andarist) commented Jan 21, 2024
View reviewed changes

Mateusz Burzyński (Andarist) mentioned this pull request Jan 22, 2024
Improve apparent type of mapped types #57122
Merged

add a test case
fe61011

Mateusz Burzyński (Andarist) added 2 commits February 13, 2024 13:15

Merge remote-tracking branch 'origin/main' into fix/any-rest
67e1810

add an extra test case
a08d7d7

TypeScript Bot (typescript-bot) assigned Daniel Rosenwasser (DanielRosenwasser)Feb 13, 2024

Mateusz Burzyński (Andarist) mentioned this pull request Feb 13, 2024
[TS 5.4.0-beta] Tuple type members being preserved #57389
Closed

Nathan Shively-Sanders (sandersn) requested a review from Anders Hejlsberg (ahejlsberg)February 15, 2024 15:00

Nathan Shively-Sanders (sandersn) assigned Anders Hejlsberg (ahejlsberg) and unassigned Daniel Rosenwasser (DanielRosenwasser)Feb 15, 2024

Nathan Shively-Sanders (sandersn) requested a review from Gabriela Araujo Britto (gabritto)February 15, 2024 15:00

Nathan Shively-Sanders (sandersn) added the For Milestone Bug PRs that fix a bug with a specific milestone label Feb 15, 2024

TypeScript Bot (typescript-bot) removed the For Milestone Bug PRs that fix a bug with a specific milestone label Feb 15, 2024

Gabriela Araujo Britto (gabritto) approved these changes Feb 16, 2024
View reviewed changes

Daniel Rosenwasser (DanielRosenwasser) approved these changes Feb 16, 2024
View reviewed changes

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Feb 16, 2024
Design Meeting Notes, 2/16/2024 #57425
Closed

Gabriela Araujo Britto (gabritto) merged commit 29c0024 into microsoft:mainFeb 16, 2024

Mateusz Burzyński (Andarist) deleted the fix/any-rest branch February 22, 2024 08:27

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Uh oh!

Conversation

Mateusz Burzyński (Andarist) commented Jan 21, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 21, 2024

Uh oh!

Mateusz Burzyński (Andarist)Jan 21, 2024

Choose a reason for hiding this comment

Uh oh!

Bruce Pascoe (fatcerberus) commented Jan 22, 2024

Uh oh!

Mateusz Burzyński (Andarist) commented Jan 22, 2024

Uh oh!

Nathan Shively-Sanders (sandersn) commented Feb 15, 2024

Uh oh!

Nathan Shively-Sanders (sandersn) commented Feb 15, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 15, 2024

puppeteer

packages/browsers/test/src/tsconfig.json

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 15, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 15, 2024

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Feb 15, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 15, 2024

Uh oh!

Jake Bailey (jakebailey) commented Feb 16, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 16, 2024

tsc

tsserver

startup

Uh oh!

David Archibald (DavidArchibald) commented Feb 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Mateusz Burzyński (Andarist) commented Jan 21, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 15, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 15, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 15, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 15, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 15, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 15, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 15, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Feb 16, 2024•
edited
Loading

David Archibald (DavidArchibald) commented Feb 22, 2024•
edited
Loading