Uh oh!
There was an error while loading. Please reload this page.
Allow plugins to be loaded from package subpaths - #57266
Merged
Sheetal Nandi (sheetalkamat) merged 7 commits intoFeb 21, 2024
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Ryan Cavanaugh (RyanCavanaugh)
requested a review
from Sheetal Nandi (sheetalkamat)February 2, 2024 18:43
Sheetal Nandi (sheetalkamat)
requested changes
Feb 2, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Sheetal Nandi <sheetalkamat@users.noreply.github.com>
Phil Pluckthun (kitten)force-pushed
the
fix/allow-plugins-in-package-subpath
branch
from
February 21, 2024 06:42
30341f7 to
14324edComparePhil Pluckthun (kitten)
commented
Feb 21, 2024
ContributorAuthor
Sheetal Nandi (@sheetalkamat) That's all applied and test cases are looking good and pass 👍 Sorry for the delay! |
Sheetal Nandi (sheetalkamat)
approved these changes
Feb 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#57047
When merged, this allows plugins to also be loaded from package subpaths.
Before,
tsconfig.json:compilerOptions.plugins[]would:package-plugin/sub/path@package-plugin/subpath..and.After,
tsconfig.json:compilerOptions.plugins[]will:package-plugin/sub/path@package-plugin/subpath@package-plugin/subpath/../../maliciousplugin/subpath/../../malicious..and.I noticed while looking at the tests that
.and..are accepted plugin names, which is likely unintentional.