Uh oh!
There was an error while loading. Please reload this page.
Revert PR 56161 - #57853
Merged
Merged
Conversation
Jake Bailey (jakebailey)
requested a review
from Daniel Rosenwasser (DanielRosenwasser)March 19, 2024 21:35
Jake Bailey (jakebailey)
commented
Mar 19, 2024
MemberAuthor
TypeScript Bot (@typescript-bot) cherry-pick this to release-5.4 |
Contributor
TypeScript Bot (typescript-bot)
commented
Mar 19, 2024
Contributor
Hey, Jake Bailey (@jakebailey)! I've created #57854 for you. |
Jake Bailey (jakebailey)
commented
Mar 19, 2024
MemberAuthor
Daniel Rosenwasser (@DanielRosenwasser) The release blog post will have to be updated to remove the breaking change. |
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a revert of #56161; it was not well-discussed (#56161 (comment)) and has caused some breaks.
We'll come back with a better fix for 5.5.
Fixes#57845
Fixes#57672
Reopens #48956