Uh oh!
There was an error while loading. Please reload this page.
Preserve resolution-mode as-written too - #57867
Merged
Jake Bailey (jakebailey) merged 1 commit intoMar 21, 2024
Merged
Conversation
Andrew Branch (andrewbranch)
approved these changes
Mar 21, 2024
Andrew Branch (andrewbranch)
left a comment
Member
There was a problem hiding this comment.
I guess this should have been discussed, but it should be small potatoes compared to needing to opt into preservation in the first place.
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Mar 21, 2024
Sheetal Nandi (sheetalkamat)
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I lost this change while working on #57681 and meant for it to be there; my understanding is that we want reference directives to be basically written verbatim. Conditionally emitting
resolution-modebased onimpliedNodeFormatbreaks that rule.Also, while here, put
const preserve = ...afterconst = resolutionMode. Not sure why I added it out of order.