Divide-and-conquer strategy for intersections of unions by ahejlsberg · Pull Request #57871 · microsoft/TypeScript

Anders Hejlsberg (ahejlsberg) · 2024-03-21T00:22:44Z

With this PR we implement a "divide and conquer" strategy for handling large intersections of union types. Specifically, when creating an intersection with four or more constituents, some of which are unions, we divide the constituents into two groups such that A & B & C & D is processed as (A & B) & (C & D). Since intersections of unions often produce far smaller unions of intersections than the full cartesian product (due to some intersections becoming never), this can dramatically reduce the overall work at the cost of generating slightly more types (because of the temporary intersections). For example, the reduced repro from #57863 that barely passes before this PR takes 0.28s to type check. That drops to 0.08s with this PR.

Fixes#57863.

Anders Hejlsberg (ahejlsberg) · 2024-03-21T00:23:33Z

TypeScript Bot (@typescript-bot) test top200
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this faster

TypeScript Bot (typescript-bot) · 2024-03-21T00:23:35Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top200`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-03-21T00:49:43Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the user test suite comparing main and refs/pull/57871/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2024-03-21T00:59:28Z

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,627k (± 0.01%)}	_{295,592k (± 0.01%)}	_{-35k (- 0.01%)}	_295,561k	_295,611k	_{p=0.031 n=6}
_{Parse Time}	_{2.66s (± 0.15%)}	_{2.66s (± 0.28%)}	_~	_2.65s	_2.67s	_{p=1.000 n=6}
_{Bind Time}	_{0.83s (± 0.00%)}	_{0.83s (± 0.66%)}	_~	_0.82s	_0.83s	_{p=0.071 n=6}
_{Check Time}	_{8.22s (± 0.32%)}	_{8.21s (± 0.31%)}	_~	_8.18s	_8.24s	_{p=1.000 n=6}
_{Emit Time}	_{7.04s (± 0.39%)}	_{7.03s (± 0.32%)}	_~	_7.01s	_7.07s	_{p=0.570 n=6}
_{Total Time}	_{18.75s (± 0.19%)}	_{18.74s (± 0.14%)}	_~	_18.70s	_18.77s	_{p=0.418 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,618k (± 0.76%)}	_{192,528k (± 0.73%)}	_~	_191,872k	_195,396k	_{p=0.575 n=6}
_{Parse Time}	_{1.36s (± 0.80%)}	_{1.36s (± 1.23%)}	_~	_1.34s	_1.38s	_{p=0.867 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.49s (± 1.04%)}	_{9.50s (± 0.73%)}	_~	_9.43s	_9.60s	_{p=0.810 n=6}
_{Emit Time}	_{2.63s (± 0.70%)}	_{2.63s (± 0.37%)}	_~	_2.62s	_2.64s	_{p=0.730 n=6}
_{Total Time}	_{14.21s (± 0.76%)}	_{14.21s (± 0.43%)}	_~	_14.14s	_14.30s	_{p=0.688 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,361k (± 0.00%)}	_{347,378k (± 0.00%)}	_~	_347,367k	_347,389k	_{p=0.054 n=6}
_{Parse Time}	_{2.49s (± 0.16%)}	_{2.49s (± 0.33%)}	_~	_2.48s	_2.50s	_{p=0.584 n=6}
_{Bind Time}	_{0.93s (± 0.44%)}	_{0.93s (± 0.44%)}	_~	_0.92s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{7.00s (± 0.37%)}	_{7.03s (± 0.43%)}	_~	_6.99s	_7.06s	_{p=0.107 n=6}
_{Emit Time}	_{4.08s (± 0.57%)}	_{4.06s (± 0.22%)}	_{-0.03s (- 0.61%)}	_4.05s	_4.07s	_{p=0.021 n=6}
_{Total Time}	_{14.50s (± 0.25%)}	_{14.50s (± 0.14%)}	_~	_14.47s	_14.53s	_{p=0.872 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,726k (± 0.01%)}	_{302,721k (± 0.01%)}	_~	_302,675k	_302,761k	_{p=0.936 n=6}
_{Parse Time}	_{2.01s (± 1.18%)}	_{2.02s (± 0.58%)}	_~	_2.00s	_2.03s	_{p=0.625 n=6}
_{Bind Time}	_{1.01s (± 1.02%)}	_{1.00s (± 0.52%)}	_~	_0.99s	_1.00s	_{p=0.069 n=6}
_{Check Time}	_{6.32s (± 0.23%)}	_{6.33s (± 0.62%)}	_~	_6.29s	_6.39s	_{p=0.935 n=6}
_{Emit Time}	_{3.60s (± 0.42%)}	_{3.60s (± 0.29%)}	_~	_3.59s	_3.62s	_{p=0.406 n=6}
_{Total Time}	_{12.93s (± 0.19%)}	_{12.95s (± 0.35%)}	_~	_12.89s	_13.02s	_{p=0.469 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{509,875k (± 0.00%)}	_{509,899k (± 0.01%)}	_~	_509,841k	_510,018k	_{p=0.810 n=6}
_{Parse Time}	_{2.65s (± 0.70%)}	_{2.66s (± 0.61%)}	_~	_2.63s	_2.68s	_{p=0.498 n=6}
_{Bind Time}	_{0.99s (± 1.38%)}	_{0.99s (± 0.52%)}	_~	_0.98s	_0.99s	_{p=0.504 n=6}
_{Check Time}	_{17.25s (± 0.36%)}	_{17.26s (± 0.51%)}	_~	_17.12s	_17.35s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.88s (± 0.31%)}	_{20.90s (± 0.45%)}	_~	_20.77s	_21.02s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,719,659k (± 0.00%)}	_{1,737,371k (± 0.00%)}	_{+17,712k (+ 1.03%)}	_1,737,338k	_1,737,411k	_{p=0.005 n=6}
_{Parse Time}	_{6.57s (± 0.40%)}	_{6.59s (± 0.72%)}	_~	_6.55s	_6.68s	_{p=0.935 n=6}
_{Bind Time}	_{2.35s (± 0.32%)}	_{2.36s (± 0.58%)}	_~	_2.35s	_2.38s	_{p=0.149 n=6}
_{Check Time}	_{56.22s (± 0.24%)}	_{56.32s (± 0.25%)}	_~	_56.14s	_56.48s	_{p=0.575 n=6}
_{Emit Time}	_{0.13s (± 3.10%)}	_{0.14s (± 4.05%)}	_~	_0.13s	_0.14s	_{p=0.282 n=6}
_{Total Time}	_{65.28s (± 0.19%)}	_{65.40s (± 0.26%)}	_~	_65.18s	_65.59s	_{p=0.520 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,392,230k (± 0.03%)}	_{2,391,836k (± 0.03%)}	_~	_2,390,583k	_2,392,691k	_{p=0.378 n=6}
_{Parse Time}	_{5.00s (± 1.42%)}	_{5.01s (± 1.57%)}	_~	_4.88s	_5.09s	_{p=0.689 n=6}
_{Bind Time}	_{1.90s (± 0.99%)}	_{1.89s (± 1.02%)}	_~	_1.87s	_1.92s	_{p=0.808 n=6}
_{Check Time}	_{33.58s (± 0.34%)}	_{33.69s (± 0.30%)}	_~	_33.57s	_33.87s	_{p=0.173 n=6}
_{Emit Time}	_{2.62s (± 1.76%)}	_{2.63s (± 1.47%)}	_~	_2.56s	_2.67s	_{p=0.573 n=6}
_{Total Time}	_{43.12s (± 0.45%)}	_{43.25s (± 0.17%)}	_~	_43.18s	_43.34s	_{p=0.128 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{415,116k (± 0.01%)}	_{415,119k (± 0.01%)}	_~	_415,083k	_415,160k	_{p=0.630 n=6}
_{Parse Time}	_{2.83s (± 0.58%)}	_{2.84s (± 0.65%)}	_~	_2.82s	_2.87s	_{p=0.560 n=6}
_{Bind Time}	_{1.07s (± 0.38%)}	_{1.08s (± 0.51%)}	_~	_1.07s	_1.08s	_{p=0.282 n=6}
_{Check Time}	_{15.32s (± 0.26%)}	_{15.30s (± 0.32%)}	_~	_15.24s	_15.36s	_{p=0.686 n=6}
_{Emit Time}	_{1.11s (± 0.47%)}	_{1.11s (± 0.68%)}	_~	_1.10s	_1.12s	_{p=0.241 n=6}
_{Total Time}	_{20.33s (± 0.29%)}	_{20.33s (± 0.31%)}	_~	_20.24s	_20.38s	_{p=0.872 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,887,899k (± 0.00%)}	_{2,887,877k (± 0.00%)}	_~	_2,887,763k	_2,887,996k	_{p=0.748 n=6}
_{Parse Time}	_{10.84s (± 0.32%)}	_{10.84s (± 0.17%)}	_~	_10.81s	_10.86s	_{p=0.511 n=6}
_{Bind Time}	_{3.47s (± 0.68%)}	_{3.46s (± 0.38%)}	_~	_3.44s	_3.48s	_{p=0.869 n=6}
_{Check Time}	_{61.41s (± 0.48%)}	_{61.81s (± 0.33%)}	_{+0.41s (+ 0.66%)}	_61.55s	_62.04s	_{p=0.030 n=6}
_{Emit Time}	_{16.38s (± 0.44%)}	_{17.02s (± 8.11%)}	_~	_16.35s	_19.84s	_{p=0.065 n=6}
_{Total Time}	_{92.10s (± 0.38%)}	_{93.15s (± 1.57%)}	_{+1.05s (+ 1.14%)}	_92.39s	_96.11s	_{p=0.013 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,023k (± 0.01%)}	_{408,046k (± 0.01%)}	_~	_407,998k	_408,158k	_{p=0.575 n=6}
_{Parse Time}	_{3.21s (± 0.51%)}	_{3.22s (± 0.60%)}	_~	_3.20s	_3.25s	_{p=0.807 n=6}
_{Bind Time}	_{1.38s (± 0.71%)}	_{1.38s (± 0.85%)}	_~	_1.36s	_1.39s	_{p=1.000 n=6}
_{Check Time}	_{14.26s (± 0.26%)}	_{14.28s (± 0.26%)}	_~	_14.24s	_14.34s	_{p=0.413 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.86s (± 0.16%)}	_{18.89s (± 0.15%)}	_~	_18.85s	_18.92s	_{p=0.124 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,961k (± 0.01%)}	_{513,044k (± 0.01%)}	_~	_512,964k	_513,118k	_{p=0.093 n=6}
_{Parse Time}	_{3.28s (± 0.23%)}	_{3.28s (± 0.19%)}	_~	_3.27s	_3.29s	_{p=0.718 n=6}
_{Bind Time}	_{1.54s (± 0.64%)}	_{1.54s (± 0.34%)}	_~	_1.53s	_1.54s	_{p=0.504 n=6}
_{Check Time}	_{2.85s (± 0.53%)}	_{2.85s (± 0.22%)}	_~	_2.84s	_2.86s	_{p=0.739 n=6}
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_~	_0.07s	_0.07s	_{p=1.000 n=6}
_{Total Time}	_{7.74s (± 0.24%)}	_{7.75s (± 0.16%)}	_~	_7.73s	_7.76s	_{p=0.519 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-03-21T01:45:49Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the top-repos suite comparing main and refs/pull/57871/merge:

Everything looks good!

Anders Hejlsberg (ahejlsberg) · 2024-03-21T13:55:43Z

TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this faster

TypeScript Bot (typescript-bot) · 2024-03-21T13:55:46Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-03-21T14:15:12Z

Hey Anders Hejlsberg (@ahejlsberg), the results of running the DT tests are ready.
There were interesting changes:

Branch only errors:

Package: amap-js-api-driving
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/amap-js-api-driving/amap-js-api-driving-tests.ts
162:9 error TypeScript@local expected type to be:
PoiExt
got:
PoiBase & { website: string; pcode: string; citycode: string; adcode: string; postcode: string; pname: string; cityname: string; adname: string; email: string; photos: PoiPhoto[]; entr_location: LngLat | null; exit_location: LngLat | null; groupbuy: boolean; discount: boolean; } & (({ indoor_map: true; indoor_data: { cpid: string; floor: string; truefloor: string; }; } | { indoor_map: false; }) & { groupbuys?: Groupbuy[] | undefined; discounts?: Discount[] | undefined; } & ({ deep_type: "CINEMA"; cinema: Cinema; } | { deep_type: "DINING"; dining: Dining; } | { deep_type: "SCENIC"; scenic: Scenic; } | { deep_type: "HOTEL"; hotel: Hotel; })) @definitelytyped/expect
166:9 error TypeScript@local expected type to be:
PoiExt
got:
PoiBase & { website: string; pcode: string; citycode: string; adcode: string; postcode: string; pname: string; cityname: string; adname: string; email: string; photos: PoiPhoto[]; entr_location: LngLat | null; exit_location: LngLat | null; groupbuy: boolean; discount: boolean; } & (({ indoor_map: true; indoor_data: { cpid: string; floor: string; truefloor: string; }; } | { indoor_map: false; }) & { groupbuys?: Groupbuy[] | undefined; discounts?: Discount[] | undefined; } & ({ deep_type: "CINEMA"; cinema: Cinema; } | { deep_type: "DINING"; dining: Dining; } | { deep_type: "SCENIC"; scenic: Scenic; } | { deep_type: "HOTEL"; hotel: Hotel; })) @definitelytyped/expect
✖ 2 problems (2 errors, 0 warnings)
at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: amap-js-api-riding
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/amap-js-api-riding/amap-js-api-riding-tests.ts
100:9 error TypeScript@local expected type to be:
PoiExt
got:
PoiBase & { website: string; pcode: string; citycode: string; adcode: string; postcode: string; pname: string; cityname: string; adname: string; email: string; photos: PoiPhoto[]; entr_location: LngLat | null; exit_location: LngLat | null; groupbuy: boolean; discount: boolean; } & (({ indoor_map: true; indoor_data: { cpid: string; floor: string; truefloor: string; }; } | { indoor_map: false; }) & { groupbuys?: Groupbuy[] | undefined; discounts?: Discount[] | undefined; } & ({ deep_type: "CINEMA"; cinema: Cinema; } | { deep_type: "DINING"; dining: Dining; } | { deep_type: "SCENIC"; scenic: Scenic; } | { deep_type: "HOTEL"; hotel: Hotel; })) @definitelytyped/expect
110:9 error TypeScript@local expected type to be:
PoiExt
got:
PoiBase & { website: string; pcode: string; citycode: string; adcode: string; postcode: string; pname: string; cityname: string; adname: string; email: string; photos: PoiPhoto[]; entr_location: LngLat | null; exit_location: LngLat | null; groupbuy: boolean; discount: boolean; } & (({ indoor_map: true; indoor_data: { cpid: string; floor: string; truefloor: string; }; } | { indoor_map: false; }) & { groupbuys?: Groupbuy[] | undefined; discounts?: Discount[] | undefined; } & ({ deep_type: "CINEMA"; cinema: Cinema; } | { deep_type: "DINING"; dining: Dining; } | { deep_type: "SCENIC"; scenic: Scenic; } | { deep_type: "HOTEL"; hotel: Hotel; })) @definitelytyped/expect
145:9 error TypeScript@local expected type to be:
PoiExt
got:
PoiBase & { website: string; pcode: string; citycode: string; adcode: string; postcode: string; pname: string; cityname: string; adname: string; email: string; photos: PoiPhoto[]; entr_location: LngLat | null; exit_location: LngLat | null; groupbuy: boolean; discount: boolean; } & (({ indoor_map: true; indoor_data: { cpid: string; floor: string; truefloor: string; }; } | { indoor_map: false; }) & { groupbuys?: Groupbuy[] | undefined; discounts?: Discount[] | undefined; } & ({ deep_type: "CINEMA"; cinema: Cinema; } | { deep_type: "DINING"; dining: Dining; } | { deep_type: "SCENIC"; scenic: Scenic; } | { deep_type: "HOTEL"; hotel: Hotel; })) @definitelytyped/expect
149:9 error TypeScript@local expected type to be:
PoiExt
got:
PoiBase & { website: string; pcode: string; citycode: string; adcode: string; postcode: string; pname: string; cityname: string; adname: string; email: string; photos: PoiPhoto[]; entr_location: LngLat | null; exit_location: LngLat | null; groupbuy: boolean; discount: boolean; } & (({ indoor_map: true; indoor_data: { cpid: string; floor: string; truefloor: string; }; } | { indoor_map: false; }) & { groupbuys?: Groupbuy[] | undefined; discounts?: Discount[] | undefined; } & ({ deep_type: "CINEMA"; cinema: Cinema; } | { deep_type: "DINING"; dining: Dining; } | { deep_type: "SCENIC"; scenic: Scenic; } | { deep_type: "HOTEL"; hotel: Hotel; })) @definitelytyped/expect
✖ 4 problems (4 errors, 0 warnings)
at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: amap-js-api-transfer
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/amap-js-api-transfer/amap-js-api-transfer-tests.ts
321:9 error TypeScript@local expected type to be:
PoiExt
got:
PoiBase & { website: string; pcode: string; citycode: string; adcode: string; postcode: string; pname: string; cityname: string; adname: string; email: string; photos: PoiPhoto[]; entr_location: LngLat | null; exit_location: LngLat | null; groupbuy: boolean; discount: boolean; } & (({ indoor_map: true; indoor_data: { cpid: string; floor: string; truefloor: string; }; } | { indoor_map: false; }) & { groupbuys?: Groupbuy[] | undefined; discounts?: Discount[] | undefined; } & ({ deep_type: "CINEMA"; cinema: Cinema; } | { deep_type: "DINING"; dining: Dining; } | { deep_type: "SCENIC"; scenic: Scenic; } | { deep_type: "HOTEL"; hotel: Hotel; })) @definitelytyped/expect
325:9 error TypeScript@local expected type to be:
PoiExt
got:
PoiBase & { website: string; pcode: string; citycode: string; adcode: string; postcode: string; pname: string; cityname: string; adname: string; email: string; photos: PoiPhoto[]; entr_location: LngLat | null; exit_location: LngLat | null; groupbuy: boolean; discount: boolean; } & (({ indoor_map: true; indoor_data: { cpid: string; floor: string; truefloor: string; }; } | { indoor_map: false; }) & { groupbuys?: Groupbuy[] | undefined; discounts?: Discount[] | undefined; } & ({ deep_type: "CINEMA"; cinema: Cinema; } | { deep_type: "DINING"; dining: Dining; } | { deep_type: "SCENIC"; scenic: Scenic; } | { deep_type: "HOTEL"; hotel: Hotel; })) @definitelytyped/expect
351:9 error TypeScript@local expected type to be:
PoiExt
got:
PoiBase & { website: string; pcode: string; citycode: string; adcode: string; postcode: string; pname: string; cityname: string; adname: string; email: string; photos: PoiPhoto[]; entr_location: LngLat | null; exit_location: LngLat | null; groupbuy: boolean; discount: boolean; } & (({ indoor_map: true; indoor_data: { cpid: string; floor: string; truefloor: string; }; } | { indoor_map: false; }) & { groupbuys?: Groupbuy[] | undefined; discounts?: Discount[] | undefined; } & ({ deep_type: "CINEMA"; cinema: Cinema; } | { deep_type: "DINING"; dining: Dining; } | { deep_type: "SCENIC"; scenic: Scenic; } | { deep_type: "HOTEL"; hotel: Hotel; })) @definitelytyped/expect
353:9 error TypeScript@local expected type to be:
PoiExt
got:
PoiBase & { website: string; pcode: string; citycode: string; adcode: string; postcode: string; pname: string; cityname: string; adname: string; email: string; photos: PoiPhoto[]; entr_location: LngLat | null; exit_location: LngLat | null; groupbuy: boolean; discount: boolean; } & (({ indoor_map: true; indoor_data: { cpid: string; floor: string; truefloor: string; }; } | { indoor_map: false; }) & { groupbuys?: Groupbuy[] | undefined; discounts?: Discount[] | undefined; } & ({ deep_type: "CINEMA"; cinema: Cinema; } | { deep_type: "DINING"; dining: Dining; } | { deep_type: "SCENIC"; scenic: Scenic; } | { deep_type: "HOTEL"; hotel: Hotel; })) @definitelytyped/expect
✖ 4 problems (4 errors, 0 warnings)
at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-03-21T14:31:51Z

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,609k (± 0.00%)}	_{295,633k (± 0.00%)}	_{+24k (+ 0.01%)}	_295,622k	_295,654k	_{p=0.013 n=6}
_{Parse Time}	_{2.67s (± 0.44%)}	_{2.67s (± 0.31%)}	_~	_2.66s	_2.68s	_{p=0.555 n=6}
_{Bind Time}	_{0.83s (± 0.62%)}	_{0.83s (± 0.49%)}	_~	_0.82s	_0.83s	_{p=0.595 n=6}
_{Check Time}	_{8.22s (± 0.22%)}	_{8.20s (± 0.39%)}	_~	_8.17s	_8.26s	_{p=0.077 n=6}
_{Emit Time}	_{7.03s (± 0.30%)}	_{7.06s (± 0.77%)}	_~	_7.01s	_7.14s	_{p=0.517 n=6}
_{Total Time}	_{18.75s (± 0.16%)}	_{18.75s (± 0.35%)}	_~	_18.67s	_18.82s	_{p=0.872 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,097k (± 0.97%)}	_{192,460k (± 0.74%)}	_~	_191,814k	_195,381k	_{p=0.298 n=6}
_{Parse Time}	_{1.35s (± 1.58%)}	_{1.36s (± 1.42%)}	_~	_1.34s	_1.39s	_{p=0.370 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.49s (± 0.71%)}	_{9.49s (± 0.76%)}	_~	_9.43s	_9.61s	_{p=1.000 n=6}
_{Emit Time}	_{2.65s (± 0.50%)}	_{2.64s (± 0.75%)}	_~	_2.61s	_2.66s	_{p=0.287 n=6}
_{Total Time}	_{14.21s (± 0.33%)}	_{14.21s (± 0.56%)}	_~	_14.13s	_14.34s	_{p=0.688 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,371k (± 0.00%)}	_{347,385k (± 0.01%)}	_~	_347,364k	_347,417k	_{p=0.261 n=6}
_{Parse Time}	_{2.49s (± 0.30%)}	_{2.49s (± 0.70%)}	_~	_2.47s	_2.52s	_{p=0.397 n=6}
_{Bind Time}	_{0.92s (± 0.56%)}	_{0.93s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=0.311 n=6}
_{Check Time}	_{7.02s (± 0.70%)}	_{7.03s (± 0.29%)}	_~	_6.99s	_7.05s	_{p=1.000 n=6}
_{Emit Time}	_{4.06s (± 0.27%)}	_{4.07s (± 0.39%)}	_~	_4.05s	_4.09s	_{p=0.410 n=6}
_{Total Time}	_{14.49s (± 0.38%)}	_{14.51s (± 0.27%)}	_~	_14.44s	_14.56s	_{p=0.744 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,716k (± 0.01%)}	_{302,732k (± 0.00%)}	_~	_302,718k	_302,740k	_{p=0.108 n=6}
_{Parse Time}	_{2.02s (± 0.51%)}	_{2.01s (± 0.80%)}	_~	_1.99s	_2.03s	_{p=0.623 n=6}
_{Bind Time}	_{1.00s (± 0.82%)}	_{1.00s (± 0.63%)}	_~	_0.99s	_1.01s	_{p=0.432 n=6}
_{Check Time}	_{6.31s (± 0.43%)}	_{6.30s (± 0.16%)}	_~	_6.29s	_6.32s	_{p=0.618 n=6}
_{Emit Time}	_{3.60s (± 0.15%)}	_{3.61s (± 0.39%)}	_~	_3.59s	_3.63s	_{p=0.498 n=6}
_{Total Time}	_{12.93s (± 0.20%)}	_{12.93s (± 0.14%)}	_~	_12.91s	_12.95s	_{p=0.935 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{509,886k (± 0.00%)}	_{509,866k (± 0.00%)}	_~	_509,837k	_509,900k	_{p=0.230 n=6}
_{Parse Time}	_{2.66s (± 0.37%)}	_{2.66s (± 0.66%)}	_~	_2.63s	_2.68s	_{p=0.869 n=6}
_{Bind Time}	_{0.98s (± 0.85%)}	_{0.98s (± 0.85%)}	_~	_0.98s	_1.00s	_{p=1.000 n=6}
_{Check Time}	_{17.24s (± 0.21%)}	_{17.26s (± 0.38%)}	_~	_17.17s	_17.33s	_{p=0.519 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.88s (± 0.19%)}	_{20.90s (± 0.28%)}	_~	_20.81s	_20.97s	_{p=0.686 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,719,639k (± 0.00%)}	_{1,737,399k (± 0.00%)}	_{+17,761k (+ 1.03%)}	_1,737,366k	_1,737,442k	_{p=0.005 n=6}
_{Parse Time}	_{6.59s (± 0.21%)}	_{6.58s (± 0.56%)}	_~	_6.54s	_6.62s	_{p=0.806 n=6}
_{Bind Time}	_{2.35s (± 0.42%)}	_{2.36s (± 0.35%)}	_~	_2.35s	_2.37s	_{p=0.282 n=6}
_{Check Time}	_{56.26s (± 0.33%)}	_{56.50s (± 0.46%)}	_~	_56.25s	_56.96s	_{p=0.149 n=6}
_{Emit Time}	_{0.13s (± 3.10%)}	_{0.13s (± 3.87%)}	_~	_0.13s	_0.14s	_{p=0.595 n=6}
_{Total Time}	_{65.33s (± 0.27%)}	_{65.57s (± 0.43%)}	_~	_65.28s	_66.07s	_{p=0.173 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,392,082k (± 0.03%)}	_{2,392,015k (± 0.04%)}	_~	_2,391,224k	_2,393,568k	_{p=0.936 n=6}
_{Parse Time}	_{5.05s (± 1.22%)}	_{5.01s (± 0.99%)}	_~	_4.92s	_5.06s	_{p=0.521 n=6}
_{Bind Time}	_{1.90s (± 0.72%)}	_{1.91s (± 0.80%)}	_~	_1.88s	_1.92s	_{p=0.868 n=6}
_{Check Time}	_{33.60s (± 0.33%)}	_{33.55s (± 0.21%)}	_~	_33.48s	_33.66s	_{p=0.575 n=6}
_{Emit Time}	_{2.62s (± 1.65%)}	_{2.63s (± 2.09%)}	_~	_2.55s	_2.70s	_{p=0.687 n=6}
_{Total Time}	_{43.20s (± 0.41%)}	_{43.11s (± 0.30%)}	_~	_42.95s	_43.31s	_{p=0.471 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{415,083k (± 0.01%)}	_{415,101k (± 0.01%)}	_~	_415,045k	_415,174k	_{p=0.575 n=6}
_{Parse Time}	_{2.82s (± 1.23%)}	_{2.84s (± 0.85%)}	_~	_2.80s	_2.86s	_{p=0.466 n=6}
_{Bind Time}	_{1.08s (± 0.78%)}	_{1.07s (± 0.70%)}	_~	_1.06s	_1.08s	_{p=0.432 n=6}
_{Check Time}	_{15.28s (± 0.38%)}	_{15.28s (± 0.20%)}	_~	_15.23s	_15.31s	_{p=0.936 n=6}
_{Emit Time}	_{1.11s (± 1.23%)}	_{1.11s (± 0.74%)}	_~	_1.10s	_1.12s	_{p=0.445 n=6}
_{Total Time}	_{20.29s (± 0.41%)}	_{20.29s (± 0.15%)}	_~	_20.25s	_20.34s	_{p=0.936 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,888,153k (± 0.00%)}	_{2,888,152k (± 0.00%)}	_~	_2,888,095k	_2,888,237k	_{p=0.810 n=6}
_{Parse Time}	_{10.82s (± 0.27%)}	_{10.85s (± 0.43%)}	_~	_10.81s	_10.94s	_{p=0.257 n=6}
_{Bind Time}	_{3.47s (± 0.65%)}	_{3.46s (± 0.30%)}	_~	_3.44s	_3.47s	_{p=0.139 n=6}
_{Check Time}	_{61.63s (± 0.24%)}	_{61.66s (± 0.44%)}	_~	_61.43s	_62.16s	_{p=0.810 n=6}
_{Emit Time}	_{16.51s (± 0.66%)}	_{16.46s (± 1.00%)}	_~	_16.32s	_16.75s	_{p=0.261 n=6}
_{Total Time}	_{92.44s (± 0.29%)}	_{92.43s (± 0.28%)}	_~	_92.18s	_92.81s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,137k (± 0.02%)}	_{408,140k (± 0.02%)}	_~	_408,064k	_408,245k	_{p=0.936 n=6}
_{Parse Time}	_{3.25s (± 0.30%)}	_{3.25s (± 0.23%)}	_~	_3.24s	_3.26s	_{p=0.858 n=6}
_{Bind Time}	_{1.38s (± 0.60%)}	_{1.38s (± 0.30%)}	_~	_1.38s	_1.39s	_{p=0.527 n=6}
_{Check Time}	_{14.27s (± 0.18%)}	_{14.25s (± 0.28%)}	_~	_14.20s	_14.29s	_{p=0.627 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.90s (± 0.17%)}	_{18.88s (± 0.23%)}	_~	_18.83s	_18.93s	_{p=0.517 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,026k (± 0.01%)}	_{513,021k (± 0.01%)}	_~	_512,915k	_513,107k	_{p=0.688 n=6}
_{Parse Time}	_{3.28s (± 0.30%)}	_{3.29s (± 0.42%)}	_~	_3.26s	_3.30s	_{p=0.315 n=6}
_{Bind Time}	_{1.54s (± 0.00%)}	_{1.54s (± 0.35%)}	_~	_1.54s	_1.55s	_{p=0.071 n=6}
_{Check Time}	_{2.85s (± 0.48%)}	_{2.85s (± 0.42%)}	_~	_2.83s	_2.86s	_{p=1.000 n=6}
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 5.69%)}	_~	_0.07s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.74s (± 0.27%)}	_{7.74s (± 0.25%)}	_~	_7.71s	_7.76s	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Anders Hejlsberg (ahejlsberg) · 2024-03-21T14:36:49Z

TypeScript Bot (@typescript-bot) run dt

TypeScript Bot (typescript-bot) · 2024-03-21T14:36:52Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`run dt`	✅ Started	✅ Results

TypeScript Bot (typescript-bot) · 2024-03-21T14:56:15Z

Hey Anders Hejlsberg (@ahejlsberg), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

Anders Hejlsberg (ahejlsberg) · 2024-03-21T15:45:01Z

Tests and performance are unaffected. This is ready for a review.

Jake Bailey (jakebailey) · 2024-03-21T19:06:18Z

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.4

TypeScript Bot (typescript-bot) · 2024-03-21T19:06:21Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.4`	✅ Started	❌ Results

TypeScript Bot (typescript-bot) · 2024-03-21T19:07:42Z

Hey, Jake Bailey (@jakebailey)! I was unable to cherry-pick this PR.

Check the logs at: https://github.com/microsoft/TypeScript/actions/runs/8380435679

Jake Bailey (jakebailey) · 2024-03-21T21:16:00Z

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.4

TypeScript Bot (typescript-bot) · 2024-03-21T21:16:02Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.4`	✅ Started	✅ Results

TypeScript Bot (typescript-bot) · 2024-03-21T21:25:47Z

Hey, Jake Bailey (@jakebailey)! I've created #57893 for you. This involved updating baselines; please check the diff.

KnorpelSenf (KnorpelSenf) · 2024-03-22T09:15:13Z

This is huge, thank you so much! I've been working around this limitation in my library for almost a year now. These changes allow me to do so much more now! 🎉❤️

KnorpelSenf (KnorpelSenf) · 2024-03-31T22:41:17Z

Anders Hejlsberg (@ahejlsberg) I would like to see a patch release on top of 5.4 with these changes. Is there anything I can do to help get this out there?

…e-5.4 (#57893) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

Jake Bailey (jakebailey) · 2024-04-02T19:59:06Z

This is backported (see above), and will be in the next patch.

Anders Hejlsberg (ahejlsberg) added 3 commits March 20, 2024 16:33

Divide-and-conquer strategy for intersections of unions
55808fe

Accept new baselines
43f1d44

Add tests
a8e74ae

TypeScript Bot (typescript-bot) assigned Anders Hejlsberg (ahejlsberg)Mar 21, 2024

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 21, 2024

Anders Hejlsberg (ahejlsberg) requested a review from Ryan Cavanaugh (RyanCavanaugh)March 21, 2024 00:22

Properly cache outermost result
5bace94

Include type alias
a83f592

Accept new baselines
72352dc

Ryan Cavanaugh (RyanCavanaugh) reviewed Mar 21, 2024
View reviewed changes

Comment threadsrc/compiler/checker.ts Outdated

Ryan Cavanaugh (RyanCavanaugh) approved these changes Mar 21, 2024
View reviewed changes

Integer positions only
df41141

Anders Hejlsberg (ahejlsberg) merged commit ecb6eb2 into mainMar 21, 2024

Anders Hejlsberg (ahejlsberg) deleted the fix57863 branch March 21, 2024 17:18

TypeScript Bot (typescript-bot) pushed a commit that referenced this pull request Mar 21, 2024
Divide-and-conquer strategy for intersections of unions (#57871)
619f330

TypeScript Bot (typescript-bot) mentioned this pull request Mar 21, 2024
🤖 Pick PR #57871 (Divide-and-conquer strategy for int...) into release-5.4 #57893
Merged

Uladzislau Hramyka (SecondThundeR) mentioned this pull request Mar 22, 2024
TypeScript compiles too long when using omitted filter or shortcut for it grammyjs/grammY#543
Closed

Daniel Rosenwasser (DanielRosenwasser) pushed a commit that referenced this pull request Apr 1, 2024
🤖 Pick PR#57871(Divide-and-conquer strategy for int...) into releas…
de9096b
…e-5.4 (#57893) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

KnorpelSenf (KnorpelSenf) mentioned this pull request Apr 1, 2024
fix: avoid mapped type during filter query type narrowing grammyjs/grammY#553
Merged

Emanuel Hoogeveen (ehoogeveen-medweb) mentioned this pull request Apr 30, 2024
Constraint in generic type forgotten in assignability check #58370
Closed

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Uh oh!

Conversation

Anders Hejlsberg (ahejlsberg) commented Mar 21, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Mar 21, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 21, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 21, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 21, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 21, 2024

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Mar 21, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 21, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 21, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 21, 2024

tsc

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Mar 21, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 21, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 21, 2024

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Mar 21, 2024

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Mar 21, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 21, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 21, 2024

Uh oh!

Jake Bailey (jakebailey) commented Mar 21, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 21, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 21, 2024

Uh oh!

KnorpelSenf (KnorpelSenf) commented Mar 22, 2024

Uh oh!

KnorpelSenf (KnorpelSenf) commented Mar 31, 2024

Uh oh!

Jake Bailey (jakebailey) commented Apr 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Anders Hejlsberg (ahejlsberg) commented Mar 21, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 21, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 21, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 21, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 21, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Mar 21, 2024•
edited
Loading