Remove sys.bufferFrom, duplicate Buffer declarations, etc by jakebailey · Pull Request #57916 · microsoft/TypeScript

Jake Bailey (jakebailey) · 2024-03-23T04:44:20Z

Direct use of Buffer was added in #22658 for base64. Later, #25659 added bufferFrom to work around a bug in Node v5. #29813 added a duplicate declaration of Buffer to get the project to compile properly.

These days, none of this appears to be needed. We can just use the global Buffer directly and drop all of the duplicate declarations and wrapping.

BufferEncoding unfortunately remains due to its use in the tsserver Session interface.

Jake Bailey (jakebailey) · 2024-03-23T04:44:31Z

TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2024-03-23T04:44:34Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-03-23T05:17:46Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,465k (± 0.01%)}	_{295,472k (± 0.01%)}	_~	_295,438k	_295,516k	_{p=0.688 n=6}
_{Parse Time}	_{3.21s (± 0.46%)}	_{3.19s (± 1.09%)}	_~	_3.15s	_3.24s	_{p=0.256 n=6}
_{Bind Time}	_{0.99s (± 0.82%)}	_{0.99s (± 0.76%)}	_~	_0.98s	_1.00s	_{p=0.729 n=6}
_{Check Time}	_{9.62s (± 0.36%)}	_{9.61s (± 0.33%)}	_~	_9.57s	_9.64s	_{p=0.512 n=6}
_{Emit Time}	_{8.38s (± 0.18%)}	_{8.38s (± 0.35%)}	_~	_8.36s	_8.44s	_{p=0.465 n=6}
_{Total Time}	_{22.21s (± 0.16%)}	_{22.17s (± 0.28%)}	_~	_22.09s	_22.26s	_{p=0.295 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,809k (± 1.07%)}	_{193,633k (± 1.00%)}	_~	_191,800k	_195,488k	_{p=0.298 n=6}
_{Parse Time}	_{1.64s (± 1.07%)}	_{1.66s (± 0.83%)}	_~	_1.64s	_1.68s	_{p=0.104 n=6}
_{Bind Time}	_{0.86s (± 0.00%)}	_{0.86s (± 0.94%)}	_~	_0.85s	_0.87s	_{p=0.290 n=6}
_{Check Time}	_{11.27s (± 0.70%)}	_{11.26s (± 1.00%)}	_~	_11.09s	_11.37s	_{p=1.000 n=6}
_{Emit Time}	_{3.16s (± 0.76%)}	_{3.15s (± 0.44%)}	_~	_3.13s	_3.17s	_{p=0.318 n=6}
_{Total Time}	_{16.93s (± 0.43%)}	_{16.93s (± 0.60%)}	_~	_16.80s	_17.04s	_{p=1.000 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,405k (± 0.00%)}	_{347,391k (± 0.00%)}	_~	_347,369k	_347,401k	_{p=0.199 n=6}
_{Parse Time}	_{2.99s (± 1.68%)}	_{2.98s (± 0.59%)}	_~	_2.97s	_3.01s	_{p=0.935 n=6}
_{Bind Time}	_{1.11s (± 0.80%)}	_{1.11s (± 0.37%)}	_~	_1.10s	_1.11s	_{p=0.787 n=6}
_{Check Time}	_{8.27s (± 0.42%)}	_{8.26s (± 0.35%)}	_~	_8.21s	_8.29s	_{p=1.000 n=6}
_{Emit Time}	_{4.86s (± 0.68%)}	_{4.86s (± 0.33%)}	_~	_4.85s	_4.89s	_{p=0.871 n=6}
_{Total Time}	_{17.22s (± 0.37%)}	_{17.21s (± 0.11%)}	_~	_17.20s	_17.25s	_{p=0.570 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,700k (± 0.01%)}	_{302,706k (± 0.00%)}	_~	_302,686k	_302,727k	_{p=0.747 n=6}
_{Parse Time}	_{2.41s (± 0.48%)}	_{2.42s (± 0.50%)}	_~	_2.41s	_2.44s	_{p=0.099 n=6}
_{Bind Time}	_{1.19s (± 0.70%)}	_{1.23s (± 0.51%)}	_{+0.04s (+ 2.93%)}	_1.22s	_1.24s	_{p=0.004 n=6}
_{Check Time}	_{7.47s (± 0.39%)}	_{7.45s (± 0.32%)}	_~	_7.42s	_7.48s	_{p=0.227 n=6}
_{Emit Time}	_{4.27s (± 0.64%)}	_{4.29s (± 0.65%)}	_~	_4.25s	_4.32s	_{p=0.216 n=6}
_{Total Time}	_{15.35s (± 0.20%)}	_{15.39s (± 0.14%)}	_{+0.04s (+ 0.29%)}	_15.37s	_15.42s	_{p=0.024 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{509,925k (± 0.01%)}	_{509,922k (± 0.00%)}	_~	_509,896k	_509,937k	_{p=0.936 n=6}
_{Parse Time}	_{3.93s (± 0.28%)}	_{3.92s (± 0.21%)}	_~	_3.91s	_3.93s	_{p=0.383 n=6}
_{Bind Time}	_{1.44s (± 1.50%)}	_{1.45s (± 0.72%)}	_~	_1.44s	_1.47s	_{p=0.343 n=6}
_{Check Time}	_{25.39s (± 0.22%)}	_{25.31s (± 0.23%)}	_~	_25.24s	_25.40s	_{p=0.054 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=0.405 n=6}
_{Total Time}	_{30.76s (± 0.24%)}	_{30.69s (± 0.17%)}	_~	_30.62s	_30.75s	_{p=0.109 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,737,550k (± 0.00%)}	_{1,737,555k (± 0.00%)}	_~	_1,737,512k	_1,737,597k	_{p=1.000 n=6}
_{Parse Time}	_{7.76s (± 0.41%)}	_{7.79s (± 0.64%)}	_~	_7.74s	_7.88s	_{p=0.466 n=6}
_{Bind Time}	_{2.79s (± 0.29%)}	_{2.79s (± 0.55%)}	_~	_2.76s	_2.80s	_{p=1.000 n=6}
_{Check Time}	_{66.55s (± 0.34%)}	_{66.63s (± 0.35%)}	_~	_66.20s	_66.85s	_{p=0.689 n=6}
_{Emit Time}	_{0.15s (± 3.53%)}	_{0.15s (± 3.53%)}	_~	_0.15s	_0.16s	_{p=1.000 n=6}
_{Total Time}	_{77.26s (± 0.30%)}	_{77.36s (± 0.35%)}	_~	_76.86s	_77.63s	_{p=0.471 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,393,636k (± 0.02%)}	_{2,389,539k (± 0.04%)}	_{-4,097k (- 0.17%)}	_2,387,932k	_2,390,587k	_{p=0.005 n=6}
_{Parse Time}	_{6.06s (± 0.56%)}	_{6.03s (± 0.74%)}	_~	_5.96s	_6.10s	_{p=0.297 n=6}
_{Bind Time}	_{2.24s (± 1.46%)}	_{2.26s (± 0.54%)}	_~	_2.25s	_2.28s	_{p=0.360 n=6}
_{Check Time}	_{39.36s (± 0.32%)}	_{39.32s (± 0.31%)}	_~	_39.21s	_39.47s	_{p=0.748 n=6}
_{Emit Time}	_{3.11s (± 1.06%)}	_{3.16s (± 1.71%)}	_~	_3.10s	_3.25s	_{p=0.092 n=6}
_{Total Time}	_{50.79s (± 0.27%)}	_{50.79s (± 0.31%)}	_~	_50.63s	_51.04s	_{p=0.873 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{415,096k (± 0.01%)}	_{414,553k (± 0.01%)}	_{-544k (- 0.13%)}	_414,506k	_414,587k	_{p=0.005 n=6}
_{Parse Time}	_{3.41s (± 0.64%)}	_{3.39s (± 0.78%)}	_~	_3.35s	_3.42s	_{p=0.225 n=6}
_{Bind Time}	_{1.29s (± 1.03%)}	_{1.30s (± 0.80%)}	_~	_1.28s	_1.31s	_{p=0.553 n=6}
_{Check Time}	_{18.04s (± 0.23%)}	_{18.02s (± 0.29%)}	_~	_17.95s	_18.10s	_{p=0.521 n=6}
_{Emit Time}	_{1.32s (± 1.76%)}	_{1.36s (± 1.29%)}	_{+0.05s (+ 3.54%)}	_1.34s	_1.38s	_{p=0.015 n=6}
_{Total Time}	_{24.06s (± 0.29%)}	_{24.07s (± 0.23%)}	_~	_24.00s	_24.14s	_{p=0.873 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,891,003k (± 0.00%)}	_{2,891,012k (± 0.00%)}	_~	_2,890,994k	_2,891,025k	_{p=0.336 n=6}
_{Parse Time}	_{12.94s (± 0.34%)}	_{12.94s (± 0.33%)}	_~	_12.89s	_13.00s	_{p=0.872 n=6}
_{Bind Time}	_{4.12s (± 0.20%)}	_{4.15s (± 1.22%)}	_~	_4.11s	_4.25s	_{p=0.190 n=6}
_{Check Time}	_{71.58s (± 0.61%)}	_{71.47s (± 0.24%)}	_~	_71.24s	_71.70s	_{p=1.000 n=6}
_{Emit Time}	_{19.50s (± 0.77%)}	_{19.40s (± 0.66%)}	_~	_19.26s	_19.54s	_{p=0.688 n=6}
_{Total Time}	_{108.15s (± 0.37%)}	_{107.96s (± 0.17%)}	_~	_107.74s	_108.18s	_{p=0.423 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,140k (± 0.01%)}	_{408,143k (± 0.01%)}	_~	_408,073k	_408,191k	_{p=0.873 n=6}
_{Parse Time}	_{3.90s (± 0.98%)}	_{3.93s (± 0.55%)}	_~	_3.89s	_3.94s	_{p=0.327 n=6}
_{Bind Time}	_{1.68s (± 0.97%)}	_{1.68s (± 0.75%)}	_~	_1.66s	_1.69s	_{p=0.681 n=6}
_{Check Time}	_{16.75s (± 0.41%)}	_{16.74s (± 0.47%)}	_~	_16.61s	_16.81s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.34s (± 0.40%)}	_{22.35s (± 0.38%)}	_~	_22.24s	_22.43s	_{p=1.000 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,030k (± 0.02%)}	_{513,070k (± 0.01%)}	_~	_512,997k	_513,150k	_{p=0.471 n=6}
_{Parse Time}	_{3.95s (± 0.44%)}	_{3.96s (± 0.89%)}	_~	_3.91s	_4.00s	_{p=0.807 n=6}
_{Bind Time}	_{1.86s (± 0.99%)}	_{1.85s (± 1.06%)}	_~	_1.84s	_1.88s	_{p=0.806 n=6}
_{Check Time}	_{3.39s (± 0.94%)}	_{3.38s (± 0.44%)}	_~	_3.37s	_3.40s	_{p=1.000 n=6}
_{Emit Time}	_{0.09s (± 6.44%)}	_{0.09s (± 5.95%)}	_~	_0.08s	_0.09s	_{p=0.640 n=6}
_{Total Time}	_{9.28s (± 0.61%)}	_{9.29s (± 0.52%)}	_~	_9.21s	_9.33s	_{p=0.748 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,376ms (± 0.69%)}	_{2,368ms (± 1.07%)}	_~	_2,329ms	_2,397ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{5,592ms (± 0.66%)}	_{5,639ms (± 1.60%)}	_~	_5,553ms	_5,806ms	_{p=0.471 n=6}
_{Req 3 - references}	_{319ms (± 0.80%)}	_{318ms (± 0.40%)}	_~	_316ms	_320ms	_{p=0.924 n=6}
_{Req 4 - navto}	_{273ms (± 0.00%)}	_{273ms (± 0.65%)}	_~	_269ms	_274ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,357 (± 0.00%)}	_{1,357 (± 0.00%)}	_~	_1,357	_1,357	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{87ms (± 0.60%)}	_{89ms (± 4.72%)}	_~	_86ms	_97ms	_{p=0.386 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,495ms (± 0.90%)}	_{2,508ms (± 1.11%)}	_~	_2,468ms	_2,536ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{4,114ms (± 0.18%)}	_{4,117ms (± 0.32%)}	_~	_4,102ms	_4,136ms	_{p=0.873 n=6}
_{Req 3 - references}	_{333ms (± 0.15%)}	_{332ms (± 0.66%)}	_~	_328ms	_334ms	_{p=0.242 n=6}
_{Req 4 - navto}	_{295ms (± 0.21%)}	_{295ms (± 0.40%)}	_~	_293ms	_296ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,519 (± 0.00%)}	_{1,519 (± 0.00%)}	_~	_1,519	_1,519	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{73ms (± 0.70%)}	_{74ms (± 0.70%)}	_~	_73ms	_74ms	_{p=0.311 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,608ms (± 0.44%)}	_{2,607ms (± 0.20%)}	_~	_2,601ms	_2,615ms	_{p=0.423 n=6}
_{Req 2 - geterr}	_{1,738ms (± 2.17%)}	_{1,715ms (± 2.35%)}	_~	_1,667ms	_1,782ms	_{p=0.298 n=6}
_{Req 3 - references}	_{124ms (± 0.94%)}	_{119ms (± 8.74%)}	_~	_104ms	_129ms	_{p=0.625 n=6}
_{Req 4 - navto}	_{367ms (± 1.10%)}	_{369ms (± 0.93%)}	_~	_363ms	_373ms	_{p=0.517 n=6}
_{Req 5 - completionInfo count}	_{2,079 (± 0.00%)}	_{2,079 (± 0.00%)}	_~	_2,079	_2,079	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{310ms (± 1.82%)}	_{311ms (± 1.73%)}	_~	_304ms	_317ms	_{p=0.871 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.28ms (± 0.17%)}	_{153.16ms (± 0.16%)}	_{-0.12ms (- 0.08%)}	_152.12ms	_155.32ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{226.16ms (± 0.15%)}	_{226.02ms (± 0.17%)}	_{-0.14ms (- 0.06%)}	_224.41ms	_232.67ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{221.82ms (± 0.15%)}	_{221.79ms (± 0.17%)}	_~	_220.27ms	_227.19ms	_{p=0.374 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{221.13ms (± 0.17%)}	_{221.10ms (± 0.18%)}	_~	_219.64ms	_226.20ms	_{p=0.514 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Remove sys.bufferFrom
44f51b4

TypeScript Bot (typescript-bot) assigned Jake Bailey (jakebailey)Mar 23, 2024

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 23, 2024

Sheetal Nandi (sheetalkamat) approved these changes Mar 25, 2024
View reviewed changes

Jake Bailey (jakebailey) merged commit 3c0a802 into microsoft:mainMar 25, 2024

Jake Bailey (jakebailey) deleted the no-buffer branch March 25, 2024 17:50

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Navigation Menu

Uh oh!

Remove sys.bufferFrom, duplicate Buffer declarations, etc - #57916

Remove sys.bufferFrom, duplicate Buffer declarations, etc#57916
Jake Bailey (jakebailey) merged 1 commit into
microsoft:mainfrom
jakebailey:no-buffer

Jake Bailey (jakebailey) commented Mar 23, 2024

Uh oh!

Jake Bailey (jakebailey) commented Mar 23, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 23, 2024•
edited
Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 23, 2024

tsc

tsserver

startup

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Jake Bailey (jakebailey) commented Mar 23, 2024

Uh oh!

Jake Bailey (jakebailey) commented Mar 23, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 23, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 23, 2024

tsc

tsserver

startup

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TypeScript Bot (typescript-bot) commented Mar 23, 2024•
edited
Loading