Deprecate module keyword for namespace declarations by Zzzen · Pull Request #58007 · microsoft/TypeScript

Zzzen (Zzzen) · 2024-03-30T18:04:27Z

Jake Bailey (jakebailey) · 2024-04-02T20:00:47Z

TypeScript Bot (@typescript-bot) test it

I'm going to make a second PR that uses this to issue a full error so we can gauge how bad things are at the moment (and verify that this is working).

TypeScript Bot (typescript-bot) · 2024-04-02T20:00:49Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-04-02T20:30:32Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,739k (± 0.01%)}	_{295,725k (± 0.01%)}	_~	_295,705k	_295,759k	_{p=0.378 n=6}
_{Parse Time}	_{2.64s (± 0.59%)}	_{2.65s (± 0.57%)}	_~	_2.63s	_2.67s	_{p=0.139 n=6}
_{Bind Time}	_{0.84s (± 1.17%)}	_{0.83s (± 0.98%)}	_~	_0.83s	_0.85s	_{p=0.144 n=6}
_{Check Time}	_{8.23s (± 0.24%)}	_{8.24s (± 0.32%)}	_~	_8.21s	_8.28s	_{p=0.289 n=6}
_{Emit Time}	_{7.04s (± 0.21%)}	_{7.05s (± 0.39%)}	_~	_7.02s	_7.09s	_{p=0.466 n=6}
_{Total Time}	_{18.75s (± 0.21%)}	_{18.79s (± 0.26%)}	_~	_18.71s	_18.84s	_{p=0.228 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,254k (± 0.11%)}	_{192,739k (± 0.79%)}	_~	_192,106k	_195,838k	_{p=0.689 n=6}
_{Parse Time}	_{1.36s (± 0.86%)}	_{1.36s (± 0.86%)}	_~	_1.35s	_1.38s	_{p=0.868 n=6}
_{Bind Time}	_{0.73s (± 0.56%)}	_{0.72s (± 0.75%)}	_~	_0.72s	_0.73s	_{p=0.282 n=6}
_{Check Time}	_{9.52s (± 0.22%)}	_{9.56s (± 0.66%)}	_~	_9.49s	_9.65s	_{p=0.332 n=6}
_{Emit Time}	_{2.63s (± 0.52%)}	_{2.63s (± 0.65%)}	_~	_2.61s	_2.66s	_{p=0.622 n=6}
_{Total Time}	_{14.23s (± 0.14%)}	_{14.28s (± 0.46%)}	_~	_14.20s	_14.37s	_{p=0.295 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,404k (± 0.00%)}	_{347,440k (± 0.00%)}	_{+36k (+ 0.01%)}	_347,427k	_347,467k	_{p=0.005 n=6}
_{Parse Time}	_{2.48s (± 0.66%)}	_{2.49s (± 0.49%)}	_~	_2.47s	_2.50s	_{p=0.934 n=6}
_{Bind Time}	_{0.93s (± 0.00%)}	_{0.93s (± 0.00%)}	_~	_0.93s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{6.99s (± 0.48%)}	_{6.99s (± 0.42%)}	_~	_6.96s	_7.03s	_{p=1.000 n=6}
_{Emit Time}	_{4.07s (± 0.40%)}	_{4.07s (± 0.21%)}	_~	_4.05s	_4.07s	_{p=1.000 n=6}
_{Total Time}	_{14.47s (± 0.22%)}	_{14.47s (± 0.17%)}	_~	_14.43s	_14.50s	_{p=1.000 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,806k (± 0.01%)}	_{302,833k (± 0.01%)}	_~	_302,807k	_302,854k	_{p=0.092 n=6}
_{Parse Time}	_{2.43s (± 1.24%)}	_{2.41s (± 1.06%)}	_~	_2.39s	_2.45s	_{p=0.221 n=6}
_{Bind Time}	_{1.20s (± 0.68%)}	_{1.20s (± 1.29%)}	_~	_1.19s	_1.23s	_{p=0.787 n=6}
_{Check Time}	_{7.53s (± 0.36%)}	_{7.56s (± 0.56%)}	_~	_7.50s	_7.62s	_{p=0.195 n=6}
_{Emit Time}	_{4.28s (± 0.39%)}	_{4.27s (± 0.60%)}	_~	_4.22s	_4.29s	_{p=0.682 n=6}
_{Total Time}	_{15.44s (± 0.35%)}	_{15.44s (± 0.51%)}	_~	_15.35s	_15.54s	_{p=0.936 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,029k (± 0.00%)}	_{510,067k (± 0.00%)}	_{+38k (+ 0.01%)}	_510,047k	_510,094k	_{p=0.020 n=6}
_{Parse Time}	_{2.66s (± 0.31%)}	_{2.67s (± 0.64%)}	_~	_2.64s	_2.69s	_{p=0.345 n=6}
_{Bind Time}	_{0.98s (± 0.64%)}	_{0.98s (± 0.85%)}	_~	_0.97s	_0.99s	_{p=0.226 n=6}
_{Check Time}	_{17.29s (± 0.59%)}	_{17.27s (± 0.26%)}	_~	_17.20s	_17.33s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.94s (± 0.53%)}	_{20.92s (± 0.23%)}	_~	_20.86s	_21.00s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,745,002k (± 0.00%)}	_{1,744,989k (± 0.00%)}	_~	_1,744,953k	_1,745,032k	_{p=0.575 n=6}
_{Parse Time}	_{7.79s (± 0.52%)}	_{7.81s (± 0.61%)}	_~	_7.76s	_7.89s	_{p=0.520 n=6}
_{Bind Time}	_{2.81s (± 1.11%)}	_{2.82s (± 0.29%)}	_~	_2.81s	_2.83s	_{p=0.796 n=6}
_{Check Time}	_{66.86s (± 0.27%)}	_{66.98s (± 0.37%)}	_~	_66.72s	_67.40s	_{p=0.630 n=6}
_{Emit Time}	_{0.16s (± 3.29%)}	_{0.16s (± 0.00%)}	_~	_0.16s	_0.16s	_{p=0.174 n=6}
_{Total Time}	_{77.62s (± 0.22%)}	_{77.77s (± 0.34%)}	_~	_77.47s	_78.18s	_{p=0.470 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,400,665k (± 0.05%)}	_{2,400,936k (± 0.04%)}	_~	_2,399,299k	_2,402,024k	_{p=0.575 n=6}
_{Parse Time}	_{7.47s (± 1.34%)}	_{7.49s (± 1.32%)}	_~	_7.30s	_7.59s	_{p=0.688 n=6}
_{Bind Time}	_{2.77s (± 1.21%)}	_{2.76s (± 0.81%)}	_~	_2.74s	_2.79s	_{p=0.627 n=6}
_{Check Time}	_{49.39s (± 0.31%)}	_{49.37s (± 0.45%)}	_~	_49.07s	_49.71s	_{p=0.936 n=6}
_{Emit Time}	_{3.99s (± 4.33%)}	_{3.95s (± 1.19%)}	_~	_3.89s	_4.01s	_{p=1.000 n=6}
_{Total Time}	_{63.65s (± 0.36%)}	_{63.57s (± 0.32%)}	_~	_63.35s	_63.91s	_{p=0.575 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{416,147k (± 0.01%)}	_{416,320k (± 0.01%)}	_{+172k (+ 0.04%)}	_416,272k	_416,387k	_{p=0.005 n=6}
_{Parse Time}	_{3.32s (± 1.09%)}	_{3.33s (± 0.62%)}	_~	_3.30s	_3.36s	_{p=0.871 n=6}
_{Bind Time}	_{1.28s (± 1.18%)}	_{1.30s (± 0.31%)}	_~	_1.29s	_1.30s	_{p=0.073 n=6}
_{Check Time}	_{18.17s (± 0.25%)}	_{18.13s (± 0.50%)}	_~	_18.00s	_18.21s	_{p=0.686 n=6}
_{Emit Time}	_{1.34s (± 2.13%)}	_{1.33s (± 1.50%)}	_~	_1.32s	_1.37s	_{p=0.742 n=6}
_{Total Time}	_{24.13s (± 0.27%)}	_{24.09s (± 0.27%)}	_~	_24.01s	_24.16s	_{p=0.521 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,899,569k (± 0.00%)}	_{2,899,546k (± 0.01%)}	_~	_2,899,316k	_2,899,670k	_{p=0.689 n=6}
_{Parse Time}	_{12.90s (± 0.18%)}	_{12.91s (± 0.42%)}	_~	_12.86s	_13.00s	_{p=0.936 n=6}
_{Bind Time}	_{4.14s (± 0.18%)}	_{4.15s (± 0.28%)}	_~	_4.13s	_4.16s	_{p=0.279 n=6}
_{Check Time}	_{71.92s (± 0.27%)}	_{72.19s (± 0.54%)}	_~	_71.74s	_72.70s	_{p=0.298 n=6}
_{Emit Time}	_{19.39s (± 0.56%)}	_{20.79s (± 9.99%)}	_~	_19.34s	_23.51s	_{p=0.093 n=6}
_{Total Time}	_{108.35s (± 0.18%)}	_{110.04s (± 2.06%)}	_~	_108.23s	_113.07s	_{p=0.172 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,922k (± 0.01%)}	_{408,911k (± 0.02%)}	_~	_408,819k	_409,013k	_{p=0.810 n=6}
_{Parse Time}	_{4.77s (± 0.80%)}	_{4.82s (± 0.95%)}	_~	_4.77s	_4.90s	_{p=0.147 n=6}
_{Bind Time}	_{2.06s (± 0.20%)}	_{2.05s (± 0.84%)}	_~	_2.02s	_2.07s	_{p=0.103 n=6}
_{Check Time}	_{20.83s (± 0.52%)}	_{20.78s (± 0.18%)}	_~	_20.74s	_20.84s	_{p=0.199 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{27.67s (± 0.36%)}	_{27.65s (± 0.26%)}	_~	_27.56s	_27.76s	_{p=0.687 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,515k (± 0.01%)}	_{513,490k (± 0.02%)}	_~	_513,427k	_513,717k	_{p=0.128 n=6}
_{Parse Time}	_{3.99s (± 0.63%)}	_{3.96s (± 0.52%)}	_~	_3.94s	_3.99s	_{p=0.142 n=6}
_{Bind Time}	_{1.88s (± 0.82%)}	_{1.89s (± 1.04%)}	_~	_1.87s	_1.91s	_{p=0.558 n=6}
_{Check Time}	_{3.44s (± 0.83%)}	_{3.44s (± 0.34%)}	_~	_3.42s	_3.45s	_{p=0.629 n=6}
_{Emit Time}	_{0.08s (± 6.44%)}	_{0.08s (± 6.19%)}	_~	_0.08s	_0.09s	_{p=0.855 n=6}
_{Total Time}	_{9.40s (± 0.42%)}	_{9.38s (± 0.31%)}	_~	_9.33s	_9.42s	_{p=0.296 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-04-02T20:31:40Z

Jake Bailey (@jakebailey) Here are the results of running the user tests comparing main and refs/pull/58007/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2024-04-02T20:32:08Z

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-04-02T21:54:40Z

Jake Bailey (@jakebailey) Here are the results of running the top 400 repos comparing main and refs/pull/58007/merge:

Everything looks good!

Jake Bailey (jakebailey) · 2024-04-02T23:02:03Z

Seems like it works? #58040 (comment)

Jake Bailey (jakebailey)

This looks good to me, but deferring to Daniel Rosenwasser (@DanielRosenwasser) / Ryan Cavanaugh (@RyanCavanaugh) for final wording.

…laration

Daniel Rosenwasser (DanielRosenwasser) · 2024-05-30T17:34:35Z

One thing I'd like to check is whether module gets a strikeout when a user has just written declare module with no identifier or string following.

Can you ensure that it doesn't, and provide a test as well?

Sheetal Nandi (sheetalkamat) · 2024-05-30T17:38:36Z


 if (isIdentifier(node.name)) {
 checkCollisionsForDeclarationName(node, node.name);
+ if (!(node.flags & (NodeFlags.Namespace | NodeFlags.GlobalAugmentation))) {


This will only report errors in editor and there is no way to report these errors on command line. I think we need to handle "deprecation" version here instead to issue error

The intent is to not report the in tsc yet, per #57913

…laration

Zzzen (Zzzen) · 2024-05-31T14:50:07Z

Tests added.

Daniel Rosenwasser (DanielRosenwasser) · 2024-05-31T19:08:23Z

TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2024-05-31T19:08:26Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

TypeScript Bot (typescript-bot) · 2024-05-31T19:11:00Z

Hey Daniel Rosenwasser (@DanielRosenwasser), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/162023/artifacts?artifactName=tgz&fileId=4C696B8DD8AD7BE042E1BFD6B2862915D9A6673F879C79EDF1344C0E12B4D0E102&fileName=/typescript-5.5.0-insiders.20240531.tgz"
}
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-58007-11".;

… for ambient module declaration.

Deprecate module keyword for namespace declarations
96ab6a9

TypeScript Bot (typescript-bot) added the For Backlog Bug PRs that fix a backlog bug label Mar 30, 2024

Jake Bailey (jakebailey) mentioned this pull request Apr 2, 2024
[experiment] error on module when namespace would work #58040
Closed

Jake Bailey (jakebailey) requested review from Daniel Rosenwasser (DanielRosenwasser) and Ryan Cavanaugh (RyanCavanaugh)April 2, 2024 23:02

Nathan Shively-Sanders (sandersn) assigned Jake Bailey (jakebailey)May 22, 2024

Jake Bailey (jakebailey) approved these changes May 23, 2024
View reviewed changes

Zzzen (Zzzen) added 2 commits May 27, 2024 00:12

Merge remote-tracking branch 'origin/main' into deprecated-module-dec…
c14e714
…laration

Merge remote-tracking branch 'origin/main' into deprecated-module-dec…
e90f714
…laration

Sheetal Nandi (sheetalkamat) requested changes May 30, 2024
View reviewed changes

Zzzen (Zzzen) added 2 commits May 31, 2024 22:23

Merge remote-tracking branch 'origin/main' into deprecated-module-dec…
3b80706
…laration

add test
8c334e5

Chengzhong Wu (legendecas) mentioned this pull request Jul 8, 2024
doc: add strip-types proposal nodejs/loaders#210
Merged

Surround namespace/module with single quotes, flatten tests, add test…
921bfdd
… for ambient module declaration.

TypeScript Bot (typescript-bot) added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Backlog Bug PRs that fix a backlog bug labels Jul 23, 2024

Daniel Rosenwasser (DanielRosenwasser) added 2 commits July 23, 2024 11:32

Switch code to 1540 for conflict.
89d66b2

Merge branch 'main' into deprecated-module-declaration
02c9248

Daniel Rosenwasser (DanielRosenwasser) approved these changes Jul 24, 2024
View reviewed changes

Daniel Rosenwasser (DanielRosenwasser) merged commit ab7b624 into microsoft:mainJul 24, 2024

Nathan Shively-Sanders (sandersn) removed this from PR Backlog Apr 22, 2025

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Uh oh!

Conversation

Zzzen (Zzzen) commented Mar 30, 2024

Uh oh!

Jake Bailey (jakebailey) commented Apr 2, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 2, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 2, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 2, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 2, 2024

Uh oh!

Jake Bailey (jakebailey) commented Apr 2, 2024

Uh oh!

Jake Bailey (jakebailey) left a comment

Choose a reason for hiding this comment

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented May 30, 2024

Uh oh!

Sheetal Nandi (sheetalkamat)May 30, 2024

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey)May 30, 2024

Choose a reason for hiding this comment

Uh oh!

Zzzen (Zzzen) commented May 31, 2024

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented May 31, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented May 31, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 31, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

TypeScript Bot (typescript-bot) commented Apr 2, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented May 31, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented May 31, 2024•
edited
Loading