Uh oh!
There was an error while loading. Please reload this page.
lib.d.ts: add missing TypedArray-from-iterable signatures - #58188
Closed
René (Renegade334) wants to merge 12 commits into
Closed
lib.d.ts: add missing TypedArray-from-iterable signatures#58188René (Renegade334) wants to merge 12 commits into
René (Renegade334) wants to merge 12 commits into
Conversation
Jake Bailey (jakebailey)
commented
Apr 14, 2024
Member
TypeScript Bot (@typescript-bot) test it |
Contributor
TypeScript Bot (typescript-bot)
commented
Apr 14, 2024
Contributor
Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready. Everything looks the same! |
TypeScript Bot (typescript-bot)
commented
Apr 14, 2024
Contributor
Jake Bailey (@jakebailey) Here are the results of running the user tests comparing Everything looks good! |
TypeScript Bot (typescript-bot)
commented
Apr 14, 2024
Contributor
Jake Bailey (@jakebailey) Here they are:tscComparison Report - baseline..pr
System info unknown Hosts
Scenarios
Developer Information: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
TypeScript Bot (typescript-bot)
commented
Apr 14, 2024
Contributor
Jake Bailey (@jakebailey) Here are the results of running the top 400 repos comparing Everything looks good! |
René (Renegade334)force-pushed
the
array-from-iterable
branch
from
June 5, 2024 22:47
8443b67 to
20c515aCompareNathan Shively-Sanders (sandersn)
requested changes
Jun 14, 2024
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
Looks good except I have one question about addition of Iterable in es2020.bigint
| * Creates an array from an array-like or iterable object. | ||
| * @param arrayLike An array-like or iterable object to convert to an array. | ||
| */ | ||
| from(arrayLike: ArrayLike<bigint> | Iterable<bigint>): BigInt64Array; |
There was a problem hiding this comment.
why do these differ from the types in TypeArray.from? For that one, we just use Iterable.
Some guesses:
- es2020.bigint can be used without including es2015.iterable (or whatever file makes Arrays Iterable)
- Iterable is added here because it's in TypedArray.from, but ArrayLike stays for backward compatibility.
ContributorAuthor
There was a problem hiding this comment.
Because in those cases, the ArrayLike overloads had already been defined in es5 prior to the introduction of iterables, so the ArrayLike signature and the Iterable signature exist as two separate overloads (eg.here and here). Since the bigint typed arrays are defined in es2020 for the first time, both need to be added here.
ArrayLike objects don't have to be iterable, so the method definitions need to accept both:
BigInt64Array.from(// ArrayLike<number> but not iterable{0: 12345678,1: 98765432,length: 2,},(n: number): bigint=>BigInt(n)**2n,)// BigInt64Array [ 152415765279684n, 9754610558146624n ]ContributorAuthor
There was a problem hiding this comment.
On that subject, though, the bigint TypedArray constructors in es2020.bigint don't look like they have a new (ArrayLike<bigint>) signature, which probably also needs addressing.
Comment on lines
+30
to
+31
| bigIntArray = BigInt64Array.from({0: 1n, 1: 2n, 2: 3n, length: 3}); | ||
| bigIntArray = BigInt64Array.from({0: 1n, 1: 2n, 2: 3n, length: 3}, n => n * 10n); |
ContributorAuthor
There was a problem hiding this comment.
re. this conversation, this is the case that necessitates keeping ArrayLike alongside Iterable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves#45198
Resolves#45199
There are stale PRs linked to these issues, but those involved wider remodelling of the array library. This should be simple enough to merge independently.