Skip to content

Clone questionMark and dotdotdot token - #58263

Merged
Jake Bailey (jakebailey) merged 2 commits into
microsoft:mainfrom
armanio123:FixTokenCloning
Apr 24, 2024
Merged

Clone questionMark and dotdotdot token#58263
Jake Bailey (jakebailey) merged 2 commits into
microsoft:mainfrom
armanio123:FixTokenCloning

Conversation

@armanio123

@armanio123Armando Aguirre (armanio123) commented Apr 20, 2024

Copy link
Copy Markdown
Contributor

Fixes#57924 (comment)

CompletionInfo is failing due to a synthetic propertySignature using an incorrect questionToken position which cause the Assert to fail.

The positions are incorrect due to the checker reusing the synthetic node for the questionToken. When assigning positions the value gets overwritten by the latest position update this generating a node that is "not contained" on the parent.

The PR fixes this by always cloning a synthetic questionToken instead of reusing it.

@gabritto

Gabriela Araujo Britto (gabritto) commented Apr 20, 2024

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 20, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

CommandStatusResults
perf test this✅ Started

@armanio123Armando Aguirre (armanio123) mentioned this pull request Apr 20, 2024
Closed
@armanio123

Armando Aguirre (armanio123) commented Apr 20, 2024

Copy link
Copy Markdown
ContributorAuthor

TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 20, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

CommandStatusResults
perf test this✅ Started👀 Results

@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 20, 2024

Copy link
Copy Markdown
Contributor

Armando Aguirre (@armanio123)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
Angular - node (v18.15.0, x64)
Memory used297,480k (± 0.01%)297,478k (± 0.02%)~297,432k297,568kp=0.521 n=6
Parse Time4.08s (± 0.44%)4.09s (± 0.40%)~4.07s4.11sp=0.222 n=6
Bind Time1.21s (± 0.81%)1.21s (± 0.45%)~1.20s1.21sp=0.662 n=6
Check Time12.20s (± 0.29%)12.19s (± 0.20%)~12.16s12.22sp=0.869 n=6
Emit Time10.54s (± 0.28%)10.53s (± 0.24%)~10.49s10.57sp=0.935 n=6
Total Time28.03s (± 0.21%)28.02s (± 0.13%)~27.98s28.07sp=1.000 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used193,332k (± 0.95%)193,310k (± 0.96%)~192,085k195,735kp=0.575 n=6
Parse Time2.00s (± 1.30%)2.01s (± 1.46%)~1.97s2.04sp=0.464 n=6
Bind Time1.07s (± 1.13%)1.07s (± 0.92%)~1.06s1.08sp=0.865 n=6
Check Time14.05s (± 0.28%)14.00s (± 0.44%)~13.89s14.06sp=0.196 n=6
Emit Time3.88s (± 0.85%)3.95s (± 3.76%)~3.86s4.25sp=0.336 n=6
Total Time21.00s (± 0.17%)21.03s (± 0.76%)~20.86s21.32sp=0.936 n=6
mui-docs - node (v18.15.0, x64)
Memory used1,753,207k (± 0.00%)1,753,192k (± 0.00%)~1,753,097k1,753,274kp=1.000 n=6
Parse Time10.04s (± 0.85%)9.99s (± 0.34%)~9.97s10.06sp=0.414 n=6
Bind Time3.37s (± 0.49%)3.36s (± 0.40%)~3.34s3.38sp=0.462 n=6
Check Time81.72s (± 0.34%)81.67s (± 0.54%)~81.30s82.48sp=0.471 n=6
Emit Time0.20s (± 2.06%)0.20s (± 2.06%)~0.19s0.20sp=1.000 n=6
Total Time95.33s (± 0.32%)95.22s (± 0.47%)~94.85s96.04sp=0.378 n=6
self-build-src - node (v18.15.0, x64)
Memory used2,322,365k (± 0.02%)2,322,760k (± 0.05%)~2,321,207k2,323,991kp=0.689 n=6
Parse Time7.55s (± 0.97%)7.54s (± 0.85%)~7.47s7.62sp=1.000 n=6
Bind Time2.72s (± 0.45%)2.72s (± 0.56%)~2.70s2.74sp=0.871 n=6
Check Time49.31s (± 0.39%)49.47s (± 0.71%)~49.08s49.92sp=0.575 n=6
Emit Time4.01s (± 2.55%)3.96s (± 2.42%)~3.79s4.05sp=0.423 n=6
Total Time63.60s (± 0.42%)63.68s (± 0.71%)~63.06s64.28sp=0.810 n=6
self-build-src-public-api - node (v18.15.0, x64)
Memory used2,396,390k (± 0.02%)2,397,150k (± 0.03%)~2,396,175k2,398,650kp=0.078 n=6
Parse Time7.80s (± 0.47%)7.79s (± 1.08%)~7.64s7.90sp=1.000 n=6
Bind Time2.46s (± 1.07%)2.45s (± 0.80%)~2.43s2.48sp=0.872 n=6
Check Time50.22s (± 0.42%)49.95s (± 0.24%)-0.26s (- 0.53%)49.79s50.11sp=0.045 n=6
Emit Time4.06s (± 2.89%)3.91s (± 2.83%)🟩-0.16s (- 3.90%)3.80s4.12sp=0.045 n=6
Total Time64.55s (± 0.38%)64.11s (± 0.18%)-0.44s (- 0.67%)64.00s64.30sp=0.008 n=6
self-compiler - node (v18.15.0, x64)
Memory used423,934k (± 0.01%)423,922k (± 0.01%)~423,863k423,954kp=0.936 n=6
Parse Time2.89s (± 0.49%)2.89s (± 0.96%)~2.86s2.92sp=1.000 n=6
Bind Time1.09s (± 0.47%)1.08s (± 0.77%)~1.07s1.09sp=0.923 n=6
Check Time15.38s (± 0.36%)15.35s (± 0.18%)~15.32s15.38sp=0.686 n=6
Emit Time1.17s (± 0.76%)1.17s (± 0.88%)~1.15s1.18sp=0.673 n=6
Total Time20.52s (± 0.29%)20.50s (± 0.23%)~20.44s20.56sp=0.466 n=6
ts-pre-modules - node (v18.15.0, x64)
Memory used369,299k (± 0.03%)369,295k (± 0.02%)~369,225k369,402kp=0.936 n=6
Parse Time2.45s (± 1.43%)2.47s (± 0.99%)~2.44s2.51sp=0.520 n=6
Bind Time1.32s (± 1.39%)1.33s (± 0.91%)~1.31s1.34sp=0.800 n=6
Check Time13.36s (± 0.17%)13.30s (± 0.38%)-0.05s (- 0.41%)13.20s13.34sp=0.016 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time17.13s (± 0.30%)17.10s (± 0.26%)~17.02s17.15sp=0.226 n=6
vscode - node (v18.15.0, x64)
Memory used2,920,845k (± 0.00%)2,920,795k (± 0.00%)~2,920,712k2,920,860kp=0.128 n=6
Parse Time16.73s (± 0.47%)16.70s (± 0.26%)~16.65s16.76sp=0.872 n=6
Bind Time5.03s (± 1.81%)5.02s (± 1.69%)~4.97s5.19sp=0.627 n=6
Check Time88.36s (± 0.39%)88.35s (± 0.40%)~87.97s88.83sp=0.936 n=6
Emit Time23.87s (± 0.51%)23.84s (± 0.59%)~23.61s23.97sp=0.936 n=6
Total Time133.97s (± 0.35%)133.90s (± 0.23%)~133.47s134.26sp=0.748 n=6
webpack - node (v18.15.0, x64)
Memory used409,811k (± 0.01%)409,858k (± 0.01%)~409,829k409,880kp=0.066 n=6
Parse Time3.95s (± 1.19%)3.94s (± 0.74%)~3.89s3.98sp=0.514 n=6
Bind Time1.64s (± 0.74%)1.64s (± 1.22%)~1.60s1.65sp=0.318 n=6
Check Time16.93s (± 0.36%)16.98s (± 0.21%)~16.94s17.03sp=0.173 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time22.51s (± 0.19%)22.56s (± 0.17%)~22.52s22.62sp=0.091 n=6
xstate-main - node (v18.15.0, x64)
Memory used459,364k (± 0.00%)459,395k (± 0.03%)~459,312k459,621kp=1.000 n=6
Parse Time4.00s (± 0.47%)4.01s (± 0.52%)~3.99s4.05sp=0.105 n=6
Bind Time1.47s (± 0.96%)1.47s (± 1.25%)~1.45s1.49sp=0.870 n=6
Check Time22.40s (± 0.35%)22.43s (± 0.24%)~22.38s22.52sp=0.297 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time27.86s (± 0.32%)27.92s (± 0.26%)~27.84s28.03sp=0.298 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

tsserver

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen3,520ms (± 0.60%)3,508ms (± 0.93%)~3,467ms3,560msp=0.378 n=6
Req 2 - geterr7,570ms (± 0.33%)7,634ms (± 1.83%)~7,533ms7,897msp=0.688 n=6
Req 3 - references430ms (± 0.77%)433ms (± 1.38%)~428ms444msp=0.467 n=6
Req 4 - navto342ms (± 1.02%)340ms (± 0.43%)~338ms342msp=0.466 n=6
Req 5 - completionInfo count1,357 (± 0.00%)1,357 (± 0.00%)~1,3571,357p=1.000 n=6
Req 5 - completionInfo111ms (± 1.05%)112ms (± 1.13%)~111ms114msp=0.210 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen3,668ms (± 0.47%)3,682ms (± 0.66%)~3,656ms3,721msp=0.575 n=6
Req 2 - geterr5,721ms (± 1.54%)5,693ms (± 0.23%)~5,681ms5,717msp=0.467 n=6
Req 3 - references447ms (± 0.66%)444ms (± 0.51%)~442ms447msp=0.124 n=6
Req 4 - navto341ms (± 1.53%)340ms (± 1.12%)~338ms348msp=0.505 n=6
Req 5 - completionInfo count1,519 (± 0.00%)1,519 (± 0.00%)~1,5191,519p=1.000 n=6
Req 5 - completionInfo122ms (± 5.85%)124ms (± 1.02%)~122ms125msp=0.866 n=6
xstate-main-1-tsserver - node (v18.15.0, x64)
Req 1 - updateOpen5,249ms (± 0.34%)5,265ms (± 0.57%)~5,224ms5,302msp=0.378 n=6
Req 2 - geterr1,127ms (± 1.19%)1,142ms (± 0.93%)~1,127ms1,153msp=0.054 n=6
Req 3 - references87ms (± 4.55%)85ms (± 1.24%)~83ms86msp=0.742 n=6
Req 4 - navto452ms (± 0.99%)450ms (± 1.08%)~446ms458msp=0.466 n=6
Req 5 - completionInfo count3,413 (± 0.00%)3,413 (± 0.00%)~3,4133,413p=1.000 n=6
Req 5 - completionInfo855ms (± 2.87%)845ms (± 2.03%)~830ms869msp=0.521 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstate-main-1-tsserver - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

startup

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
tsc-startup - node (v18.15.0, x64)
Execution time156.44ms (± 0.15%)156.19ms (± 0.16%)-0.25ms (- 0.16%)155.26ms160.03msp=0.000 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time344.67ms (± 0.29%)344.60ms (± 0.30%)~336.43ms354.85msp=0.312 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time274.18ms (± 0.28%)274.05ms (± 0.28%)-0.13ms (- 0.05%)267.75ms279.75msp=0.002 n=600
typescript-startup - node (v18.15.0, x64)
Execution time336.22ms (± 0.33%)336.33ms (± 0.31%)~328.00ms343.55msp=0.155 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

Developer Information:

Download Benchmarks

@jakebailey

Jake Bailey (jakebailey) commented Apr 20, 2024

Copy link
Copy Markdown
Member

This makes sense; getSynthesizedDeepCloneWorker is similar and passes in the token visitor. Makes me wonder if we should try and make the visitor required and see where else we've missed this.

But, this does need a test; the linked issue should come with one that can be minimized.

@jakebailey

Jake Bailey (jakebailey) commented Apr 24, 2024

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 24, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

CommandStatusResults
perf test this✅ Started👀 Results

@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
Compiler-Unions - node (v18.15.0, x64)
Errors30 (± 0.00%)30 (± 0.00%)~3030p=1.000 n=6
Symbols62,154 (± 0.00%)62,154 (± 0.00%)~62,15462,154p=1.000 n=6
Types50,273 (± 0.00%)50,273 (± 0.00%)~50,27350,273p=1.000 n=6
Memory used192,737k (± 0.77%)192,107k (± 0.02%)~192,076k192,178kp=0.128 n=6
Parse Time1.65s (± 1.08%)1.64s (± 1.37%)~1.61s1.67sp=0.806 n=6
Bind Time0.86s (± 0.47%)0.87s (± 0.97%)~0.86s0.88sp=0.527 n=6
Check Time11.32s (± 0.49%)11.32s (± 0.47%)~11.22s11.37sp=0.629 n=6
Emit Time3.15s (± 0.52%)3.16s (± 0.37%)~3.15s3.18sp=0.250 n=6
Total Time16.98s (± 0.36%)16.99s (± 0.27%)~16.93s17.05sp=0.630 n=6
angular-1 - node (v18.15.0, x64)
Errors5 (± 0.00%)5 (± 0.00%)~55p=1.000 n=6
Symbols945,172 (± 0.00%)945,172 (± 0.00%)~945,172945,172p=1.000 n=6
Types408,068 (± 0.00%)408,068 (± 0.00%)~408,068408,068p=1.000 n=6
Memory used1,221,850k (± 0.00%)1,221,869k (± 0.00%)~1,221,803k1,221,945kp=0.575 n=6
Parse Time8.30s (± 0.28%)8.32s (± 0.48%)~8.27s8.38sp=0.416 n=6
Bind Time2.23s (± 0.23%)2.23s (± 0.66%)~2.20s2.24sp=0.324 n=6
Check Time36.48s (± 0.43%)36.39s (± 0.49%)~36.14s36.58sp=0.575 n=6
Emit Time17.29s (± 0.54%)17.39s (± 0.39%)~17.31s17.48sp=0.065 n=6
Total Time64.29s (± 0.32%)64.33s (± 0.22%)~64.16s64.47sp=1.000 n=6
mui-docs - node (v18.15.0, x64)
Errors5 (± 0.00%)5 (± 0.00%)~55p=1.000 n=6
Symbols1,954,583 (± 0.00%)1,954,583 (± 0.00%)~1,954,5831,954,583p=1.000 n=6
Types676,355 (± 0.00%)676,355 (± 0.00%)~676,355676,355p=1.000 n=6
Memory used1,753,237k (± 0.00%)1,753,286k (± 0.00%)~1,753,179k1,753,359kp=0.173 n=6
Parse Time10.03s (± 0.44%)10.00s (± 0.50%)~9.94s10.08sp=0.261 n=6
Bind Time3.38s (± 0.31%)3.37s (± 0.61%)~3.35s3.41sp=0.459 n=6
Check Time82.07s (± 0.37%)82.04s (± 0.30%)~81.75s82.35sp=1.000 n=6
Emit Time0.20s (± 2.62%)0.19s (± 2.81%)~0.19s0.20sp=0.640 n=6
Total Time95.67s (± 0.35%)95.61s (± 0.29%)~95.26s96.04sp=0.873 n=6
self-build-src - node (v18.15.0, x64)
Errors0 (± 0.00%)0 (± 0.00%)~00p=1.000 n=6
Symbols1,215,036 (± 0.00%)1,215,031 (± 0.00%)-5 (- 0.00%)1,215,0311,215,031p=0.001 n=6
Types257,343 (± 0.00%)257,343 (± 0.00%)~257,343257,343p=1.000 n=6
Memory used2,323,581k (± 0.01%)2,323,299k (± 0.05%)~2,321,843k2,324,661kp=0.689 n=6
Parse Time7.62s (± 0.74%)7.58s (± 1.22%)~7.46s7.67sp=0.575 n=6
Bind Time2.74s (± 1.01%)2.75s (± 1.14%)~2.70s2.78sp=0.418 n=6
Check Time49.42s (± 0.50%)49.25s (± 0.49%)~48.92s49.59sp=0.471 n=6
Emit Time3.95s (± 2.89%)4.10s (± 3.30%)~3.95s4.34sp=0.066 n=6
Total Time63.73s (± 0.62%)63.68s (± 0.42%)~63.36s64.07sp=1.000 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors0 (± 0.00%)0 (± 0.00%)~00p=1.000 n=6
Symbols1,215,036 (± 0.00%)1,215,031 (± 0.00%)-5 (- 0.00%)1,215,0311,215,031p=0.001 n=6
Types257,343 (± 0.00%)257,343 (± 0.00%)~257,343257,343p=1.000 n=6
Memory used2,398,138k (± 0.03%)2,397,930k (± 0.02%)~2,397,143k2,398,440kp=0.575 n=6
Parse Time7.84s (± 1.04%)7.84s (± 0.83%)~7.74s7.92sp=1.000 n=6
Bind Time2.46s (± 0.95%)2.47s (± 0.78%)~2.45s2.50sp=0.195 n=6
Check Time50.09s (± 0.21%)50.08s (± 0.27%)~49.96s50.28sp=0.689 n=6
Emit Time3.96s (± 1.68%)4.02s (± 3.90%)~3.84s4.26sp=0.630 n=6
Total Time64.36s (± 0.29%)64.43s (± 0.40%)~64.06s64.78sp=0.575 n=6
self-compiler - node (v18.15.0, x64)
Errors0 (± 0.00%)0 (± 0.00%)~00p=1.000 n=6
Symbols256,196 (± 0.00%)256,191 (± 0.00%)-5 (- 0.00%)256,191256,191p=0.001 n=6
Types103,624 (± 0.00%)103,624 (± 0.00%)~103,624103,624p=1.000 n=6
Memory used423,918k (± 0.01%)423,958k (± 0.01%)~423,915k424,009kp=0.297 n=6
Parse Time4.34s (± 0.79%)4.34s (± 0.79%)~4.30s4.38sp=0.807 n=6
Bind Time1.59s (± 1.08%)1.59s (± 1.89%)~1.55s1.62sp=0.684 n=6
Check Time22.41s (± 0.33%)22.50s (± 0.25%)+0.09s (+ 0.42%)22.45s22.60sp=0.028 n=6
Emit Time1.77s (± 1.27%)1.76s (± 0.51%)~1.75s1.77sp=0.806 n=6
Total Time30.10s (± 0.34%)30.20s (± 0.23%)~30.08s30.27sp=0.108 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors34 (± 0.00%)34 (± 0.00%)~3434p=1.000 n=6
Symbols224,824 (± 0.00%)224,824 (± 0.00%)~224,824224,824p=1.000 n=6
Types93,390 (± 0.00%)93,390 (± 0.00%)~93,39093,390p=1.000 n=6
Memory used369,384k (± 0.03%)369,268k (± 0.01%)~369,210k369,328kp=0.093 n=6
Parse Time2.94s (± 0.70%)2.94s (± 0.93%)~2.92s2.99sp=1.000 n=6
Bind Time1.57s (± 1.25%)1.58s (± 0.74%)~1.56s1.59sp=0.166 n=6
Check Time15.66s (± 0.15%)15.64s (± 0.18%)~15.61s15.68sp=0.226 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time20.17s (± 0.18%)20.16s (± 0.19%)~20.11s20.22sp=0.936 n=6
vscode - node (v18.15.0, x64)
Errors18 (± 0.00%)18 (± 0.00%)~1818p=1.000 n=6
Symbols2,795,998 (± 0.00%)2,795,998 (± 0.00%)~2,795,9982,795,998p=1.000 n=6
Types949,921 (± 0.00%)949,921 (± 0.00%)~949,921949,921p=1.000 n=6
Memory used2,923,882k (± 0.00%)2,923,894k (± 0.01%)~2,923,370k2,924,627kp=0.936 n=6
Parse Time16.73s (± 0.39%)16.76s (± 0.36%)~16.66s16.84sp=0.423 n=6
Bind Time5.03s (± 1.83%)5.03s (± 1.84%)~4.99s5.22sp=0.360 n=6
Check Time88.44s (± 0.55%)88.51s (± 0.39%)~88.07s89.05sp=0.936 n=6
Emit Time26.90s (± 8.73%)26.31s (± 7.52%)~23.85s28.53sp=0.521 n=6
Total Time137.09s (± 1.50%)136.60s (± 1.43%)~133.94s138.64sp=0.575 n=6
webpack - node (v18.15.0, x64)
Errors0 (± 0.00%)0 (± 0.00%)~00p=1.000 n=6
Symbols265,593 (± 0.00%)265,593 (± 0.00%)~265,593265,593p=1.000 n=6
Types108,389 (± 0.00%)108,389 (± 0.00%)~108,389108,389p=1.000 n=6
Memory used409,798k (± 0.01%)409,750k (± 0.01%)~409,701k409,810kp=0.054 n=6
Parse Time3.28s (± 0.81%)3.26s (± 0.60%)~3.25s3.30sp=0.284 n=6
Bind Time1.36s (± 0.72%)1.36s (± 1.10%)~1.34s1.38sp=0.730 n=6
Check Time14.43s (± 0.12%)14.43s (± 0.14%)~14.40s14.45sp=0.807 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time19.07s (± 0.24%)19.05s (± 0.11%)~19.03s19.08sp=0.629 n=6
xstate-main - node (v18.15.0, x64)
Errors0 (± 0.00%)0 (± 0.00%)~00p=1.000 n=6
Symbols519,608 (± 0.00%)519,608 (± 0.00%)~519,608519,608p=1.000 n=6
Types178,842 (± 0.00%)178,842 (± 0.00%)~178,842178,842p=1.000 n=6
Memory used459,394k (± 0.01%)459,351k (± 0.01%)~459,276k459,475kp=0.471 n=6
Parse Time4.02s (± 0.85%)4.00s (± 0.46%)~3.98s4.02sp=0.415 n=6
Bind Time1.47s (± 1.11%)1.48s (± 0.60%)~1.47s1.49sp=0.563 n=6
Check Time22.31s (± 0.76%)22.30s (± 0.28%)~22.19s22.35sp=0.378 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time27.81s (± 0.50%)27.78s (± 0.19%)~27.69s27.84sp=0.470 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

tsserver

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen2,352ms (± 0.53%)2,364ms (± 1.01%)~2,337ms2,400msp=0.575 n=6
Req 2 - geterr5,115ms (± 0.30%)5,101ms (± 0.62%)~5,065ms5,149msp=0.298 n=6
Req 3 - references286ms (± 0.65%)287ms (± 1.89%)~282ms296msp=1.000 n=6
Req 4 - navto228ms (± 1.03%)229ms (± 0.46%)~227ms230msp=0.744 n=6
Req 5 - completionInfo count1,357 (± 0.00%)1,357 (± 0.00%)~1,3571,357p=1.000 n=6
Req 5 - completionInfo86ms (± 6.39%)80ms (± 3.31%)~77ms83msp=0.119 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen2,483ms (± 0.56%)2,500ms (± 0.61%)~2,482ms2,522msp=0.066 n=6
Req 2 - geterr3,829ms (± 0.31%)3,837ms (± 0.20%)~3,825ms3,846msp=0.128 n=6
Req 3 - references301ms (± 0.72%)300ms (± 0.50%)~299ms303msp=1.000 n=6
Req 4 - navto227ms (± 0.23%)228ms (± 0.33%)~227ms229msp=0.247 n=6
Req 5 - completionInfo count1,519 (± 0.00%)1,519 (± 0.00%)~1,5191,519p=1.000 n=6
Req 5 - completionInfo73ms (± 1.35%)73ms (± 7.70%)~68ms84msp=0.454 n=6
xstate-main-1-tsserver - node (v18.15.0, x64)
Req 1 - updateOpen5,180ms (± 0.14%)5,190ms (± 0.12%)+10ms (+ 0.20%)5,179ms5,196msp=0.030 n=6
Req 2 - geterr1,128ms (± 0.89%)1,133ms (± 1.09%)~1,123ms1,151msp=0.470 n=6
Req 3 - references87ms (± 3.69%)85ms (± 0.96%)~84ms86msp=0.112 n=6
Req 4 - navto449ms (± 0.53%)449ms (± 0.74%)~446ms454msp=0.935 n=6
Req 5 - completionInfo count3,413 (± 0.00%)3,413 (± 0.00%)~3,4133,413p=1.000 n=6
Req 5 - completionInfo849ms (± 2.40%)842ms (± 1.99%)~829ms866msp=0.334 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstate-main-1-tsserver - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

startup

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
tsc-startup - node (v18.15.0, x64)
Execution time156.44ms (± 0.16%)156.40ms (± 0.15%)~155.57ms159.87msp=0.464 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time239.23ms (± 0.13%)239.18ms (± 0.13%)~237.87ms241.98msp=0.142 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time235.47ms (± 0.14%)235.29ms (± 0.15%)-0.18ms (- 0.07%)233.84ms240.21msp=0.000 n=600
typescript-startup - node (v18.15.0, x64)
Execution time235.23ms (± 0.16%)235.23ms (± 0.15%)~233.89ms238.68msp=0.897 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

Developer Information:

Download Benchmarks

@jakebailey

Jake Bailey (jakebailey) commented Apr 24, 2024

Copy link
Copy Markdown
Member

Tested, and the test does actually test the crash, nice.

@jakebailey
Jake Bailey (jakebailey) merged commit 5b69fdf into microsoft:mainApr 24, 2024
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranchAndrew Branch (andrewbranch)andrewbranch approved these changes
@jakebaileyJake Bailey (jakebailey)jakebailey approved these changes
@weswighamWesley Wigham (weswigham)Awaiting requested review from weswigham
@gabrittoGabriela Araujo Britto (gabritto)Awaiting requested review from gabritto

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ServerErrors][JavaScript] 5.5.0-dev.20240324

5 participants

@armanio123@gabritto@typescript-bot@jakebailey@andrewbranch