Report RegExp errors in grammar check, use Annex B grammar by rbuckton · Pull Request #58295 · microsoft/TypeScript

Ron Buckton (rbuckton) · 2024-04-23T16:59:23Z

This moves extended regular expression syntax checks to a grammar check. This ensures that RegExp grammar checks don't prevent type checking and allows them to be overridden via // @ts-ignore when necessary.

This also weakens the grammar check to use the productions and semantics in Annex B. This uses a boolean value to choose whether to use Annex B grammar in case we want to make this configurable, but for now the only place this is defined is guaranteed to be true.

Related #58287

Jake Bailey (jakebailey) · 2024-04-23T17:20:51Z

Theoretically this should net some "missing" errors

TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) test top400

TypeScript Bot (typescript-bot) · 2024-04-23T17:20:53Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started
`test top400`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-04-23T17:42:15Z

Jake Bailey (@jakebailey) Here are the results of running the user tests comparing main and refs/pull/58295/merge:

Something interesting changed - please have a look.

Details

azure-sdk

/mnt/ts_downloads/_/m/azure-sdk/build.sh

[MISSING] error TS2322: Type 'string' is not assignable to type 'never'.
- /mnt/ts_downloads/_/m/azure-sdk/test/narrowedTypes.ts(59,9)
- /mnt/ts_downloads/_/m/azure-sdk/test/narrowedTypes.ts(213,9)
- /mnt/ts_downloads/_/m/azure-sdk/test/narrowedTypes.ts(254,11)

puppeteer

tsconfig.base.json

[MISSING] error TS1487: Octal escape sequences are not allowed. Use the syntax '\x20'.
- packages/puppeteer-core/src/common/util.ts#L333 in tsconfig.base.json
[MISSING] error TS1530: Unicode property value expressions are only available when the Unicode (u) flag or the Unicode Sets (v) flag is set.
- packages/puppeteer-core/src/injected/PQuerySelector.ts#L25 in tsconfig.base.json

packages/puppeteer-core/tsconfig.json

pyright

/mnt/ts_downloads/_/m/pyright/build.sh

[MISSING] error TS1516: A character class range must not be bounded by another character class.
- /mnt/ts_downloads/_/m/pyright/pyright: ../pyright-internal/src/parser/tokenizer.ts(1271,94)
- /mnt/ts_downloads/_/m/pyright/pyright: ../pyright-internal/src/parser/tokenizer.ts(1290,100)
- /mnt/ts_downloads/_/m/pyright/pyright-internal: src/parser/tokenizer.ts(1271,94)
- /mnt/ts_downloads/_/m/pyright/pyright-internal: src/parser/tokenizer.ts(1290,100)
- /mnt/ts_downloads/_/m/pyright/vscode-pyright: ../pyright-internal/src/parser/tokenizer.ts(1271,94)
- /mnt/ts_downloads/_/m/pyright/vscode-pyright: ../pyright-internal/src/parser/tokenizer.ts(1290,100)

url-search-params

/mnt/ts_downloads/_/m/url-search-params/tsconfig.json

[MISSING] error TS2629: Cannot assign to 'URLSearchParams' because it is a class.
- /mnt/ts_downloads/_/m/url-search-params/node_modules/url-search-params/build/url-search-params.node.js(174,1)

TypeScript Bot (typescript-bot) · 2024-04-23T19:08:25Z

Jake Bailey (@jakebailey) Here are the results of running the top 400 repos comparing main and refs/pull/58295/merge:

Something interesting changed - please have a look.

Details

tinacms/tinacms

11 of 24 projects failed to build with the old tsc and were ignored

packages/@tinacms/vercel-previews/tsconfig.json

error TS2307: Cannot find module 'tinacms/dist/react' or its corresponding type declarations.
- packages/@tinacms/vercel-previews/src/index.ts#L3

graphemecluster (graphemecluster) · 2024-04-23T21:34:30Z

FYI the cause of the CI error was modified here:
https://github.com/microsoft/TypeScript/pull/55600/files#diff-fd7e6ee327c7bf4e89fe266a9f7cb6cc989a6c59562cc8bec3581da1d2fe4eed

Ron Buckton (rbuckton) · 2024-04-23T22:13:20Z

In general, I think there might be a happy medium between general specification strictness and Annex B looseness. For example, we probably want to treat \1, \2, etc., as an error when they are either higher than the number of capturing left parens or are used in a character class as they are ambiguous. It's likely that the user expected \2 to be treated as a backreference, and most of the cases where users have written [^\2] seem to be due to a misunderstanding about how character classes work. Erroring in these cases makes sense as it would point out the misuse.

Cases like [\w-_], where a minus (-) appears in a character class before or after a character class escape like \w or \d, are usually the result of a user conflating - as a potential character to match vs - to denote a range. Annex B would treat [\w-_] the same as [-\w_], so there's no ambiguity with that syntax. The only ambiguity here would be one that strict checking wouldn't catch, such as [a-_] where the user may have intended to use - as a character to match against rather than a range. There may be value in reporting an error for the [\w-_] case to make users take more notice of the [a-_] case, but that's not going to be a reliable check.

Most of the other Annex B checks we may want to just leave out in favor of stricter parsing as they generally indicate invalid syntax that you're less likely to actually come across in practice.

The upside of doing this during the grammar check pass is that if a user really wants to use that syntax then they have the option to annotate the line with // @ts-ignore.

There are a few other things I want to explore either in this PR or another follow up PR to cut down on the number --target-specific errors, either by just treating them as suggestion diagnostics for now, or introducing a compiler flag to give the users control over reporting such errors broadly as opposed to just using // @ts-ignore to silence them on a case by case basis.

Ron Buckton (rbuckton) · 2024-04-24T19:55:55Z

I'll discuss whether we should use stricter rules than Annex B in the next Design Meeting, with any changes coming in a follow-up PR.

Ron Buckton (rbuckton) · 2024-04-24T19:56:33Z

TypeScript Bot (@typescript-bot) perf test
TypeScript Bot (@typescript-bot) run dt

TypeScript Bot (typescript-bot) · 2024-04-24T19:56:37Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test`	✅ Started	👀 Results
`run dt`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-04-24T20:16:35Z

Hey Ron Buckton (@rbuckton), the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: codemirror
Error:

Error: Debug Failure. False expression.
Occurred while linting /mnt/vss/_work/1/DefinitelyTyped/types/codemirror/test/addon/mode/simple.ts:1
Rule: "@definitelytyped/expect"
at checkGrammarRegularExpressionLiteral (/mnt/vss/_work/1/s/built/local/typescript.js:75972:13)
at checkRegularExpressionLiteral (/mnt/vss/_work/1/s/built/local/typescript.js:75982:5)
at checkExpressionWorker (/mnt/vss/_work/1/s/built/local/typescript.js:82919:16)
at checkExpression (/mnt/vss/_work/1/s/built/local/typescript.js:82845:32)
at checkExpressionForMutableLocation (/mnt/vss/_work/1/s/built/local/typescript.js:82603:18)
at checkPropertyAssignment (/mnt/vss/_work/1/s/built/local/typescript.js:82619:12)
at checkObjectLiteral (/mnt/vss/_work/1/s/built/local/typescript.js:76200:71)
at checkExpressionWorker (/mnt/vss/_work/1/s/built/local/typescript.js:82923:16)
at checkExpression (/mnt/vss/_work/1/s/built/local/typescript.js:82845:32)
at checkExpressionForMutableLocation (/mnt/vss/_work/1/s/built/local/typescript.js:82603:18)

You can check the log here.

Jake Bailey (jakebailey) · 2024-04-24T20:20:00Z

Hm, crash on the DT code, it looks. Definitely relevant.

TypeScript Bot (typescript-bot) · 2024-04-24T20:33:31Z

Ron Buckton (@rbuckton)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,273	_50,273	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,705k (± 0.74%)}	_{193,991k (± 0.97%)}	_~	_192,104k	_195,808k	_{p=0.128 n=6}
_{Parse Time}	_{1.64s (± 0.94%)}	_{1.65s (± 0.77%)}	_~	_1.64s	_1.67s	_{p=0.328 n=6}
_{Bind Time}	_{0.87s (± 1.13%)}	_{0.87s (± 0.60%)}	_~	_0.86s	_0.87s	_{p=0.931 n=6}
_{Check Time}	_{11.35s (± 0.14%)}	_{11.34s (± 0.48%)}	_~	_11.26s	_11.41s	_{p=0.630 n=6}
_{Emit Time}	_{3.15s (± 0.52%)}	_{3.14s (± 0.73%)}	_~	_3.10s	_3.17s	_{p=0.870 n=6}
_{Total Time}	_{17.01s (± 0.12%)}	_{16.99s (± 0.36%)}	_~	_16.92s	_17.06s	_{p=0.686 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Symbols	_945,172	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Types	_408,068	₀	_~	_~	_~	_{p=1.000 n=6+0}
_{Memory used}	_{1,221,853k (± 0.01%)}	_0k	_~	_~	_~	_{p=1.000 n=6+0}
_{Parse Time}	_{8.29s (± 0.28%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Bind Time}	_{2.23s (± 0.47%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Check Time}	_{36.34s (± 0.52%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Emit Time}	_{17.39s (± 0.85%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Total Time}	_{64.24s (± 0.34%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Symbols	_1,954,598	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Types	_676,387	₀	_~	_~	_~	_{p=1.000 n=6+0}
_{Memory used}	_{1,753,234k (± 0.00%)}	_0k	_~	_~	_~	_{p=1.000 n=6+0}
_{Parse Time}	_{10.04s (± 0.66%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Bind Time}	_{3.29s (± 5.84%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Check Time}	_{82.04s (± 0.33%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Emit Time}	_0.20s	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Total Time}	_{95.57s (± 0.44%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,215,031	_1,215,064	_{+33 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_257,343	_257,352	_{+9 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,322,975k (± 0.05%)}	_{2,322,813k (± 0.04%)}	_~	_2,322,132k	_2,324,351k	_{p=0.471 n=6}
_{Parse Time}	_{7.58s (± 0.59%)}	_{7.50s (± 0.71%)}	_{-0.07s (- 0.95%)}	_7.44s	_7.59s	_{p=0.031 n=6}
_{Bind Time}	_{2.73s (± 0.43%)}	_{2.73s (± 0.64%)}	_~	_2.70s	_2.75s	_{p=0.683 n=6}
_{Check Time}	_{49.53s (± 0.79%)}	_{49.47s (± 0.49%)}	_~	_49.19s	_49.79s	_{p=0.936 n=6}
_{Emit Time}	_{4.04s (± 2.22%)}	_{4.11s (± 2.03%)}	_~	_3.96s	_4.20s	_{p=0.230 n=6}
_{Total Time}	_{63.90s (± 0.66%)}	_{63.82s (± 0.35%)}	_~	_63.57s	_64.14s	_{p=0.575 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,215,031	_1,215,064	_{+33 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_257,343	_257,352	_{+9 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,398,236k (± 0.04%)}	_{2,397,698k (± 0.03%)}	_~	_2,396,914k	_2,398,915k	_{p=0.298 n=6}
_{Parse Time}	_{7.84s (± 0.82%)}	_{7.82s (± 0.81%)}	_~	_7.73s	_7.88s	_{p=0.630 n=6}
_{Bind Time}	_{2.45s (± 0.66%)}	_{2.45s (± 0.95%)}	_~	_2.43s	_2.49s	_{p=0.936 n=6}
_{Check Time}	_{50.11s (± 0.32%)}	_{50.19s (± 0.37%)}	_~	_49.94s	_50.47s	_{p=0.575 n=6}
_{Emit Time}	_{3.96s (± 3.27%)}	_{3.95s (± 2.67%)}	_~	_3.83s	_4.08s	_{p=0.630 n=6}
_{Total Time}	_{64.37s (± 0.39%)}	_{64.43s (± 0.44%)}	_~	_64.19s	_64.86s	_{p=0.470 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,191	_256,213	_{+22 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_103,624	_103,633	_{+9 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{423,993k (± 0.00%)}	_{424,063k (± 0.01%)}	_{+70k (+ 0.02%)}	_424,020k	_424,097k	_{p=0.008 n=6}
_{Parse Time}	_{4.33s (± 0.68%)}	_{4.35s (± 0.72%)}	_~	_4.30s	_4.39s	_{p=0.625 n=6}
_{Bind Time}	_{1.60s (± 0.97%)}	_{1.59s (± 1.38%)}	_~	_1.56s	_1.62s	_{p=0.276 n=6}
_{Check Time}	_{22.44s (± 0.34%)}	_{22.40s (± 0.23%)}	_~	_22.30s	_22.44s	_{p=0.687 n=6}
_{Emit Time}	_{1.75s (± 1.67%)}	_{1.76s (± 1.31%)}	_~	_1.73s	_1.80s	_{p=0.374 n=6}
_{Total Time}	_{30.12s (± 0.31%)}	_{30.09s (± 0.24%)}	_~	_29.99s	_30.17s	_{p=0.687 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,824	_224,824	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,390	_93,390	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,292k (± 0.02%)}	_{369,290k (± 0.02%)}	_~	_369,197k	_369,399k	_{p=1.000 n=6}
_{Parse Time}	_{2.96s (± 0.75%)}	_{2.95s (± 1.37%)}	_~	_2.89s	_2.99s	_{p=0.629 n=6}
_{Bind Time}	_{1.59s (± 1.34%)}	_{1.59s (± 0.65%)}	_~	_1.58s	_1.60s	_{p=0.560 n=6}
_{Check Time}	_{15.71s (± 0.26%)}	_{15.73s (± 0.26%)}	_~	_15.68s	_15.77s	_{p=0.418 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.26s (± 0.27%)}	_{20.27s (± 0.24%)}	_~	_20.22s	_20.36s	_{p=0.628 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₈	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Symbols	_2,795,223	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Types	_949,808	₀	_~	_~	_~	_{p=1.000 n=6+0}
_{Memory used}	_{2,923,552k (± 0.00%)}	_0k	_~	_~	_~	_{p=1.000 n=6+0}
_{Parse Time}	_{16.79s (± 0.76%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Bind Time}	_{5.05s (± 2.32%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Check Time}	_{88.08s (± 0.42%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Emit Time}	_{26.84s (± 8.43%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Total Time}	_{136.76s (± 1.29%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,853	_265,853	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,438	_108,438	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,229k (± 0.02%)}	_{410,204k (± 0.01%)}	_~	_410,165k	_410,276k	_{p=0.936 n=6}
_{Parse Time}	_{3.27s (± 0.53%)}	_{3.25s (± 0.82%)}	_~	_3.21s	_3.28s	_{p=0.081 n=6}
_{Bind Time}	_{1.41s (± 0.45%)}	_{1.40s (± 1.05%)}	_~	_1.37s	_1.41s	_{p=0.081 n=6}
_{Check Time}	_{14.44s (± 0.36%)}	_{14.45s (± 0.45%)}	_~	_14.38s	_14.55s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.13s (± 0.33%)}	_{19.10s (± 0.33%)}	_~	_19.03s	_19.17s	_{p=0.468 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_523,981	_523,981	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,708	_178,708	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{461,150k (± 0.01%)}	_{461,219k (± 0.02%)}	_~	_461,136k	_461,334k	_{p=0.199 n=6}
_{Parse Time}	_{2.69s (± 1.08%)}	_{2.69s (± 0.80%)}	_~	_2.66s	_2.72s	_{p=1.000 n=6}
_{Bind Time}	_0.99s	_0.99s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{15.41s (± 0.24%)}	_{15.42s (± 0.33%)}	_~	_15.36s	_15.51s	_{p=0.872 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.09s (± 0.23%)}	_{19.11s (± 0.28%)}	_~	_19.06s	_19.21s	_{p=0.374 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,831ms (± 1.09%)}	_{2,819ms (± 0.87%)}	_~	_2,789ms	_2,841ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{6,137ms (± 0.65%)}	_{6,128ms (± 0.65%)}	_~	_6,085ms	_6,199ms	_{p=0.936 n=6}
_{Req 3 - references}	_{368ms (± 9.69%)}	_{356ms (± 2.04%)}	_~	_346ms	_363ms	_{p=0.809 n=6}
_{Req 4 - navto}	_{286ms (± 6.31%)}	_{296ms (± 9.43%)}	_~	_276ms	_339ms	_{p=0.864 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{95ms (± 3.08%)}	_{108ms (± 9.92%)}	_~	_94ms	_116ms	_{p=0.060 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,497ms (± 1.85%)}	_{2,502ms (± 1.38%)}	_~	_2,474ms	_2,568ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{3,834ms (± 0.11%)}	_{3,839ms (± 0.26%)}	_~	_3,828ms	_3,849ms	_{p=0.571 n=6}
_{Req 3 - references}	_{300ms (± 0.40%)}	_{300ms (± 0.47%)}	_~	_298ms	_302ms	_{p=0.743 n=6}
_{Req 4 - navto}	_{228ms (± 0.43%)}	_{229ms (± 0.24%)}	_~	_228ms	_229ms	_{p=0.662 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{77ms (± 7.40%)}	_{79ms (± 7.70%)}	_~	_72ms	_85ms	_{p=0.360 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,195ms (± 0.31%)}	_{5,179ms (± 0.20%)}	_~	_5,167ms	_5,196ms	_{p=0.063 n=6}
_{Req 2 - geterr}	_{1,126ms (± 0.05%)}	_{1,130ms (± 0.70%)}	_~	_1,124ms	_1,145ms	_{p=0.803 n=6}
_{Req 3 - references}	_{85ms (± 1.21%)}	_{87ms (± 3.85%)}	_~	_84ms	_93ms	_{p=0.784 n=6}
_{Req 4 - navto}	_{448ms (± 0.09%)}	_{452ms (± 1.11%)}	_~	_446ms	_458ms	_{p=0.199 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{837ms (± 0.74%)}	_{853ms (± 2.68%)}	_~	_834ms	_890ms	_{p=0.172 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{157.37ms (± 0.15%)}	_{157.57ms (± 0.17%)}	_{+0.21ms (+ 0.13%)}	_156.42ms	_161.28ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{239.31ms (± 0.13%)}	_{239.39ms (± 0.14%)}	_{+0.09ms (+ 0.04%)}	_238.00ms	_244.45ms	_{p=0.009 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{235.53ms (± 0.15%)}	_{235.63ms (± 0.13%)}	_{+0.10ms (+ 0.04%)}	_234.21ms	_237.79ms	_{p=0.001 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{287.18ms (± 0.29%)}	_{286.97ms (± 0.27%)}	_{-0.21ms (- 0.07%)}	_279.74ms	_292.17ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Ron Buckton (rbuckton) · 2024-04-24T20:36:25Z

Hm, crash on the DT code, it looks. Definitely relevant.

Not source mapped, so that's less than helpful :/

Jake Bailey (jakebailey) · 2024-04-24T20:44:42Z

The assert is from:

Debug.assert(scanner.reScanSlashToken(/*reportErrors*/ true) === SyntaxKind.RegularExpressionLiteral);

In: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/codemirror/test/addon/mode/simple.ts

$ NODE_OPTIONS=--enable-source-maps pnpm dtslint --localTs ~/work/TypeScript/built/local types codemirrordtslint@0.2.20Error: Debug Failure. False expression.Occurred while linting /home/jabaile/work/DefinitelyTyped/types/codemirror/test/addon/mode/simple.ts:1Rule: "@definitelytyped/expect" at checkGrammarRegularExpressionLiteral (/home/jabaile/work/TypeScript/src/compiler/checker.ts:31382:23) at <anonymous> (/home/jabaile/work/TypeScript/src/compiler/checker.ts:31397:37) at addLazyDiagnostic (/home/jabaile/work/TypeScript/src/compiler/checker.ts:47223:35) at checkRegularExpressionLiteral (/home/jabaile/work/TypeScript/src/compiler/checker.ts:31397:13) at checkExpressionWorker (/home/jabaile/work/TypeScript/src/compiler/checker.ts:39712:24) at checkExpression (/home/jabaile/work/TypeScript/src/compiler/checker.ts:39621:36) at checkExpressionForMutableLocation (/home/jabaile/work/TypeScript/src/compiler/checker.ts:39357:22) at checkPropertyAssignment (/home/jabaile/work/TypeScript/src/compiler/checker.ts:39371:16) at checkObjectLiteral (/home/jabaile/work/TypeScript/src/compiler/checker.ts:31658:80) at checkExpressionWorker (/home/jabaile/work/TypeScript/src/compiler/checker.ts:39716:24)

Repro instructions are:

$ git clone --filter=blob:none https://github.com/DefinitelyTyped/DefinitelyTyped.git
$ cd DefinitelyTyped
$ pnpm i --filter . --filter '...{./types/codemirror}...'
$ NODE_OPTIONS=--enable-source-maps pnpm dtslint --localTs ~/work/TypeScript/built/local types codemirror

Ron Buckton (rbuckton) · 2024-04-24T20:52:13Z

The assert is from: [...]

I was able to repro it locally. I was lamenting the lack of source maps, but I should have tagged the assert with an appropriate message anyways.

The assert was overaggressive since we can also rescan /= as well. I removed it since the assert on the next line would catch any discrepancy anyways.

Ron Buckton (rbuckton) · 2024-04-24T20:52:52Z

TypeScript Bot (@typescript-bot) run dt

TypeScript Bot (typescript-bot) · 2024-04-24T20:52:54Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`run dt`	✅ Started	✅ Results

TypeScript Bot (typescript-bot) · 2024-04-24T21:12:44Z

Hey Ron Buckton (@rbuckton), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

Ron Buckton (rbuckton) · 2024-04-24T21:20:37Z

Wesley Wigham (@weswigham), Daniel Rosenwasser (@DanielRosenwasser), any other comments?

Wesley Wigham (weswigham) · 2024-04-24T21:28:59Z

+
+ function checkRegularExpressionLiteral(node: RegularExpressionLiteral) {
+ const nodeLinks = getNodeLinks(node);
+ if (!nodeLinks.grammarChecked) {


I think you can actually reuse NodeCheckFlags.TypeChecked for this, if you'd like. It's how we do similar marking for getter/setter pairs, and nodes with a checkNodeDeferred component.

Daniel Rosenwasser (DanielRosenwasser) · 2024-04-24T21:35:16Z

The assert was overaggressive since we can also rescan /= as well. I removed it since the assert on the next line would catch any discrepancy anyways.

Does that mean we have no test with /= in it?

Ron Buckton (rbuckton) · 2024-04-24T21:37:20Z

The assert was overaggressive since we can also rescan /= as well. I removed it since the assert on the next line would catch any discrepancy anyways.
Does that mean we have no test with /= in it?

Apparently not. I'll add one.

Daniel Rosenwasser (DanielRosenwasser) · 2024-04-24T21:37:58Z

Wesley Wigham (@weswigham) why does it have to be a lazy diagnostic though? Where does the order-checking impact anything else here?

Wesley Wigham (weswigham) · 2024-04-24T21:54:43Z

why does it have to be a lazy diagnostic though? Where does the order-checking impact anything else here?

It allows us to completely skip the rescan when, eg, requesting completions in the file.

Ron Buckton (rbuckton) · 2024-04-24T22:06:54Z

why does it have to be a lazy diagnostic though? Where does the order-checking impact anything else here?
It allows us to completely skip the rescan when, eg, requesting completions in the file.

We will eventually want to always perform the scan if we want to leverage information like group names or capture group counting to infer stronger types for RegExpExecArray, but it makes sense to defer it for now.

Daniel Rosenwasser (DanielRosenwasser) · 2024-04-24T23:02:09Z

Okay, I guess don't have a strong opinion about it. It does feel a little premature since ideally a scan should be fast enough, but it's no big deal for now. Are we good with merging?

Ron Buckton (rbuckton) · 2024-04-24T23:09:53Z

Okay, I guess don't have a strong opinion about it. It does feel a little premature since ideally a scan should be fast enough, but it's no big deal for now. Are we good with merging?

I'm mostly waiting on the macos tests to catch up, but they're lagging about 4hrs behind right now. Nothing in this PR should be OS dependent, so I'm fine with merging if we don't want to wait.

graphemecluster (graphemecluster) · 2024-04-25T21:53:25Z

After this PR, these lines no longer work and might happen to break something as the early exit causes the token span and value to be different depending on reportErrors, thus should be removed. (I did it in #58289)

The change is no longer necessary since it’s moved to `checker.ts` in microsoft#58295. The partially reverts microsoft@1a5228d.

Report RegExp errors in grammar check, use Annex B grammar
f105513

Ron Buckton (rbuckton) requested review from Daniel Rosenwasser (DanielRosenwasser), Ryan Cavanaugh (RyanCavanaugh), Andrew Branch (andrewbranch) and Jake Bailey (jakebailey)April 23, 2024 16:59

TypeScript Bot (typescript-bot) assigned Ron Buckton (rbuckton)Apr 23, 2024

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 23, 2024

graphemecluster (graphemecluster) reviewed Apr 23, 2024
View reviewed changes

Comment threadsrc/compiler/scanner.ts Outdated

graphemecluster (graphemecluster) reviewed Apr 23, 2024
View reviewed changes

Comment threadsrc/compiler/scanner.ts

Revert change to incremental parser test
40ea4df

Jake Bailey (jakebailey) approved these changes Apr 24, 2024
View reviewed changes

Wesley Wigham (weswigham) reviewed Apr 24, 2024
View reviewed changes

Comment threadsrc/compiler/checker.ts Outdated

Daniel Rosenwasser (DanielRosenwasser) reviewed Apr 24, 2024
View reviewed changes

Comment threadsrc/compiler/scanner.ts Outdated

Daniel Rosenwasser (DanielRosenwasser) reviewed Apr 24, 2024
View reviewed changes

Comment threadsrc/testRunner/unittests/incrementalParser.ts

Daniel Rosenwasser (DanielRosenwasser) reviewed Apr 24, 2024
View reviewed changes

Comment threadsrc/compiler/checker.ts Outdated

PR feedback
48d0a0a

Remove overaggressive assert
aa8c585

Fix format
19cb6ca

Wesley Wigham (weswigham) reviewed Apr 24, 2024
View reviewed changes

Wesley Wigham (weswigham) approved these changes Apr 24, 2024
View reviewed changes

Use NodeCheckFlags.TypeChecked
d67ab82

Add test for /=/
74d995c

Daniel Rosenwasser (DanielRosenwasser) approved these changes Apr 24, 2024
View reviewed changes

Ron Buckton (rbuckton) merged commit e28ad99 into mainApr 24, 2024

Ron Buckton (rbuckton) deleted the regexp-syntax-check-annexB branch April 24, 2024 23:16

graphemecluster (graphemecluster) mentioned this pull request Apr 25, 2024
Correct Regular Expressions Behavior Related to Annex B #58320
Merged

graphemecluster (graphemecluster) mentioned this pull request May 3, 2024
Design Meeting Notes, 4/26/2024 #58416
Closed

Raphael Lang (nostalic) mentioned this pull request May 10, 2024
Regular Expression finds #58287
Closed
1 task

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Uh oh!

Conversation

Ron Buckton (rbuckton) commented Apr 23, 2024

Uh oh!

Jake Bailey (jakebailey) commented Apr 23, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 23, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 23, 2024

/mnt/ts_downloads/_/m/azure-sdk/build.sh

/mnt/ts_downloads/_/m/pyright/build.sh

/mnt/ts_downloads/_/m/url-search-params/tsconfig.json

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 23, 2024

Uh oh!

graphemecluster (graphemecluster) commented Apr 23, 2024

Uh oh!

Uh oh!

Uh oh!

Ron Buckton (rbuckton) commented Apr 23, 2024

Uh oh!

Ron Buckton (rbuckton) commented Apr 24, 2024

Uh oh!

Ron Buckton (rbuckton) commented Apr 24, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 24, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 24, 2024

Uh oh!

Jake Bailey (jakebailey) commented Apr 24, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 24, 2024

tsc

tsserver

startup

Uh oh!

Ron Buckton (rbuckton) commented Apr 24, 2024

Uh oh!

Jake Bailey (jakebailey) commented Apr 24, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ron Buckton (rbuckton) commented Apr 24, 2024

Uh oh!

Ron Buckton (rbuckton) commented Apr 24, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 24, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 24, 2024

Uh oh!

Ron Buckton (rbuckton) commented Apr 24, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Apr 24, 2024

Uh oh!

Ron Buckton (rbuckton) commented Apr 24, 2024

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Apr 24, 2024

Uh oh!

Wesley Wigham (weswigham) commented Apr 24, 2024

Uh oh!

Ron Buckton (rbuckton) commented Apr 24, 2024

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Apr 24, 2024

Uh oh!

Ron Buckton (rbuckton) commented Apr 24, 2024

Uh oh!

graphemecluster (graphemecluster) commented Apr 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

TypeScript Bot (typescript-bot) commented Apr 23, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Apr 24, 2024•
edited
Loading

Jake Bailey (jakebailey) commented Apr 24, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Apr 24, 2024•
edited
Loading