fixed types for Object.values and Object.entries by typeholes · Pull Request #58358 · microsoft/TypeScript

typeholes · 2024-04-29T17:35:20Z

Jake Bailey (jakebailey) · 2024-04-29T17:36:04Z

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) · 2024-04-29T17:36:15Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-04-29T17:56:17Z

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-04-29T18:04:45Z

Jake Bailey (@jakebailey) Here are the results of running the user tests comparing main and refs/pull/58358/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2024-04-29T18:18:00Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,273	_50,273	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,415k (± 0.92%)}	_{194,619k (± 0.98%)}	_~	_192,137k	_196,010k	_{p=0.378 n=6}
_{Parse Time}	_{1.34s (± 1.38%)}	_{1.35s (± 0.30%)}	_~	_1.35s	_1.36s	_{p=0.787 n=6}
_{Bind Time}	_{0.72s (± 0.57%)}	_0.72s	_~	_~	_~	_{p=0.405 n=6}
_{Check Time}	_{9.58s (± 0.32%)}	_{9.62s (± 0.30%)}	_~	_9.57s	_9.65s	_{p=0.077 n=6}
_{Emit Time}	_{2.61s (± 0.38%)}	_{2.62s (± 0.57%)}	_~	_2.61s	_2.65s	_{p=0.209 n=6}
_{Total Time}	_{14.26s (± 0.29%)}	_{14.32s (± 0.21%)}	_{+0.06s (+ 0.42%)}	_14.26s	_14.34s	_{p=0.024 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,172	_945,416	_{+244 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_Types	_408,068	_407,894	_{-174 (- 0.04%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,221,990k (± 0.00%)}	_{1,222,117k (± 0.00%)}	_{+127k (+ 0.01%)}	_1,222,053k	_1,222,171k	_{p=0.008 n=6}
_{Parse Time}	_{8.23s (± 0.76%)}	_{8.22s (± 0.51%)}	_~	_8.15s	_8.28s	_{p=0.936 n=6}
_{Bind Time}	_{2.24s (± 0.75%)}	_{2.24s (± 0.59%)}	_~	_2.22s	_2.25s	_{p=0.933 n=6}
_{Check Time}	_{36.68s (± 0.30%)}	_{36.63s (± 0.31%)}	_~	_36.48s	_36.74s	_{p=0.471 n=6}
_{Emit Time}	_{17.43s (± 0.34%)}	_{17.44s (± 0.45%)}	_~	_17.34s	_17.55s	_{p=1.000 n=6}
_{Total Time}	_{64.57s (± 0.24%)}	_{64.53s (± 0.32%)}	_~	_64.27s	_64.80s	_{p=0.689 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,955,870	_1,955,915	_{+45 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_676,290	_676,279	_{-11 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,754,518k (± 0.00%)}	_{1,754,514k (± 0.00%)}	_~	_1,754,420k	_1,754,558k	_{p=1.000 n=6}
_{Parse Time}	_{8.11s (± 0.40%)}	_{8.09s (± 0.34%)}	_~	_8.04s	_8.12s	_{p=0.329 n=6}
_{Bind Time}	_{2.72s (± 0.49%)}	_{2.73s (± 0.55%)}	_~	_2.72s	_2.76s	_{p=0.249 n=6}
_{Check Time}	_{67.07s (± 0.42%)}	_{67.24s (± 0.37%)}	_~	_66.97s	_67.56s	_{p=0.297 n=6}
_{Emit Time}	_{0.16s (± 4.99%)}	_{0.17s (± 6.19%)}	_~	_0.16s	_0.18s	_{p=0.595 n=6}
_{Total Time}	_{78.07s (± 0.38%)}	_{78.23s (± 0.31%)}	_~	_77.98s	_78.57s	_{p=0.336 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,215,669	_1,216,532	_{+863 (+ 0.07%)}	_~	_~	_{p=0.001 n=6}
_Types	_257,620	_257,489	_{-131 (- 0.05%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,323,692k (± 0.02%)}	_{2,382,197k (± 6.00%)}	_~	_2,322,934k	_2,674,296k	_{p=0.936 n=6}
_{Parse Time}	_{7.62s (± 0.64%)}	_{7.56s (± 0.60%)}	_~	_7.49s	_7.63s	_{p=0.054 n=6}
_{Bind Time}	_{2.75s (± 0.88%)}	_{2.75s (± 0.38%)}	_~	_2.73s	_2.76s	_{p=0.293 n=6}
_{Check Time}	_{49.51s (± 0.64%)}	_{49.00s (± 0.84%)}	_{-0.52s (- 1.04%)}	_48.42s	_49.45s	_{p=0.045 n=6}
_{Emit Time}	_{3.92s (± 0.50%)}	_{3.84s (± 2.14%)}	_{-0.08s (- 2.04%)}	_3.72s	_3.94s	_{p=0.045 n=6}
_{Total Time}	_{63.80s (± 0.55%)}	_{63.14s (± 0.67%)}	_{-0.66s (- 1.04%)}	_62.65s	_63.65s	_{p=0.020 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,215,669	_1,216,532	_{+863 (+ 0.07%)}	_~	_~	_{p=0.001 n=6}
_Types	_257,620	_257,489	_{-131 (- 0.05%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,397,921k (± 0.01%)}	_{2,398,508k (± 0.01%)}	_{+588k (+ 0.02%)}	_2,398,055k	_2,398,833k	_{p=0.020 n=6}
_{Parse Time}	_{6.34s (± 0.30%)}	_{6.34s (± 0.19%)}	_~	_6.32s	_6.35s	_{p=1.000 n=6}
_{Bind Time}	_{2.01s (± 0.68%)}	_{2.02s (± 0.94%)}	_~	_2.00s	_2.04s	_{p=0.218 n=6}
_{Check Time}	_{40.55s (± 0.18%)}	_{40.06s (± 0.25%)}	_{-0.49s (- 1.22%)}	_39.95s	_40.24s	_{p=0.005 n=6}
_{Emit Time}	_{3.13s (± 0.89%)}	_{3.13s (± 1.30%)}	_~	_3.10s	_3.21s	_{p=0.810 n=6}
_{Total Time}	_{52.03s (± 0.14%)}	_{51.56s (± 0.18%)}	_{-0.47s (- 0.91%)}	_51.47s	_51.73s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,176	_256,241	_{+65 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_Types	_103,637	_103,527	_{-110 (- 0.11%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{424,282k (± 0.01%)}	_{424,309k (± 0.01%)}	_~	_424,264k	_424,334k	_{p=0.149 n=6}
_{Parse Time}	_{3.50s (± 0.72%)}	_{3.49s (± 1.15%)}	_~	_3.42s	_3.52s	_{p=0.871 n=6}
_{Bind Time}	_{1.30s (± 1.26%)}	_{1.30s (± 1.02%)}	_~	_1.28s	_1.32s	_{p=0.615 n=6}
_{Check Time}	_{18.29s (± 0.19%)}	_{17.78s (± 0.39%)}	_{-0.51s (- 2.79%)}	_17.70s	_17.86s	_{p=0.005 n=6}
_{Emit Time}	_{1.36s (± 2.00%)}	_{1.38s (± 2.22%)}	_~	_1.34s	_1.42s	_{p=0.468 n=6}
_{Total Time}	_{24.46s (± 0.17%)}	_{23.95s (± 0.43%)}	_{-0.51s (- 2.09%)}	_23.79s	_24.07s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,824	_224,845	_{+21 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_93,390	_93,394	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{369,312k (± 0.01%)}	_{369,346k (± 0.01%)}	_~	_369,304k	_369,388k	_{p=0.066 n=6}
_{Parse Time}	_{3.67s (± 0.30%)}	_{3.66s (± 0.61%)}	_~	_3.63s	_3.68s	_{p=0.365 n=6}
_{Bind Time}	_{1.93s (± 1.17%)}	_{1.93s (± 0.76%)}	_~	_1.91s	_1.95s	_{p=0.935 n=6}
_{Check Time}	_{19.41s (± 0.32%)}	_{19.40s (± 0.18%)}	_~	_19.36s	_19.45s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.02s (± 0.26%)}	_{24.99s (± 0.12%)}	_~	_24.95s	_25.03s	_{p=0.808 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,798,852	_2,798,955	_{+103 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_950,749	_950,678	_{-71 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,926,479k (± 0.00%)}	_{2,926,449k (± 0.00%)}	_~	_2,926,343k	_2,926,701k	_{p=0.378 n=6}
_{Parse Time}	_{16.65s (± 0.41%)}	_{16.68s (± 0.48%)}	_~	_16.53s	_16.75s	_{p=0.575 n=6}
_{Bind Time}	_{4.97s (± 0.45%)}	_{5.05s (± 1.91%)}	_{+0.08s (+ 1.58%)}	_4.98s	_5.24s	_{p=0.015 n=6}
_{Check Time}	_{88.91s (± 0.49%)}	_{88.92s (± 0.34%)}	_~	_88.40s	_89.21s	_{p=0.810 n=6}
_{Emit Time}	_{26.22s (± 9.58%)}	_{26.95s (± 8.80%)}	_~	_23.83s	_28.62s	_{p=1.000 n=6}
_{Total Time}	_{136.75s (± 1.93%)}	_{137.61s (± 1.67%)}	_~	_134.46s	_139.26s	_{p=0.873 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,853	_265,957	_{+104 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_Types	_108,438	_108,476	_{+38 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{410,404k (± 0.02%)}	_{410,561k (± 0.02%)}	_{+157k (+ 0.04%)}	_410,448k	_410,667k	_{p=0.013 n=6}
_{Parse Time}	_{4.87s (± 0.49%)}	_{4.88s (± 0.46%)}	_~	_4.85s	_4.91s	_{p=0.415 n=6}
_{Bind Time}	_{2.07s (± 1.04%)}	_{2.07s (± 0.79%)}	_~	_2.04s	_2.09s	_{p=0.869 n=6}
_{Check Time}	_{21.12s (± 0.21%)}	_{21.09s (± 0.24%)}	_~	_21.00s	_21.13s	_{p=0.170 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.07s (± 0.29%)}	_{28.03s (± 0.21%)}	_~	_27.96s	_28.09s	_{p=0.630 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_523,981	_524,002	_{+21 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_178,708	_178,702	_{-6 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{461,255k (± 0.01%)}	_{461,299k (± 0.02%)}	_~	_461,223k	_461,396k	_{p=0.575 n=6}
_{Parse Time}	_{2.70s (± 0.68%)}	_{2.69s (± 0.45%)}	_~	_2.67s	_2.70s	_{p=0.162 n=6}
_{Bind Time}	_0.98s	_{0.98s (± 0.64%)}	_~	_0.97s	_0.99s	_{p=1.000 n=6}
_{Check Time}	_{15.50s (± 0.12%)}	_{15.45s (± 0.77%)}	_~	_15.21s	_15.53s	_{p=0.627 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.18s (± 0.14%)}	_{19.12s (± 0.62%)}	_~	_18.88s	_19.19s	_{p=0.294 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-04-29T19:32:17Z

Jake Bailey (@jakebailey) Here are the results of running the top 400 repos comparing main and refs/pull/58358/merge:

Everything looks good!

typeholes · 2024-04-30T15:44:18Z

Once #58372 🙂 lands the overload should probably be replaced by a simple union.

typeholes · 2024-04-30T17:35:43Z

fixes #58376

Emanuel Hoogeveen (ehoogeveen-medweb) · 2024-04-30T17:43:02Z

Does this also need some sort of handling for objects with symbol type keys? Properties with such keys won't be returned, but Object.values() and Object.entries() should still accept such objects.

typeholes · 2024-04-30T18:51:17Z

Does this also need some sort of handling for objects with symbol type keys? Properties with such keys won't be returned, but Object.values() and Object.entries() should still accept such objects.

There is already an overload for values and entries, so they will be accepted.
for example, values(o: {}): any[]; Of course the any[] return type is not ideal, but I'm not sure anything else is workable for the fallback.

Emanuel Hoogeveen (ehoogeveen-medweb) · 2024-04-30T19:53:02Z

Thanks, I didn't look beyond the context of the diff :)

Locally I use something like this:

typeKeyToString<Kextendsnumber|string|symbol>=Kextendsstring ? K : Kextendsnumber ? `${K}` : never;keys<Kextendsnumber|string|symbol,V>(o: Record<K,V>): KeyToString<K>[];entries<Kextendsnumber|string|symbol,V>(o: Record<K,V>): [KeyToString<K>,V][];values<Kextendsnumber|string|symbol,V>(o: Record<K,V>): V[];

but aside from being too complex for the standard library, that probably opens up a whole can of worms if applied to everything (works well for my code though!).

fixed types for Object.values and Object.entries
99acf3a

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 29, 2024

corrected baselines
e27cff8

added strictNullChecks to new test
5f94c11

typeholes marked this pull request as ready for review April 30, 2024 14:58

typeholes mentioned this pull request May 3, 2024
Unnecessary any returned from Object.values and Object.entries #58376
Closed

typeholes closed this Jun 13, 2024

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Navigation Menu

Uh oh!

fixed types for Object.values and Object.entries - #58358

fixed types for Object.values and Object.entries#58358
typeholes wants to merge 3 commits into
microsoft:mainfrom
typeholes:fix26010

typeholes commented Apr 29, 2024

Uh oh!

Jake Bailey (jakebailey) commented Apr 29, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 29, 2024•
edited
Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 29, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 29, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 29, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 29, 2024

Uh oh!

typeholes commented Apr 30, 2024

Uh oh!

typeholes commented Apr 30, 2024

Uh oh!

Emanuel Hoogeveen (ehoogeveen-medweb) commented Apr 30, 2024•
edited
Loading

Uh oh!

typeholes commented Apr 30, 2024

Uh oh!

Emanuel Hoogeveen (ehoogeveen-medweb) commented Apr 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

typeholes commented Apr 29, 2024

Uh oh!

Jake Bailey (jakebailey) commented Apr 29, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 29, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 29, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 29, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 29, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 29, 2024

Uh oh!

typeholes commented Apr 30, 2024

Uh oh!

typeholes commented Apr 30, 2024

Uh oh!

Emanuel Hoogeveen (ehoogeveen-medweb) commented Apr 30, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typeholes commented Apr 30, 2024

Uh oh!

Emanuel Hoogeveen (ehoogeveen-medweb) commented Apr 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TypeScript Bot (typescript-bot) commented Apr 29, 2024•
edited
Loading

Emanuel Hoogeveen (ehoogeveen-medweb) commented Apr 30, 2024•
edited
Loading