Fixed a regression with reporting unused parameters in potential predicates by Andarist · Pull Request #58514 · microsoft/TypeScript

Mateusz Burzyński (Andarist) · 2024-05-13T08:00:45Z

…icates

Jake Bailey (jakebailey) · 2024-05-13T21:37:20Z

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) · 2024-05-13T21:37:22Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-05-13T22:08:09Z

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-05-13T22:13:22Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,248	_50,248	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,058k (± 1.03%)}	_{193,425k (± 0.99%)}	_~	_192,164k	_195,959k	_{p=0.173 n=6}
_{Parse Time}	_{1.30s (± 0.69%)}	_{1.30s (± 1.57%)}	_~	_1.27s	_1.32s	_{p=1.000 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.55s (± 0.34%)}	_{9.54s (± 0.38%)}	_~	_9.48s	_9.58s	_{p=0.627 n=6}
_{Emit Time}	_{2.65s (± 0.44%)}	_{2.64s (± 1.01%)}	_~	_2.59s	_2.66s	_{p=0.236 n=6}
_{Total Time}	_{14.22s (± 0.22%)}	_{14.19s (± 0.36%)}	_~	_14.13s	_14.26s	_{p=0.377 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,110	_944,110	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,140	_407,140	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,106k (± 0.00%)}	_{1,222,086k (± 0.01%)}	_~	_1,222,021k	_1,222,196k	_{p=0.471 n=6}
_{Parse Time}	_{6.77s (± 0.59%)}	_{6.78s (± 0.62%)}	_~	_6.73s	_6.84s	_{p=1.000 n=6}
_{Bind Time}	_{1.87s (± 0.44%)}	_{1.88s (± 0.52%)}	_~	_1.87s	_1.89s	_{p=0.498 n=6}
_{Check Time}	_{31.15s (± 0.27%)}	_{31.26s (± 0.21%)}	_{+0.11s (+ 0.34%)}	_31.14s	_31.32s	_{p=0.045 n=6}
_{Emit Time}	_{14.72s (± 0.53%)}	_{14.80s (± 0.10%)}	_~	_14.78s	_14.82s	_{p=0.064 n=6}
_{Total Time}	_{54.51s (± 0.30%)}	_{54.72s (± 0.13%)}	_{+0.20s (+ 0.38%)}	_54.59s	_54.80s	_{p=0.013 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,961,349	_1,961,349	_~	_~	_~	_{p=1.000 n=6}
_Types	_696,910	_696,910	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,778,083k (± 0.00%)}	_{1,778,093k (± 0.00%)}	_~	_1,778,052k	_1,778,114k	_{p=0.575 n=6}
_{Parse Time}	_{6.77s (± 0.18%)}	_{6.78s (± 0.29%)}	_~	_6.76s	_6.81s	_{p=0.797 n=6}
_{Bind Time}	_{2.30s (± 0.65%)}	_{2.30s (± 0.53%)}	_~	_2.29s	_2.32s	_{p=1.000 n=6}
_{Check Time}	_{56.95s (± 0.37%)}	_{57.10s (± 0.31%)}	_~	_56.85s	_57.34s	_{p=0.261 n=6}
_{Emit Time}	_0.14s	_0.14s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{66.17s (± 0.32%)}	_{66.32s (± 0.27%)}	_~	_66.07s	_66.56s	_{p=0.261 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,221,120	_1,221,121	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,503	_259,503	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,336,352k (± 0.03%)}	_{2,337,014k (± 0.04%)}	_~	_2,336,098k	_2,338,264k	_{p=0.173 n=6}
_{Parse Time}	_{5.04s (± 1.54%)}	_{5.05s (± 0.38%)}	_~	_5.03s	_5.08s	_{p=0.471 n=6}
_{Bind Time}	_{1.88s (± 0.64%)}	_{1.87s (± 0.99%)}	_~	_1.85s	_1.89s	_{p=0.934 n=6}
_{Check Time}	_{33.78s (± 0.73%)}	_{33.81s (± 0.21%)}	_~	_33.73s	_33.91s	_{p=0.748 n=6}
_{Emit Time}	_{2.68s (± 3.44%)}	_{2.63s (± 1.61%)}	_~	_2.57s	_2.69s	_{p=0.128 n=6}
_{Total Time}	_{43.41s (± 0.41%)}	_{43.38s (± 0.26%)}	_~	_43.25s	_43.56s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,221,120	_1,221,121	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,503	_259,503	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,412,625k (± 0.02%)}	_{2,413,238k (± 0.03%)}	_~	_2,412,040k	_2,414,007k	_{p=0.093 n=6}
_{Parse Time}	_{6.28s (± 1.24%)}	_{6.20s (± 1.64%)}	_~	_6.01s	_6.29s	_{p=0.173 n=6}
_{Bind Time}	_{2.04s (± 0.67%)}	_{2.06s (± 0.81%)}	_{+0.02s (+ 1.15%)}	_2.04s	_2.08s	_{p=0.043 n=6}
_{Check Time}	_{40.20s (± 0.29%)}	_{40.31s (± 0.42%)}	_~	_40.08s	_40.49s	_{p=0.336 n=6}
_{Emit Time}	_{3.18s (± 2.27%)}	_{3.11s (± 2.90%)}	_~	_3.00s	_3.26s	_{p=0.173 n=6}
_{Total Time}	_{51.71s (± 0.26%)}	_{51.68s (± 0.45%)}	_~	_51.31s	_51.91s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,716	_256,717	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,580	_104,580	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{425,973k (± 0.02%)}	_{425,883k (± 0.01%)}	_~	_425,813k	_425,966k	_{p=0.093 n=6}
_{Parse Time}	_{4.17s (± 0.58%)}	_{4.16s (± 0.42%)}	_~	_4.13s	_4.18s	_{p=0.168 n=6}
_{Bind Time}	_{1.62s (± 0.50%)}	_{1.63s (± 0.85%)}	_~	_1.61s	_1.65s	_{p=0.270 n=6}
_{Check Time}	_{22.15s (± 0.49%)}	_{22.11s (± 0.15%)}	_~	_22.06s	_22.15s	_{p=1.000 n=6}
_{Emit Time}	_{1.70s (± 1.05%)}	_{1.73s (± 1.08%)}	_~	_1.71s	_1.75s	_{p=0.056 n=6}
_{Total Time}	_{29.64s (± 0.36%)}	_{29.61s (± 0.17%)}	_~	_29.54s	_29.67s	_{p=0.936 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,575	_224,575	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,785	_93,785	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,887k (± 0.02%)}	_{369,847k (± 0.04%)}	_~	_369,711k	_370,106k	_{p=0.230 n=6}
_{Parse Time}	_{2.85s (± 0.67%)}	_{2.84s (± 0.82%)}	_~	_2.81s	_2.88s	_{p=0.624 n=6}
_{Bind Time}	_{1.58s (± 1.01%)}	_{1.58s (± 0.80%)}	_~	_1.56s	_1.59s	_{p=0.869 n=6}
_{Check Time}	_{15.64s (± 0.44%)}	_{15.64s (± 0.24%)}	_~	_15.60s	_15.70s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.07s (± 0.41%)}	_{20.06s (± 0.24%)}	_~	_19.99s	_20.14s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,822,415	_2,822,415	_~	_~	_~	_{p=1.000 n=6}
_Types	_957,541	_957,541	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,994,941k (± 0.00%)}	_{2,995,024k (± 0.00%)}	_~	_2,994,981k	_2,995,122k	_{p=0.128 n=6}
_{Parse Time}	_{13.82s (± 0.19%)}	_{13.82s (± 0.13%)}	_~	_13.79s	_13.84s	_{p=0.508 n=6}
_{Bind Time}	_{4.14s (± 0.33%)}	_{4.14s (± 0.12%)}	_~	_4.14s	_4.15s	_{p=0.928 n=6}
_{Check Time}	_{73.44s (± 0.46%)}	_{73.44s (± 0.43%)}	_~	_73.06s	_74.02s	_{p=0.936 n=6}
_{Emit Time}	_{23.61s (± 0.45%)}	_{23.47s (± 0.48%)}	_~	_23.26s	_23.57s	_{p=0.078 n=6}
_{Total Time}	_{115.02s (± 0.35%)}	_{114.88s (± 0.30%)}	_~	_114.53s	_115.47s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,866	_265,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,401	_108,401	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,516k (± 0.01%)}	_{410,514k (± 0.01%)}	_~	_410,452k	_410,570k	_{p=0.748 n=6}
_{Parse Time}	_{3.84s (± 1.39%)}	_{3.83s (± 0.86%)}	_~	_3.79s	_3.87s	_{p=1.000 n=6}
_{Bind Time}	_{1.66s (± 0.59%)}	_{1.66s (± 1.04%)}	_~	_1.64s	_1.68s	_{p=0.805 n=6}
_{Check Time}	_{16.98s (± 0.32%)}	_{16.96s (± 0.32%)}	_~	_16.89s	_17.02s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.49s (± 0.38%)}	_{22.45s (± 0.36%)}	_~	_22.34s	_22.56s	_{p=0.748 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,639	_524,639	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,906	_178,906	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,675k (± 0.02%)}	_{462,662k (± 0.01%)}	_~	_462,595k	_462,744k	_{p=0.689 n=6}
_{Parse Time}	_{3.89s (± 0.46%)}	_{3.88s (± 0.36%)}	_~	_3.86s	_3.90s	_{p=0.370 n=6}
_{Bind Time}	_{1.44s (± 1.04%)}	_{1.44s (± 1.57%)}	_~	_1.42s	_1.48s	_{p=0.285 n=6}
_{Check Time}	_{22.53s (± 0.33%)}	_{22.57s (± 0.54%)}	_~	_22.36s	_22.72s	_{p=0.377 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.87s (± 0.26%)}	_{27.89s (± 0.38%)}	_~	_27.74s	_28.06s	_{p=0.810 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-05-13T22:14:54Z

Jake Bailey (@jakebailey) Here are the results of running the user tests comparing main and refs/pull/58514/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2024-05-13T23:24:19Z

Jake Bailey (@jakebailey) Here are the results of running the top 400 repos comparing main and refs/pull/58514/merge:

Everything looks good!

Nathan Shively-Sanders (sandersn)

Dan Vanderkam (@danvk) guessed that the source of the problem was a speculative getTypeOfSymbol. But this PR fixes resolution for all parameters. If it applies to all parameters, why wasn't this observed before Dan's change?

Need tests of used/unused binding patterns. These probably exist already, but please double-check.
If this implementation is correct, I think it would be easier to read in isSelfReferenceLocation, as long as that doesn't make performance worse (from adding a second parameter).

Edit: having looked at checkIfExpressionRefinesAnyParameter, Dan's specific guess doesn't make sense to me. My (fuzzier) guess is that we haven't tried to resolve a parameter name from itself before and never observed that it mistakenly caused the parameter to be marked as used. But I'm not sure what in the new code is causing that.

Nathan Shively-Sanders (sandersn) · 2024-05-17T21:27:41Z

 break;
- case SyntaxKind.Parameter:
+ case SyntaxKind.Parameter: {
+ const param = location as ParameterDeclaration;


style question: is there a reason for all the casts in this code? Maybe it's better to drop this alias and use location as ParameterDeclaration) everywhere.

No specific reason, I just prefer to have a single cast than multiple ones that are the same for the same variable. I can change this if you prefer the other style.

Nathan Shively-Sanders (sandersn) · 2024-05-17T21:38:25Z

+ case SyntaxKind.Parameter: {
+ const param = location as ParameterDeclaration;
+ if (lastLocation === param.name) {
+ lastSelfReferenceLocation = param;


I'd almost prefer a new parameter and entry in isSelfReferenceLocation like
functionisSelfReferenceLocation(node: Node,lastLocation: Node): node is SelfReferenceLocation{switch(node.kind){caseSyntaxKind.Parameter: returnlastLocation===(nodeasParameterDeclaration).name// ...

I just pushed out the suggested change

Nathan Shively-Sanders (sandersn) · 2024-05-17T21:45:44Z

- case SyntaxKind.Parameter:
+ case SyntaxKind.Parameter: {
+ const param = location as ParameterDeclaration;
+ if (lastLocation === param.name) {


what does this do when param.name is a BindingPattern? Do we have tests to make sure that they still correctly get marked unused (and used when used)?

yeah, there are tests for that already and the changes to checkIfExpressionRefinesAnyParameter that introduced this bug don't affect binding patterns

Mateusz Burzyński (Andarist) · 2024-06-10T07:51:02Z

My (fuzzier) guess is that we haven't tried to resolve a parameter name from itself before and never observed that it mistakenly caused the parameter to be marked as used.

This is correct.

But I'm not sure what in the new code is causing that.

It's checkIfExpressionRefinesParameter through the getFlowTypeOfReference. It leads to narrowTypeByCallExpression and thus to isMatchingReference and getResolvedSymbol that calls resolveName. It's this newly introduced "fake" control flow that changed this. By fake, I mean it's not created by the binder.

…icate

Jake Bailey (jakebailey) · 2024-06-10T17:28:43Z

TypeScript Bot (@typescript-bot) test it
TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2024-06-10T17:28:46Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results
`pack this`	✅ Started	✅ Results

TypeScript Bot (typescript-bot) · 2024-06-10T17:30:51Z

Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/162149/artifacts?artifactName=tgz&fileId=86D11D5A48715012B573506CBDBDE84042DDBF22442164A7053BEC2F662E26FF02&fileName=/typescript-5.6.0-insiders.20240610.tgz"
}
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.6.0-pr-58514-9".;

TypeScript Bot (typescript-bot) · 2024-06-10T17:56:29Z

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-06-10T17:57:03Z

Jake Bailey (@jakebailey) Here are the results of running the user tests with tsc comparing main and refs/pull/58514/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2024-06-10T18:21:02Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,964k (± 0.78%)}	_{193,521k (± 0.93%)}	_~	_192,323k	_195,877k	_{p=0.471 n=6}
_{Parse Time}	_{1.95s (± 1.12%)}	_{1.95s (± 0.46%)}	_~	_1.94s	_1.96s	_{p=0.557 n=6}
_{Bind Time}	_{1.07s (± 1.24%)}	_{1.07s (± 0.97%)}	_~	_1.05s	_1.08s	_{p=0.804 n=6}
_{Check Time}	_{14.04s (± 0.38%)}	_{14.02s (± 0.37%)}	_~	_13.96s	_14.08s	_{p=0.377 n=6}
_{Emit Time}	_{4.05s (± 1.21%)}	_{4.02s (± 1.04%)}	_~	_3.96s	_4.07s	_{p=0.226 n=6}
_{Total Time}	_{21.11s (± 0.48%)}	_{21.05s (± 0.27%)}	_~	_20.96s	_21.14s	_{p=0.628 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,109	_944,109	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,049	_407,049	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,168k (± 0.00%)}	_{1,222,184k (± 0.01%)}	_~	_1,222,074k	_1,222,260k	_{p=0.575 n=6}
_{Parse Time}	_{8.11s (± 0.55%)}	_{8.11s (± 0.37%)}	_~	_8.08s	_8.16s	_{p=0.747 n=6}
_{Bind Time}	_{2.24s (± 0.82%)}	_{2.23s (± 0.59%)}	_~	_2.21s	_2.25s	_{p=0.372 n=6}
_{Check Time}	_{36.65s (± 0.39%)}	_{36.49s (± 0.26%)}	_~	_36.33s	_36.61s	_{p=0.054 n=6}
_{Emit Time}	_{18.11s (± 0.71%)}	_{18.07s (± 0.35%)}	_~	_17.99s	_18.14s	_{p=0.810 n=6}
_{Total Time}	_{65.11s (± 0.25%)}	_{64.90s (± 0.21%)}	_~	_64.66s	_65.06s	_{p=0.093 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,061,575	_2,061,575	_~	_~	_~	_{p=1.000 n=6}
_Types	_905,189	_905,189	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,072,041k (± 0.01%)}	_{2,072,012k (± 0.01%)}	_~	_2,071,830k	_2,072,127k	_{p=0.873 n=6}
_{Parse Time}	_{10.00s (± 0.57%)}	_{9.98s (± 0.23%)}	_~	_9.94s	_10.01s	_{p=0.257 n=6}
_{Bind Time}	_{3.38s (± 1.22%)}	_{3.39s (± 0.85%)}	_~	_3.35s	_3.42s	_{p=0.686 n=6}
_{Check Time}	_{100.70s (± 1.29%)}	_{100.75s (± 1.15%)}	_~	_98.43s	_101.62s	_{p=0.936 n=6}
_{Emit Time}	_{0.20s (± 3.73%)}	_{0.20s (± 2.54%)}	_~	_0.20s	_0.21s	_{p=0.784 n=6}
_{Total Time}	_{114.27s (± 1.09%)}	_{114.31s (± 0.99%)}	_~	_112.08s	_115.22s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,424	_1,230,425	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,178	_261,178	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,351,286k (± 0.05%)}	_{2,351,511k (± 0.03%)}	_~	_2,350,104k	_2,352,279k	_{p=0.936 n=6}
_{Parse Time}	_{4.97s (± 0.74%)}	_{4.99s (± 1.19%)}	_~	_4.92s	_5.10s	_{p=0.575 n=6}
_{Bind Time}	_{1.90s (± 0.27%)}	_{1.89s (± 0.52%)}	_{-0.02s (- 0.79%)}	_1.88s	_1.90s	_{p=0.020 n=6}
_{Check Time}	_{34.14s (± 0.43%)}	_{34.06s (± 0.20%)}	_~	_34.00s	_34.19s	_{p=0.297 n=6}
_{Emit Time}	_{2.67s (± 2.32%)}	_{2.63s (± 1.66%)}	_~	_2.58s	_2.68s	_{p=0.470 n=6}
_{Total Time}	_{43.70s (± 0.34%)}	_{43.60s (± 0.25%)}	_~	_43.50s	_43.80s	_{p=0.128 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,424	_1,230,425	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,178	_261,178	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,504,148k (± 3.31%)}	_{2,479,398k (± 3.16%)}	_~	_2,428,391k	_2,581,177k	_{p=0.936 n=6}
_{Parse Time}	_{6.24s (± 0.88%)}	_{6.23s (± 0.87%)}	_~	_6.15s	_6.30s	_{p=0.688 n=6}
_{Bind Time}	_{2.02s (± 0.41%)}	_{2.01s (± 0.99%)}	_~	_1.98s	_2.04s	_{p=0.625 n=6}
_{Check Time}	_{40.62s (± 0.25%)}	_{40.64s (± 0.40%)}	_~	_40.47s	_40.92s	_{p=0.936 n=6}
_{Emit Time}	_{3.10s (± 1.97%)}	_{3.09s (± 2.55%)}	_~	_3.01s	_3.22s	_{p=0.518 n=6}
_{Total Time}	_{51.99s (± 0.29%)}	_{51.98s (± 0.44%)}	_~	_51.70s	_52.27s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,181	_259,182	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,173	_105,173	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,879k (± 0.02%)}	_{428,883k (± 0.01%)}	_~	_428,831k	_428,950k	_{p=0.471 n=6}
_{Parse Time}	_{4.08s (± 0.48%)}	_{4.07s (± 0.48%)}	_~	_4.05s	_4.10s	_{p=0.806 n=6}
_{Bind Time}	_{1.63s (± 1.38%)}	_{1.65s (± 0.49%)}	_~	_1.64s	_1.66s	_{p=0.142 n=6}
_{Check Time}	_{22.42s (± 0.28%)}	_{22.36s (± 0.24%)}	_~	_22.30s	_22.42s	_{p=0.108 n=6}
_{Emit Time}	_{1.73s (± 1.29%)}	_{1.73s (± 1.84%)}	_~	_1.70s	_1.79s	_{p=1.000 n=6}
_{Total Time}	_{29.87s (± 0.28%)}	_{29.81s (± 0.29%)}	_~	_29.72s	_29.95s	_{p=0.297 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,725k (± 0.02%)}	_{369,729k (± 0.02%)}	_~	_369,692k	_369,839k	_{p=1.000 n=6}
_{Parse Time}	_{2.80s (± 0.84%)}	_{2.80s (± 0.76%)}	_~	_2.77s	_2.82s	_{p=1.000 n=6}
_{Bind Time}	_{1.59s (± 1.05%)}	_{1.57s (± 0.53%)}	_~	_1.57s	_1.59s	_{p=0.122 n=6}
_{Check Time}	_{15.69s (± 0.19%)}	_{15.65s (± 0.14%)}	_{-0.04s (- 0.29%)}	_15.62s	_15.68s	_{p=0.023 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.07s (± 0.22%)}	_{20.02s (± 0.12%)}	_{-0.05s (- 0.27%)}	_19.98s	_20.05s	_{p=0.045 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,852,851	_2,852,851	_~	_~	_~	_{p=1.000 n=6}
_Types	_967,821	_967,821	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,024,837k (± 0.00%)}	_{3,024,806k (± 0.00%)}	_~	_3,024,738k	_3,024,900k	_{p=0.298 n=6}
_{Parse Time}	_{13.87s (± 0.42%)}	_{13.85s (± 0.17%)}	_~	_13.82s	_13.88s	_{p=0.421 n=6}
_{Bind Time}	_{4.21s (± 1.93%)}	_{4.21s (± 2.20%)}	_~	_4.13s	_4.39s	_{p=0.871 n=6}
_{Check Time}	_{75.70s (± 2.49%)}	_{74.34s (± 1.47%)}	_~	_73.42s	_76.38s	_{p=0.173 n=6}
_{Emit Time}	_{22.01s (± 7.99%)}	_{23.16s (± 4.44%)}	_~	_21.26s	_24.02s	_{p=0.230 n=6}
_{Total Time}	_{115.78s (± 0.21%)}	_{115.57s (± 0.35%)}	_~	_115.00s	_116.19s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,613	_266,613	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,648	_108,648	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,753k (± 0.02%)}	_{411,812k (± 0.02%)}	_~	_411,678k	_411,926k	_{p=0.378 n=6}
_{Parse Time}	_{4.76s (± 0.91%)}	_{4.76s (± 0.61%)}	_~	_4.73s	_4.80s	_{p=0.871 n=6}
_{Bind Time}	_{2.06s (± 1.18%)}	_{2.06s (± 1.17%)}	_~	_2.02s	_2.09s	_{p=0.462 n=6}
_{Check Time}	_{21.11s (± 0.30%)}	_{21.13s (± 0.53%)}	_~	_20.97s	_21.24s	_{p=0.688 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.93s (± 0.37%)}	_{27.95s (± 0.42%)}	_~	_27.80s	_28.08s	_{p=0.630 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_526,436	_526,436	_~	_~	_~	_{p=1.000 n=6}
_Types	_179,425	_179,425	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{464,301k (± 0.02%)}	_{464,180k (± 0.07%)}	_~	_463,540k	_464,434k	_{p=0.810 n=6}
_{Parse Time}	_{2.64s (± 0.62%)}	_{2.63s (± 0.24%)}	_~	_2.62s	_2.64s	_{p=0.615 n=6}
_{Bind Time}	_{0.99s (± 0.76%)}	_{0.99s (± 0.52%)}	_~	_0.99s	_1.00s	_{p=0.241 n=6}
_{Check Time}	_{15.27s (± 0.46%)}	_{15.23s (± 0.34%)}	_~	_15.17s	_15.30s	_{p=0.336 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.89s (± 0.38%)}	_{18.85s (± 0.27%)}	_~	_18.80s	_18.92s	_{p=0.423 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-06-10T19:24:16Z

Jake Bailey (@jakebailey) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/58514/merge:

Everything looks good!

Jake Bailey (jakebailey) · 2024-06-12T20:30:10Z

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.5

TypeScript Bot (typescript-bot) · 2024-06-12T20:30:15Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.5`	✅ Started	✅ Results

…icates (#58514)

TypeScript Bot (typescript-bot) · 2024-06-12T20:31:49Z

Hey, Jake Bailey (@jakebailey)! I've created #58841 for you.

…e-5.5 (#58841) Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

Fixed a regression with reporting unused parameters in potential pred…
27ad6f1
…icates

TypeScript Bot (typescript-bot) assigned Nathan Shively-Sanders (sandersn)May 13, 2024

TypeScript Bot (typescript-bot) added the For Milestone Bug PRs that fix a bug with a specific milestone label May 13, 2024

Dan Vanderkam (danvk) mentioned this pull request May 15, 2024
Infer AssertsIdentifier type predicates #58495
Closed

Nathan Shively-Sanders (sandersn) requested changes May 17, 2024
View reviewed changes

Merge remote-tracking branch 'origin/main' into unused-locals-in-pred…
2046dce
…icate

Mateusz Burzyński (Andarist) requested a review from Nathan Shively-Sanders (sandersn)June 10, 2024 08:15

address PR feedback
3d0b2b8

Mateusz Burzyński (Andarist)force-pushed the unused-locals-in-predicate branch from 0dcf1c2 to 3d0b2b8Compare June 10, 2024 09:48

Jake Bailey (jakebailey) reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/compiler/utilities.ts Outdated

Mateusz Burzyński (Andarist) commented Jun 10, 2024
View reviewed changes

Comment threadsrc/compiler/utilities.ts Outdated

remove leftover formatting change
0846b36

Jake Bailey (jakebailey) approved these changes Jun 12, 2024
View reviewed changes

Nathan Shively-Sanders (sandersn) approved these changes Jun 12, 2024
View reviewed changes

Jake Bailey (jakebailey) merged commit 359646b into microsoft:mainJun 12, 2024

TypeScript Bot (typescript-bot) pushed a commit that referenced this pull request Jun 12, 2024
Fixed a regression with reporting unused parameters in potential pred…
92998fe
…icates (#58514)

TypeScript Bot (typescript-bot) mentioned this pull request Jun 12, 2024
🤖 Pick PR #58514 (Fixed a regression with reporting u...) into release-5.5 #58841
Merged

Mateusz Burzyński (Andarist) deleted the unused-locals-in-predicate branch June 12, 2024 21:14

Nathan Shively-Sanders (sandersn) pushed a commit that referenced this pull request Jun 14, 2024
🤖 Pick PR#58514(Fixed a regression with reporting u...) into releas…
a20c69e
…e-5.5 (#58841) Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Uh oh!

Conversation

Mateusz Burzyński (Andarist) commented May 13, 2024

Uh oh!

Jake Bailey (jakebailey) commented May 13, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented May 13, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 13, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented May 13, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented May 13, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented May 13, 2024

Uh oh!

Nathan Shively-Sanders (sandersn) left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nathan Shively-Sanders (sandersn)May 17, 2024

Choose a reason for hiding this comment

Uh oh!

Mateusz Burzyński (Andarist)Jun 10, 2024

Choose a reason for hiding this comment

Uh oh!

Nathan Shively-Sanders (sandersn)May 17, 2024

Choose a reason for hiding this comment

Uh oh!

Mateusz Burzyński (Andarist)Jun 10, 2024

Choose a reason for hiding this comment

Uh oh!

Nathan Shively-Sanders (sandersn)May 17, 2024

Choose a reason for hiding this comment

Uh oh!

Mateusz Burzyński (Andarist)Jun 10, 2024

Choose a reason for hiding this comment

Uh oh!

Mateusz Burzyński (Andarist) commented Jun 10, 2024

Uh oh!

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Jun 10, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 10, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 10, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 10, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 10, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 10, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 10, 2024

Uh oh!

Jake Bailey (jakebailey) commented Jun 12, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 12, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TypeScript Bot (typescript-bot) commented May 13, 2024•
edited
Loading

Nathan Shively-Sanders (sandersn) left a comment •
edited
Loading

TypeScript Bot (typescript-bot) commented Jun 10, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Jun 10, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Jun 12, 2024•
edited
Loading