fix35982: allow BigIntLiteral to parse as PropertyName for literal object and indices by iisaduan · Pull Request #58608 · microsoft/TypeScript

Isabel Duan (iisaduan) · 2024-05-21T21:21:10Z

This PR allows more valid bigint uses in JS to parse and emit correctly. We will parse (and correctly emit) the following cases, but give the following errors:

{ ({1n: 123}); };
~~ 1538: A `bigint` literal may not be used as a property name.
[1,2,3][1n]; ~~ 2538: Type `bigint` cannot be used as an index type.
const arr = [1,2,3];
const { 0n: f } = arr; ~~ 2538: Type `bigint` cannot be used as an index type.
class K {
4n = 0;
~~ 1538: A `bigint` literal may not be used as a property name.
}

TypeScript Bot (typescript-bot) · 2024-05-21T21:21:21Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure Daniel Rosenwasser (@DanielRosenwasser) and Ryan Cavanaugh (@RyanCavanaugh) are aware of the changes, just as a heads up.

Isabel Duan (iisaduan) · 2024-05-21T21:22:43Z

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) · 2024-05-21T21:22:47Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-05-21T21:42:54Z

Hey Isabel Duan (@iisaduan), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-05-21T21:47:19Z

Isabel Duan (@iisaduan) Here are the results of running the user tests comparing main and refs/pull/58608/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2024-05-21T21:58:20Z

Isabel Duan (@iisaduan)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,248	_50,248	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,446k (± 0.95%)}	_{192,952k (± 0.75%)}	_~	_192,172k	_195,875k	_{p=0.689 n=6}
_{Parse Time}	_{1.55s (± 2.16%)}	_{1.54s (± 1.40%)}	_~	_1.51s	_1.57s	_{p=0.686 n=6}
_{Bind Time}	_{0.87s (± 1.26%)}	_{0.86s (± 1.41%)}	_~	_0.85s	_0.88s	_{p=0.476 n=6}
_{Check Time}	_{11.35s (± 0.47%)}	_{11.32s (± 0.18%)}	_~	_11.29s	_11.34s	_{p=0.227 n=6}
_{Emit Time}	_{3.14s (± 1.00%)}	_{3.15s (± 0.71%)}	_~	_3.13s	_3.19s	_{p=1.000 n=6}
_{Total Time}	_{16.92s (± 0.30%)}	_{16.88s (± 0.13%)}	_~	_16.84s	_16.90s	_{p=0.062 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,110	_944,110	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,140	_407,140	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,028k (± 0.00%)}	_{1,222,038k (± 0.00%)}	_~	_1,222,011k	_1,222,077k	_{p=1.000 n=6}
_{Parse Time}	_{8.10s (± 0.45%)}	_{8.13s (± 0.42%)}	_~	_8.09s	_8.19s	_{p=0.145 n=6}
_{Bind Time}	_{2.24s (± 0.63%)}	_{2.25s (± 0.56%)}	_~	_2.23s	_2.26s	_{p=0.249 n=6}
_{Check Time}	_{36.47s (± 0.31%)}	_{36.40s (± 0.31%)}	_~	_36.25s	_36.55s	_{p=0.377 n=6}
_{Emit Time}	_{17.53s (± 0.92%)}	_{17.54s (± 0.59%)}	_~	_17.39s	_17.68s	_{p=0.872 n=6}
_{Total Time}	_{64.35s (± 0.22%)}	_{64.33s (± 0.17%)}	_~	_64.15s	_64.42s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,978,789	_1,978,789	_~	_~	_~	_{p=1.000 n=6}
_Types	_882,017	_882,017	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,884,687k (± 0.01%)}	_{1,884,644k (± 0.00%)}	_~	_1,884,551k	_1,884,696k	_{p=0.066 n=6}
_{Parse Time}	_{8.02s (± 0.29%)}	_{8.02s (± 0.35%)}	_~	_7.97s	_8.04s	_{p=0.867 n=6}
_{Bind Time}	_{2.67s (± 5.33%)}	_{2.73s (± 0.73%)}	_~	_2.69s	_2.74s	_{p=0.300 n=6}
_{Check Time}	_{71.01s (± 0.46%)}	_{70.87s (± 0.28%)}	_~	_70.67s	_71.17s	_{p=0.575 n=6}
_{Emit Time}	_{0.17s (± 3.72%)}	_{0.17s (± 2.42%)}	_~	_0.16s	_0.17s	_{p=0.673 n=6}
_{Total Time}	_{81.87s (± 0.52%)}	_{81.79s (± 0.26%)}	_~	_81.53s	_82.13s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,223,198	_1,223,681	_{+483 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,141	_260,452	_{+311 (+ 0.12%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,340,437k (± 0.05%)}	_{2,340,209k (± 0.03%)}	_~	_2,339,523k	_2,341,237k	_{p=0.689 n=6}
_{Parse Time}	_{5.00s (± 1.44%)}	_{4.98s (± 1.62%)}	_~	_4.88s	_5.09s	_{p=0.689 n=6}
_{Bind Time}	_{1.90s (± 0.64%)}	_{1.89s (± 0.62%)}	_~	_1.87s	_1.90s	_{p=0.323 n=6}
_{Check Time}	_{33.81s (± 0.39%)}	_{33.75s (± 0.45%)}	_~	_33.54s	_33.96s	_{p=0.630 n=6}
_{Emit Time}	_{2.63s (± 3.81%)}	_{2.70s (± 1.48%)}	_~	_2.64s	_2.76s	_{p=0.521 n=6}
_{Total Time}	_{43.35s (± 0.60%)}	_{43.35s (± 0.49%)}	_~	_43.06s	_43.55s	_{p=1.000 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,223,198	_1,223,681	_{+483 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,141	_260,452	_{+311 (+ 0.12%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,415,349k (± 0.03%)}	_{2,416,424k (± 0.03%)}	_{+1,075k (+ 0.04%)}	_2,415,535k	_2,417,111k	_{p=0.031 n=6}
_{Parse Time}	_{6.30s (± 1.30%)}	_{6.31s (± 0.65%)}	_~	_6.26s	_6.36s	_{p=0.936 n=6}
_{Bind Time}	_{2.04s (± 0.95%)}	_{2.04s (± 1.19%)}	_~	_1.99s	_2.06s	_{p=1.000 n=6}
_{Check Time}	_{40.16s (± 0.49%)}	_{40.21s (± 0.38%)}	_~	_39.98s	_40.42s	_{p=0.810 n=6}
_{Emit Time}	_{3.22s (± 1.62%)}	_{3.19s (± 2.28%)}	_~	_3.05s	_3.26s	_{p=0.471 n=6}
_{Total Time}	_{51.72s (± 0.51%)}	_{51.76s (± 0.40%)}	_~	_51.45s	_51.98s	_{p=0.689 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_257,714	_258,106	_{+392 (+ 0.15%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,904	_105,170	_{+266 (+ 0.25%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{426,512k (± 0.02%)}	_{427,412k (± 0.01%)}	_{+900k (+ 0.21%)}	_427,391k	_427,454k	_{p=0.005 n=6}
_{Parse Time}	_{4.18s (± 0.61%)}	_{4.18s (± 0.49%)}	_~	_4.15s	_4.21s	_{p=0.454 n=6}
_{Bind Time}	_{1.62s (± 0.72%)}	_{1.62s (± 0.91%)}	_~	_1.59s	_1.63s	_{p=0.666 n=6}
_{Check Time}	_{22.26s (± 0.27%)}	_{22.26s (± 0.37%)}	_~	_22.11s	_22.36s	_{p=0.872 n=6}
_{Emit Time}	_{1.72s (± 1.50%)}	_{1.70s (± 1.21%)}	_~	_1.67s	_1.73s	_{p=0.105 n=6}
_{Total Time}	_{29.79s (± 0.28%)}	_{29.76s (± 0.31%)}	_~	_29.63s	_29.90s	_{p=0.747 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,575	_224,575	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,785	_93,785	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,881k (± 0.03%)}	_{369,826k (± 0.02%)}	_~	_369,765k	_369,969k	_{p=0.575 n=6}
_{Parse Time}	_{3.50s (± 0.44%)}	_{3.50s (± 0.53%)}	_~	_3.47s	_3.52s	_{p=0.370 n=6}
_{Bind Time}	_{1.94s (± 1.10%)}	_{1.94s (± 0.83%)}	_~	_1.91s	_1.95s	_{p=0.934 n=6}
_{Check Time}	_{19.31s (± 0.17%)}	_{19.33s (± 0.44%)}	_~	_19.24s	_19.46s	_{p=0.809 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.75s (± 0.18%)}	_{24.78s (± 0.33%)}	_~	_24.65s	_24.86s	_{p=0.377 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,823,879	_2,823,879	_~	_~	_~	_{p=1.000 n=6}
_Types	_957,876	_957,876	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,998,648k (± 0.00%)}	_{2,998,669k (± 0.00%)}	_~	_2,998,573k	_2,998,765k	_{p=0.936 n=6}
_{Parse Time}	_{13.87s (± 0.30%)}	_{13.90s (± 0.23%)}	_~	_13.86s	_13.95s	_{p=0.196 n=6}
_{Bind Time}	_{4.13s (± 0.25%)}	_{4.13s (± 0.34%)}	_~	_4.11s	_4.15s	_{p=0.738 n=6}
_{Check Time}	_{73.48s (± 0.40%)}	_{73.57s (± 0.33%)}	_~	_73.33s	_73.96s	_{p=0.575 n=6}
_{Emit Time}	_{23.42s (± 1.02%)}	_{23.43s (± 1.08%)}	_~	_23.06s	_23.73s	_{p=0.810 n=6}
_{Total Time}	_{114.90s (± 0.43%)}	_{115.02s (± 0.17%)}	_~	_114.70s	_115.25s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,866	_265,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,401	_108,401	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,505k (± 0.01%)}	_{410,540k (± 0.01%)}	_~	_410,487k	_410,602k	_{p=0.173 n=6}
_{Parse Time}	_{3.82s (± 1.07%)}	_{3.84s (± 0.88%)}	_~	_3.80s	_3.89s	_{p=0.518 n=6}
_{Bind Time}	_{1.67s (± 1.03%)}	_{1.68s (± 1.24%)}	_~	_1.65s	_1.70s	_{p=0.744 n=6}
_{Check Time}	_{16.91s (± 0.63%)}	_{16.90s (± 0.40%)}	_~	_16.79s	_16.97s	_{p=0.748 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.41s (± 0.46%)}	_{22.42s (± 0.47%)}	_~	_22.27s	_22.55s	_{p=1.000 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,654	_524,654	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,920	_178,920	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,683k (± 0.03%)}	_{462,756k (± 0.03%)}	_~	_462,633k	_462,994k	_{p=0.575 n=6}
_{Parse Time}	_{3.90s (± 0.51%)}	_{3.91s (± 0.53%)}	_~	_3.88s	_3.94s	_{p=0.615 n=6}
_{Bind Time}	_{1.45s (± 1.31%)}	_{1.45s (± 1.34%)}	_~	_1.42s	_1.47s	_{p=0.935 n=6}
_{Check Time}	_{22.48s (± 0.87%)}	_{22.63s (± 0.40%)}	_~	_22.52s	_22.76s	_{p=0.149 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.83s (± 0.65%)}	_{27.98s (± 0.35%)}	_~	_27.82s	_28.09s	_{p=0.148 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-05-21T23:10:37Z

Isabel Duan (@iisaduan) Here are the results of running the top 400 repos comparing main and refs/pull/58608/merge:

Everything looks good!

Isabel Duan (iisaduan) · 2024-05-23T23:21:19Z

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) · 2024-05-23T23:21:23Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-05-23T23:42:49Z

Hey Isabel Duan (@iisaduan), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-05-23T23:48:40Z

Isabel Duan (@iisaduan) Here are the results of running the user tests comparing main and refs/pull/58608/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2024-05-24T00:04:15Z

Isabel Duan (@iisaduan)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,248	_50,248	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,946k (± 0.73%)}	_{192,908k (± 0.76%)}	_~	_192,160k	_195,894k	_{p=0.936 n=6}
_{Parse Time}	_{1.30s (± 0.63%)}	_{1.29s (± 1.50%)}	_~	_1.26s	_1.31s	_{p=0.157 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.56s (± 0.56%)}	_{9.54s (± 0.44%)}	_~	_9.49s	_9.59s	_{p=0.469 n=6}
_{Emit Time}	_{2.65s (± 0.52%)}	_{2.64s (± 0.75%)}	_~	_2.62s	_2.67s	_{p=0.247 n=6}
_{Total Time}	_{14.23s (± 0.20%)}	_{14.18s (± 0.41%)}	_~	_14.09s	_14.23s	_{p=0.183 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,110	_944,110	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,140	_407,140	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,015k (± 0.00%)}	_{1,222,009k (± 0.01%)}	_~	_1,221,856k	_1,222,126k	_{p=0.575 n=6}
_{Parse Time}	_{8.06s (± 0.22%)}	_{8.12s (± 0.78%)}	_~	_8.05s	_8.22s	_{p=0.158 n=6}
_{Bind Time}	_{2.25s (± 0.86%)}	_{2.25s (± 0.61%)}	_~	_2.23s	_2.27s	_{p=0.459 n=6}
_{Check Time}	_{36.45s (± 0.37%)}	_{36.59s (± 0.63%)}	_~	_36.26s	_36.82s	_{p=0.378 n=6}
_{Emit Time}	_{17.53s (± 0.58%)}	_{17.58s (± 0.55%)}	_~	_17.45s	_17.71s	_{p=0.470 n=6}
_{Total Time}	_{64.29s (± 0.24%)}	_{64.54s (± 0.43%)}	_~	_64.09s	_64.78s	_{p=0.128 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,978,570	_1,978,570	_~	_~	_~	_{p=1.000 n=6}
_Types	_882,090	_882,090	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,885,387k (± 0.00%)}	_{1,885,367k (± 0.00%)}	_~	_1,885,341k	_1,885,421k	_{p=0.199 n=6}
_{Parse Time}	_{6.76s (± 0.36%)}	_{6.80s (± 0.41%)}	_~	_6.76s	_6.83s	_{p=0.052 n=6}
_{Bind Time}	_{2.29s (± 0.76%)}	_{2.30s (± 0.76%)}	_~	_2.27s	_2.32s	_{p=0.684 n=6}
_{Check Time}	_{60.71s (± 0.32%)}	_{60.74s (± 0.31%)}	_~	_60.42s	_60.96s	_{p=0.688 n=6}
_{Emit Time}	_{0.15s (± 2.75%)}	_{0.15s (± 3.77%)}	_~	_0.14s	_0.15s	_{p=0.282 n=6}
_{Total Time}	_{69.92s (± 0.30%)}	_{69.98s (± 0.26%)}	_~	_69.71s	_70.24s	_{p=0.687 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,000	_1,225,496	_{+496 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,662	_260,983	_{+321 (+ 0.12%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,341,618k (± 0.03%)}	_{2,343,070k (± 0.04%)}	_{+1,453k (+ 0.06%)}	_2,342,133k	_2,344,638k	_{p=0.020 n=6}
_{Parse Time}	_{4.98s (± 0.68%)}	_{4.96s (± 0.96%)}	_~	_4.90s	_5.02s	_{p=0.688 n=6}
_{Bind Time}	_{1.91s (± 0.57%)}	_{1.89s (± 0.27%)}	_{-0.02s (- 0.87%)}	_1.89s	_1.90s	_{p=0.023 n=6}
_{Check Time}	_{33.81s (± 0.31%)}	_{33.96s (± 0.43%)}	_~	_33.71s	_34.13s	_{p=0.128 n=6}
_{Emit Time}	_{2.67s (± 2.06%)}	_{2.67s (± 1.75%)}	_~	_2.62s	_2.76s	_{p=0.575 n=6}
_{Total Time}	_{43.38s (± 0.26%)}	_{43.50s (± 0.36%)}	_~	_43.27s	_43.69s	_{p=0.230 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,000	_1,225,496	_{+496 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,662	_260,983	_{+321 (+ 0.12%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,418,024k (± 0.01%)}	_{2,469,490k (± 3.15%)}	_{+51,466k (+ 2.13%)}	_2,417,832k	_2,571,118k	_{p=0.045 n=6}
_{Parse Time}	_{6.21s (± 1.34%)}	_{6.16s (± 0.78%)}	_~	_6.09s	_6.21s	_{p=0.230 n=6}
_{Bind Time}	_{2.05s (± 0.99%)}	_{2.05s (± 1.26%)}	_~	_2.01s	_2.08s	_{p=0.744 n=6}
_{Check Time}	_{40.32s (± 0.21%)}	_{40.32s (± 0.32%)}	_~	_40.17s	_40.50s	_{p=1.000 n=6}
_{Emit Time}	_{3.08s (± 2.07%)}	_{3.16s (± 6.05%)}	_~	_2.97s	_3.50s	_{p=0.575 n=6}
_{Total Time}	_{51.67s (± 0.20%)}	_{51.71s (± 0.27%)}	_~	_51.55s	_51.93s	_{p=0.748 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_257,735	_258,129	_{+394 (+ 0.15%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,934	_105,209	_{+275 (+ 0.26%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{426,658k (± 0.01%)}	_{427,626k (± 0.02%)}	_{+968k (+ 0.23%)}	_427,516k	_427,729k	_{p=0.005 n=6}
_{Parse Time}	_{4.18s (± 0.62%)}	_{4.17s (± 0.80%)}	_~	_4.12s	_4.20s	_{p=0.871 n=6}
_{Bind Time}	_{1.62s (± 1.44%)}	_{1.62s (± 1.72%)}	_~	_1.58s	_1.65s	_{p=0.809 n=6}
_{Check Time}	_{22.26s (± 0.49%)}	_{22.36s (± 0.38%)}	_~	_22.24s	_22.47s	_{p=0.228 n=6}
_{Emit Time}	_{1.69s (± 1.48%)}	_{1.67s (± 0.76%)}	_~	_1.65s	_1.68s	_{p=0.102 n=6}
_{Total Time}	_{29.74s (± 0.38%)}	_{29.81s (± 0.45%)}	_~	_29.67s	_29.98s	_{p=0.521 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,575	_224,575	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,785	_93,785	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,936k (± 0.03%)}	_{369,917k (± 0.03%)}	_~	_369,797k	_370,074k	_{p=0.689 n=6}
_{Parse Time}	_{2.83s (± 1.17%)}	_{2.85s (± 0.72%)}	_~	_2.82s	_2.87s	_{p=0.292 n=6}
_{Bind Time}	_{1.59s (± 1.22%)}	_{1.57s (± 0.53%)}	_~	_1.56s	_1.58s	_{p=0.162 n=6}
_{Check Time}	_{15.68s (± 0.35%)}	_{15.61s (± 0.33%)}	_~	_15.56s	_15.70s	_{p=0.078 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.10s (± 0.27%)}	_{20.04s (± 0.36%)}	_~	_19.95s	_20.15s	_{p=0.199 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,835,595	_2,835,595	_~	_~	_~	_{p=1.000 n=6}
_Types	_961,025	_961,025	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,008,099k (± 0.00%)}	_{3,008,021k (± 0.00%)}	_~	_3,007,932k	_3,008,125k	_{p=0.093 n=6}
_{Parse Time}	_{17.02s (± 0.21%)}	_{17.10s (± 0.88%)}	_~	_16.99s	_17.39s	_{p=0.514 n=6}
_{Bind Time}	_{5.06s (± 0.48%)}	_{5.04s (± 0.77%)}	_~	_5.01s	_5.11s	_{p=0.260 n=6}
_{Check Time}	_{90.14s (± 2.17%)}	_{88.98s (± 0.26%)}	_~	_88.70s	_89.30s	_{p=0.471 n=6}
_{Emit Time}	_{27.47s (± 7.39%)}	_{28.59s (± 0.70%)}	_~	_28.35s	_28.85s	_{p=0.748 n=6}
_{Total Time}	_{139.69s (± 0.24%)}	_{139.71s (± 0.24%)}	_~	_139.37s	_140.32s	_{p=1.000 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,087	_266,087	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,518	_108,518	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,934k (± 0.02%)}	_{410,960k (± 0.01%)}	_~	_410,866k	_411,035k	_{p=0.471 n=6}
_{Parse Time}	_{4.75s (± 0.75%)}	_{4.75s (± 0.41%)}	_~	_4.72s	_4.77s	_{p=0.628 n=6}
_{Bind Time}	_{2.07s (± 0.90%)}	_{2.05s (± 1.29%)}	_~	_2.00s	_2.07s	_{p=0.563 n=6}
_{Check Time}	_{21.01s (± 0.18%)}	_{21.03s (± 0.26%)}	_~	_20.95s	_21.08s	_{p=0.419 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.83s (± 0.23%)}	_{27.83s (± 0.23%)}	_~	_27.74s	_27.90s	_{p=1.000 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_535,745	_535,745	_~	_~	_~	_{p=1.000 n=6}
_Types	_182,753	_182,753	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{470,453k (± 0.02%)}	_{470,445k (± 0.02%)}	_~	_470,351k	_470,611k	_{p=0.936 n=6}
_{Parse Time}	_{3.18s (± 0.69%)}	_{3.16s (± 0.77%)}	_~	_3.13s	_3.20s	_{p=0.062 n=6}
_{Bind Time}	_{1.20s (± 0.86%)}	_{1.20s (± 0.34%)}	_~	_1.19s	_1.20s	_{p=0.924 n=6}
_{Check Time}	_{18.43s (± 0.29%)}	_{18.36s (± 0.37%)}	_~	_18.29s	_18.46s	_{p=0.199 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.80s (± 0.33%)}	_{22.72s (± 0.33%)}	_~	_22.62s	_22.80s	_{p=0.128 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-05-24T00:54:13Z

Isabel Duan (@iisaduan) Here are the results of running the top 400 repos comparing main and refs/pull/58608/merge:

Everything looks good!

Isabel Duan (iisaduan) · 2024-07-13T02:42:07Z

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) · 2024-07-13T02:42:10Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-07-13T03:03:53Z

Hey Isabel Duan (@iisaduan), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-07-13T03:19:04Z

Isabel Duan (@iisaduan)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,750k (± 0.76%)}	_{193,357k (± 0.94%)}	_~	_192,136k	_195,703k	_{p=0.298 n=6}
_{Parse Time}	_{1.95s (± 0.95%)}	_{1.94s (± 0.60%)}	_~	_1.92s	_1.95s	_{p=0.357 n=6}
_{Bind Time}	_{1.05s (± 0.93%)}	_{1.07s (± 0.76%)}	_{+0.01s (+ 1.43%)}	_1.06s	_1.08s	_{p=0.026 n=6}
_{Check Time}	_{13.89s (± 0.29%)}	_{13.87s (± 0.44%)}	_~	_13.81s	_13.97s	_{p=0.571 n=6}
_{Emit Time}	_{4.03s (± 0.53%)}	_{4.00s (± 0.65%)}	_~	_3.96s	_4.03s	_{p=0.102 n=6}
_{Total Time}	_{20.93s (± 0.13%)}	_{20.88s (± 0.34%)}	_~	_20.82s	_20.98s	_{p=0.257 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,410k (± 0.00%)}	_{1,218,395k (± 0.00%)}	_~	_1,218,350k	_1,218,456k	_{p=0.689 n=6}
_{Parse Time}	_{6.70s (± 0.51%)}	_{6.72s (± 0.46%)}	_~	_6.69s	_6.78s	_{p=0.373 n=6}
_{Bind Time}	_{1.87s (± 0.68%)}	_{1.86s (± 0.74%)}	_~	_1.85s	_1.88s	_{p=0.564 n=6}
_{Check Time}	_{30.73s (± 0.18%)}	_{30.72s (± 0.36%)}	_~	_30.59s	_30.89s	_{p=0.936 n=6}
_{Emit Time}	_{13.55s (± 0.62%)}	_{13.57s (± 0.49%)}	_~	_13.47s	_13.65s	_{p=0.936 n=6}
_{Total Time}	_{52.85s (± 0.19%)}	_{52.88s (± 0.26%)}	_~	_52.70s	_53.10s	_{p=0.748 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,148,730	_2,148,730	_~	_~	_~	_{p=1.000 n=6}
_Types	_929,320	_929,320	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,116,402k (± 0.01%)}	_{2,116,449k (± 0.01%)}	_~	_2,116,230k	_2,116,690k	_{p=0.471 n=6}
_{Parse Time}	_{6.58s (± 0.25%)}	_{6.59s (± 0.12%)}	_~	_6.58s	_6.60s	_{p=0.934 n=6}
_{Bind Time}	_{2.33s (± 0.24%)}	_{2.32s (± 0.47%)}	_~	_2.30s	_2.33s	_{p=0.476 n=6}
_{Check Time}	_{70.68s (± 0.12%)}	_{70.66s (± 0.43%)}	_~	_70.36s	_71.06s	_{p=0.810 n=6}
_{Emit Time}	_{0.14s (± 3.77%)}	_{0.14s (± 2.88%)}	_~	_0.14s	_0.15s	_{p=0.114 n=6}
_{Total Time}	_{79.73s (± 0.11%)}	_{79.71s (± 0.39%)}	_~	_79.40s	_80.12s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,948	_1,226,432	_{+484 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,589	_261,903	_{+314 (+ 0.12%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,338,875k (± 0.01%)}	_{2,340,095k (± 0.03%)}	_{+1,221k (+ 0.05%)}	_2,339,334k	_2,340,856k	_{p=0.008 n=6}
_{Parse Time}	_{5.08s (± 0.67%)}	_{5.05s (± 0.85%)}	_~	_4.98s	_5.10s	_{p=0.297 n=6}
_{Bind Time}	_{1.90s (± 0.86%)}	_{1.91s (± 0.39%)}	_~	_1.90s	_1.92s	_{p=0.189 n=6}
_{Check Time}	_{34.15s (± 0.25%)}	_{34.16s (± 0.40%)}	_~	_34.01s	_34.36s	_{p=1.000 n=6}
_{Emit Time}	_{3.24s (± 1.36%)}	_{3.25s (± 1.68%)}	_~	_3.19s	_3.34s	_{p=1.000 n=6}
_{Total Time}	_{44.39s (± 0.20%)}	_{44.38s (± 0.36%)}	_~	_44.23s	_44.64s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,948	_1,226,432	_{+484 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,589	_261,903	_{+314 (+ 0.12%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,413,293k (± 0.03%)}	_{2,414,369k (± 0.04%)}	_~	_2,413,444k	_2,415,752k	_{p=0.066 n=6}
_{Parse Time}	_{5.20s (± 1.09%)}	_{5.23s (± 0.72%)}	_~	_5.19s	_5.28s	_{p=0.574 n=6}
_{Bind Time}	_{1.70s (± 0.62%)}	_{1.71s (± 1.21%)}	_~	_1.69s	_1.74s	_{p=0.405 n=6}
_{Check Time}	_{34.66s (± 0.29%)}	_{34.65s (± 0.20%)}	_~	_34.55s	_34.73s	_{p=0.936 n=6}
_{Emit Time}	_{3.31s (± 2.10%)}	_{3.30s (± 2.53%)}	_~	_3.19s	_3.40s	_{p=0.809 n=6}
_{Total Time}	_{44.88s (± 0.22%)}	_{44.88s (± 0.19%)}	_~	_44.79s	_45.02s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,230	_258,623	_{+393 (+ 0.15%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,789	_105,058	_{+269 (+ 0.26%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{427,103k (± 0.03%)}	_{428,136k (± 0.04%)}	_{+1,033k (+ 0.24%)}	_427,960k	_428,413k	_{p=0.005 n=6}
_{Parse Time}	_{3.32s (± 0.70%)}	_{3.31s (± 1.06%)}	_~	_3.27s	_3.36s	_{p=0.746 n=6}
_{Bind Time}	_{1.32s (± 1.49%)}	_{1.32s (± 0.88%)}	_~	_1.30s	_1.33s	_{p=0.868 n=6}
_{Check Time}	_{17.84s (± 0.26%)}	_{17.93s (± 0.24%)}	_{+0.10s (+ 0.54%)}	_17.86s	_17.98s	_{p=0.016 n=6}
_{Emit Time}	_{1.66s (± 0.91%)}	_{1.65s (± 1.40%)}	_~	_1.62s	_1.68s	_{p=0.806 n=6}
_{Total Time}	_{24.13s (± 0.15%)}	_{24.22s (± 0.29%)}	_{+0.09s (+ 0.38%)}	_24.12s	_24.29s	_{p=0.037 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,466k (± 0.03%)}	_{369,519k (± 0.01%)}	_~	_369,477k	_369,556k	_{p=0.128 n=6}
_{Parse Time}	_{3.43s (± 1.35%)}	_{3.44s (± 0.68%)}	_~	_3.41s	_3.47s	_{p=0.687 n=6}
_{Bind Time}	_{1.93s (± 0.60%)}	_{1.93s (± 0.89%)}	_~	_1.91s	_1.95s	_{p=0.935 n=6}
_{Check Time}	_{19.14s (± 0.46%)}	_{19.16s (± 0.35%)}	_~	_19.04s	_19.23s	_{p=0.572 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.51s (± 0.45%)}	_{24.53s (± 0.35%)}	_~	_24.39s	_24.63s	_{p=0.810 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,891,160	_2,891,160	_~	_~	_~	_{p=1.000 n=6}
_Types	_978,184	_978,184	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,054,909k (± 0.00%)}	_{3,054,954k (± 0.00%)}	_~	_3,054,858k	_3,055,012k	_{p=0.173 n=6}
_{Parse Time}	_{13.70s (± 0.14%)}	_{13.69s (± 0.22%)}	_~	_13.64s	_13.73s	_{p=0.570 n=6}
_{Bind Time}	_{4.18s (± 0.82%)}	_{4.18s (± 0.28%)}	_~	_4.16s	_4.19s	_{p=0.681 n=6}
_{Check Time}	_{74.29s (± 2.08%)}	_{74.73s (± 3.04%)}	_~	_72.97s	_77.73s	_{p=0.810 n=6}
_{Emit Time}	_{23.06s (± 6.80%)}	_{22.50s (± 8.89%)}	_~	_19.87s	_24.13s	_{p=1.000 n=6}
_{Total Time}	_{115.22s (± 0.35%)}	_{115.10s (± 0.31%)}	_~	_114.56s	_115.54s	_{p=0.630 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,239	_267,239	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,815	_108,815	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,860k (± 0.02%)}	_{411,845k (± 0.03%)}	_~	_411,702k	_411,960k	_{p=1.000 n=6}
_{Parse Time}	_{4.75s (± 0.54%)}	_{4.73s (± 0.55%)}	_~	_4.69s	_4.76s	_{p=0.107 n=6}
_{Bind Time}	_{2.10s (± 0.63%)}	_{2.09s (± 0.49%)}	_~	_2.07s	_2.10s	_{p=0.134 n=6}
_{Check Time}	_{20.76s (± 0.31%)}	_{20.78s (± 0.35%)}	_~	_20.64s	_20.85s	_{p=0.572 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.61s (± 0.20%)}	_{27.60s (± 0.19%)}	_~	_27.51s	_27.67s	_{p=0.687 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_510,479	_510,479	_~	_~	_~	_{p=1.000 n=6}
_Types	_161,600	_161,600	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{448,002k (± 0.05%)}	_{447,988k (± 0.07%)}	_~	_447,649k	_448,501k	_{p=0.810 n=6}
_{Parse Time}	_{3.17s (± 0.62%)}	_{3.17s (± 0.59%)}	_~	_3.14s	_3.19s	_{p=0.870 n=6}
_{Bind Time}	_{1.17s (± 0.35%)}	_{1.17s (± 1.00%)}	_~	_1.16s	_1.19s	_{p=0.242 n=6}
_{Check Time}	_{17.00s (± 0.21%)}	_{17.05s (± 0.42%)}	_~	_16.97s	_17.14s	_{p=0.295 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.34s (± 0.25%)}	_{21.39s (± 0.30%)}	_~	_21.33s	_21.48s	_{p=0.291 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-07-13T04:21:02Z

Isabel Duan (@iisaduan) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/58608/merge:

Everything looks good!

Isabel Duan (iisaduan) · 2024-07-13T05:25:49Z

TypeScript Bot (@typescript-bot) user test this

TypeScript Bot (typescript-bot) · 2024-07-13T05:25:53Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`user test this`	✅ Started	✅ Results

TypeScript Bot (typescript-bot) · 2024-07-13T05:56:01Z

Isabel Duan (@iisaduan) Here are the results of running the user tests with tsc comparing main and refs/pull/58608/merge:

Everything looks good!

Ron Buckton (rbuckton) · 2024-07-16T20:08:34Z

 }
 else {
- error(indexNode, Diagnostics.Type_0_cannot_be_used_as_an_index_type, typeToString(indexType));
+ const typeString = typeToString(indexNode.kind === SyntaxKind.BigIntLiteral ? getBaseTypeOfLiteralType(getContextFreeTypeOfExpression(indexNode)) : indexType);


Does this just end up producing bigint or do we expect something else to show up here? If something other than bigint can appear, we should add tests as the tests only show bigint. If this can only ever produce bigint, then I would just use the literal string.
Also, unless anyone else has a particular preference, I think Type '1n' cannot be used as an index type is also acceptable, so leaving this as typeToString(indexType) might be fine.

I'm not really sure how the latest push resolved this; "bigInt" isn't a thing in TS or JS and I think Ron was suggesting to actually write the value? (See also my comment on the earlier thread with suggested code)

We should either write the value, or bigint (all lowercase) as it's the underlying base type.

Sorry, I've been looking at the tests, and some of the test cases have been inconsistent with the caps. I'll fix that.
Would you prefer the "property does not exist on type" error? I was using the "bigint literal type cannot be used as an index" error because the original design choice was the bigintliteral type cannot be used as an index, as you should use a string or number instead. "cannot be used as index" seemed more descriptive of what was happening than "property does not exist".
I don't mind using the value in the error message (1n cannot be used as an index type) if you like that better, and it is what you would get with typeToString(indexType). I changed it because bigint made the above more clear as well.

cc Ron Buckton (@rbuckton)Jake Bailey (@jakebailey)Daniel Rosenwasser (@DanielRosenwasser)

I guess if you just swap it back to bigint, that should be sufficient. I see what you mean about the inconsistency; it's not that say 1n doesn't exist on the type, but that bigint isn't supported at all?

Yes, it's valid syntactically in js to index with bigints, but we've disallowed them when type checking

…arse-bigint-index

Daniel Rosenwasser (DanielRosenwasser)

There are a few things that I didn't catch before that I want addressed, but I'm going to mark this as approved so you're not blocked on merging.

Isabel Duan (iisaduan) added 2 commits May 21, 2024 13:55

add BigIntLiteral to PropertyName
549c2f5

change error wording
dc4fa17

TypeScript Bot (typescript-bot) assigned Isabel Duan (iisaduan)May 21, 2024

TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 21, 2024

Isabel Duan (iisaduan) added 2 commits May 23, 2024 14:36

change error to be a grammar error, add index error
fadbf13

more specific index error
262c6b1

Isabel Duan (iisaduan) changed the title ~~fix35982: allow BigIntLiteral to parse as PropertyName for literal object~~fix35982: allow BigIntLiteral to parse as PropertyName for literal object and indicesMay 23, 2024

update baselines again?
026f259

Daniel Rosenwasser (DanielRosenwasser) reviewed May 24, 2024
View reviewed changes

Comment threadsrc/compiler/diagnosticMessages.json Outdated

Isabel Duan (iisaduan) added 2 commits May 24, 2024 19:24

suggested changes
f2da07f

fix errors
544d4a3

Isabel Duan (iisaduan) requested a review from Daniel Rosenwasser (DanielRosenwasser)May 28, 2024 17:53

Daniel Rosenwasser (DanielRosenwasser) reviewed Jun 18, 2024
View reviewed changes

Comment threadsrc/compiler/checker.ts Outdated

merge/change error number
42c9150

Daniel Rosenwasser (DanielRosenwasser) reviewed Jun 18, 2024
View reviewed changes

Comment threadtests/cases/compiler/bigintIndex.ts Outdated

Merge branch 'main' into parse-bigint-index
c5a891e

Isabel Duan (iisaduan) added 3 commits July 11, 2024 17:24

add tests
49b1369

add even more tests + fix crashes
2b1bafa

fix tests
bcd6023

Jake Bailey (jakebailey) reviewed Jul 12, 2024
View reviewed changes

Comment threadsrc/compiler/diagnosticMessages.json Outdated

Isabel Duan (iisaduan) requested review from Daniel Rosenwasser (DanielRosenwasser), Andrew Branch (andrewbranch), Ron Buckton (rbuckton) and Nathan Shively-Sanders (sandersn)July 15, 2024 22:03

Ron Buckton (rbuckton) reviewed Jul 16, 2024
View reviewed changes

changed error to use literal string
2cb0357

Daniel Rosenwasser (DanielRosenwasser) added Breaking Change Would introduce errors in existing code Domain: API Relates to the public API for TypeScript labels Jul 19, 2024

Isabel Duan (iisaduan) added 3 commits July 19, 2024 14:53

fix error
4a4ee7e

Merge branch 'main' ofhttps://github.com/microsoft/TypeScriptinto p…
8aa6c0d
…arse-bigint-index

update baselines
2c222c6

Daniel Rosenwasser (DanielRosenwasser) approved these changes Jul 20, 2024
View reviewed changes

Comment threadsrc/compiler/checker.ts Outdated
Comment threadsrc/compiler/diagnosticMessages.json Outdated

fix error messages
46f1b44

Isabel Duan (iisaduan) merged commit dfb8701 into microsoft:mainJul 20, 2024

Isabel Duan (iisaduan) deleted the parse-bigint-index branch July 20, 2024 00:48

Nathan Shively-Sanders (sandersn) removed this from PR Backlog Apr 22, 2025

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Uh oh!

Conversation

Isabel Duan (iisaduan) commented May 21, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 21, 2024

Uh oh!

Isabel Duan (iisaduan) commented May 21, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented May 21, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 21, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented May 21, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented May 21, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented May 21, 2024

Uh oh!

Isabel Duan (iisaduan) commented May 23, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented May 23, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 23, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented May 23, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented May 24, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented May 24, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Isabel Duan (iisaduan) commented Jul 13, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 13, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 13, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 13, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 13, 2024

Uh oh!

Isabel Duan (iisaduan) commented Jul 13, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 13, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 13, 2024

Uh oh!

Ron Buckton (rbuckton)Jul 16, 2024

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey)Jul 17, 2024

Choose a reason for hiding this comment

Uh oh!

Ron Buckton (rbuckton)Jul 17, 2024

Choose a reason for hiding this comment

Uh oh!

Isabel Duan (iisaduan)Jul 17, 2024

Choose a reason for hiding this comment

Uh oh!

Isabel Duan (iisaduan)Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey)Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

Isabel Duan (iisaduan)Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Isabel Duan (iisaduan) commented May 21, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented May 21, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented May 23, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Jul 13, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Jul 13, 2024•
edited
Loading