Clone node to remove location even when it has been modified if needed by weswigham · Pull Request #58706 · microsoft/TypeScript

Wesley Wigham (weswigham) · 2024-05-29T23:00:24Z

Because when a node is updated because its' children changed, location data is, by default, copied by the node update functions. In addition, I also handle deleting location data from node arrays from other files as well, as I noticed that while debugging.

Additionally, one of the comment range copies in the test was coming from an unchecked setCommentRange outside the node copying code, so that now has builtin checks now, too.

Fixes#58698

Jake Bailey (jakebailey) · 2024-05-31T19:32:53Z

Wow, this is a big baseline change, but maybe it's just going to have to happen given #58698 is a bad bug?

Jake Bailey (jakebailey) · 2024-05-31T19:33:36Z

Would run perf on this but I think the merge conflict will make the bot mad.

Jake Bailey (jakebailey) · 2024-05-31T19:51:11Z

TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2024-05-31T19:51:14Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-05-31T20:33:26Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,716k (± 0.93%)}	_{192,937k (± 0.74%)}	_~	_192,325k	_195,870k	_{p=0.066 n=6}
_{Parse Time}	_{1.96s (± 0.70%)}	_{1.95s (± 0.65%)}	_~	_1.93s	_1.97s	_{p=0.103 n=6}
_{Bind Time}	_{1.07s (± 1.42%)}	_{1.06s (± 0.71%)}	_~	_1.05s	_1.07s	_{p=0.867 n=6}
_{Check Time}	_{14.02s (± 0.61%)}	_{14.06s (± 0.73%)}	_~	_13.86s	_14.15s	_{p=0.422 n=6}
_{Emit Time}	_{3.99s (± 1.09%)}	_{4.05s (± 0.75%)}	_{+0.06s (+ 1.55%)}	_4.02s	_4.10s	_{p=0.024 n=6}
_{Total Time}	_{21.04s (± 0.37%)}	_{21.12s (± 0.34%)}	_{+0.08s (+ 0.36%)}	_20.98s	_21.20s	_{p=0.045 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,109	_944,109	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,049	_407,049	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,140k (± 0.00%)}	_{1,222,157k (± 0.00%)}	_~	_1,222,101k	_1,222,213k	_{p=0.298 n=6}
_{Parse Time}	_{8.09s (± 0.60%)}	_{8.12s (± 0.68%)}	_~	_8.03s	_8.18s	_{p=0.470 n=6}
_{Bind Time}	_{2.23s (± 0.84%)}	_{2.25s (± 0.97%)}	_~	_2.22s	_2.28s	_{p=0.256 n=6}
_{Check Time}	_{36.52s (± 0.11%)}	_{36.47s (± 0.36%)}	_~	_36.28s	_36.64s	_{p=0.575 n=6}
_{Emit Time}	_{18.10s (± 0.59%)}	_{18.12s (± 0.41%)}	_~	_18.03s	_18.23s	_{p=0.630 n=6}
_{Total Time}	_{64.95s (± 0.25%)}	_{64.95s (± 0.17%)}	_~	_64.81s	_65.12s	_{p=0.873 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,051,460	_2,051,460	_~	_~	_~	_{p=1.000 n=6}
_Types	_899,446	_899,446	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,065,714k (± 0.00%)}	_{2,065,597k (± 0.00%)}	_{-117k (- 0.01%)}	_2,065,464k	_2,065,693k	_{p=0.020 n=6}
_{Parse Time}	_{9.94s (± 0.29%)}	_{9.98s (± 0.21%)}	_~	_9.94s	_10.00s	_{p=0.052 n=6}
_{Bind Time}	_{3.36s (± 1.01%)}	_{3.38s (± 0.76%)}	_~	_3.34s	_3.42s	_{p=0.288 n=6}
_{Check Time}	_{99.88s (± 1.21%)}	_{99.49s (± 1.89%)}	_~	_96.89s	_100.96s	_{p=0.936 n=6}
_{Emit Time}	_{0.20s (± 2.67%)}	_{0.20s (± 2.02%)}	_~	_0.20s	_0.21s	_{p=0.282 n=6}
_{Total Time}	_{113.39s (± 1.04%)}	_{113.05s (± 1.66%)}	_~	_110.43s	_114.48s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,666	_1,229,706	_{+40 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,899	_260,911	_{+12 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,376,011k (± 2.59%)}	_{2,376,495k (± 2.62%)}	_~	_2,349,580k	_2,503,599k	_{p=1.000 n=6}
_{Parse Time}	_{7.52s (± 0.77%)}	_{7.49s (± 0.72%)}	_~	_7.42s	_7.57s	_{p=0.230 n=6}
_{Bind Time}	_{2.79s (± 0.95%)}	_{2.80s (± 0.98%)}	_~	_2.78s	_2.85s	_{p=0.808 n=6}
_{Check Time}	_{49.70s (± 0.61%)}	_{49.54s (± 0.77%)}	_~	_49.12s	_50.20s	_{p=0.521 n=6}
_{Emit Time}	_{3.89s (± 3.77%)}	_{3.94s (± 6.32%)}	_~	_3.71s	_4.42s	_{p=0.873 n=6}
_{Total Time}	_{63.92s (± 0.51%)}	_{63.78s (± 0.72%)}	_~	_63.22s	_64.43s	_{p=0.575 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,666	_1,229,706	_{+40 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,899	_260,911	_{+12 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,502,761k (± 3.34%)}	_{2,477,259k (± 3.16%)}	_~	_2,425,442k	_2,578,894k	_{p=0.575 n=6}
_{Parse Time}	_{5.17s (± 1.20%)}	_{5.16s (± 0.74%)}	_~	_5.10s	_5.21s	_{p=0.873 n=6}
_{Bind Time}	_{1.68s (± 0.49%)}	_{1.68s (± 0.70%)}	_~	_1.66s	_1.69s	_{p=0.738 n=6}
_{Check Time}	_{34.42s (± 0.17%)}	_{34.35s (± 0.37%)}	_~	_34.11s	_34.44s	_{p=0.261 n=6}
_{Emit Time}	_{2.58s (± 2.23%)}	_{2.61s (± 3.24%)}	_~	_2.51s	_2.74s	_{p=0.689 n=6}
_{Total Time}	_{43.86s (± 0.25%)}	_{43.81s (± 0.44%)}	_~	_43.48s	_44.05s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,551	_258,591	_{+40 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,006	_105,018	_{+12 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,129k (± 0.01%)}	_{428,274k (± 0.02%)}	_{+146k (+ 0.03%)}	_428,204k	_428,453k	_{p=0.008 n=6}
_{Parse Time}	_{2.73s (± 0.54%)}	_{2.75s (± 0.56%)}	_~	_2.73s	_2.77s	_{p=0.102 n=6}
_{Bind Time}	_{1.10s (± 1.41%)}	_{1.10s (± 1.21%)}	_~	_1.09s	_1.12s	_{p=0.865 n=6}
_{Check Time}	_{15.37s (± 0.50%)}	_{15.36s (± 0.47%)}	_~	_15.27s	_15.45s	_{p=0.936 n=6}
_{Emit Time}	_{1.14s (± 0.66%)}	_{1.16s (± 1.93%)}	_~	_1.12s	_1.18s	_{p=0.062 n=6}
_{Total Time}	_{20.35s (± 0.49%)}	_{20.38s (± 0.39%)}	_~	_20.30s	_20.51s	_{p=0.470 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,866k (± 0.03%)}	_{369,822k (± 0.02%)}	_~	_369,725k	_369,933k	_{p=0.471 n=6}
_{Parse Time}	_{3.49s (± 0.35%)}	_{3.52s (± 0.70%)}	_{+0.03s (+ 0.72%)}	_3.49s	_3.56s	_{p=0.050 n=6}
_{Bind Time}	_{1.97s (± 1.19%)}	_{1.93s (± 1.26%)}	_{-0.04s (- 2.12%)}	_1.89s	_1.95s	_{p=0.015 n=6}
_{Check Time}	_{19.41s (± 0.15%)}	_{19.36s (± 0.41%)}	_~	_19.25s	_19.47s	_{p=0.259 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.87s (± 0.12%)}	_{24.80s (± 0.28%)}	_~	_24.71s	_24.89s	_{p=0.090 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₀	₁₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,842,923	_2,842,923	_~	_~	_~	_{p=1.000 n=6}
_Types	_963,434	_963,434	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,015,788k (± 0.00%)}	_{3,015,749k (± 0.00%)}	_~	_3,015,672k	_3,015,809k	_{p=0.261 n=6}
_{Parse Time}	_{13.84s (± 0.37%)}	_{13.81s (± 0.19%)}	_~	_13.77s	_13.85s	_{p=0.627 n=6}
_{Bind Time}	_{4.17s (± 0.15%)}	_{4.20s (± 1.91%)}	_~	_4.15s	_4.36s	_{p=0.802 n=6}
_{Check Time}	_{73.27s (± 0.23%)}	_{73.36s (± 0.53%)}	_~	_73.12s	_74.14s	_{p=0.936 n=6}
_{Emit Time}	_{23.67s (± 0.64%)}	_{23.61s (± 0.32%)}	_~	_23.49s	_23.69s	_{p=0.520 n=6}
_{Total Time}	_{114.94s (± 0.25%)}	_{114.98s (± 0.30%)}	_~	_114.70s	_115.66s	_{p=0.521 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,361	_266,361	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,554	_108,554	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,273k (± 0.00%)}	_{411,308k (± 0.02%)}	_~	_411,207k	_411,377k	_{p=0.298 n=6}
_{Parse Time}	_{3.85s (± 0.70%)}	_{3.83s (± 0.59%)}	_~	_3.82s	_3.88s	_{p=0.354 n=6}
_{Bind Time}	_{1.66s (± 1.10%)}	_{1.67s (± 0.31%)}	_~	_1.66s	_1.67s	_{p=0.548 n=6}
_{Check Time}	_{17.00s (± 0.16%)}	_{17.00s (± 0.43%)}	_~	_16.93s	_17.10s	_{p=0.468 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.52s (± 0.21%)}	_{22.50s (± 0.28%)}	_~	_22.44s	_22.60s	_{p=0.629 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,588	_525,588	_~	_~	_~	_{p=1.000 n=6}
_Types	_179,032	_179,032	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,968k (± 0.04%)}	_{463,259k (± 0.08%)}	_~	_462,840k	_463,635k	_{p=0.261 n=6}
_{Parse Time}	_{3.14s (± 0.90%)}	_{3.15s (± 0.81%)}	_~	_3.12s	_3.19s	_{p=0.418 n=6}
_{Bind Time}	_{1.19s (± 0.34%)}	_{1.18s (± 0.44%)}	_{-0.01s (- 0.70%)}	_1.18s	_1.19s	_{p=0.022 n=6}
_{Check Time}	_{18.07s (± 0.47%)}	_{18.11s (± 0.51%)}	_~	_17.95s	_18.22s	_{p=0.260 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.40s (± 0.30%)}	_{22.45s (± 0.45%)}	_~	_22.28s	_22.57s	_{p=0.261 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,418ms (± 0.57%)}	_{3,420ms (± 0.20%)}	_~	_3,407ms	_3,428ms	_{p=0.628 n=6}
_{Req 2 - geterr}	_{7,569ms (± 0.44%)}	_{7,594ms (± 0.51%)}	_~	_7,549ms	_7,653ms	_{p=0.471 n=6}
_{Req 3 - references}	_{434ms (± 1.20%)}	_{433ms (± 1.48%)}	_~	_423ms	_441ms	_{p=0.936 n=6}
_{Req 4 - navto}	_{340ms (± 0.71%)}	_{341ms (± 1.85%)}	_~	_334ms	_353ms	_{p=0.868 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{117ms (± 8.17%)}	_{116ms (± 4.65%)}	_~	_111ms	_125ms	_{p=0.627 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,605ms (± 0.45%)}	_{3,618ms (± 0.25%)}	_~	_3,602ms	_3,626ms	_{p=0.090 n=6}
_{Req 2 - geterr}	_{5,705ms (± 0.45%)}	_{5,714ms (± 0.20%)}	_~	_5,701ms	_5,728ms	_{p=0.936 n=6}
_{Req 3 - references}	_{449ms (± 0.82%)}	_{449ms (± 0.97%)}	_~	_444ms	_456ms	_{p=0.871 n=6}
_{Req 4 - navto}	_{342ms (± 1.54%)}	_{345ms (± 1.52%)}	_~	_341ms	_352ms	_{p=0.157 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{117ms (± 8.31%)}	_{117ms (± 7.84%)}	_~	_107ms	_125ms	_{p=1.000 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{6,117ms (± 0.55%)}	_{6,141ms (± 0.36%)}	_~	_6,115ms	_6,165ms	_{p=0.229 n=6}
_{Req 2 - geterr}	_{1,361ms (± 1.85%)}	_{1,355ms (± 1.02%)}	_~	_1,343ms	_1,380ms	_{p=0.810 n=6}
_{Req 3 - references}	_{115ms (± 6.04%)}	_{113ms (± 3.64%)}	_~	_109ms	_118ms	_{p=0.366 n=6}
_{Req 4 - navto}	_{534ms (± 6.92%)}	_{524ms (± 7.52%)}	_~	_496ms	_588ms	_{p=0.630 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{1,075ms (± 9.25%)}	_{1,057ms (±11.61%)}	_~	_986ms	_1,306ms	_{p=0.297 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{187.86ms (± 0.15%)}	_{187.50ms (± 0.15%)}	_{-0.35ms (- 0.19%)}	_186.09ms	_191.31ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{360.95ms (± 0.26%)}	_{361.33ms (± 0.27%)}	_{+0.38ms (+ 0.10%)}	_353.18ms	_368.84ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{287.28ms (± 0.27%)}	_{287.08ms (± 0.27%)}	_{-0.20ms (- 0.07%)}	_280.39ms	_290.56ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{288.08ms (± 0.29%)}	_{288.03ms (± 0.28%)}	_~	_280.81ms	_294.41ms	_{p=0.225 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Wesley Wigham (weswigham) · 2024-05-31T20:53:25Z

Jake Bailey (@jakebailey) I've minimized the diff (and swapped them all to only improvements) by adding a small change to explicitly add positions for type parameter names. I think the original change caused us to stop attaching positions to them spuriously, and now we actually do it explicitly, so there's a smaller diff, but there is a diff of parameter names where we now actually have locations. Also a fourslash test update that shows a new comment getting preserved.

Jake Bailey (jakebailey) · 2024-05-31T21:26:07Z

+import {fn} from "./a";
+export const m = { 
+ /**
+ * leading doc for prop
+ */ 
+ prop: 1
+}
+
+
+export const x = { p: fn }; 


This test doesn't seem like it tests #58698; am I missing something?

Hm, maybe I'm just wrong given the issue was about pulling comments from other files, yeah.

Jake Bailey (jakebailey) · 2024-05-31T21:34:48Z

TypeScript Bot (@typescript-bot) perf test this faster

TypeScript Bot (typescript-bot) · 2024-05-31T21:34:51Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

Jake Bailey (jakebailey)

LGTM assuming perf remains unchanged.

TypeScript Bot (typescript-bot) · 2024-05-31T22:10:08Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,601k (± 0.94%)}	_{193,543k (± 0.98%)}	_~	_192,298k	_196,074k	_{p=0.688 n=6}
_{Parse Time}	_{1.31s (± 0.62%)}	_{1.30s (± 0.58%)}	_~	_1.29s	_1.31s	_{p=0.206 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.59s (± 0.39%)}	_{9.58s (± 0.50%)}	_~	_9.53s	_9.65s	_{p=0.688 n=6}
_{Emit Time}	_{2.75s (± 0.42%)}	_{2.76s (± 0.58%)}	_~	_2.74s	_2.78s	_{p=0.316 n=6}
_{Total Time}	_{14.36s (± 0.31%)}	_{14.35s (± 0.33%)}	_~	_14.32s	_14.44s	_{p=0.936 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,109	_944,109	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,049	_407,049	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,175k (± 0.00%)}	_{1,222,155k (± 0.01%)}	_~	_1,222,039k	_1,222,250k	_{p=0.471 n=6}
_{Parse Time}	_{8.07s (± 0.35%)}	_{8.04s (± 0.39%)}	_~	_7.98s	_8.06s	_{p=0.122 n=6}
_{Bind Time}	_{2.22s (± 0.53%)}	_{2.23s (± 0.52%)}	_~	_2.21s	_2.24s	_{p=0.365 n=6}
_{Check Time}	_{36.25s (± 0.31%)}	_{36.26s (± 0.33%)}	_~	_36.07s	_36.41s	_{p=0.936 n=6}
_{Emit Time}	_{18.10s (± 0.62%)}	_{18.02s (± 0.44%)}	_~	_17.91s	_18.14s	_{p=0.229 n=6}
_{Total Time}	_{64.64s (± 0.16%)}	_{64.55s (± 0.27%)}	_~	_64.31s	_64.82s	_{p=0.572 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,051,460	_2,051,460	_~	_~	_~	_{p=1.000 n=6}
_Types	_899,446	_899,446	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,065,705k (± 0.01%)}	_{2,065,648k (± 0.01%)}	_~	_2,065,488k	_2,065,811k	_{p=0.298 n=6}
_{Parse Time}	_{8.10s (± 0.23%)}	_{8.08s (± 0.22%)}	_~	_8.06s	_8.11s	_{p=0.121 n=6}
_{Bind Time}	_{2.74s (± 0.74%)}	_{2.75s (± 1.23%)}	_~	_2.70s	_2.79s	_{p=0.935 n=6}
_{Check Time}	_{81.94s (± 0.58%)}	_{82.18s (± 0.39%)}	_~	_81.76s	_82.46s	_{p=0.332 n=6}
_{Emit Time}	_{0.17s (± 3.32%)}	_{0.17s (± 2.42%)}	_~	_0.16s	_0.17s	_{p=0.282 n=6}
_{Total Time}	_{92.95s (± 0.52%)}	_{93.18s (± 0.34%)}	_~	_92.76s	_93.51s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,666	_1,229,707	_{+41 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,892	_260,904	_{+12 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,402,475k (± 3.26%)}	_{2,351,996k (± 0.04%)}	_~	_2,350,837k	_2,353,107k	_{p=0.378 n=6}
_{Parse Time}	_{7.46s (± 0.90%)}	_{7.42s (± 0.76%)}	_~	_7.37s	_7.51s	_{p=0.336 n=6}
_{Bind Time}	_{2.80s (± 0.90%)}	_{2.82s (± 0.35%)}	_~	_2.81s	_2.83s	_{p=0.195 n=6}
_{Check Time}	_{49.45s (± 0.41%)}	_{49.61s (± 0.65%)}	_~	_49.18s	_50.18s	_{p=0.471 n=6}
_{Emit Time}	_{3.76s (± 4.56%)}	_{3.80s (± 2.17%)}	_~	_3.68s	_3.92s	_{p=0.230 n=6}
_{Total Time}	_{63.48s (± 0.63%)}	_{63.67s (± 0.56%)}	_~	_63.29s	_64.33s	_{p=0.378 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,666	_1,229,707	_{+41 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,892	_260,904	_{+12 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,478,063k (± 3.14%)}	_{2,478,139k (± 3.13%)}	_~	_2,426,955k	_2,579,274k	_{p=0.936 n=6}
_{Parse Time}	_{6.24s (± 0.52%)}	_{6.25s (± 0.41%)}	_~	_6.21s	_6.29s	_{p=0.873 n=6}
_{Bind Time}	_{2.01s (± 0.81%)}	_{2.02s (± 0.75%)}	_~	_1.99s	_2.03s	_{p=0.462 n=6}
_{Check Time}	_{40.50s (± 0.21%)}	_{40.47s (± 0.27%)}	_~	_40.34s	_40.62s	_{p=0.470 n=6}
_{Emit Time}	_{3.02s (± 2.57%)}	_{3.06s (± 2.49%)}	_~	_2.99s	_3.20s	_{p=0.423 n=6}
_{Total Time}	_{51.79s (± 0.25%)}	_{51.82s (± 0.30%)}	_~	_51.65s	_52.00s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,551	_258,592	_{+41 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,999	_105,011	_{+12 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,176k (± 0.02%)}	_{428,239k (± 0.01%)}	_~	_428,212k	_428,280k	_{p=0.199 n=6}
_{Parse Time}	_{4.08s (± 0.59%)}	_{4.08s (± 0.48%)}	_~	_4.06s	_4.11s	_{p=0.570 n=6}
_{Bind Time}	_{1.62s (± 1.39%)}	_{1.63s (± 1.62%)}	_~	_1.58s	_1.65s	_{p=0.627 n=6}
_{Check Time}	_{22.42s (± 0.42%)}	_{22.40s (± 0.43%)}	_~	_22.31s	_22.57s	_{p=0.687 n=6}
_{Emit Time}	_{1.69s (± 1.10%)}	_{1.71s (± 1.13%)}	_~	_1.68s	_1.73s	_{p=0.106 n=6}
_{Total Time}	_{29.80s (± 0.29%)}	_{29.82s (± 0.31%)}	_~	_29.69s	_29.97s	_{p=0.748 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,873k (± 0.02%)}	_{369,766k (± 0.02%)}	_{-107k (- 0.03%)}	_369,690k	_369,854k	_{p=0.045 n=6}
_{Parse Time}	_{3.51s (± 0.59%)}	_{3.49s (± 0.49%)}	_~	_3.47s	_3.52s	_{p=0.121 n=6}
_{Bind Time}	_{1.94s (± 0.95%)}	_{1.94s (± 0.89%)}	_~	_1.91s	_1.96s	_{p=0.569 n=6}
_{Check Time}	_{19.41s (± 0.41%)}	_{19.42s (± 0.24%)}	_~	_19.36s	_19.47s	_{p=0.574 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.85s (± 0.26%)}	_{24.85s (± 0.22%)}	_~	_24.76s	_24.89s	_{p=0.686 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₀	₁₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,843,069	_2,843,069	_~	_~	_~	_{p=1.000 n=6}
_Types	_963,472	_963,472	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,015,828k (± 0.00%)}	_{3,015,850k (± 0.00%)}	_~	_3,015,765k	_3,015,928k	_{p=0.575 n=6}
_{Parse Time}	_{13.86s (± 0.36%)}	_{13.85s (± 0.23%)}	_~	_13.82s	_13.89s	_{p=1.000 n=6}
_{Bind Time}	_{4.21s (± 2.19%)}	_{4.19s (± 2.32%)}	_~	_4.14s	_4.39s	_{p=0.357 n=6}
_{Check Time}	_{73.78s (± 1.93%)}	_{73.95s (± 2.06%)}	_~	_72.84s	_77.00s	_{p=0.471 n=6}
_{Emit Time}	_{22.99s (± 6.51%)}	_{23.02s (± 6.45%)}	_~	_20.00s	_23.90s	_{p=1.000 n=6}
_{Total Time}	_{114.83s (± 0.23%)}	_{115.01s (± 0.36%)}	_~	_114.37s	_115.46s	_{p=0.378 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,361	_266,361	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,554	_108,554	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,489k (± 0.02%)}	_{411,433k (± 0.02%)}	_~	_411,363k	_411,568k	_{p=0.378 n=6}
_{Parse Time}	_{4.78s (± 1.04%)}	_{4.77s (± 0.68%)}	_~	_4.74s	_4.83s	_{p=0.872 n=6}
_{Bind Time}	_{2.08s (± 0.79%)}	_{2.08s (± 0.61%)}	_~	_2.07s	_2.10s	_{p=0.567 n=6}
_{Check Time}	_{21.20s (± 0.53%)}	_{21.08s (± 0.25%)}	_~	_21.02s	_21.16s	_{p=0.063 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.07s (± 0.29%)}	_{27.92s (± 0.21%)}	_{-0.14s (- 0.51%)}	_27.84s	_28.00s	_{p=0.020 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,588	_525,588	_~	_~	_~	_{p=1.000 n=6}
_Types	_179,032	_179,032	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{463,316k (± 0.07%)}	_{463,353k (± 0.08%)}	_~	_462,839k	_463,657k	_{p=0.873 n=6}
_{Parse Time}	_{2.62s (± 0.31%)}	_{2.62s (± 0.24%)}	_~	_2.61s	_2.63s	_{p=0.599 n=6}
_{Bind Time}	_{0.99s (± 0.52%)}	_{0.99s (± 0.52%)}	_~	_0.99s	_1.00s	_{p=1.000 n=6}
_{Check Time}	_{15.23s (± 0.58%)}	_{15.24s (± 0.40%)}	_~	_15.14s	_15.33s	_{p=0.568 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.85s (± 0.43%)}	_{18.85s (± 0.31%)}	_~	_18.75s	_18.93s	_{p=0.419 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

* upstream/main: (37 commits) Added NoTruncation flag to completions (microsoft#58719) Clone node to remove location even when it has been modified if needed (microsoft#58706) Properly account for `this` argument in intersection apparent type caching (microsoft#58677) Fix: Include Values of Script Extensions for Unicode Property Value Expressions in Regular Expressions (microsoft#58615) In `reScanSlashToken` use `charCodeChecked` not `codePointChecked` (microsoft#58727) Shorten error spans for errors reported on constructor declarations (microsoft#58061) Mark file as skips typechecking if it contains ts-nocheck (microsoft#58593) Fixed an issue with broken `await using` declarations in `for of` loops (microsoft#56466) Do not expand type references in keyof and index access (microsoft#58715) Improve the performance of isolatedDeclarations quickfix (microsoft#58722) Unwrap `NoInfer` types when narrowing (microsoft#58292) Recover from type reuse errors by falling back to inferred type printing (microsoft#58720) Fixing self import (microsoft#58718) Enable JS emit for noCheck and noCheck for transpileModule (microsoft#58364) Revert PR 55371 (microsoft#58702) Update dependencies (microsoft#58639) Fix baselines after PR 58621 (microsoft#58705) Do not infer `yield*` type from contextual `TReturn` (microsoft#58621) `await using` normative changes (microsoft#58624) Handling statements from a known source file (microsoft#58679) ...

Clone node to remove location even when it has been modified if needed
e85543f

TypeScript Bot (typescript-bot) assigned Wesley Wigham (weswigham)May 29, 2024

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 29, 2024

Wesley Wigham (weswigham) added 2 commits May 30, 2024 13:41

Merge branch 'main' into textrange-to-original-node
1d27384

Accept baselines
a8f73f8

Wesley Wigham (weswigham)force-pushed the textrange-to-original-node branch from e58f95a to a8f73f8Compare May 30, 2024 21:09

Wesley Wigham (weswigham) marked this pull request as ready for review May 30, 2024 23:26

Wesley Wigham (weswigham) added 2 commits May 31, 2024 12:33

Comment & small cleanup
9927a3c

Merge branch 'main' into textrange-to-original-node
e84e554

Tack locations onto copied type parameter names explicitly
9400b2e

Jake Bailey (jakebailey) reviewed May 31, 2024
View reviewed changes

Jake Bailey (jakebailey) approved these changes May 31, 2024
View reviewed changes

Wesley Wigham (weswigham) merged commit d4976c0 into microsoft:mainMay 31, 2024

Bruce Pascoe (fatcerberus) mentioned this pull request Jun 9, 2024
[nightly] Syntactically invalid declaration files emitted under extremely specific conditions #58807
Closed

michaelm (MichaelMitchell-at) mentioned this pull request Feb 21, 2025
Reused nodes leak comment ranges for other files, leading to bad declaration emit #61239
Closed

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Uh oh!

Conversation

Wesley Wigham (weswigham) commented May 29, 2024

Uh oh!

Jake Bailey (jakebailey) commented May 31, 2024

Uh oh!

Jake Bailey (jakebailey) commented May 31, 2024

Uh oh!

Jake Bailey (jakebailey) commented May 31, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented May 31, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 31, 2024

tsc

tsserver

startup

Uh oh!

Wesley Wigham (weswigham) commented May 31, 2024

Uh oh!

Jake Bailey (jakebailey)May 31, 2024

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey)May 31, 2024

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey) commented May 31, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented May 31, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jake Bailey (jakebailey) left a comment

Choose a reason for hiding this comment

Uh oh!

TypeScript Bot (typescript-bot) commented May 31, 2024

tsc

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TypeScript Bot (typescript-bot) commented May 31, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented May 31, 2024•
edited
Loading