Analyze control flow effects of lambdas passed as arguments by ahejlsberg · Pull Request #58729 · microsoft/TypeScript

Anders Hejlsberg (ahejlsberg) · 2024-05-31T22:38:49Z

This PR introduces a new immediate modifier that can be applied to callback parameters to indicate that control flow analysis should assume that function expressions or arrow functions (in the following called lambda expressions) passed as arguments in a function call may be invoked synchronously during that call. For example:

declarefunctionmystery(immediatecb: ()=>void): void;letx: string|number="OK";x;// stringmystery(()=>{x=10;});x;// string | numberif(x===10){// Error without 'immediate' modifier}

Without the immediate modifier, control flow analysis will assume that the lambda expression is never invoked synchronously and thus will consider the type of x to be string following the call. With the immediate modifier, control flow analysis assumes that the lambda expression may have been invoked synchronously and thus considers the type of x to be string | number following the call.

It an error to apply the immediate modifier to anything but a parameter with a type that permits functions. Async arrow functions, async function expressions, and generator function expressions are always assumed to be deferred, regardless of whether their corresponding parameter includes an immediate modifier.

In JavaScript files, an immediate callback parameter can be declared using an /** @immediate */ JSDoc annotation:

/** * @param {() => void} cb */functioncallNow(/** @immediate */cb){ ... }

Since the immediate modifier is considered an error by earlier versions of TypeScript, it isn't possible to add immediate modifiers to frameworks and libraries without also requiring the latest version of the compiler. The compiler therefore also recognizes /** @immediate */ JSDoc comments in TypeScript files such that they can be used in cases where backwards compatibility matters. However, use of immediate modifiers is recommended whenever possible.

NOTE: This PR initially changed control flow analysis to assume possibly-immediately-called semantics by default and implemented a deferred modifier to indicate never-immediately-called semantics. While technically more sound (absent knowledge of whether or when a callback is called, it is safest and most conservative to assume it may have been called), this turned out to require too much remediation in existing code. The PR now preserves the default never-immediately-called semantics and allows code to opt into possibly-immediately-called analysis using the immediate modifier.

Fixes#11498.
Fixes#15380.
Fixes#57880.

Anders Hejlsberg (ahejlsberg) · 2024-05-31T22:39:06Z

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) · 2024-05-31T22:39:10Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-05-31T22:59:55Z

Hey Anders Hejlsberg (@ahejlsberg), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-05-31T23:03:24Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the user tests with tsc comparing main and refs/pull/58729/merge:

Something interesting changed - please have a look.

Details

enhanced-resolve

/mnt/ts_downloads/_/m/enhanced-resolve/tsconfig.json

[MISSING] error TS2339: Property 'replace' does not exist on type 'never'.
- /mnt/ts_downloads/_/m/enhanced-resolve/node_modules/enhanced-resolve/lib/concord.js(149,24)
- /mnt/ts_downloads/_/m/enhanced-resolve/node_modules/enhanced-resolve/lib/concord.js(188,17)

pyright

/mnt/ts_downloads/_/m/pyright/build.sh

[NEW] error TS18048: 'cacheEntry' is possibly 'undefined'.
- /mnt/ts_downloads/_/m/pyright/pyright: ../pyright-internal/src/analyzer/codeFlowEngine.ts(951,25)
- /mnt/ts_downloads/_/m/pyright/pyright: ../pyright-internal/src/analyzer/codeFlowEngine.ts(1064,41)
- /mnt/ts_downloads/_/m/pyright/pyright-internal: src/analyzer/codeFlowEngine.ts(951,25)
- /mnt/ts_downloads/_/m/pyright/pyright-internal: src/analyzer/codeFlowEngine.ts(1064,41)
- /mnt/ts_downloads/_/m/pyright/vscode-pyright: ../pyright-internal/src/analyzer/codeFlowEngine.ts(951,25)
- /mnt/ts_downloads/_/m/pyright/vscode-pyright: ../pyright-internal/src/analyzer/codeFlowEngine.ts(1064,41)

uglify-js

/mnt/ts_downloads/_/m/uglify-js/tsconfig.json

[MISSING] error TS18048: 'ldef' is possibly 'undefined'.
- /mnt/ts_downloads/_/m/uglify-js/node_modules/uglify-js/lib/compress.js(6753,56)

webpack

tsconfig.types.json

[MISSING] error TS2349: This expression is not callable.
- lib/cache/PackFileCacheStrategy.js#L1243

xterm.js

src/tsconfig-library-base.json

[NEW] error TS2322: Type 'boolean | undefined' is not assignable to type 'boolean'.
- src/browser/services/CoreBrowserService.ts#L62 in src/tsconfig-library-base.json

TypeScript Bot (typescript-bot) · 2024-05-31T23:21:48Z

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,243	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{192,920k (± 0.75%)}	_{192,999k (± 0.75%)}	_{+79k (+ 0.04%)}	_192,402k	_195,952k	_{p=0.045 n=6}
_{Parse Time}	_{1.95s (± 0.96%)}	_{1.95s (± 0.53%)}	_~	_1.94s	_1.97s	_{p=0.317 n=6}
_{Bind Time}	_{1.08s (± 0.70%)}	_{1.10s (± 0.74%)}	_{+0.02s (+ 2.00%)}	_1.09s	_1.11s	_{p=0.007 n=6}
_{Check Time}	_{14.05s (± 0.46%)}	_{14.15s (± 0.52%)}	_{+0.10s (+ 0.70%)}	_14.05s	_14.27s	_{p=0.037 n=6}
_{Emit Time}	_{4.07s (± 1.00%)}	_{4.06s (± 0.53%)}	_~	_4.03s	_4.09s	_{p=0.223 n=6}
_{Total Time}	_{21.14s (± 0.18%)}	_{21.26s (± 0.32%)}	_{+0.12s (+ 0.54%)}	_21.17s	_21.37s	_{p=0.010 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₉	_{🔻+4 (+80.00%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_944,109	_944,283	_{+174 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_407,049	_407,127	_{+78 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,222,154k (± 0.00%)}	_{1,223,819k (± 0.00%)}	_{+1,664k (+ 0.14%)}	_1,223,752k	_1,223,903k	_{p=0.005 n=6}
_{Parse Time}	_{8.05s (± 0.57%)}	_{8.07s (± 0.67%)}	_~	_8.02s	_8.16s	_{p=0.809 n=6}
_{Bind Time}	_{2.23s (± 0.62%)}	_{2.28s (± 0.72%)}	_{+0.05s (+ 2.32%)}	_2.26s	_2.30s	_{p=0.005 n=6}
_{Check Time}	_{36.28s (± 0.12%)}	_{36.72s (± 0.27%)}	_{+0.43s (+ 1.19%)}	_36.62s	_36.90s	_{p=0.005 n=6}
_{Emit Time}	_{17.94s (± 0.68%)}	_{18.11s (± 0.50%)}	_{+0.17s (+ 0.95%)}	_18.01s	_18.25s	_{p=0.030 n=6}
_{Total Time}	_{64.49s (± 0.28%)}	_{65.18s (± 0.29%)}	_{+0.68s (+ 1.06%)}	_64.97s	_65.46s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,051,460	_2,051,489	_{+29 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_899,446	_899,469	_{+23 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,065,603k (± 0.01%)}	_{2,065,874k (± 0.00%)}	_{+271k (+ 0.01%)}	_2,065,749k	_2,065,985k	_{p=0.013 n=6}
_{Parse Time}	_{8.10s (± 0.46%)}	_{8.11s (± 0.21%)}	_~	_8.09s	_8.13s	_{p=1.000 n=6}
_{Bind Time}	_{2.75s (± 0.88%)}	_{2.77s (± 0.84%)}	_~	_2.74s	_2.80s	_{p=0.124 n=6}
_{Check Time}	_{81.77s (± 0.36%)}	_{82.13s (± 0.44%)}	_~	_81.76s	_82.71s	_{p=0.066 n=6}
_{Emit Time}	_{0.16s (± 3.16%)}	_{0.17s (± 3.10%)}	_~	_0.16s	_0.17s	_{p=0.311 n=6}
_{Total Time}	_{92.78s (± 0.28%)}	_{93.18s (± 0.40%)}	_{+0.39s (+ 0.43%)}	_92.82s	_93.78s	_{p=0.045 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,708	_1,229,781	_{+73 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,904	_260,917	_{+13 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,351,266k (± 0.02%)}	_{2,350,890k (± 0.06%)}	_~	_2,349,360k	_2,353,094k	_{p=0.575 n=6}
_{Parse Time}	_{4.98s (± 0.91%)}	_{4.98s (± 0.85%)}	_~	_4.94s	_5.05s	_{p=0.936 n=6}
_{Bind Time}	_{1.91s (± 0.55%)}	_{1.93s (± 0.39%)}	_{+0.03s (+ 1.40%)}	_1.92s	_1.94s	_{p=0.006 n=6}
_{Check Time}	_{34.12s (± 0.30%)}	_{34.20s (± 0.17%)}	_~	_34.11s	_34.27s	_{p=0.109 n=6}
_{Emit Time}	_{2.56s (± 1.65%)}	_{2.63s (± 2.41%)}	_~	_2.56s	_2.72s	_{p=0.066 n=6}
_{Total Time}	_{43.55s (± 0.21%)}	_{43.78s (± 0.22%)}	_{+0.22s (+ 0.51%)}	_43.63s	_43.89s	_{p=0.013 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,708	_1,229,781	_{+73 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,904	_260,917	_{+13 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,452,360k (± 2.48%)}	_{2,428,222k (± 0.04%)}	_~	_2,427,090k	_2,429,614k	_{p=0.810 n=6}
_{Parse Time}	_{6.24s (± 0.45%)}	_{6.26s (± 0.55%)}	_~	_6.22s	_6.30s	_{p=0.471 n=6}
_{Bind Time}	_{2.01s (± 0.96%)}	_{2.20s (± 4.72%)}	_{🔻+0.19s (+ 9.28%)}	_2.05s	_2.27s	_{p=0.005 n=6}
_{Check Time}	_{40.47s (± 0.33%)}	_{40.48s (± 0.93%)}	_~	_40.18s	_41.00s	_{p=0.378 n=6}
_{Emit Time}	_{3.07s (± 2.70%)}	_{3.05s (± 1.79%)}	_~	_2.99s	_3.11s	_{p=0.575 n=6}
_{Total Time}	_{51.82s (± 0.25%)}	_{52.02s (± 0.49%)}	_~	_51.71s	_52.35s	_{p=0.230 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,593	_258,618	_{+25 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,011	_105,024	_{+13 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,227k (± 0.01%)}	_{428,434k (± 0.01%)}	_{+207k (+ 0.05%)}	_428,406k	_428,469k	_{p=0.005 n=6}
_{Parse Time}	_{4.06s (± 0.57%)}	_{4.08s (± 0.38%)}	_~	_4.07s	_4.10s	_{p=0.210 n=6}
_{Bind Time}	_{1.63s (± 0.92%)}	_{1.65s (± 1.31%)}	_~	_1.62s	_1.68s	_{p=0.124 n=6}
_{Check Time}	_{22.42s (± 0.40%)}	_{22.43s (± 0.20%)}	_~	_22.37s	_22.47s	_{p=0.809 n=6}
_{Emit Time}	_{1.70s (± 1.93%)}	_{1.71s (± 1.41%)}	_~	_1.68s	_1.75s	_{p=0.466 n=6}
_{Total Time}	_{29.81s (± 0.35%)}	_{29.88s (± 0.21%)}	_~	_29.80s	_29.95s	_{p=0.295 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,736	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{369,857k (± 0.03%)}	_{369,994k (± 0.04%)}	_~	_369,826k	_370,188k	_{p=0.173 n=6}
_{Parse Time}	_{2.85s (± 0.79%)}	_{2.85s (± 0.85%)}	_~	_2.82s	_2.87s	_{p=0.808 n=6}
_{Bind Time}	_{1.59s (± 0.97%)}	_{1.60s (± 0.65%)}	_~	_1.59s	_1.62s	_{p=0.118 n=6}
_{Check Time}	_{15.73s (± 0.39%)}	_{15.76s (± 0.27%)}	_~	_15.71s	_15.82s	_{p=0.746 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.17s (± 0.36%)}	_{20.21s (± 0.31%)}	_~	_20.12s	_20.29s	_{p=0.377 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₀	₉₀	_{🔻+80 (+800.00%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_2,842,991	_2,847,064	_{+4,073 (+ 0.14%)}	_~	_~	_{p=0.001 n=6}
_Types	_963,472	_964,365	_{+893 (+ 0.09%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,015,847k (± 0.00%)}	_{3,019,578k (± 0.00%)}	_{+3,732k (+ 0.12%)}	_3,019,506k	_3,019,681k	_{p=0.005 n=6}
_{Parse Time}	_{17.02s (± 0.26%)}	_{17.07s (± 0.32%)}	_~	_17.02s	_17.16s	_{p=0.065 n=6}
_{Bind Time}	_{5.16s (± 2.45%)}	_{5.21s (± 1.76%)}	_~	_5.17s	_5.40s	_{p=0.226 n=6}
_{Check Time}	_{89.08s (± 0.11%)}	_{91.48s (± 1.87%)}	_{+2.41s (+ 2.70%)}	_90.25s	_94.91s	_{p=0.005 n=6}
_{Emit Time}	_{28.89s (± 0.78%)}	_{28.10s (± 6.97%)}	_~	_24.11s	_29.07s	_{p=0.936 n=6}
_{Total Time}	_{140.15s (± 0.15%)}	_{141.87s (± 0.36%)}	_{+1.72s (+ 1.23%)}	_141.29s	_142.45s	_{p=0.005 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,361	_266,362	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_108,554	_108,557	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{411,503k (± 0.02%)}	_{411,827k (± 0.04%)}	_{+324k (+ 0.08%)}	_411,629k	_412,030k	_{p=0.005 n=6}
_{Parse Time}	_{4.83s (± 0.54%)}	_{4.78s (± 0.70%)}	_{-0.05s (- 1.04%)}	_4.73s	_4.83s	_{p=0.028 n=6}
_{Bind Time}	_{2.09s (± 0.58%)}	_{2.12s (± 0.42%)}	_{+0.03s (+ 1.60%)}	_2.11s	_2.13s	_{p=0.005 n=6}
_{Check Time}	_{21.13s (± 0.16%)}	_{21.29s (± 0.58%)}	_~	_21.07s	_21.41s	_{p=0.065 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.05s (± 0.18%)}	_{28.19s (± 0.38%)}	_~	_27.99s	_28.28s	_{p=0.066 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,588	_525,588	_~	_~	_~	_{p=1.000 n=6}
_Types	_179,032	_179,032	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{463,503k (± 0.07%)}	_{463,672k (± 0.06%)}	_~	_463,176k	_463,934k	_{p=0.378 n=6}
_{Parse Time}	_{2.62s (± 0.45%)}	_{2.62s (± 0.16%)}	_~	_2.62s	_2.63s	_{p=0.787 n=6}
_{Bind Time}	_{0.99s (± 0.41%)}	_{1.00s (± 0.54%)}	_{+0.01s (+ 1.34%)}	_1.00s	_1.01s	_{p=0.006 n=6}
_{Check Time}	_{15.24s (± 0.62%)}	_{15.33s (± 0.37%)}	_~	_15.27s	_15.41s	_{p=0.065 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.85s (± 0.48%)}	_{18.96s (± 0.30%)}	_~	_18.89s	_19.03s	_{p=0.054 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Bruce Pascoe (fatcerberus) · 2024-05-31T23:41:47Z

I feel like this is just going to flip the problem on its head in the end - instead of people complaining because their immediately-invoked callbacks didn't affect narrowing, an equal number of people will probably now complain instead that callbacks they know will be called out-of-band do affect narrowing. The goalposts don't even move really - the other team just gets possession is all 😄

TypeScript Bot (typescript-bot) · 2024-06-01T00:11:33Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/58729/merge:

Something interesting changed - please have a look.

Details

apollographql/apollo-client

1 of 12 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS7022: 'match' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.
- src/cache/inmemory/policies.ts#L746

src/tsconfig.json

error TS7022: 'match' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.
- src/cache/inmemory/policies.ts#L746

conwnet/github1s

extensions/github1s/tsconfig.json

error TS2531: Object is possibly 'null'.
- extensions/github1s/src/adapters/github1s/authentication.ts#L132

electron-react-boilerplate/electron-react-boilerplate

tsconfig.json

error TS2345: Argument of type 'BrowserWindow | null' is not assignable to parameter of type 'BrowserWindow'.
- src/main/main.ts#L101
error TS18047: 'mainWindow' is possibly 'null'.
- src/main/main.ts#L105

highcharts/highcharts

25 of 26 projects failed to build with the old tsc and were ignored

test/ts-node-unit-tests/tsconfig.json

error TS2345: Argument of type 'string | void' is not assignable to parameter of type 'string'.
- test/ts-node-unit-tests/benchmark-compare.ts#L232

labring/FastGPT

projects/app/tsconfig.json

error TS18047: 'global.pgClient' is possibly 'null'.
- packages/service/common/vectorStore/pg/index.ts#L34
error TS2322: Type 'Pool | null' is not assignable to type 'Pool'.
- packages/service/common/vectorStore/pg/index.ts#L36

packages/service/tsconfig.json

error TS18047: 'global.pgClient' is possibly 'null'.
- packages/service/common/vectorStore/pg/index.ts#L34
error TS2322: Type 'Pool | null' is not assignable to type 'Pool'.
- packages/service/common/vectorStore/pg/index.ts#L36

lyswhut/lx-music-desktop

1 of 6 projects failed to build with the old tsc and were ignored

src/main/tsconfig.json

error TS18047: 'browserWindow' is possibly 'null'.

microsoft/vscode

7 of 54 projects failed to build with the old tsc and were ignored

extensions/vscode-test-resolver/tsconfig.json

error TS18048: 'extHostProcess' is possibly 'undefined'.
- extensions/vscode-test-resolver/src/extension.ts#L194

extensions/vscode-api-tests/tsconfig.json

error TS7022: 'created' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.

reduxjs/redux-toolkit

11 of 32 projects failed to build with the old tsc and were ignored

packages/toolkit/tsconfig.build.json

error TS2722: Cannot invoke an object which is possibly 'undefined'.
- packages/toolkit/src/query/core/buildMiddleware/cacheLifecycle.ts#L324
error TS18048: 'onCacheEntryAdded' is possibly 'undefined'.
- packages/toolkit/src/query/core/buildMiddleware/cacheLifecycle.ts#L324

subquery/subql

2 of 6 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2345: Argument of type 'ParentProject | undefined' is not assignable to parameter of type 'ParentProject'.
- packages/node-core/src/configure/ProjectUpgrade.service.ts#L338 in packages/node-core/tsconfig.json
error TS18048: 'currentProject.parent' is possibly 'undefined'.
- packages/node-core/src/configure/ProjectUpgrade.service.ts#L340 in packages/node-core/tsconfig.json

tinacms/tinacms

12 of 24 projects failed to build with the old tsc and were ignored

packages/@tinacms/mdx/tsconfig.json

error TS2345: Argument of type '{ type: "inlineCode"; value: string; }' is not assignable to parameter of type 'Text'.
- packages/@tinacms/mdx/src/next/stringify/marks.ts#L239
- packages/@tinacms/mdx/src/stringify/marks.ts#L236

Bruce Pascoe (fatcerberus) · 2024-06-01T01:19:38Z

https://github.com/electron-react-boilerplate/electron-react-boilerplate/blob/83b826fa9d810e26da7b5f17b4ed543e5f52bb17/src/main/main.ts#L101 is a good example

Anders Hejlsberg (ahejlsberg) · 2024-06-01T16:26:34Z

I think it's clear that there's no one-size-fits-all answer to whether effects of executing lambda arguments should be reflected in CFA types. Our current assumption is that lambdas are never executed synchronously. This PR experiments with the assumption they're possibly executed, which, given no additional information about the function to which the lambda arguments are passed, is definitely a more sound assumption. Also, the PR validates an implementation strategy and gives us data on the performance cost of analyzing lambda effects.

I would nice to avoid modifiers (like sync, immediate, deferred) on callback parameters, but in the end it may be unavoidable. Modifiers come with the added complication that CFA will need to resolve the function's type, which may in turn lead to circularities.

Anders Hejlsberg (ahejlsberg) · 2024-06-03T22:42:13Z

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) · 2024-06-03T22:42:16Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-06-03T23:03:49Z

Hey Anders Hejlsberg (@ahejlsberg), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-06-03T23:18:33Z

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,243	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{193,572k (± 1.01%)}	_{193,028k (± 0.73%)}	_~	_192,339k	_195,911k	_{p=0.378 n=6}
_{Parse Time}	_{1.29s (± 0.94%)}	_{1.29s (± 0.81%)}	_~	_1.28s	_1.31s	_{p=0.868 n=6}
_{Bind Time}	_0.72s	_0.74s	_{+0.02s (+ 2.78%)}	_~	_~	_{p=0.001 n=6}
_{Check Time}	_{9.57s (± 0.23%)}	_{9.59s (± 0.70%)}	_~	_9.48s	_9.66s	_{p=0.468 n=6}
_{Emit Time}	_{2.76s (± 0.20%)}	_{2.75s (± 0.74%)}	_~	_2.72s	_2.78s	_{p=0.100 n=6}
_{Total Time}	_{14.35s (± 0.16%)}	_{14.37s (± 0.48%)}	_~	_14.25s	_14.44s	_{p=0.195 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₉	_{🔻+4 (+80.00%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_944,109	_944,283	_{+174 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_407,049	_407,096	_{+47 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,222,193k (± 0.00%)}	_{1,223,909k (± 0.00%)}	_{+1,717k (+ 0.14%)}	_1,223,856k	_1,223,966k	_{p=0.005 n=6}
_{Parse Time}	_{6.80s (± 0.47%)}	_{6.79s (± 0.50%)}	_~	_6.74s	_6.84s	_{p=0.420 n=6}
_{Bind Time}	_{1.88s (± 0.29%)}	_{1.91s (± 0.57%)}	_{+0.03s (+ 1.87%)}	_1.89s	_1.92s	_{p=0.004 n=6}
_{Check Time}	_{31.38s (± 0.34%)}	_{31.71s (± 0.56%)}	_{+0.34s (+ 1.07%)}	_31.49s	_31.98s	_{p=0.006 n=6}
_{Emit Time}	_{15.21s (± 0.97%)}	_{15.20s (± 0.32%)}	_~	_15.12s	_15.24s	_{p=0.575 n=6}
_{Total Time}	_{55.26s (± 0.23%)}	_{55.60s (± 0.41%)}	_{+0.34s (+ 0.62%)}	_55.33s	_55.97s	_{p=0.013 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,054,061	_2,054,090	_{+29 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_899,813	_899,836	_{+23 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,067,140k (± 0.01%)}	_{2,067,295k (± 0.01%)}	_~	_2,067,100k	_2,067,509k	_{p=0.336 n=6}
_{Parse Time}	_{8.10s (± 0.18%)}	_{8.13s (± 0.34%)}	_~	_8.10s	_8.17s	_{p=0.120 n=6}
_{Bind Time}	_{2.75s (± 0.90%)}	_{2.78s (± 0.87%)}	_~	_2.74s	_2.80s	_{p=0.145 n=6}
_{Check Time}	_{82.19s (± 0.36%)}	_{82.05s (± 0.55%)}	_~	_81.46s	_82.49s	_{p=0.689 n=6}
_{Emit Time}	_0.16s	_{0.17s (± 4.89%)}	_~	_0.16s	_0.18s	_{p=0.073 n=6}
_{Total Time}	_{93.21s (± 0.31%)}	_{93.12s (± 0.51%)}	_~	_92.53s	_93.57s	_{p=1.000 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,585	_1,229,658	_{+73 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,899	_260,912	_{+13 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,350,738k (± 0.02%)}	_{2,350,985k (± 0.04%)}	_~	_2,350,160k	_2,352,793k	_{p=0.810 n=6}
_{Parse Time}	_{4.99s (± 1.00%)}	_{4.99s (± 0.76%)}	_~	_4.95s	_5.05s	_{p=1.000 n=6}
_{Bind Time}	_{1.91s (± 0.51%)}	_{1.94s (± 0.51%)}	_{+0.03s (+ 1.39%)}	_1.92s	_1.95s	_{p=0.008 n=6}
_{Check Time}	_{33.99s (± 0.36%)}	_{34.19s (± 0.34%)}	_{+0.20s (+ 0.59%)}	_33.98s	_34.28s	_{p=0.031 n=6}
_{Emit Time}	_{2.58s (± 1.35%)}	_{2.65s (± 3.33%)}	_~	_2.52s	_2.73s	_{p=0.230 n=6}
_{Total Time}	_{43.50s (± 0.31%)}	_{43.78s (± 0.47%)}	_{+0.27s (+ 0.63%)}	_43.41s	_43.94s	_{p=0.045 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,585	_1,229,658	_{+73 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,899	_260,912	_{+13 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,451,724k (± 2.52%)}	_{2,426,666k (± 0.04%)}	_~	_2,426,036k	_2,428,177k	_{p=0.810 n=6}
_{Parse Time}	_{5.20s (± 0.51%)}	_{5.16s (± 0.65%)}	_{-0.04s (- 0.83%)}	_5.12s	_5.21s	_{p=0.037 n=6}
_{Bind Time}	_{1.68s (± 0.58%)}	_{1.89s (± 4.74%)}	_{🔻+0.21s (+12.29%)}	_1.71s	_1.95s	_{p=0.004 n=6}
_{Check Time}	_{34.45s (± 0.15%)}	_{34.35s (± 0.58%)}	_~	_34.13s	_34.70s	_{p=0.092 n=6}
_{Emit Time}	_{2.64s (± 3.81%)}	_{2.64s (± 2.98%)}	_~	_2.56s	_2.77s	_{p=0.936 n=6}
_{Total Time}	_{43.99s (± 0.19%)}	_{44.07s (± 0.39%)}	_~	_43.78s	_44.31s	_{p=0.230 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,592	_258,617	_{+25 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,012	_105,025	_{+13 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,264k (± 0.01%)}	_{428,428k (± 0.01%)}	_{+165k (+ 0.04%)}	_428,359k	_428,468k	_{p=0.005 n=6}
_{Parse Time}	_{4.08s (± 0.22%)}	_{4.07s (± 0.57%)}	_~	_4.05s	_4.10s	_{p=0.685 n=6}
_{Bind Time}	_{1.64s (± 1.89%)}	_{1.67s (± 0.99%)}	_~	_1.64s	_1.69s	_{p=0.103 n=6}
_{Check Time}	_{22.39s (± 0.10%)}	_{22.40s (± 0.38%)}	_~	_22.32s	_22.52s	_{p=1.000 n=6}
_{Emit Time}	_{1.72s (± 0.61%)}	_{1.72s (± 0.70%)}	_~	_1.71s	_1.74s	_{p=0.868 n=6}
_{Total Time}	_{29.84s (± 0.20%)}	_{29.87s (± 0.31%)}	_~	_29.76s	_30.02s	_{p=1.000 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,736	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{369,775k (± 0.01%)}	_{369,980k (± 0.02%)}	_{+206k (+ 0.06%)}	_369,875k	_370,097k	_{p=0.005 n=6}
_{Parse Time}	_{2.84s (± 0.87%)}	_{2.84s (± 1.03%)}	_~	_2.80s	_2.87s	_{p=1.000 n=6}
_{Bind Time}	_{1.58s (± 0.84%)}	_{1.61s (± 0.64%)}	_{+0.03s (+ 1.80%)}	_1.59s	_1.62s	_{p=0.011 n=6}
_{Check Time}	_{15.72s (± 0.48%)}	_{15.74s (± 0.38%)}	_~	_15.65s	_15.82s	_{p=0.376 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.14s (± 0.33%)}	_{20.18s (± 0.40%)}	_~	_20.06s	_20.30s	_{p=0.226 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₇₉	_{🔻+79 (+ ∞%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_2,845,596	_2,849,669	_{+4,073 (+ 0.14%)}	_~	_~	_{p=0.001 n=6}
_Types	_964,085	_964,978	_{+893 (+ 0.09%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,017,140k (± 0.00%)}	_{3,021,037k (± 0.00%)}	_{+3,897k (+ 0.13%)}	_3,020,987k	_3,021,138k	_{p=0.005 n=6}
_{Parse Time}	_{13.90s (± 0.17%)}	_{13.88s (± 0.23%)}	_~	_13.83s	_13.93s	_{p=0.326 n=6}
_{Bind Time}	_{4.23s (± 2.59%)}	_{4.27s (± 1.80%)}	_~	_4.20s	_4.42s	_{p=0.230 n=6}
_{Check Time}	_{73.40s (± 0.42%)}	_{75.35s (± 2.27%)}	_{+1.95s (+ 2.66%)}	_74.38s	_78.83s	_{p=0.005 n=6}
_{Emit Time}	_{23.70s (± 0.61%)}	_{23.06s (± 7.06%)}	_~	_19.75s	_23.90s	_{p=0.810 n=6}
_{Total Time}	_{115.23s (± 0.26%)}	_{116.57s (± 0.11%)}	_{+1.34s (+ 1.17%)}	_116.36s	_116.75s	_{p=0.005 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,361	_266,362	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_108,554	_108,557	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{411,328k (± 0.03%)}	_{411,647k (± 0.02%)}	_{+320k (+ 0.08%)}	_411,571k	_411,847k	_{p=0.005 n=6}
_{Parse Time}	_{3.84s (± 0.39%)}	_{3.84s (± 0.50%)}	_~	_3.82s	_3.87s	_{p=0.677 n=6}
_{Bind Time}	_{1.66s (± 0.82%)}	_{1.70s (± 0.69%)}	_{+0.04s (+ 2.30%)}	_1.69s	_1.72s	_{p=0.005 n=6}
_{Check Time}	_{17.02s (± 0.27%)}	_{17.12s (± 0.29%)}	_{+0.10s (+ 0.59%)}	_17.05s	_17.19s	_{p=0.008 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.52s (± 0.23%)}	_{22.66s (± 0.22%)}	_{+0.14s (+ 0.61%)}	_22.62s	_22.72s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_526,436	_526,436	_~	_~	_~	_{p=1.000 n=6}
_Types	_179,425	_179,425	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{464,088k (± 0.06%)}	_{464,116k (± 0.08%)}	_~	_463,817k	_464,702k	_{p=0.936 n=6}
_{Parse Time}	_{3.15s (± 0.56%)}	_{3.16s (± 0.68%)}	_~	_3.13s	_3.18s	_{p=0.870 n=6}
_{Bind Time}	_{1.19s (± 0.43%)}	_{1.20s (± 0.53%)}	_{+0.01s (+ 1.12%)}	_1.19s	_1.21s	_{p=0.009 n=6}
_{Check Time}	_{18.20s (± 0.30%)}	_{18.12s (± 0.26%)}	_{-0.08s (- 0.47%)}	_18.05s	_18.18s	_{p=0.037 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.54s (± 0.30%)}	_{22.48s (± 0.25%)}	_~	_22.37s	_22.53s	_{p=0.148 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-06-03T23:31:48Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the user tests with tsc comparing main and refs/pull/58729/merge:

Something interesting changed - please have a look.

Details

enhanced-resolve

/mnt/ts_downloads/_/m/enhanced-resolve/tsconfig.json

[MISSING] error TS2339: Property 'replace' does not exist on type 'never'.
- /mnt/ts_downloads/_/m/enhanced-resolve/node_modules/enhanced-resolve/lib/concord.js(149,24)
- /mnt/ts_downloads/_/m/enhanced-resolve/node_modules/enhanced-resolve/lib/concord.js(188,17)

pyright

/mnt/ts_downloads/_/m/pyright/build.sh

[NEW] error TS18048: 'cacheEntry' is possibly 'undefined'.
- /mnt/ts_downloads/_/m/pyright/pyright: ../pyright-internal/src/analyzer/codeFlowEngine.ts(951,25)
- /mnt/ts_downloads/_/m/pyright/pyright: ../pyright-internal/src/analyzer/codeFlowEngine.ts(1064,41)
- /mnt/ts_downloads/_/m/pyright/pyright-internal: src/analyzer/codeFlowEngine.ts(951,25)
- /mnt/ts_downloads/_/m/pyright/pyright-internal: src/analyzer/codeFlowEngine.ts(1064,41)
- /mnt/ts_downloads/_/m/pyright/vscode-pyright: ../pyright-internal/src/analyzer/codeFlowEngine.ts(951,25)
- /mnt/ts_downloads/_/m/pyright/vscode-pyright: ../pyright-internal/src/analyzer/codeFlowEngine.ts(1064,41)

uglify-js

/mnt/ts_downloads/_/m/uglify-js/tsconfig.json

[MISSING] error TS18048: 'ldef' is possibly 'undefined'.
- /mnt/ts_downloads/_/m/uglify-js/node_modules/uglify-js/lib/compress.js(6753,56)

xterm.js

src/tsconfig-library-base.json

[NEW] error TS2322: Type 'boolean | undefined' is not assignable to type 'boolean'.
- src/browser/services/CoreBrowserService.ts#L62 in src/tsconfig-library-base.json

TypeScript Bot (typescript-bot) · 2024-06-04T00:17:59Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/58729/merge:

Something interesting changed - please have a look.

Details

apollographql/apollo-client

1 of 12 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS7022: 'match' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.
- src/cache/inmemory/policies.ts#L746

src/tsconfig.json

error TS7022: 'match' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.
- src/cache/inmemory/policies.ts#L746

conwnet/github1s

extensions/github1s/tsconfig.json

error TS2531: Object is possibly 'null'.
- extensions/github1s/src/adapters/github1s/authentication.ts#L132

electron-react-boilerplate/electron-react-boilerplate

tsconfig.json

error TS2345: Argument of type 'BrowserWindow | null' is not assignable to parameter of type 'BrowserWindow'.
- src/main/main.ts#L101
error TS18047: 'mainWindow' is possibly 'null'.
- src/main/main.ts#L105

labring/FastGPT

projects/app/tsconfig.json

error TS18047: 'global.pgClient' is possibly 'null'.
- packages/service/common/vectorStore/pg/index.ts#L35
error TS2322: Type 'Pool | null' is not assignable to type 'Pool'.
- packages/service/common/vectorStore/pg/index.ts#L37

packages/service/tsconfig.json

error TS18047: 'global.pgClient' is possibly 'null'.
- packages/service/common/vectorStore/pg/index.ts#L35
error TS2322: Type 'Pool | null' is not assignable to type 'Pool'.
- packages/service/common/vectorStore/pg/index.ts#L37

lyswhut/lx-music-desktop

1 of 6 projects failed to build with the old tsc and were ignored

src/main/tsconfig.json

error TS18047: 'browserWindow' is possibly 'null'.

microsoft/vscode

4 of 54 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

error TS2532: Object is possibly 'undefined'.
error TS2531: Object is possibly 'null'.
error TS18048: 'tunnelProcess' is possibly 'undefined'.
- src/vs/platform/remoteTunnel/node/remoteTunnelService.ts#L456
error TS2345: Argument of type 'string[] | undefined' is not assignable to parameter of type 'string[]'.
- src/vs/platform/userDataSync/common/settingsSync.ts#L330
error TS2322: Type 'CancelablePromise<void> | undefined' is not assignable to type 'Promise<void>'.
- src/vs/platform/userDataSync/common/userDataAutoSyncService.ts#L451
error TS18048: '_configDelta' is possibly 'undefined'.
- src/vs/workbench/api/common/configurationExtensionPoint.ts#L155
- src/vs/workbench/api/common/configurationExtensionPoint.ts#L173
error TS2322: Type 'State.SHOW_REQUEST | State.SHOW_RESPONSE | State.PAUSE | State.CANCEL | State.ACCEPT' is not assignable to type 'State.WAIT_FOR_INPUT | State.SHOW_RESPONSE | State.PAUSE | State.CANCEL | State.ACCEPT'.
- src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts#L757
error TS2322: Type 'ITextModel | null' is not assignable to type 'ITextModel'.
- src/vs/workbench/contrib/output/common/outputChannelModel.ts#L179
error TS2322: Type 'HTMLElement | undefined' is not assignable to type 'HTMLElement'.
- src/vs/workbench/contrib/terminalContrib/chat/browser/terminal.initialHint.contribution.ts#L335
error TS2345: Argument of type 'Action | undefined' is not assignable to parameter of type 'IAction | readonly IAction[]'.
- src/vs/workbench/electron-sandbox/window.ts#L1192

src/tsconfig.monaco.json

error TS2532: Object is possibly 'undefined'.
- src/vs/editor/contrib/gotoSymbol/browser/peek/referencesController.ts#L113
error TS2345: Argument of type 'string[] | undefined' is not assignable to parameter of type 'string[]'.
- src/vs/platform/userDataSync/common/settingsSync.ts#L330
error TS2322: Type 'CancelablePromise<void> | undefined' is not assignable to type 'Promise<void>'.
- src/vs/platform/userDataSync/common/userDataAutoSyncService.ts#L451

src/tsconfig.json

error TS2532: Object is possibly 'undefined'.
- src/vs/editor/contrib/gotoSymbol/browser/peek/referencesController.ts#L113
- src/vs/platform/terminal/electron-main/electronPtyHostStarter.ts#L80
- src/vs/workbench/contrib/testing/browser/testingOutputPeek.ts#L594
- src/vs/workbench/contrib/testing/browser/testingOutputPeek.ts#L601
- src/vs/workbench/contrib/update/browser/releaseNotesEditor.ts#L128
error TS7006: Parameter 'e' implicitly has an 'any' type.
- src/vs/editor/test/browser/controller/cursor.test.ts#L851
- src/vs/editor/test/browser/controller/cursor.test.ts#L866
- src/vs/editor/test/browser/controller/cursor.test.ts#L1346
- src/vs/workbench/contrib/notebook/test/browser/notebookTextModel.test.ts#L690
error TS2339: Property 'startOffset' does not exist on type 'TextEdit'.
- src/vs/editor/test/common/model/bracketPairColorizer/beforeEditPositionMapper.test.ts#L324
error TS2339: Property 'endOffset' does not exist on type 'TextEdit'.
- src/vs/editor/test/common/model/bracketPairColorizer/beforeEditPositionMapper.test.ts#L324
error TS2345: Argument of type 'TextEdit[]' is not assignable to parameter of type 'readonly TextEditInfo[]'.
- src/vs/editor/test/common/model/bracketPairColorizer/beforeEditPositionMapper.test.ts#L327
error TS2506: 'TextEdit' is referenced directly or indirectly in its own base expression.
- src/vs/editor/test/common/model/bracketPairColorizer/beforeEditPositionMapper.test.ts#L373
error TS2531: Object is possibly 'null'.
- src/vs/platform/issue/electron-main/issueMainService.ts#L262
- src/vs/platform/issue/electron-main/issueMainService.ts#L263
- src/vs/workbench/contrib/search/browser/searchModel.ts#L2454
error TS18048: 'tunnelProcess' is possibly 'undefined'.
- src/vs/platform/remoteTunnel/node/remoteTunnelService.ts#L456
error TS2345: Argument of type 'string[] | undefined' is not assignable to parameter of type 'string[]'.
- src/vs/platform/userDataSync/common/settingsSync.ts#L330
error TS2322: Type 'CancelablePromise<void> | undefined' is not assignable to type 'Promise<void>'.
- src/vs/platform/userDataSync/common/userDataAutoSyncService.ts#L451
error TS18048: '_configDelta' is possibly 'undefined'.
- src/vs/workbench/api/common/configurationExtensionPoint.ts#L155
- src/vs/workbench/api/common/configurationExtensionPoint.ts#L173
error TS2322: Type 'State.SHOW_REQUEST | State.SHOW_RESPONSE | State.PAUSE | State.CANCEL | State.ACCEPT' is not assignable to type 'State.WAIT_FOR_INPUT | State.SHOW_RESPONSE | State.PAUSE | State.CANCEL | State.ACCEPT'.
- src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts#L757
error TS2345: Argument of type 'MergeModelInterface' is not assignable to parameter of type 'IDisposable'.
- src/vs/workbench/contrib/mergeEditor/test/browser/model.test.ts#L253
error TS2339: Property 'mergeModel' does not exist on type 'IDisposable'.
- src/vs/workbench/contrib/mergeEditor/test/browser/model.test.ts#L255
error TS2345: Argument of type 'IDisposable' is not assignable to parameter of type 'MergeModelInterface'.
- src/vs/workbench/contrib/mergeEditor/test/browser/model.test.ts#L256
error TS2310: Type 'MergeModelInterface' recursively references itself as a base type.
- src/vs/workbench/contrib/mergeEditor/test/browser/model.test.ts#L274
error TS2506: 'MergeModelInterface' is referenced directly or indirectly in its own base expression.
- src/vs/workbench/contrib/mergeEditor/test/browser/model.test.ts#L274
error TS2339: Property '_register' does not exist on type 'MergeModelInterface'.
- src/vs/workbench/contrib/mergeEditor/test/browser/model.test.ts#L279
- src/vs/workbench/contrib/mergeEditor/test/browser/model.test.ts#L280
- src/vs/workbench/contrib/mergeEditor/test/browser/model.test.ts#L281
- src/vs/workbench/contrib/mergeEditor/test/browser/model.test.ts#L282
- src/vs/workbench/contrib/mergeEditor/test/browser/model.test.ts#L306
error TS2322: Type 'ITextModel | null' is not assignable to type 'ITextModel'.
- src/vs/workbench/contrib/output/common/outputChannelModel.ts#L179
error TS2322: Type 'HTMLElement | undefined' is not assignable to type 'HTMLElement'.
- src/vs/workbench/contrib/terminalContrib/chat/browser/terminal.initialHint.contribution.ts#L335
error TS2554: Expected 0 arguments, but got 3.
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L114
error TS2339: Property 'dispose' does not exist on type 'TestTypeAheadAddon'.
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L122
error TS2339: Property 'activate' does not exist on type 'TestTypeAheadAddon'.
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L127
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L134
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L142
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L159
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L177
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L193
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L212
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L231
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L251
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L267
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L282
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L298
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L306
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L314
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L323
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L333
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L355
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L367
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L384
error TS2339: Property 'stats' does not exist on type 'TestTypeAheadAddon'.
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L137
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L154
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L172
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L188
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L262
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L277
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L293
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L301
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L309
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L318
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L328
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L413
error TS2310: Type 'TestTypeAheadAddon' recursively references itself as a base type.
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L399
error TS2506: 'TestTypeAheadAddon' is referenced directly or indirectly in its own base expression.
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L399
error TS2339: Property '_lastRow' does not exist on type 'TestTypeAheadAddon'.
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L401
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L405
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L409
error TS2339: Property '_reevaluatePredictorStateNow' does not exist on type 'TestTypeAheadAddon'.
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L413
error TS2339: Property '_timeline' does not exist on type 'TestTypeAheadAddon'.
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L413
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L417
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L421
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L425
- src/vs/workbench/contrib/terminalContrib/typeAhead/test/browser/terminalTypeAhead.test.ts#L429
error TS2345: Argument of type 'Action | undefined' is not assignable to parameter of type 'IAction | readonly IAction[]'.
- src/vs/workbench/electron-sandbox/window.ts#L1192

extensions/vscode-test-resolver/tsconfig.json

error TS18048: 'extHostProcess' is possibly 'undefined'.
- extensions/vscode-test-resolver/src/extension.ts#L194

extensions/vscode-api-tests/tsconfig.json

error TS7022: 'created' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.

tinacms/tinacms

12 of 24 projects failed to build with the old tsc and were ignored

packages/@tinacms/mdx/tsconfig.json

error TS2345: Argument of type '{ type: "inlineCode"; value: string; }' is not assignable to parameter of type 'Text'.
- packages/@tinacms/mdx/src/next/stringify/marks.ts#L239
- packages/@tinacms/mdx/src/stringify/marks.ts#L236

Ethan Resnick (ethanresnick) · 2024-06-05T05:37:15Z

Anders Hejlsberg (@ahejlsberg) If I'm understanding correctly, this would apply to arguments that are declared as arrow functions or function expressions, but not function declarations. Is that right? If so, why exclude function declarations?

(FWIW, I do like this experiment and the attempt at added strictness, if it ends up not being too breaking.)

Anders Hejlsberg (ahejlsberg) · 2024-06-05T17:04:17Z

Ethan Resnick (@ethanresnick) It only applies to arrow functions and function expressions passed directly as arguments. It does not apply to functions referenced through identifiers or other indirect expression constructs.

TypeScript Bot (typescript-bot) · 2024-06-05T22:32:16Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure Daniel Rosenwasser (@DanielRosenwasser) and Ryan Cavanaugh (@RyanCavanaugh) are aware of the changes, just as a heads up.

Anders Hejlsberg (ahejlsberg) · 2024-06-05T23:02:24Z

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) · 2024-08-08T17:50:18Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-08-08T18:10:52Z

Hey Anders Hejlsberg (@ahejlsberg), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-08-08T18:18:15Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the user tests with tsc comparing main and refs/pull/58729/merge:

Something interesting changed - please have a look.

Details

enhanced-resolve

/mnt/ts_downloads/_/m/enhanced-resolve/tsconfig.json

[MISSING] error TS2339: Property 'replace' does not exist on type 'never'.
- /mnt/ts_downloads/_/m/enhanced-resolve/node_modules/enhanced-resolve/lib/concord.js(149,24)
- /mnt/ts_downloads/_/m/enhanced-resolve/node_modules/enhanced-resolve/lib/concord.js(188,17)

pyright

/mnt/ts_downloads/_/m/pyright/build.sh

[NEW] error TS18048: 'cacheEntry' is possibly 'undefined'.
- /mnt/ts_downloads/_/m/pyright/pyright: ../pyright-internal/src/analyzer/codeFlowEngine.ts(981,25)
- /mnt/ts_downloads/_/m/pyright/pyright: ../pyright-internal/src/analyzer/codeFlowEngine.ts(1105,41)
- /mnt/ts_downloads/_/m/pyright/pyright-internal: src/analyzer/codeFlowEngine.ts(981,25)
- /mnt/ts_downloads/_/m/pyright/pyright-internal: src/analyzer/codeFlowEngine.ts(1105,41)
- /mnt/ts_downloads/_/m/pyright/vscode-pyright: ../pyright-internal/src/analyzer/codeFlowEngine.ts(981,25)
- /mnt/ts_downloads/_/m/pyright/vscode-pyright: ../pyright-internal/src/analyzer/codeFlowEngine.ts(1105,41)

TypeScript Bot (typescript-bot) · 2024-08-08T18:33:13Z

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,609k (± 0.92%)}	_{194,558k (± 0.91%)}	_~	_192,713k	_196,242k	_{p=0.066 n=6}
_{Parse Time}	_{1.57s (± 0.96%)}	_{1.59s (± 1.10%)}	_~	_1.56s	_1.61s	_{p=0.211 n=6}
_{Bind Time}	_{0.85s (± 1.37%)}	_{0.88s (± 1.33%)}	_{+0.03s (+ 3.13%)}	_0.86s	_0.89s	_{p=0.012 n=6}
_{Check Time}	_{11.35s (± 0.50%)}	_{11.32s (± 0.40%)}	_~	_11.27s	_11.38s	_{p=0.628 n=6}
_{Emit Time}	_{3.23s (± 0.75%)}	_{3.24s (± 0.23%)}	_~	_3.23s	_3.25s	_{p=0.075 n=6}
_{Total Time}	_{17.01s (± 0.42%)}	_{17.03s (± 0.15%)}	_~	_16.99s	_17.06s	_{p=0.336 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,757	_945,752	_{-5 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,045	_410,082	_{+37 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,222,457k (± 0.00%)}	_{1,223,097k (± 0.00%)}	_{+641k (+ 0.05%)}	_1,223,068k	_1,223,128k	_{p=0.005 n=6}
_{Parse Time}	_{7.95s (± 0.42%)}	_{7.95s (± 0.79%)}	_~	_7.87s	_8.02s	_{p=0.872 n=6}
_{Bind Time}	_{2.23s (± 0.18%)}	_{2.28s (± 0.66%)}	_{+0.05s (+ 2.47%)}	_2.27s	_2.31s	_{p=0.004 n=6}
_{Check Time}	_{36.28s (± 0.54%)}	_{36.30s (± 0.37%)}	_~	_36.15s	_36.47s	_{p=0.748 n=6}
_{Emit Time}	_{17.77s (± 0.35%)}	_{17.86s (± 0.77%)}	_~	_17.74s	_18.11s	_{p=0.225 n=6}
_{Total Time}	_{64.22s (± 0.29%)}	_{64.39s (± 0.38%)}	_~	_64.15s	_64.83s	_{p=0.296 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,487,631	_2,487,654	_{+23 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,012,953	_1,012,969	_{+16 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,493,621k (± 0.01%)}	_{2,494,038k (± 0.01%)}	_{+416k (+ 0.02%)}	_2,493,890k	_2,494,358k	_{p=0.005 n=6}
_{Parse Time}	_{13.44s (± 0.45%)}	_{13.45s (± 0.45%)}	_~	_13.36s	_13.54s	_{p=0.872 n=6}
_{Bind Time}	_{3.20s (± 0.88%)}	_{3.21s (± 0.74%)}	_~	_3.18s	_3.24s	_{p=0.520 n=6}
_{Check Time}	_{109.30s (± 1.14%)}	_{109.53s (± 0.84%)}	_~	_108.59s	_111.20s	_{p=0.378 n=6}
_{Emit Time}	_{0.40s (± 3.40%)}	_{0.40s (± 2.06%)}	_~	_0.38s	_0.40s	_{p=0.101 n=6}
_{Total Time}	_{126.33s (± 1.00%)}	_{126.58s (± 0.74%)}	_~	_125.66s	_128.32s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,292	_1,229,795	_{+503 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,032	_264,159	_{+127 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,348,388k (± 0.03%)}	_{2,472,550k (± 7.41%)}	_{🔻+124,162k (+ 5.29%)}	_2,353,335k	_2,709,589k	_{p=0.005 n=6}
_{Parse Time}	_{6.07s (± 0.65%)}	_{6.09s (± 0.72%)}	_~	_6.05s	_6.16s	_{p=0.572 n=6}
_{Bind Time}	_{2.25s (± 1.08%)}	_{2.35s (± 1.73%)}	_{🔻+0.10s (+ 4.67%)}	_2.30s	_2.41s	_{p=0.005 n=6}
_{Check Time}	_{40.82s (± 0.67%)}	_{40.83s (± 0.74%)}	_~	_40.30s	_41.15s	_{p=0.689 n=6}
_{Emit Time}	_{4.05s (± 2.13%)}	_{4.01s (± 1.16%)}	_~	_3.94s	_4.06s	_{p=0.575 n=6}
_{Total Time}	_{53.21s (± 0.58%)}	_{53.30s (± 0.65%)}	_~	_52.77s	_53.71s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,292	_1,229,795	_{+503 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,032	_264,159	_{+127 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,422,365k (± 0.05%)}	_{2,486,773k (± 5.80%)}	_{+64,408k (+ 2.66%)}	_2,427,642k	_2,781,443k	_{p=0.005 n=6}
_{Parse Time}	_{6.25s (± 1.15%)}	_{6.33s (± 0.87%)}	_~	_6.26s	_6.40s	_{p=0.066 n=6}
_{Bind Time}	_{2.02s (± 1.06%)}	_{2.40s (± 1.68%)}	_{🔻+0.37s (+18.47%)}	_2.33s	_2.45s	_{p=0.005 n=6}
_{Check Time}	_{41.41s (± 0.92%)}	_{40.94s (± 0.52%)}	_{-0.47s (- 1.14%)}	_40.53s	_41.09s	_{p=0.031 n=6}
_{Emit Time}	_{4.06s (± 2.84%)}	_{4.06s (± 0.98%)}	_~	_4.00s	_4.11s	_{p=1.000 n=6}
_{Total Time}	_{53.76s (± 0.80%)}	_{53.73s (± 0.36%)}	_~	_53.42s	_53.94s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,694	_256,830	_{+136 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,545	_105,615	_{+70 (+ 0.07%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,918k (± 0.02%)}	_{429,740k (± 0.01%)}	_{+821k (+ 0.19%)}	_429,713k	_429,788k	_{p=0.005 n=6}
_{Parse Time}	_{4.16s (± 0.38%)}	_{4.17s (± 0.55%)}	_~	_4.15s	_4.21s	_{p=0.565 n=6}
_{Bind Time}	_{1.61s (± 1.91%)}	_{1.63s (± 0.60%)}	_~	_1.61s	_1.64s	_{p=0.211 n=6}
_{Check Time}	_{22.30s (± 0.41%)}	_{22.39s (± 0.34%)}	_~	_22.32s	_22.50s	_{p=0.092 n=6}
_{Emit Time}	_{2.02s (± 1.46%)}	_{2.03s (± 0.59%)}	_~	_2.02s	_2.05s	_{p=0.935 n=6}
_{Total Time}	_{30.08s (± 0.28%)}	_{30.22s (± 0.21%)}	_{+0.14s (+ 0.47%)}	_30.15s	_30.33s	_{p=0.030 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,245	_94,245	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,225k (± 0.04%)}	_{370,391k (± 0.03%)}	_{+166k (+ 0.04%)}	_370,252k	_370,510k	_{p=0.045 n=6}
_{Parse Time}	_{3.44s (± 0.56%)}	_{3.47s (± 0.89%)}	_~	_3.42s	_3.50s	_{p=0.124 n=6}
_{Bind Time}	_{1.92s (± 0.97%)}	_{1.97s (± 0.89%)}	_{+0.06s (+ 2.96%)}	_1.94s	_1.99s	_{p=0.008 n=6}
_{Check Time}	_{19.30s (± 0.45%)}	_{19.42s (± 0.30%)}	_~	_19.37s	_19.50s	_{p=0.108 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.66s (± 0.38%)}	_{24.86s (± 0.24%)}	_{+0.20s (+ 0.81%)}	_24.77s	_24.95s	_{p=0.010 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,995,242	_2,995,246	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,032,059	_1,032,072	_{+13 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,120,605k (± 0.00%)}	_{3,121,257k (± 0.00%)}	_{+652k (+ 0.02%)}	_3,121,170k	_3,121,369k	_{p=0.005 n=6}
_{Parse Time}	_{17.02s (± 0.32%)}	_{17.14s (± 0.19%)}	_{+0.11s (+ 0.67%)}	_17.08s	_17.17s	_{p=0.013 n=6}
_{Bind Time}	_{5.24s (± 0.39%)}	_{5.28s (± 0.22%)}	_{+0.04s (+ 0.86%)}	_5.27s	_5.30s	_{p=0.007 n=6}
_{Check Time}	_{96.69s (± 0.34%)}	_{96.59s (± 0.29%)}	_~	_96.25s	_96.87s	_{p=0.810 n=6}
_{Emit Time}	_{25.00s (± 0.86%)}	_{24.99s (± 0.57%)}	_~	_24.79s	_25.12s	_{p=0.810 n=6}
_{Total Time}	_{143.95s (± 0.23%)}	_{144.00s (± 0.24%)}	_~	_143.64s	_144.44s	_{p=0.810 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_271,703	_271,703	_~	_~	_~	_{p=1.000 n=6}
_Types	_110,714	_110,714	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{417,637k (± 0.01%)}	_{418,169k (± 0.01%)}	_{+532k (+ 0.13%)}	_418,130k	_418,196k	_{p=0.005 n=6}
_{Parse Time}	_{3.83s (± 0.75%)}	_{3.88s (± 0.66%)}	_{+0.05s (+ 1.26%)}	_3.84s	_3.90s	_{p=0.029 n=6}
_{Bind Time}	_{1.69s (± 1.33%)}	_{1.76s (± 1.10%)}	_{🔻+0.07s (+ 4.04%)}	_1.74s	_1.79s	_{p=0.005 n=6}
_{Check Time}	_{16.98s (± 0.40%)}	_{17.06s (± 0.38%)}	_~	_16.96s	_17.14s	_{p=0.077 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.50s (± 0.32%)}	_{22.71s (± 0.31%)}	_{+0.20s (+ 0.89%)}	_22.59s	_22.80s	_{p=0.008 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_538,614	_538,614	_~	_~	_~	_{p=1.000 n=6}
_Types	_176,536	_176,536	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{481,404k (± 0.01%)}	_{481,817k (± 0.02%)}	_{+413k (+ 0.09%)}	_481,735k	_481,927k	_{p=0.005 n=6}
_{Parse Time}	_{2.83s (± 0.71%)}	_{2.83s (± 0.85%)}	_~	_2.81s	_2.87s	_{p=1.000 n=6}
_{Bind Time}	_{1.04s (± 0.61%)}	_1.09s	_{🔻+0.05s (+ 4.81%)}	_~	_~	_{p=0.002 n=6}
_{Check Time}	_{15.29s (± 0.39%)}	_{15.30s (± 0.39%)}	_~	_15.21s	_15.34s	_{p=0.686 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.16s (± 0.23%)}	_{19.22s (± 0.35%)}	_~	_19.12s	_19.29s	_{p=0.173 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-08-08T19:34:13Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/58729/merge:

Something interesting changed - please have a look.

Details

tinacms/tinacms

11 of 23 projects failed to build with the old tsc and were ignored

packages/@tinacms/mdx/tsconfig.json

error TS2345: Argument of type '{ type: "inlineCode"; value: string; }' is not assignable to parameter of type 'Text'.
- packages/@tinacms/mdx/src/next/stringify/marks.ts#L239
- packages/@tinacms/mdx/src/stringify/marks.ts#L236

Anders Hejlsberg (ahejlsberg) · 2024-08-08T20:44:48Z

TypeScript Bot (@typescript-bot) perf test this faster

TypeScript Bot (typescript-bot) · 2024-08-08T20:44:51Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-08-08T21:28:21Z

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,926k (± 0.77%)}	_{194,413k (± 1.02%)}	_{+1,487k (+ 0.77%)}	_192,600k	_196,272k	_{p=0.020 n=6}
_{Parse Time}	_{1.94s (± 0.56%)}	_{1.96s (± 1.10%)}	_{+0.02s (+ 1.20%)}	_1.94s	_2.00s	_{p=0.046 n=6}
_{Bind Time}	_{1.06s (± 1.29%)}	_{1.09s (± 0.47%)}	_{+0.03s (+ 2.84%)}	_1.08s	_1.09s	_{p=0.007 n=6}
_{Check Time}	_{14.08s (± 1.10%)}	_{14.06s (± 0.22%)}	_~	_14.02s	_14.11s	_{p=0.809 n=6}
_{Emit Time}	_{3.97s (± 1.63%)}	_{4.00s (± 0.47%)}	_~	_3.97s	_4.02s	_{p=0.746 n=6}
_{Total Time}	_{21.05s (± 0.65%)}	_{21.10s (± 0.14%)}	_~	_21.05s	_21.14s	_{p=0.172 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,757	_945,752	_{-5 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,045	_410,082	_{+37 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,222,503k (± 0.00%)}	_{1,223,132k (± 0.00%)}	_{+629k (+ 0.05%)}	_1,223,093k	_1,223,214k	_{p=0.005 n=6}
_{Parse Time}	_{7.89s (± 0.91%)}	_{7.93s (± 0.71%)}	_~	_7.87s	_7.99s	_{p=0.378 n=6}
_{Bind Time}	_{2.21s (± 0.37%)}	_{2.27s (± 0.36%)}	_{+0.05s (+ 2.41%)}	_2.26s	_2.28s	_{p=0.003 n=6}
_{Check Time}	_{36.20s (± 0.26%)}	_{36.34s (± 0.51%)}	_~	_36.13s	_36.62s	_{p=0.149 n=6}
_{Emit Time}	_{17.70s (± 0.37%)}	_{17.76s (± 0.34%)}	_~	_17.64s	_17.80s	_{p=0.090 n=6}
_{Total Time}	_{64.00s (± 0.09%)}	_{64.30s (± 0.34%)}	_{+0.30s (+ 0.47%)}	_64.01s	_64.58s	_{p=0.020 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,487,631	_2,487,654	_{+23 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,012,953	_1,012,969	_{+16 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,493,587k (± 0.01%)}	_{2,493,965k (± 0.00%)}	_{+378k (+ 0.02%)}	_2,493,888k	_2,494,012k	_{p=0.005 n=6}
_{Parse Time}	_{10.95s (± 0.29%)}	_{10.93s (± 0.29%)}	_~	_10.88s	_10.96s	_{p=0.373 n=6}
_{Bind Time}	_{2.61s (± 0.45%)}	_{2.63s (± 0.24%)}	_{+0.02s (+ 0.83%)}	_2.62s	_2.64s	_{p=0.007 n=6}
_{Check Time}	_{89.50s (± 0.51%)}	_{89.50s (± 0.36%)}	_~	_89.00s	_89.90s	_{p=0.936 n=6}
_{Emit Time}	_{0.33s (± 2.57%)}	_{0.34s (± 2.22%)}	_{🔻+0.01s (+ 4.10%)}	_0.33s	_0.35s	_{p=0.030 n=6}
_{Total Time}	_{103.39s (± 0.46%)}	_{103.40s (± 0.30%)}	_~	_102.94s	_103.79s	_{p=0.873 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,498	_1,230,001	_{+503 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,061	_264,188	_{+127 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,468,078k (±11.76%)}	_{2,354,875k (± 0.04%)}	_~	_2,353,520k	_2,355,889k	_{p=0.066 n=6}
_{Parse Time}	_{7.52s (± 1.70%)}	_{7.54s (± 0.63%)}	_~	_7.49s	_7.60s	_{p=0.199 n=6}
_{Bind Time}	_{2.77s (± 0.87%)}	_{2.92s (± 0.82%)}	_{🔻+0.15s (+ 5.23%)}	_2.88s	_2.94s	_{p=0.005 n=6}
_{Check Time}	_{50.56s (± 0.86%)}	_{50.74s (± 0.74%)}	_~	_50.35s	_51.30s	_{p=0.298 n=6}
_{Emit Time}	_{5.01s (± 4.58%)}	_{5.09s (± 3.54%)}	_~	_4.94s	_5.36s	_{p=0.336 n=6}
_{Total Time}	_{65.91s (± 0.58%)}	_{66.32s (± 0.46%)}	_~	_65.95s	_66.67s	_{p=0.066 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,498	_1,230,001	_{+503 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,061	_264,188	_{+127 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,423,316k (± 0.02%)}	_{2,427,894k (± 0.02%)}	_{+4,578k (+ 0.19%)}	_2,427,190k	_2,428,315k	_{p=0.005 n=6}
_{Parse Time}	_{6.22s (± 0.78%)}	_{6.30s (± 0.66%)}	_{+0.08s (+ 1.37%)}	_6.25s	_6.35s	_{p=0.020 n=6}
_{Bind Time}	_{2.02s (± 0.68%)}	_{2.38s (± 0.93%)}	_{🔻+0.36s (+17.61%)}	_2.35s	_2.42s	_{p=0.005 n=6}
_{Check Time}	_{41.18s (± 0.44%)}	_{41.06s (± 0.27%)}	_~	_40.87s	_41.20s	_{p=0.230 n=6}
_{Emit Time}	_{4.07s (± 3.79%)}	_{4.20s (± 4.08%)}	_{+0.13s (+ 3.11%)}	_4.08s	_4.47s	_{p=0.045 n=6}
_{Total Time}	_{53.51s (± 0.30%)}	_{53.96s (± 0.24%)}	_{+0.45s (+ 0.85%)}	_53.82s	_54.20s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,739	_256,875	_{+136 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,560	_105,630	_{+70 (+ 0.07%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,907k (± 0.01%)}	_{429,683k (± 0.01%)}	_{+776k (+ 0.18%)}	_429,628k	_429,738k	_{p=0.005 n=6}
_{Parse Time}	_{3.36s (± 0.45%)}	_{3.35s (± 0.52%)}	_~	_3.34s	_3.38s	_{p=0.744 n=6}
_{Bind Time}	_{1.32s (± 0.93%)}	_{1.32s (± 1.41%)}	_~	_1.31s	_1.36s	_{p=0.655 n=6}
_{Check Time}	_{18.07s (± 0.24%)}	_{18.15s (± 0.45%)}	_~	_18.03s	_18.26s	_{p=0.128 n=6}
_{Emit Time}	_{1.64s (± 1.88%)}	_{1.66s (± 1.12%)}	_~	_1.64s	_1.69s	_{p=0.125 n=6}
_{Total Time}	_{24.38s (± 0.13%)}	_{24.49s (± 0.32%)}	_{+0.11s (+ 0.44%)}	_24.40s	_24.61s	_{p=0.010 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,245	_94,245	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,197k (± 0.04%)}	_{370,385k (± 0.03%)}	_~	_370,291k	_370,538k	_{p=0.066 n=6}
_{Parse Time}	_{2.76s (± 0.58%)}	_{2.78s (± 1.05%)}	_~	_2.74s	_2.81s	_{p=0.256 n=6}
_{Bind Time}	_{1.57s (± 0.70%)}	_{1.61s (± 0.61%)}	_{+0.04s (+ 2.65%)}	_1.60s	_1.63s	_{p=0.004 n=6}
_{Check Time}	_{15.67s (± 0.31%)}	_{15.72s (± 0.53%)}	_~	_15.59s	_15.80s	_{p=0.377 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.00s (± 0.18%)}	_{20.11s (± 0.45%)}	_{+0.10s (+ 0.52%)}	_19.94s	_20.18s	_{p=0.044 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,995,250	_2,995,254	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,032,086	_1,032,099	_{+13 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,120,649k (± 0.00%)}	_{3,121,303k (± 0.00%)}	_{+655k (+ 0.02%)}	_3,121,181k	_3,121,441k	_{p=0.005 n=6}
_{Parse Time}	_{16.99s (± 0.17%)}	_{17.14s (± 0.25%)}	_{+0.16s (+ 0.91%)}	_17.10s	_17.21s	_{p=0.005 n=6}
_{Bind Time}	_{5.26s (± 1.77%)}	_{5.28s (± 0.53%)}	_~	_5.26s	_5.33s	_{p=0.063 n=6}
_{Check Time}	_{96.55s (± 0.27%)}	_{97.01s (± 0.21%)}	_{+0.46s (+ 0.48%)}	_96.75s	_97.34s	_{p=0.020 n=6}
_{Emit Time}	_{25.16s (± 0.58%)}	_{25.00s (± 0.47%)}	_~	_24.87s	_25.18s	_{p=0.078 n=6}
_{Total Time}	_{143.95s (± 0.23%)}	_{144.42s (± 0.15%)}	_{+0.48s (+ 0.33%)}	_144.20s	_144.78s	_{p=0.020 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_273,789	_273,789	_~	_~	_~	_{p=1.000 n=6}
_Types	_111,669	_111,669	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{419,923k (± 0.02%)}	_{420,355k (± 0.02%)}	_{+432k (+ 0.10%)}	_420,245k	_420,457k	_{p=0.005 n=6}
_{Parse Time}	_{4.92s (± 0.44%)}	_{4.91s (± 0.43%)}	_~	_4.89s	_4.94s	_{p=0.627 n=6}
_{Bind Time}	_{2.11s (± 0.98%)}	_{2.16s (± 0.63%)}	_{+0.05s (+ 2.29%)}	_2.14s	_2.18s	_{p=0.006 n=6}
_{Check Time}	_{21.10s (± 0.29%)}	_{21.35s (± 0.77%)}	_{+0.25s (+ 1.18%)}	_21.15s	_21.55s	_{p=0.010 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.13s (± 0.24%)}	_{28.43s (± 0.55%)}	_{+0.30s (+ 1.05%)}	_28.22s	_28.62s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_538,614	_538,614	_~	_~	_~	_{p=1.000 n=6}
_Types	_176,536	_176,536	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{481,460k (± 0.01%)}	_{481,823k (± 0.00%)}	_{+363k (+ 0.08%)}	_481,807k	_481,839k	_{p=0.005 n=6}
_{Parse Time}	_{3.38s (± 0.95%)}	_{3.38s (± 0.54%)}	_~	_3.36s	_3.40s	_{p=0.809 n=6}
_{Bind Time}	_{1.24s (± 1.11%)}	_{1.31s (± 0.39%)}	_{🔻+0.06s (+ 4.95%)}	_1.30s	_1.31s	_{p=0.004 n=6}
_{Check Time}	_{18.04s (± 0.51%)}	_{18.09s (± 0.20%)}	_~	_18.03s	_18.13s	_{p=0.335 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.67s (± 0.47%)}	_{22.78s (± 0.14%)}	_{+0.11s (+ 0.49%)}	_22.72s	_22.81s	_{p=0.012 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Jake Bailey (jakebailey) · 2024-08-08T23:42:51Z

TypeScript Bot (@typescript-bot) perf test this faster predictable=true

TypeScript Bot (typescript-bot) · 2024-08-08T23:42:54Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster predictable=true`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-08-09T00:21:12Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_192,317k	_192,541k	_{+224k (+ 0.12%)}	_~	_~	_{p=0.001 n=6}
_{Parse Time}	_{1.28s (± 0.40%)}	_1.29s	_{+0.01s (+ 0.52%)}	_~	_~	_{p=0.025 n=6}
_{Bind Time}	_{0.71s (± 0.73%)}	_{0.73s (± 0.71%)}	_{+0.02s (+ 2.83%)}	_0.72s	_0.73s	_{p=0.004 n=6}
_{Check Time}	_{9.35s (± 0.12%)}	_{9.21s (± 0.06%)}	_{-0.14s (- 1.44%)}	_9.21s	_9.22s	_{p=0.004 n=6}
_{Emit Time}	_{2.89s (± 0.18%)}	_{2.98s (± 0.14%)}	_{+0.09s (+ 3.05%)}	_2.98s	_2.99s	_{p=0.003 n=6}
_{Total Time}	_{14.24s (± 0.07%)}	_{14.21s (± 0.04%)}	_{-0.02s (- 0.15%)}	_14.21s	_14.22s	_{p=0.007 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,757	_945,752	_{-5 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,045	_410,082	_{+37 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,222,697k (± 0.00%)}	_{1,223,212k (± 0.01%)}	_{+515k (+ 0.04%)}	_1,223,101k	_1,223,382k	_{p=0.004 n=6}
_{Parse Time}	_{6.27s (± 0.14%)}	_{6.31s (± 0.25%)}	_{+0.04s (+ 0.64%)}	_6.30s	_6.34s	_{p=0.004 n=6}
_{Bind Time}	_{1.85s (± 0.28%)}	_{1.92s (± 0.64%)}	_{+0.06s (+ 3.33%)}	_1.91s	_1.94s	_{p=0.003 n=6}
_{Check Time}	_{35.27s (± 0.18%)}	_{33.63s (± 0.16%)}	_{🟩-1.64s (- 4.64%)}	_33.58s	_33.73s	_{p=0.005 n=6}
_{Emit Time}	_{14.65s (± 0.19%)}	_{16.69s (± 0.22%)}	_{🔻+2.04s (+13.92%)}	_16.65s	_16.74s	_{p=0.005 n=6}
_{Total Time}	_{58.04s (± 0.13%)}	_{58.55s (± 0.05%)}	_{+0.51s (+ 0.87%)}	_58.52s	_58.59s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,487,631	_2,487,654	_{+23 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,012,953	_1,012,969	_{+16 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_2,493,838k	_2,494,479k	_{+641k (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Parse Time}	_{8.93s (± 0.06%)}	_{8.93s (± 0.15%)}	_~	_8.92s	_8.95s	_{p=0.794 n=6}
_{Bind Time}	_{2.81s (± 0.18%)}	_{2.27s (± 0.23%)}	_{🟩-0.54s (-19.19%)}	_2.27s	_2.28s	_{p=0.004 n=6}
_{Check Time}	_{77.26s (± 0.11%)}	_{77.23s (± 0.05%)}	_~	_77.18s	_77.28s	_{p=0.298 n=6}
_{Emit Time}	_0.29s	_0.29s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{89.29s (± 0.09%)}	_{88.73s (± 0.05%)}	_{-0.56s (- 0.63%)}	_88.67s	_88.78s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,498	_1,230,001	_{+503 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,061	_264,188	_{+127 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,350,880k (± 0.00%)}	_{2,355,888k (± 0.00%)}	_{+5,008k (+ 0.21%)}	_2,355,874k	_2,355,947k	_{p=0.005 n=6}
_{Parse Time}	_{5.75s (± 0.32%)}	_{5.85s (± 0.13%)}	_{+0.10s (+ 1.80%)}	_5.84s	_5.86s	_{p=0.005 n=6}
_{Bind Time}	_{2.11s (± 0.24%)}	_{2.31s (± 0.35%)}	_{🔻+0.19s (+ 9.15%)}	_2.29s	_2.31s	_{p=0.003 n=6}
_{Check Time}	_{41.18s (± 0.06%)}	_{41.61s (± 0.10%)}	_{+0.43s (+ 1.03%)}	_41.56s	_41.66s	_{p=0.005 n=6}
_{Emit Time}	_{4.18s (± 0.18%)}	_{4.19s (± 0.29%)}	_~	_4.17s	_4.20s	_{p=0.323 n=6}
_{Total Time}	_{53.24s (± 0.06%)}	_{53.96s (± 0.09%)}	_{+0.72s (+ 1.35%)}	_53.89s	_54.02s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,498	_1,230,001	_{+503 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,061	_264,188	_{+127 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,423,250k (± 0.00%)}	_2,428,200k	_{+4,950k (+ 0.20%)}	_~	_~	_{p=0.002 n=6}
_{Parse Time}	_{4.94s (± 0.17%)}	_{5.00s (± 0.10%)}	_{+0.06s (+ 1.18%)}	_5.00s	_5.01s	_{p=0.004 n=6}
_{Bind Time}	_{1.70s (± 0.24%)}	_{1.81s (± 0.23%)}	_{🔻+0.11s (+ 6.46%)}	_1.81s	_1.82s	_{p=0.003 n=6}
_{Check Time}	_{35.37s (± 0.07%)}	_{35.60s (± 0.12%)}	_{+0.23s (+ 0.65%)}	_35.53s	_35.66s	_{p=0.005 n=6}
_{Emit Time}	_{3.56s (± 0.15%)}	_{3.57s (± 0.18%)}	_{+0.01s (+ 0.37%)}	_3.56s	_3.58s	_{p=0.009 n=6}
_{Total Time}	_{45.59s (± 0.07%)}	_{45.96s (± 0.09%)}	_{+0.37s (+ 0.82%)}	_45.89s	_46.02s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,739	_256,875	_{+136 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,560	_105,630	_{+70 (+ 0.07%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_428,755k	_429,618k	_{+863k (+ 0.20%)}	_~	_~	_{p=0.001 n=6}
_{Parse Time}	_{3.16s (± 0.38%)}	_{3.15s (± 0.33%)}	_~	_3.14s	_3.17s	_{p=0.180 n=6}
_{Bind Time}	_{1.46s (± 0.35%)}	_1.50s	_{+0.04s (+ 2.51%)}	_~	_~	_{p=0.002 n=6}
_{Check Time}	_{18.12s (± 0.24%)}	_{18.19s (± 0.08%)}	_~	_18.17s	_18.20s	_{p=0.062 n=6}
_{Emit Time}	_{1.63s (± 0.33%)}	_{1.65s (± 0.31%)}	_{+0.01s (+ 0.71%)}	_1.64s	_1.65s	_{p=0.013 n=6}
_{Total Time}	_{24.39s (± 0.16%)}	_{24.49s (± 0.09%)}	_{+0.10s (+ 0.41%)}	_24.46s	_24.51s	_{p=0.007 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,245	_94,245	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_370,111k	_370,356k	_{+245k (+ 0.07%)}	_~	_~	_{p=0.001 n=6}
_{Parse Time}	_{3.42s (± 0.40%)}	_{3.45s (± 0.57%)}	_{+0.03s (+ 0.88%)}	_3.43s	_3.48s	_{p=0.016 n=6}
_{Bind Time}	_{1.73s (± 0.24%)}	_{1.78s (± 0.23%)}	_{+0.05s (+ 3.09%)}	_1.78s	_1.79s	_{p=0.003 n=6}
_{Check Time}	_{19.89s (± 0.07%)}	_{19.88s (± 0.13%)}	_~	_19.86s	_19.93s	_{p=0.277 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.04s (± 0.10%)}	_{25.11s (± 0.11%)}	_{+0.07s (+ 0.29%)}	_25.08s	_25.15s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,995,021	_2,995,025	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,032,070	_1,032,083	_{+13 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,120,667k (± 0.00%)}	_{3,121,565k (± 0.00%)}	_{+897k (+ 0.03%)}	_3,121,556k	_3,121,605k	_{p=0.003 n=6}
_{Parse Time}	_{14.39s (± 0.17%)}	_{14.52s (± 0.06%)}	_{+0.13s (+ 0.87%)}	_14.50s	_14.52s	_{p=0.004 n=6}
_{Bind Time}	_{4.48s (± 0.14%)}	_{4.72s (± 0.18%)}	_{🔻+0.24s (+ 5.25%)}	_4.71s	_4.73s	_{p=0.004 n=6}
_{Check Time}	_{77.44s (± 0.15%)}	_{77.50s (± 0.11%)}	_~	_77.39s	_77.60s	_{p=0.295 n=6}
_{Emit Time}	_{26.01s (± 0.24%)}	_{25.98s (± 0.23%)}	_~	_25.91s	_26.06s	_{p=0.470 n=6}
_{Total Time}	_{122.32s (± 0.12%)}	_{122.71s (± 0.09%)}	_{+0.39s (+ 0.32%)}	_122.55s	_122.87s	_{p=0.006 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_273,789	_273,789	_~	_~	_~	_{p=1.000 n=6}
_Types	_111,669	_111,669	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_419,865k	_420,361k	_{+496k (+ 0.12%)}	_~	_~	_{p=0.001 n=6}
_{Parse Time}	_{3.81s (± 0.26%)}	_{3.95s (± 0.19%)}	_{+0.14s (+ 3.68%)}	_3.94s	_3.96s	_{p=0.004 n=6}
_{Bind Time}	_1.77s	_1.83s	_{+0.06s (+ 3.39%)}	_~	_~	_{p=0.001 n=6}
_{Check Time}	_{16.94s (± 0.03%)}	_{17.07s (± 0.07%)}	_{+0.13s (+ 0.79%)}	_17.06s	_17.09s	_{p=0.004 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.52s (± 0.06%)}	_{22.84s (± 0.05%)}	_{+0.33s (+ 1.46%)}	_22.83s	_22.86s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_538,614	_538,614	_~	_~	_~	_{p=1.000 n=6}
_Types	_176,536	_176,536	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_481,455k	_481,794k	_{+339k (+ 0.07%)}	_~	_~	_{p=0.001 n=6}
_{Parse Time}	_{3.23s (± 0.32%)}	_{3.23s (± 0.46%)}	_~	_3.22s	_3.26s	_{p=0.558 n=6}
_{Bind Time}	_1.48s	_{1.51s (± 0.27%)}	_{+0.03s (+ 2.14%)}	_1.51s	_1.52s	_{p=0.002 n=6}
_{Check Time}	_{18.00s (± 0.12%)}	_{18.01s (± 0.12%)}	_~	_17.99s	_18.05s	_{p=0.464 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.71s (± 0.09%)}	_{22.75s (± 0.14%)}	_{+0.04s (+ 0.19%)}	_22.72s	_22.80s	_{p=0.030 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Anders Hejlsberg (ahejlsberg) · 2024-08-09T13:07:46Z

Jake Bailey (@jakebailey) Asking for predictable seems to have very unpredictable effects. 😮

Anders Hejlsberg (ahejlsberg) · 2024-08-09T13:27:03Z

Jake Bailey (@jakebailey) The issue with switching to actual immediate modifiers is that we need an updated ESLint.

Jake Bailey (jakebailey) · 2024-08-09T16:50:10Z

Asking for predictable seems to have very unpredictable effects. 😮

The error bars are 3-4x smaller! 😄 But yes, don't use this feature, I'm still not sure if it's a good thing or not.

The issue with switching to actual immediate modifiers is that we need an updated ESLint.

Ah, right. Theoretically we can exclude src/lib from both linting and formatting temporarily. But, let me see if I can switch to the keyword locally and compare profiles before or after to see if there's some potential JSDoc win... (I assume you didn't commit that to a branch somewhere?)

Jake Bailey (jakebailey) · 2024-08-09T20:22:47Z

Even with the keyword, #59580 (comment) shows roughly the same perf regression in bind. Still not sure what it could be reading 5ae48a2 (#58729).

Issue addressed

David Greenspan (dgreensp) · 2024-09-23T19:47:28Z

I'm just a passer-by (who writes a lot of TypeScript), who got excited by the prospect of a new keyword that would improve CFA or soundness, but I'm not sure I understand the motivation here, relative to the magnitude of the change (new syntax).

I guess it started as an effort to improve soundness by considering that called functions might have side effects, and now it basically helps correct for overzealous CFA.

Here is another case (not related to this feature) where CFA thinks it knows everything and narrows the type annotation of a local variable:

functionfoo(a: number[],i: number){// I'm serious, Typescript, I'm saying this could be out-of-bounds!constn: number|undefined=a[i];constn2=n;// : number}

In both cases, you have to occasionally override CFA, e.g. in the example at the top of this thread, one could write:

declarefunctionmystery(cb: ()=>void): void;letx: string|number="OK"asstring|number;mystery(()=>{x=10;});if(x===10){// works}

In terms of the larger issue of side effects, I think it should at least be acknowledged that passing any closure to any function could lead to functions having side effects that affect local variables; it doesn't really depend on whether a callback is invoked "immediately" or "deferred."

For example:

constfoo=newFoo(()=>{/* ... set a local variable */});foo.execute();

Here, the callback is not called immediately, but it is called during the course of the function. The point is, the question of whether a callback might be called immediately or not by a function is only loosely connected to the question of whether a function call has side effects that might affect the analysis of local variables.

I think an annotation that says "this callback is called exactly once, synchronously" or "this callback is called at least once, synchronously" might even be more useful? It would serve a slightly different purpose. If this keyword opens the door to other keywords, I'm for it. There are a lot of keywords I would want.

Simon Schick (SimonSchick) · 2024-11-14T00:21:51Z

Is this going to make the 5.7 release? I see it is in the iteration plan and I'm curious what work is remaining here 👀

Jake Bailey (jakebailey) · 2024-11-14T00:23:38Z

No, 5.7 is cut, and its release candidate is already out. https://devblogs.microsoft.com/typescript/announcing-typescript-5-7-rc/

Something being in the iteration plan does not guarantee its completion / inclusion in a release.

TypeScript Bot (typescript-bot) · 2026-03-24T21:19:14Z

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

Anders Hejlsberg (ahejlsberg) added 2 commits May 31, 2024 15:16

Analyze control flow effects of lambdas passed as arguments
8ccfb4a

Accept new baselines
e4d20f8

TypeScript Bot (typescript-bot) assigned Anders Hejlsberg (ahejlsberg)May 31, 2024

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 31, 2024

Bruce Pascoe (fatcerberus) mentioned this pull request Jun 1, 2024
"Property does not exist on type 'never'" with optional chaining #58733
Closed

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Jun 3, 2024
Design Meeting Notes, 5/31/2024 #58763
Closed

Formatting + handle unreachable code
de9171e

Anders Hejlsberg (ahejlsberg) added 2 commits June 5, 2024 15:31

Add Deferred<T> intrinsic + only check lambdas with mutation flow nodes
18f1ba9

Accept new baselines
46f6706

Local declarations don't mutate captured outer variables
dd59710

Delete old test baselines
22faf4e

Jake Bailey (jakebailey) mentioned this pull request Aug 9, 2024
[experiment] perf testing immediate keyword for lib #59580
Closed

Anders Hejlsberg (ahejlsberg) added 2 commits August 12, 2024 13:51

Handle immediate modifier in strictSubtypeRelation and union signatures
e037d82

Add tests
64e0459

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Sep 9, 2024
TypeScript 5.7 Iteration Plan #59905
Closed

Martin Johns (MartinJohns) mentioned this pull request Nov 4, 2024
Cannot set readonly property in IIFE #60413
Closed

Martin Johns (MartinJohns) mentioned this pull request Feb 18, 2025
Error TS2729 should occur inside arrow function #61212
Closed

LukeAbby added a commit to League-of-Foundry-Developers/foundry-vtt-types that referenced this pull request Mar 2, 2025
Apply@Immediate, seemicrosoft/TypeScript#58729
2c5079d

LukeAbby added a commit to League-of-Foundry-Developers/foundry-vtt-types that referenced this pull request Mar 2, 2025
Apply@Immediate, seemicrosoft/TypeScript#58729
e961469

TypeScript Bot (typescript-bot) closed this Mar 24, 2026

Uh oh!

Conversation

Anders Hejlsberg (ahejlsberg) commented May 31, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anders Hejlsberg (ahejlsberg) commented May 31, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented May 31, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 31, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented May 31, 2024

/mnt/ts_downloads/_/m/enhanced-resolve/tsconfig.json

/mnt/ts_downloads/_/m/pyright/build.sh

/mnt/ts_downloads/_/m/uglify-js/tsconfig.json

Uh oh!

TypeScript Bot (typescript-bot) commented May 31, 2024

tsc

Uh oh!

Bruce Pascoe (fatcerberus) commented May 31, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 1, 2024

Uh oh!

Bruce Pascoe (fatcerberus) commented Jun 1, 2024

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Jun 1, 2024

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Jun 3, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 3, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 3, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 3, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 3, 2024

/mnt/ts_downloads/_/m/enhanced-resolve/tsconfig.json

/mnt/ts_downloads/_/m/pyright/build.sh

/mnt/ts_downloads/_/m/uglify-js/tsconfig.json

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 4, 2024

Uh oh!

Ethan Resnick (ethanresnick) commented Jun 5, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Jun 5, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 5, 2024

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Jun 5, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 8, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 8, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 8, 2024

/mnt/ts_downloads/_/m/enhanced-resolve/tsconfig.json

/mnt/ts_downloads/_/m/pyright/build.sh

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 8, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 8, 2024

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Aug 8, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 8, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 8, 2024

tsc

Uh oh!

Jake Bailey (jakebailey) commented Aug 8, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 8, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Anders Hejlsberg (ahejlsberg) commented May 31, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented May 31, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Jun 3, 2024•
edited
Loading

Ethan Resnick (ethanresnick) commented Jun 5, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Aug 8, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Aug 8, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Aug 8, 2024•
edited
Loading