Only look up package.json type if module is node16/nodenext or file is in node_modules by andrewbranch · Pull Request #58825 · microsoft/TypeScript

Andrew Branch (andrewbranch) · 2024-06-10T23:39:49Z

This walks back the heuristics added to non-Node.js module modes in #57896 a bit, based mostly on feedback in #58663. In 5.5-beta, an explicit package.json "type" or module-format-specific file extension started overriding "module": "commonjs" or "module": "esnext" in tsconfig.json. This impacted both type checking (relevant primarily for imports of node_modules dependencies, but with some effects on local files, e.g. with verbatimModuleSyntax) and emit (relevant for local project source files, if emit was enabled). The feedback in #58663 was that the effects on local files were unwelcome because the emitted files (whether from tsc or another tool) were going to be placed in some other context tsc didn’t know about, so the package.json tsc was finding during compilation shouldn’t be considered during the build.

With this PR, we only look up package.json "type" if --module is node16/nodenext (as we’ve always done) or if the file is inside node_modules.

~~Some testing and experimentation is still needed to ensure this doesn’t create inconsistencies with symlinked monorepos.~~ This doesn’t seem to cause inconsistencies with workspaces-style monorepos, because module resolution takes the realpath of files in node_modules before we see if we need to look up a package.json "type". So in a project references example like

.
└── packages/
├── app/
│ ├── node_modules/shared ↪︎
│ ├── tsconfig.json
│ ├── package.json
│ └── index.ts
└── shared/
├── dist/index.d.ts
├── src/index.ts
├── tsconfig.json
└── package.json

When we build shared/tsconfig.json, we decide that shared/src/index.ts is not inside node_modules. Then, when we build app/tsconfig.json, even though we resolve app/node_modules/shared/dist/index.d.ts, we realpath it to shared/dist/index.d.ts and count it as not inside node_modules. Having this consistency between input and output files regardless of how they’re resolved is what matters most. The caveat is that the realpath and project references logic can cause the type checking of app/tsconfig.json during development to behave differently than it would after publishing/deploying into a situation where app/node_modules/shared is no longer a symlink, but a real node_modules package.

Fixes#54752
Fixes#50647

Andrew Branch (andrewbranch) · 2024-06-11T16:36:18Z

TypeScript Bot (@typescript-bot) test top400

TypeScript Bot (typescript-bot) · 2024-06-11T16:36:22Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results

TypeScript Bot (typescript-bot) · 2024-06-11T18:15:04Z

Andrew Branch (@andrewbranch) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/58825/merge:

Everything looks good!

Andrew Branch (andrewbranch) · 2024-06-11T18:47:39Z

TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2024-06-11T18:47:43Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

TypeScript Bot (typescript-bot) · 2024-06-11T18:49:41Z

Hey Andrew Branch (@andrewbranch), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/162168/artifacts?artifactName=tgz&fileId=C1ACA7462D57C70E93C4D3280AA7732A4C19585806197BFA46B31559D77CD4B402&fileName=/typescript-5.6.0-insiders.20240611.tgz"
}
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.6.0-pr-58825-5".;

Andrew Branch (andrewbranch) · 2024-06-11T19:46:11Z

Perf should be unchanged or better, but

TypeScript Bot (@typescript-bot) perf test faster

TypeScript Bot (typescript-bot) · 2024-06-11T19:46:14Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-06-11T20:22:28Z

Andrew Branch (@andrewbranch)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,725k (± 0.89%)}	_{193,513k (± 0.90%)}	_~	_192,250k	_195,779k	_{p=0.230 n=6}
_{Parse Time}	_{1.30s (± 0.79%)}	_{1.30s (± 0.64%)}	_~	_1.29s	_1.31s	_{p=0.923 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.58s (± 0.35%)}	_{9.58s (± 0.61%)}	_~	_9.53s	_9.68s	_{p=0.936 n=6}
_{Emit Time}	_{2.77s (± 0.37%)}	_{2.76s (± 0.70%)}	_~	_2.74s	_2.79s	_{p=0.325 n=6}
_{Total Time}	_{14.37s (± 0.28%)}	_{14.37s (± 0.44%)}	_~	_14.31s	_14.45s	_{p=0.871 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,109	_944,109	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,049	_407,049	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,155k (± 0.00%)}	_{1,219,694k (± 0.00%)}	_{-2,462k (- 0.20%)}	_1,219,639k	_1,219,782k	_{p=0.005 n=6}
_{Parse Time}	_{8.09s (± 0.47%)}	_{8.04s (± 0.18%)}	_~	_8.02s	_8.06s	_{p=0.064 n=6}
_{Bind Time}	_{2.24s (± 0.69%)}	_{2.26s (± 0.40%)}	_{+0.02s (+ 0.89%)}	_2.25s	_2.27s	_{p=0.039 n=6}
_{Check Time}	_{36.63s (± 0.37%)}	_{36.44s (± 0.43%)}	_~	_36.25s	_36.67s	_{p=0.054 n=6}
_{Emit Time}	_{18.07s (± 0.40%)}	_{17.90s (± 0.55%)}	_{-0.17s (- 0.96%)}	_17.78s	_18.03s	_{p=0.013 n=6}
_{Total Time}	_{65.03s (± 0.26%)}	_{64.64s (± 0.20%)}	_{-0.39s (- 0.60%)}	_64.46s	_64.76s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,131,876	_2,131,876	_~	_~	_~	_{p=1.000 n=6}
_Types	_925,869	_925,869	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,120,037k (± 0.00%)}	_{2,116,210k (± 0.01%)}	_{-3,827k (- 0.18%)}	_2,116,098k	_2,116,356k	_{p=0.005 n=6}
_{Parse Time}	_{6.83s (± 0.17%)}	_{6.69s (± 0.30%)}	_{-0.14s (- 2.05%)}	_6.66s	_6.72s	_{p=0.005 n=6}
_{Bind Time}	_{2.29s (± 0.18%)}	_{2.32s (± 0.79%)}	_{+0.03s (+ 1.31%)}	_2.29s	_2.34s	_{p=0.016 n=6}
_{Check Time}	_{71.30s (± 0.38%)}	_{71.26s (± 0.44%)}	_~	_70.70s	_71.64s	_{p=0.936 n=6}
_{Emit Time}	_0.14s	_0.14s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{80.56s (± 0.34%)}	_{80.41s (± 0.37%)}	_~	_79.87s	_80.74s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,424	_1,230,425	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,178	_261,178	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,376,991k (± 2.59%)}	_{2,351,721k (± 0.06%)}	_~	_2,350,180k	_2,353,055k	_{p=0.689 n=6}
_{Parse Time}	_{4.98s (± 0.93%)}	_{4.97s (± 0.89%)}	_~	_4.91s	_5.04s	_{p=0.810 n=6}
_{Bind Time}	_{1.90s (± 0.61%)}	_{1.89s (± 0.33%)}	_~	_1.88s	_1.90s	_{p=0.070 n=6}
_{Check Time}	_{34.11s (± 0.39%)}	_{34.12s (± 0.41%)}	_~	_33.98s	_34.35s	_{p=0.873 n=6}
_{Emit Time}	_{2.64s (± 0.79%)}	_{2.66s (± 2.65%)}	_~	_2.57s	_2.74s	_{p=0.378 n=6}
_{Total Time}	_{43.65s (± 0.34%)}	_{43.66s (± 0.26%)}	_~	_43.48s	_43.82s	_{p=0.575 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,424	_1,230,425	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,178	_261,178	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,427,658k (± 0.02%)}	_{2,427,123k (± 0.05%)}	_~	_2,425,891k	_2,428,927k	_{p=0.298 n=6}
_{Parse Time}	_{5.17s (± 0.39%)}	_{5.19s (± 1.04%)}	_~	_5.14s	_5.26s	_{p=1.000 n=6}
_{Bind Time}	_{1.68s (± 0.31%)}	_{1.69s (± 0.75%)}	_~	_1.68s	_1.71s	_{p=0.418 n=6}
_{Check Time}	_{34.51s (± 0.29%)}	_{34.57s (± 0.22%)}	_~	_34.49s	_34.70s	_{p=0.423 n=6}
_{Emit Time}	_{2.65s (± 2.76%)}	_{2.70s (± 2.62%)}	_~	_2.58s	_2.77s	_{p=0.173 n=6}
_{Total Time}	_{44.02s (± 0.35%)}	_{44.17s (± 0.19%)}	_~	_44.08s	_44.31s	_{p=0.065 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,181	_259,182	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,173	_105,173	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,866k (± 0.03%)}	_{428,867k (± 0.01%)}	_~	_428,827k	_428,913k	_{p=0.378 n=6}
_{Parse Time}	_{4.07s (± 0.65%)}	_{4.09s (± 1.00%)}	_~	_4.03s	_4.15s	_{p=0.517 n=6}
_{Bind Time}	_{1.63s (± 0.74%)}	_{1.62s (± 1.49%)}	_~	_1.59s	_1.65s	_{p=0.622 n=6}
_{Check Time}	_{22.27s (± 0.67%)}	_{22.38s (± 0.30%)}	_~	_22.27s	_22.46s	_{p=0.228 n=6}
_{Emit Time}	_{1.74s (± 1.01%)}	_{1.72s (± 1.41%)}	_~	_1.69s	_1.76s	_{p=0.126 n=6}
_{Total Time}	_{29.72s (± 0.47%)}	_{29.80s (± 0.39%)}	_~	_29.60s	_29.89s	_{p=0.376 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,796k (± 0.04%)}	_{369,638k (± 0.03%)}	_{-158k (- 0.04%)}	_369,515k	_369,775k	_{p=0.045 n=6}
_{Parse Time}	_{3.46s (± 1.35%)}	_{3.46s (± 0.41%)}	_~	_3.44s	_3.48s	_{p=0.936 n=6}
_{Bind Time}	_{1.95s (± 0.96%)}	_{1.95s (± 2.12%)}	_~	_1.89s	_2.01s	_{p=0.807 n=6}
_{Check Time}	_{19.36s (± 0.28%)}	_{19.40s (± 0.19%)}	_~	_19.35s	_19.44s	_{p=0.148 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.77s (± 0.31%)}	_{24.82s (± 0.16%)}	_~	_24.74s	_24.85s	_{p=0.224 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,852,976	_2,852,976	_~	_~	_~	_{p=1.000 n=6}
_Types	_967,867	_967,867	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,025,016k (± 0.00%)}	_{3,020,070k (± 0.00%)}	_{-4,946k (- 0.16%)}	_3,019,976k	_3,020,204k	_{p=0.005 n=6}
_{Parse Time}	_{13.82s (± 0.16%)}	_{13.65s (± 0.40%)}	_{-0.18s (- 1.30%)}	_13.57s	_13.73s	_{p=0.005 n=6}
_{Bind Time}	_{4.27s (± 2.62%)}	_{4.17s (± 0.25%)}	_~	_4.16s	_4.19s	_{p=0.406 n=6}
_{Check Time}	_{74.97s (± 2.49%)}	_{73.60s (± 0.32%)}	_~	_73.27s	_73.96s	_{p=0.066 n=6}
_{Emit Time}	_{22.53s (± 8.36%)}	_{23.90s (± 0.77%)}	_~	_23.69s	_24.12s	_{p=0.054 n=6}
_{Total Time}	_{115.59s (± 0.17%)}	_{115.32s (± 0.31%)}	_~	_114.88s	_115.77s	_{p=0.173 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,914	_266,914	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,685	_108,685	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,894k (± 0.02%)}	_{411,499k (± 0.02%)}	_{-396k (- 0.10%)}	_411,379k	_411,655k	_{p=0.005 n=6}
_{Parse Time}	_{3.82s (± 1.09%)}	_{3.83s (± 0.59%)}	_~	_3.80s	_3.86s	_{p=0.627 n=6}
_{Bind Time}	_{1.66s (± 0.99%)}	_{1.69s (± 0.65%)}	_{+0.03s (+ 2.11%)}	_1.67s	_1.70s	_{p=0.007 n=6}
_{Check Time}	_{17.01s (± 0.45%)}	_{16.98s (± 0.42%)}	_~	_16.84s	_17.03s	_{p=0.688 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.49s (± 0.35%)}	_{22.51s (± 0.38%)}	_~	_22.34s	_22.58s	_{p=0.809 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_523,429	_523,429	_~	_~	_~	_{p=1.000 n=6}
_Types	_177,955	_177,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{461,890k (± 0.02%)}	_{461,564k (± 0.07%)}	_~	_461,216k	_461,953k	_{p=0.093 n=6}
_{Parse Time}	_{3.15s (± 0.68%)}	_{3.15s (± 0.55%)}	_~	_3.12s	_3.17s	_{p=0.872 n=6}
_{Bind Time}	_{1.18s (± 0.46%)}	_{1.19s (± 0.69%)}	_~	_1.18s	_1.20s	_{p=0.859 n=6}
_{Check Time}	_{18.21s (± 0.20%)}	_{18.14s (± 0.83%)}	_~	_17.95s	_18.32s	_{p=0.568 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{22.55s (± 0.24%)}	_{22.47s (± 0.66%)}	_~	_22.30s	_22.65s	_{p=0.520 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

…fic file extensions in more `module` modes (microsoft#57896)"" This reverts commit d3c8f08.

…ExportInfoMap (microsoft#58837)"" This reverts commit a19bf0c.

TypeScript Bot (typescript-bot) · 2024-06-17T18:56:09Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure Daniel Rosenwasser (@DanielRosenwasser) and Ryan Cavanaugh (@RyanCavanaugh) are aware of the changes, just as a heads up.

Wesley Wigham (weswigham)

We don't need these new ModuleSpecifierResolutionHost members to be public because we automatically attach them or have fallbacks, right? Because these'll be missing from a user-provided host object. We probably wannt mark 'em as optional and handle appropriately if they're non-public.

Andrew Branch (andrewbranch) · 2024-06-24T18:40:55Z

We don't need these new ModuleSpecifierResolutionHost members to be public

Wesley Wigham (@weswigham)ModuleSpecifierResolutionHost itself is internal.

Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>

Andrew Branch (andrewbranch) · 2024-07-01T19:01:20Z

There’s a knip failure but it’s public API?

Wesley Wigham (weswigham) · 2024-07-01T19:50:59Z

ModuleSpecifierResolutionHost itself is internal.

The specifics are internal, yes, but we expose and consume public objects and interfaces that we use as and expect to be ModuleSpecifierResolutionHosts which cannot be correctly implemented without these being made public in some way. There's a definite reason almost everything on ModuleSpecifierResolutionHost is optional. For example, Program has a second (@internal) declaration declaring it extends ModuleSpecifierResolutionHost. If there are any 3rd-party Programs (like our LS or builder construct internally to orchestrate builds, but external), they won't know they need these new methods on their Program to satisfy ModuleSpecifierResolutionHost uses, and since they're required, we'll just crash at runtime when they're inevitably missing.

Andrew Branch (andrewbranch) · 2024-07-01T20:45:43Z

There are 43 non-optional internal methods and properties declared on the public Program interface declaration—we haven’t made it possible to implement a third-party Program up from its public interface.

Andrew Branch (andrewbranch) · 2024-07-10T16:40:05Z

Wesley Wigham (@weswigham) any other feedback on the API (or any of the PR)? I’d like to get this in soon.

TypeScript Bot (typescript-bot) assigned Andrew Branch (andrewbranch)Jun 10, 2024

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 10, 2024

Andrew Branch (andrewbranch) mentioned this pull request Jun 11, 2024
[5.5 beta] package.json "type" lookup in non-Node.js module is unexpected #58663
Closed

Andrew Branch (andrewbranch) mentioned this pull request Jun 11, 2024
Disable #57896 (Respect package.json "type" and module-format-specific file extensions in more module modes) #58831
Merged

Andrew Branch (andrewbranch) added 2 commits June 17, 2024 11:51

Revert "Revert "Respect package.json "type" and module-format-speci…
c4069c5
…fic file extensions in more `module` modes (microsoft#57896)"" This reverts commit d3c8f08.

Revert "Revert "[DO NOT MERGE UNTIL 5.6] Fix re-exported defaults in …
6208d2f
…ExportInfoMap (microsoft#58837)"" This reverts commit a19bf0c.

Andrew Branch (andrewbranch)force-pushed the package-json-type-only-in-node_modules branch from 2677b01 to 6208d2fCompare June 17, 2024 18:55

Andrew Branch (andrewbranch) marked this pull request as ready for review June 17, 2024 22:44

Andrew Branch (andrewbranch) requested review from Sheetal Nandi (sheetalkamat) and Wesley Wigham (weswigham)June 17, 2024 22:44

This was referenced Jun 17, 2024
Typescript [4.8.2] is adding invalid javascript for *.cjs files #50647
Closed
ESM-only packages come with synthesized default in moduleResolution: bundler#54752
Closed

TypeScript Bot (typescript-bot) added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 17, 2024

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Jun 18, 2024
Design Meeting Notes, 6/11/2024 #58918
Closed

Wesley Wigham (weswigham) reviewed Jun 20, 2024
View reviewed changes

Sheetal Nandi (sheetalkamat) approved these changes Jun 20, 2024
View reviewed changes

Merge branch 'main' into package-json-type-only-in-node_modules
1df4982

Merge branch 'main' into package-json-type-only-in-node_modules
953711b

Andrew Branch (andrewbranch) requested review from Daniel Rosenwasser (DanielRosenwasser), Jake Bailey (jakebailey) and Wesley Wigham (weswigham)July 1, 2024 18:21

Jake Bailey (jakebailey) reviewed Jul 1, 2024
View reviewed changes

Comment threadsrc/compiler/checker.ts

Jake Bailey (jakebailey) reviewed Jul 1, 2024
View reviewed changes

Comment threadsrc/compiler/utilities.ts Outdated

Jake Bailey (jakebailey) reviewed Jul 1, 2024
View reviewed changes

Comment threadsrc/compiler/utilities.ts Outdated

Jake Bailey (jakebailey) approved these changes Jul 1, 2024
View reviewed changes

Remove unnecessary type import modifier
5445d35
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>

Update comments
8e6ae69

Silence knip bug
9d9a7a8

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Jul 11, 2024
TypeScript 5.6 Iteration Plan #59250
Closed

Andrew Branch (andrewbranch) merged commit a9139bf into microsoft:mainJul 17, 2024

Andrew Branch (andrewbranch) deleted the package-json-type-only-in-node_modules branch July 17, 2024 16:23

Andrew Branch (andrewbranch) mentioned this pull request Jul 31, 2024
Actually set impliedNodeFormat in more cases #59479
Merged

Andrew Branch (andrewbranch) mentioned this pull request Aug 8, 2024
should allow use export = in .cts when module is esnext #51018
Closed

David Sherret (dsherret) mentioned this pull request Sep 11, 2024
Ability for compiler host to provide resolution mode for file and say it supports impledNodeFormat #59939
Closed
6 tasks

This was referenced Sep 13, 2024
tsimp does not work with TypeScript v5.6.2 tapjs/tsimp#29
Closed
Fix call to getMode to include compilerOptions tapjs/tsimp#30
Closed

Mateusz Burzyński (Andarist) mentioned this pull request Sep 17, 2024
CommonJS module output broken after updating from 5.5.4 to 5.6.2 #59991
Closed

Andrew Branch (andrewbranch) mentioned this pull request Sep 24, 2024
Set impliedNodeFormat based on redirectedReference options #60039
Closed

Guillaume Pascal (g-pascal) mentioned this pull request Oct 6, 2024
Module '"zod"' has no exported member 'z'.ts colinhacks/zod#3739
Open

Jake Bailey (jakebailey) mentioned this pull request Oct 14, 2024
[api-extractor] building with TS 5.6.2 causes error on wildcard import microsoft/rushstack#4919
Closed

Nathan Shively-Sanders (sandersn) removed this from PR Backlog Apr 22, 2025

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Uh oh!

Conversation

Andrew Branch (andrewbranch) commented Jun 10, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Andrew Branch (andrewbranch) commented Jun 11, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 11, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 11, 2024

Uh oh!

Andrew Branch (andrewbranch) commented Jun 11, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 11, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 11, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Andrew Branch (andrewbranch) commented Jun 11, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 11, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 11, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 17, 2024

Uh oh!

Wesley Wigham (weswigham) left a comment

Choose a reason for hiding this comment

Uh oh!

Andrew Branch (andrewbranch) commented Jun 24, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Andrew Branch (andrewbranch) commented Jul 1, 2024

Uh oh!

Wesley Wigham (weswigham) commented Jul 1, 2024

Uh oh!

Andrew Branch (andrewbranch) commented Jul 1, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Andrew Branch (andrewbranch) commented Jul 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Andrew Branch (andrewbranch) commented Jun 10, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Jun 11, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Jun 11, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Jun 11, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Jun 11, 2024•
edited
Loading

Andrew Branch (andrewbranch) commented Jul 1, 2024•
edited
Loading