Always build project irrespective of errors in dependency with tsc -b by sheetalkamat · Pull Request #58854 · microsoft/TypeScript

Sheetal Nandi (sheetalkamat) · 2024-06-13T20:46:50Z

No description provided.

Sheetal Nandi (sheetalkamat) · 2024-06-13T20:48:41Z

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) · 2024-06-13T20:48:44Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-06-13T21:15:25Z

Hey Sheetal Nandi (@sheetalkamat), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-06-13T21:21:35Z

Sheetal Nandi (@sheetalkamat) Here are the results of running the user tests with tsc comparing main and refs/pull/58854/merge:

Something interesting changed - please have a look.

Details

effect

tsconfig.json

[NEW] error TS7016: Could not find a declaration file for module 'effect/Array'. '/mnt/ts_downloads/_/m/effect/packages/effect/src/Array.js' implicitly has an 'any' type.
[NEW] error TS7016: Could not find a declaration file for module 'effect/Either'. '/mnt/ts_downloads/_/m/effect/packages/effect/src/Either.js' implicitly has an 'any' type.
[NEW] error TS7016: Could not find a declaration file for module 'effect/Function'. '/mnt/ts_downloads/_/m/effect/packages/effect/src/Function.js' implicitly has an 'any' type.

TypeScript Bot (typescript-bot) · 2024-06-13T21:36:37Z

Sheetal Nandi (@sheetalkamat)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,462k (± 0.97%)}	_{193,456k (± 0.92%)}	_~	_192,193k	_195,753k	_{p=0.810 n=6}
_{Parse Time}	_{1.58s (± 0.65%)}	_{1.57s (± 0.74%)}	_~	_1.55s	_1.58s	_{p=0.491 n=6}
_{Bind Time}	_{0.87s (± 0.94%)}	_{0.87s (± 0.87%)}	_~	_0.86s	_0.88s	_{p=0.729 n=6}
_{Check Time}	_{11.39s (± 0.31%)}	_{11.40s (± 0.40%)}	_~	_11.33s	_11.46s	_{p=0.872 n=6}
_{Emit Time}	_{3.26s (± 0.36%)}	_{3.26s (± 0.86%)}	_~	_3.21s	_3.29s	_{p=0.869 n=6}
_{Total Time}	_{17.09s (± 0.20%)}	_{17.09s (± 0.47%)}	_~	_16.95s	_17.19s	_{p=0.686 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,104	_944,104	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,044	_407,044	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,572k (± 0.00%)}	_{1,218,505k (± 0.00%)}	_{-67k (- 0.01%)}	_1,218,482k	_1,218,528k	_{p=0.010 n=6}
_{Parse Time}	_{7.97s (± 0.86%)}	_{7.96s (± 0.31%)}	_~	_7.92s	_7.99s	_{p=0.688 n=6}
_{Bind Time}	_{2.24s (± 0.77%)}	_{2.23s (± 0.67%)}	_~	_2.22s	_2.25s	_{p=0.323 n=6}
_{Check Time}	_{36.28s (± 0.23%)}	_{36.22s (± 0.16%)}	_~	_36.14s	_36.28s	_{p=0.149 n=6}
_{Emit Time}	_{17.81s (± 0.34%)}	_{17.82s (± 0.37%)}	_~	_17.71s	_17.89s	_{p=0.810 n=6}
_{Total Time}	_{64.30s (± 0.24%)}	_{64.24s (± 0.21%)}	_~	_63.99s	_64.39s	_{p=0.423 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,132,301	_2,132,301	_~	_~	_~	_{p=1.000 n=6}
_Types	_926,081	_926,081	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,114,966k (± 0.00%)}	_{2,114,934k (± 0.00%)}	_~	_2,114,808k	_2,115,053k	_{p=0.575 n=6}
_{Parse Time}	_{7.86s (± 0.24%)}	_{7.87s (± 0.25%)}	_~	_7.83s	_7.89s	_{p=0.738 n=6}
_{Bind Time}	_{2.75s (± 0.96%)}	_{2.74s (± 0.55%)}	_~	_2.73s	_2.77s	_{p=0.517 n=6}
_{Check Time}	_{83.52s (± 1.08%)}	_{83.95s (± 0.59%)}	_~	_83.40s	_84.61s	_{p=0.471 n=6}
_{Emit Time}	_{0.16s (± 5.21%)}	_{0.16s (± 3.95%)}	_~	_0.15s	_0.17s	_{p=0.432 n=6}
_{Total Time}	_{94.29s (± 0.94%)}	_{94.72s (± 0.53%)}	_~	_94.14s	_95.37s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,542	_1,229,411	_{-131 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,916	_260,872	_{-44 (- 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,344,302k (± 0.05%)}	_{2,344,034k (± 0.04%)}	_~	_2,342,196k	_2,344,923k	_{p=1.000 n=6}
_{Parse Time}	_{4.97s (± 0.82%)}	_{4.98s (± 0.62%)}	_~	_4.93s	_5.01s	_{p=1.000 n=6}
_{Bind Time}	_{1.88s (± 0.52%)}	_{1.88s (± 1.48%)}	_~	_1.84s	_1.91s	_{p=0.745 n=6}
_{Check Time}	_{34.10s (± 0.44%)}	_{34.21s (± 0.23%)}	_~	_34.11s	_34.32s	_{p=0.199 n=6}
_{Emit Time}	_{2.72s (± 2.15%)}	_{2.72s (± 1.95%)}	_~	_2.65s	_2.79s	_{p=1.000 n=6}
_{Total Time}	_{43.69s (± 0.40%)}	_{43.83s (± 0.18%)}	_~	_43.75s	_43.96s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,542	_1,229,411	_{-131 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,916	_260,872	_{-44 (- 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,421,018k (± 0.04%)}	_{2,422,071k (± 0.01%)}	_{+1,053k (+ 0.04%)}	_2,421,583k	_2,422,497k	_{p=0.045 n=6}
_{Parse Time}	_{6.28s (± 0.70%)}	_{6.26s (± 0.19%)}	_~	_6.25s	_6.28s	_{p=0.228 n=6}
_{Bind Time}	_{2.00s (± 0.80%)}	_{2.00s (± 1.57%)}	_~	_1.97s	_2.06s	_{p=0.934 n=6}
_{Check Time}	_{40.60s (± 0.27%)}	_{40.54s (± 0.44%)}	_~	_40.35s	_40.84s	_{p=0.471 n=6}
_{Emit Time}	_{3.20s (± 3.18%)}	_{3.13s (± 1.44%)}	_~	_3.06s	_3.19s	_{p=0.423 n=6}
_{Total Time}	_{52.08s (± 0.42%)}	_{51.94s (± 0.29%)}	_~	_51.75s	_52.17s	_{p=0.230 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,665	_258,633	_{-32 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,931	_104,889	_{-42 (- 0.04%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,319k (± 0.03%)}	_{428,167k (± 0.01%)}	_{-153k (- 0.04%)}	_428,116k	_428,219k	_{p=0.008 n=6}
_{Parse Time}	_{3.31s (± 0.75%)}	_{3.30s (± 0.47%)}	_~	_3.28s	_3.32s	_{p=0.462 n=6}
_{Bind Time}	_{1.30s (± 1.05%)}	_{1.30s (± 0.76%)}	_~	_1.29s	_1.31s	_{p=0.801 n=6}
_{Check Time}	_{18.04s (± 0.29%)}	_{18.07s (± 0.11%)}	_~	_18.04s	_18.10s	_{p=0.227 n=6}
_{Emit Time}	_{1.40s (± 1.23%)}	_{1.38s (± 1.48%)}	_~	_1.36s	_1.41s	_{p=0.222 n=6}
_{Total Time}	_{24.04s (± 0.37%)}	_{24.05s (± 0.13%)}	_~	_24.00s	_24.09s	_{p=0.936 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,662k (± 0.03%)}	_{369,639k (± 0.04%)}	_~	_369,408k	_369,873k	_{p=0.810 n=6}
_{Parse Time}	_{3.45s (± 0.70%)}	_{3.44s (± 0.80%)}	_~	_3.41s	_3.48s	_{p=0.806 n=6}
_{Bind Time}	_{1.94s (± 1.40%)}	_{1.95s (± 0.70%)}	_~	_1.93s	_1.96s	_{p=0.560 n=6}
_{Check Time}	_{19.38s (± 0.30%)}	_{19.33s (± 0.28%)}	_~	_19.26s	_19.40s	_{p=0.125 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.78s (± 0.27%)}	_{24.72s (± 0.22%)}	_~	_24.63s	_24.78s	_{p=0.199 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,853,842	_2,853,842	_~	_~	_~	_{p=1.000 n=6}
_Types	_968,167	_968,167	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,020,740k (± 0.00%)}	_{3,020,693k (± 0.00%)}	_~	_3,020,621k	_3,020,731k	_{p=0.066 n=6}
_{Parse Time}	_{13.65s (± 0.36%)}	_{13.67s (± 0.12%)}	_~	_13.64s	_13.68s	_{p=0.677 n=6}
_{Bind Time}	_{4.21s (± 2.12%)}	_{4.17s (± 0.25%)}	_~	_4.16s	_4.19s	_{p=0.459 n=6}
_{Check Time}	_{73.81s (± 0.29%)}	_{74.00s (± 0.58%)}	_~	_73.58s	_74.83s	_{p=0.872 n=6}
_{Emit Time}	_{23.65s (± 1.08%)}	_{23.71s (± 1.39%)}	_~	_23.20s	_24.21s	_{p=0.689 n=6}
_{Total Time}	_{115.31s (± 0.26%)}	_{115.55s (± 0.28%)}	_~	_115.03s	_115.94s	_{p=0.128 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,914	_266,914	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,685	_108,685	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,414k (± 0.02%)}	_{411,384k (± 0.02%)}	_~	_411,332k	_411,506k	_{p=0.336 n=6}
_{Parse Time}	_{3.81s (± 0.68%)}	_{3.80s (± 0.40%)}	_~	_3.79s	_3.83s	_{p=0.565 n=6}
_{Bind Time}	_{1.69s (± 0.48%)}	_{1.69s (± 0.61%)}	_~	_1.68s	_1.71s	_{p=0.270 n=6}
_{Check Time}	_{16.96s (± 0.35%)}	_{16.93s (± 0.40%)}	_~	_16.82s	_17.00s	_{p=0.470 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.46s (± 0.29%)}	_{22.42s (± 0.31%)}	_~	_22.33s	_22.51s	_{p=0.422 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_523,429	_523,429	_~	_~	_~	_{p=1.000 n=6}
_Types	_177,955	_177,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{461,398k (± 0.05%)}	_{461,637k (± 0.07%)}	_~	_461,183k	_461,966k	_{p=0.128 n=6}
_{Parse Time}	_{3.15s (± 0.65%)}	_{3.17s (± 0.44%)}	_~	_3.15s	_3.18s	_{p=0.162 n=6}
_{Bind Time}	_1.18s	_{1.18s (± 0.44%)}	_~	_1.18s	_1.19s	_{p=0.174 n=6}
_{Check Time}	_{18.18s (± 0.25%)}	_{18.24s (± 0.46%)}	_~	_18.15s	_18.39s	_{p=0.127 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.51s (± 0.21%)}	_{22.58s (± 0.36%)}	_~	_22.51s	_22.74s	_{p=0.051 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Jake Bailey (jakebailey) · 2024-06-13T21:40:55Z

This is going to be awesome for benchmarking and extended testing, since we'll actually be able to build build-mode projects without them short circuiting, right?

TypeScript Bot (typescript-bot) · 2024-06-13T22:43:23Z

Sheetal Nandi (@sheetalkamat) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/58854/merge:

Everything looks good!

Sheetal Nandi (sheetalkamat) · 2024-06-14T16:51:35Z

This is going to be awesome for benchmarking and extended testing, since we'll actually be able to build build-mode projects without them short circuiting, right?

Yes. While debugging you could just build without having to block on errors

Sheetal Nandi (sheetalkamat) · 2024-06-14T17:57:25Z

#58854 (comment) shows how more packages are being built and errors are reported

Wesley Wigham (weswigham)

Since we don't do project concatenation anymore, there's not even a reason to block when noEmitOnError is set, neat.

Jake Bailey (jakebailey)

So excited for this one.

Are there any issues that this closes? I assume that docs will have to be updated too (surely we document the short circuiting somewhere...).

I also assume that nobody's hard depending on this behavior and we don't need some sort of flag to ask build mode to bail early on failures?

Sheetal Nandi (sheetalkamat) · 2024-06-14T20:11:59Z

I am hoping we dont need a flag. If the need arises we should evaluate adding the flag at that point.

Daniel Rosenwasser (DanielRosenwasser) · 2024-06-14T20:28:58Z

Could that flag be --noEmitOnError?

Sheetal Nandi (sheetalkamat) · 2024-06-14T21:45:13Z

Daniel Rosenwasser (@DanielRosenwasser) when i was working on this, i tried that option already and it has no effect, because "d.ts" files from referenced projects will not have errors and blocking project build just because its dependency had error means nothing really. its really whether d.ts file from referenced project has changed or not.

Stav Alfi (stavalfi) · 2024-06-21T17:53:41Z

Sheetal Nandi (@sheetalkamat) Does this PR means that if project1 depends on project2, if project 2 has an error, I would eventually see compilation errors in both projects?
if yes, this is such an awasome PR!!!!!

Sheetal Nandi (sheetalkamat) · 2024-06-21T19:52:44Z

Sheetal Nandi (@sheetalkamat) Does this PR means that if project1 depends on project2, if project 2 has an error, I would eventually see compilation errors in both projects? if yes, this is such an awasome PR!!!!!

Yes

Build project even if it upstream has errors
536d50f

TypeScript Bot (typescript-bot) assigned Sheetal Nandi (sheetalkamat)Jun 13, 2024

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 13, 2024

Sheetal Nandi (sheetalkamat) requested review from Andrew Branch (andrewbranch), Jake Bailey (jakebailey) and Wesley Wigham (weswigham)June 14, 2024 17:56

Sheetal Nandi (sheetalkamat) marked this pull request as ready for review June 14, 2024 17:56

Merge branch 'main' into alwaysBuildDependency
b575d6e

Wesley Wigham (weswigham) approved these changes Jun 14, 2024
View reviewed changes

Jake Bailey (jakebailey) approved these changes Jun 14, 2024
View reviewed changes

Sheetal Nandi (sheetalkamat) merged commit d44c9c3 into mainJun 14, 2024

Sheetal Nandi (sheetalkamat) deleted the alwaysBuildDependency branch June 14, 2024 20:12

Daniel Rosenwasser (DanielRosenwasser) added this to the TypeScript 5.6.0 milestone Jun 14, 2024

Jake Bailey (jakebailey) mentioned this pull request Jul 10, 2024
Disable noEmitOnError #59223
Merged

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Jul 11, 2024
TypeScript 5.6 Iteration Plan #59250
Closed

Sheetal Nandi (sheetalkamat) mentioned this pull request Jul 26, 2024
Add option --stopBuildOnErrors to tsbuild to get previous behavior of not building downstream projects if upstream has errors #59433
Merged

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Uh oh!

Conversation

Sheetal Nandi (sheetalkamat) commented Jun 13, 2024

Uh oh!

Sheetal Nandi (sheetalkamat) commented Jun 13, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 13, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 13, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 13, 2024

effect

tsconfig.json

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 13, 2024

tsc

Uh oh!

Jake Bailey (jakebailey) commented Jun 13, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 13, 2024

Uh oh!

Sheetal Nandi (sheetalkamat) commented Jun 14, 2024

Uh oh!

Sheetal Nandi (sheetalkamat) commented Jun 14, 2024

Uh oh!

Wesley Wigham (weswigham) left a comment

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey) left a comment

Choose a reason for hiding this comment

Uh oh!

Sheetal Nandi (sheetalkamat) commented Jun 14, 2024

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Jun 14, 2024

Uh oh!

Sheetal Nandi (sheetalkamat) commented Jun 14, 2024

Uh oh!

Stav Alfi (stavalfi) commented Jun 21, 2024

Uh oh!

Sheetal Nandi (sheetalkamat) commented Jun 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

TypeScript Bot (typescript-bot) commented Jun 13, 2024•
edited
Loading