Uh oh!
There was an error while loading. Please reload this page.
Defer creation of barebonesLibSourceFile - #58931
Merged
Jake Bailey (jakebailey) merged 1 commit intoJun 19, 2024
Merged
Conversation
Co-authored-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
Jake Bailey (jakebailey)
requested review from
Daniel Rosenwasser (DanielRosenwasser) and Wesley Wigham (weswigham)June 19, 2024 16:48
Jake Bailey (jakebailey)
commented
Jun 19, 2024
MemberAuthor
TypeScript Bot (@typescript-bot) perf test this |
Contributor
TypeScript Bot (typescript-bot)
commented
Jun 19, 2024
Contributor
Jake Bailey (@jakebailey) Here they are:tscComparison Report - baseline..pr
System info unknown Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown Hosts
Scenarios
startupComparison Report - baseline..pr
System info unknown Hosts
Scenarios
Developer Information: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Jake Bailey (jakebailey)
commented
Jun 19, 2024
MemberAuthor
Yeah that's 4% startup time. |
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Jun 19, 2024
Member
TypeScript Bot (@typescript-bot) cherry-pick this to release-5.5 |
Contributor
TypeScript Bot (typescript-bot)
commented
Jun 19, 2024
Contributor
Hey, Daniel Rosenwasser (@DanielRosenwasser)! I've created #58933 for you. |
Wesley Wigham (weswigham)
approved these changes
Jun 19, 2024
Daniel Rosenwasser (DanielRosenwasser) pushed a commit
that referenced
this pull request
Jun 19, 2024
…e-5.5 (#58933) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out of #58928.
Locally, this looks like a big win for typescript.js startup:
Also, this apparently runs before services swaps out the object allocators, so it causes a decrease in monomorphism.