Skip to content

Update knip - #59182

Merged
Jake Bailey (jakebailey) merged 1 commit into
microsoft:mainfrom
webpro:knip-slim
Jul 8, 2024
Merged

Update knip#59182
Jake Bailey (jakebailey) merged 1 commit into
microsoft:mainfrom
webpro:knip-slim

Conversation

@webpro

Copy link
Copy Markdown
Contributor

Sorry, no ticket. Reference: #56817 (comment). Let me know if I should still create one.

Follow-up to #56817. slim down Knip further.

@typescript-botTypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 8, 2024
@jakebailey

Copy link
Copy Markdown
Member

Seems like 5.25 is broken; an old import left behind?

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/runner/work/TypeScript/TypeScript/node_modules/knip/vendor/bash-parser/index.js' imported from /home/runner/work/TypeScript/TypeScript/node_modules/knip/dist/binaries/bash-parser.js
at finalizeResolution (node:internal/modules/esm/resolve:260:11)
at moduleResolve (node:internal/modules/esm/resolve:921:10)
at defaultResolve (node:internal/modules/esm/resolve:11[20](https://github.com/microsoft/TypeScript/actions/runs/9845364241/job/27180753018?pr=59182#step:5:21):11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:526:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:249:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49) {
code: 'ERR_MODULE_NOT_FOUND',
url: 'file:///home/runner/work/TypeScript/TypeScript/node_modules/knip/vendor/bash-parser/index.js'
}

@webpro

Copy link
Copy Markdown
ContributorAuthor

Thanks for the catch! Forgot to add vendor to package.json#files to publish. Same relative path so went unnoticed even in integration tests.

@webpro
Lars Kappert (webpro) marked this pull request as ready for review July 8, 2024 20:20
@typescript-bot

Copy link
Copy Markdown
Contributor

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@jakebailey
Jake Bailey (jakebailey) merged commit eb23677 into microsoft:mainJul 8, 2024
@webpro
Lars Kappert (webpro) deleted the knip-slim branch July 9, 2024 06:01
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Uncommitted BugPR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@webpro@jakebailey@typescript-bot