Make types monomorphic by dragomirtitian · Pull Request #59191 · microsoft/TypeScript

Titian Cernicova-Dragomir (dragomirtitian) · 2024-07-08T22:57:53Z

Part of #58928 - Only make types monomorphic.

Jake Bailey (jakebailey) · 2024-07-08T23:06:04Z

TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2024-07-08T23:06:07Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-07-09T00:14:56Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,820k (± 0.76%)}	_{194,722k (± 0.79%)}	_{+1,901k (+ 0.99%)}	_194,060k	_197,861k	_{p=0.045 n=6}
_{Parse Time}	_{1.30s (± 0.42%)}	_{1.31s (± 0.31%)}	_~	_1.31s	_1.32s	_{p=0.054 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.42s (± 0.27%)}	_{7.75s (± 0.69%)}	_{🟩-1.67s (-17.74%)}	_7.65s	_7.79s	_{p=0.005 n=6}
_{Emit Time}	_{2.74s (± 0.76%)}	_{2.71s (± 0.49%)}	_{-0.03s (- 1.03%)}	_2.69s	_2.73s	_{p=0.043 n=6}
_{Total Time}	_{14.18s (± 0.19%)}	_{12.48s (± 0.36%)}	_{🟩-1.70s (-11.95%)}	_12.40s	_12.52s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,350k (± 0.00%)}	_{1,231,603k (± 0.00%)}	_{+13,253k (+ 1.09%)}	_1,231,532k	_1,231,637k	_{p=0.005 n=6}
_{Parse Time}	_{7.94s (± 0.37%)}	_{7.97s (± 0.67%)}	_~	_7.93s	_8.07s	_{p=0.293 n=6}
_{Bind Time}	_{2.21s (± 0.83%)}	_{2.21s (± 0.74%)}	_~	_2.19s	_2.24s	_{p=0.622 n=6}
_{Check Time}	_{35.60s (± 0.30%)}	_{31.65s (± 0.28%)}	_{🟩-3.95s (-11.10%)}	_31.53s	_31.73s	_{p=0.005 n=6}
_{Emit Time}	_{16.11s (± 0.75%)}	_{16.07s (± 0.49%)}	_~	_15.92s	_16.13s	_{p=1.000 n=6}
_{Total Time}	_{61.86s (± 0.26%)}	_{57.90s (± 0.12%)}	_{🟩-3.96s (- 6.40%)}	_57.81s	_58.00s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,130,343	_2,130,343	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,684	_927,684	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,107,307k (± 0.01%)}	_{2,132,992k (± 0.00%)}	_{+25,685k (+ 1.22%)}	_2,132,934k	_2,133,060k	_{p=0.005 n=6}
_{Parse Time}	_{6.61s (± 0.32%)}	_{6.61s (± 0.22%)}	_~	_6.59s	_6.63s	_{p=0.744 n=6}
_{Bind Time}	_{2.33s (± 0.98%)}	_{2.32s (± 0.35%)}	_~	_2.31s	_2.33s	_{p=0.869 n=6}
_{Check Time}	_{70.41s (± 1.24%)}	_{54.51s (± 0.16%)}	_{🟩-15.90s (-22.59%)}	_54.40s	_54.60s	_{p=0.005 n=6}
_{Emit Time}	_{0.14s (± 5.44%)}	_{0.14s (± 2.95%)}	_~	_0.13s	_0.14s	_{p=1.000 n=6}
_{Total Time}	_{79.49s (± 1.08%)}	_{63.58s (± 0.13%)}	_{🟩-15.91s (-20.02%)}	_63.46s	_63.67s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,588	_1,228,769	_{+3,181 (+ 0.26%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,474	_261,559	_{+85 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,341,105k (± 0.01%)}	_{2,358,676k (± 0.06%)}	_{+17,570k (+ 0.75%)}	_2,357,042k	_2,360,562k	_{p=0.005 n=6}
_{Parse Time}	_{5.03s (± 1.19%)}	_{5.00s (± 0.86%)}	_~	_4.94s	_5.05s	_{p=0.575 n=6}
_{Bind Time}	_{1.90s (± 0.80%)}	_{1.94s (± 2.23%)}	_{+0.04s (+ 2.37%)}	_1.90s	_2.02s	_{p=0.023 n=6}
_{Check Time}	_{34.17s (± 0.31%)}	_{30.91s (± 0.24%)}	_{🟩-3.26s (- 9.54%)}	_30.81s	_30.99s	_{p=0.005 n=6}
_{Emit Time}	_{2.60s (± 2.82%)}	_{2.62s (± 3.18%)}	_~	_2.51s	_2.72s	_{p=0.873 n=6}
_{Total Time}	_{43.72s (± 0.20%)}	_{40.50s (± 0.31%)}	_{🟩-3.22s (- 7.37%)}	_40.32s	_40.67s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,588	_1,228,769	_{+3,181 (+ 0.26%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,474	_261,559	_{+85 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,414,993k (± 0.03%)}	_{2,442,836k (± 1.01%)}	_{+27,843k (+ 1.15%)}	_2,431,943k	_2,493,227k	_{p=0.005 n=6}
_{Parse Time}	_{6.27s (± 0.88%)}	_{6.31s (± 1.05%)}	_~	_6.22s	_6.39s	_{p=0.423 n=6}
_{Bind Time}	_{2.03s (± 0.90%)}	_{2.04s (± 0.84%)}	_~	_2.02s	_2.07s	_{p=0.413 n=6}
_{Check Time}	_{40.87s (± 0.71%)}	_{37.00s (± 0.08%)}	_{🟩-3.87s (- 9.47%)}	_36.98s	_37.05s	_{p=0.005 n=6}
_{Emit Time}	_{3.23s (± 6.29%)}	_{3.20s (± 2.40%)}	_~	_3.12s	_3.32s	_{p=0.521 n=6}
_{Total Time}	_{52.40s (± 0.72%)}	_{48.58s (± 0.25%)}	_{🟩-3.82s (- 7.28%)}	_48.44s	_48.78s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,188	_258,776	_{+588 (+ 0.23%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,737	_104,887	_{+150 (+ 0.14%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{427,458k (± 0.01%)}	_{432,522k (± 0.02%)}	_{+5,064k (+ 1.18%)}	_432,425k	_432,664k	_{p=0.005 n=6}
_{Parse Time}	_{4.07s (± 0.52%)}	_{4.08s (± 0.48%)}	_~	_4.05s	_4.10s	_{p=0.367 n=6}
_{Bind Time}	_{1.61s (± 1.69%)}	_{1.64s (± 1.58%)}	_~	_1.60s	_1.66s	_{p=0.090 n=6}
_{Check Time}	_{22.02s (± 0.31%)}	_{19.39s (± 0.20%)}	_{🟩-2.63s (-11.94%)}	_19.33s	_19.43s	_{p=0.005 n=6}
_{Emit Time}	_{1.56s (± 1.12%)}	_{1.55s (± 1.20%)}	_~	_1.52s	_1.57s	_{p=0.511 n=6}
_{Total Time}	_{29.26s (± 0.31%)}	_{26.66s (± 0.25%)}	_{🟩-2.60s (- 8.90%)}	_26.59s	_26.75s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,526k (± 0.02%)}	_{373,034k (± 0.04%)}	_{+3,507k (+ 0.95%)}	_372,890k	_373,307k	_{p=0.005 n=6}
_{Parse Time}	_{2.31s (± 0.45%)}	_{2.31s (± 0.59%)}	_~	_2.30s	_2.34s	_{p=0.391 n=6}
_{Bind Time}	_{1.33s (± 1.62%)}	_{1.32s (± 0.31%)}	_~	_1.32s	_1.33s	_{p=0.473 n=6}
_{Check Time}	_{13.12s (± 0.34%)}	_{11.66s (± 0.29%)}	_{🟩-1.46s (-11.15%)}	_11.60s	_11.69s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{16.76s (± 0.24%)}	_{15.29s (± 0.24%)}	_{🟩-1.47s (- 8.75%)}	_15.23s	_15.32s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,884,910	_2,884,910	_~	_~	_~	_{p=1.000 n=6}
_Types	_976,550	_976,550	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,047,952k (± 0.00%)}	_{3,080,785k (± 0.00%)}	_{+32,833k (+ 1.08%)}	_3,080,741k	_3,080,848k	_{p=0.005 n=6}
_{Parse Time}	_{13.75s (± 0.16%)}	_{13.76s (± 0.46%)}	_~	_13.68s	_13.84s	_{p=1.000 n=6}
_{Bind Time}	_{4.21s (± 2.04%)}	_{4.17s (± 0.25%)}	_~	_4.15s	_4.18s	_{p=0.250 n=6}
_{Check Time}	_{75.18s (± 2.30%)}	_{70.14s (± 0.22%)}	_{🟩-5.03s (- 6.69%)}	_69.88s	_70.37s	_{p=0.005 n=6}
_{Emit Time}	_{22.48s (± 8.25%)}	_{20.21s (± 0.55%)}	_~	_20.08s	_20.40s	_{p=0.066 n=6}
_{Total Time}	_{115.62s (± 0.30%)}	_{108.29s (± 0.25%)}	_{🟩-7.33s (- 6.34%)}	_107.95s	_108.75s	_{p=0.005 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,548k (± 0.01%)}	_{415,575k (± 0.01%)}	_{+4,027k (+ 0.98%)}	_415,522k	_415,630k	_{p=0.005 n=6}
_{Parse Time}	_{3.18s (± 0.70%)}	_{3.16s (± 0.64%)}	_~	_3.14s	_3.18s	_{p=0.111 n=6}
_{Bind Time}	_{1.42s (± 0.53%)}	_{1.42s (± 0.29%)}	_~	_1.41s	_1.42s	_{p=1.000 n=6}
_{Check Time}	_{14.20s (± 0.31%)}	_{13.44s (± 0.30%)}	_{🟩-0.76s (- 5.33%)}	_13.41s	_13.52s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.80s (± 0.20%)}	_{18.03s (± 0.32%)}	_{🟩-0.78s (- 4.13%)}	_17.97s	_18.12s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,773k (± 0.07%)}	_{468,377k (± 0.04%)}	_{+5,604k (+ 1.21%)}	_468,216k	_468,625k	_{p=0.005 n=6}
_{Parse Time}	_{3.93s (± 0.39%)}	_{3.92s (± 0.62%)}	_~	_3.89s	_3.96s	_{p=0.684 n=6}
_{Bind Time}	_{1.45s (± 1.07%)}	_{1.46s (± 1.81%)}	_~	_1.44s	_1.51s	_{p=0.337 n=6}
_{Check Time}	_{22.14s (± 0.22%)}	_{19.48s (± 0.34%)}	_{🟩-2.66s (-12.01%)}	_19.38s	_19.58s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.52s (± 0.21%)}	_{24.87s (± 0.27%)}	_{🟩-2.65s (- 9.62%)}	_24.79s	_24.98s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,425ms (± 0.64%)}	_{3,430ms (± 0.49%)}	_~	_3,401ms	_3,442ms	_{p=0.470 n=6}
_{Req 2 - geterr}	_{7,503ms (± 0.44%)}	_{6,637ms (± 0.60%)}	_{🟩-866ms (-11.54%)}	_6,593ms	_6,685ms	_{p=0.005 n=6}
_{Req 3 - references}	_{394ms (± 0.25%)}	_{395ms (± 0.31%)}	_~	_394ms	_397ms	_{p=0.734 n=6}
_{Req 4 - navto}	_{340ms (± 0.22%)}	_{340ms (± 0.49%)}	_~	_338ms	_342ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{130ms (± 1.15%)}	_{118ms (± 6.42%)}	_{🟩-12ms (- 9.21%)}	_112ms	_128ms	_{p=0.007 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,591ms (± 1.30%)}	_{3,590ms (± 0.65%)}	_~	_3,560ms	_3,624ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{5,552ms (± 0.55%)}	_{5,278ms (± 0.08%)}	_{🟩-274ms (- 4.93%)}	_5,273ms	_5,283ms	_{p=0.005 n=6}
_{Req 3 - references}	_{416ms (± 0.25%)}	_{415ms (± 0.20%)}	_~	_413ms	_415ms	_{p=0.122 n=6}
_{Req 4 - navto}	_{338ms (± 0.75%)}	_{338ms (± 1.88%)}	_~	_334ms	_351ms	_{p=0.189 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{110ms (± 0.37%)}	_{104ms (± 6.68%)}	_~	_99ms	_117ms	_{p=0.056 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{7,736ms (± 0.40%)}	_{7,740ms (± 0.26%)}	_~	_7,700ms	_7,756ms	_{p=0.689 n=6}
_{Req 2 - geterr}	_{1,699ms (± 0.64%)}	_{1,544ms (± 1.44%)}	_{🟩-155ms (- 9.12%)}	_1,527ms	_1,588ms	_{p=0.005 n=6}
_{Req 3 - references}	_{113ms (± 4.07%)}	_{111ms (± 0.99%)}	_~	_110ms	_113ms	_{p=0.652 n=6}
_{Req 4 - navto}	_{594ms (± 1.32%)}	_{597ms (± 2.84%)}	_~	_581ms	_628ms	_{p=0.747 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{1,228ms (± 2.28%)}	_{1,251ms (± 0.56%)}	_~	_1,241ms	_1,259ms	_{p=0.066 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{188.10ms (± 0.18%)}	_{188.53ms (± 0.16%)}	_{+0.42ms (+ 0.23%)}	_187.03ms	_193.25ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{345.09ms (± 0.28%)}	_{346.12ms (± 0.29%)}	_{+1.04ms (+ 0.30%)}	_337.34ms	_349.93ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{336.76ms (± 0.31%)}	_{337.88ms (± 0.30%)}	_{+1.12ms (+ 0.33%)}	_329.83ms	_344.39ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{226.11ms (± 0.16%)}	_{226.96ms (± 0.20%)}	_{+0.85ms (+ 0.37%)}	_225.16ms	_236.15ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Make types monomorphic
840c489

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 8, 2024

Titian Cernicova-Dragomir (dragomirtitian) mentioned this pull request Jul 9, 2024
Performance: Monomorphic AST Nodes #59198
Open

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Jul 11, 2024
Modified parse node definitions so they are all "monomorphic" (the sa… microsoft/pyright#8371
Closed

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Oct 18, 2024
Design Meeting Notes, 9/6/2024 #60282
Closed

Titian Cernicova-Dragomir (dragomirtitian) closed this Dec 15, 2025

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Jun 23, 2026

Navigation Menu

Uh oh!

Make types monomorphic - #59191

Make types monomorphic#59191
Titian Cernicova-Dragomir (dragomirtitian) wants to merge 1 commit into
microsoft:mainfrom
bloomberg:experiment-monomorphic-type

Titian Cernicova-Dragomir (dragomirtitian) commented Jul 8, 2024

Uh oh!

Jake Bailey (jakebailey) commented Jul 8, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 8, 2024•
edited
Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 9, 2024

tsc

tsserver

startup

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Titian Cernicova-Dragomir (dragomirtitian) commented Jul 8, 2024

Uh oh!

Jake Bailey (jakebailey) commented Jul 8, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 8, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 9, 2024

tsc

tsserver

startup

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TypeScript Bot (typescript-bot) commented Jul 8, 2024•
edited
Loading