Make Signature monomorphic by dragomirtitian · Pull Request #59192 · microsoft/TypeScript

Titian Cernicova-Dragomir (dragomirtitian) · 2024-07-08T22:57:56Z

Part of #58928 - Only make signatures monomorphic.

Jake Bailey (jakebailey) · 2024-07-08T23:06:01Z

TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2024-07-08T23:06:03Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-07-09T00:07:31Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,434k (± 0.94%)}	_{193,349k (± 0.94%)}	_~	_192,087k	_195,686k	_{p=0.298 n=6}
_{Parse Time}	_{1.30s (± 0.40%)}	_{1.30s (± 0.63%)}	_~	_1.29s	_1.31s	_{p=0.929 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.46s (± 0.34%)}	_{9.41s (± 0.27%)}	_{-0.05s (- 0.56%)}	_9.39s	_9.45s	_{p=0.019 n=6}
_{Emit Time}	_{2.75s (± 0.63%)}	_{2.73s (± 0.45%)}	_~	_2.72s	_2.75s	_{p=0.188 n=6}
_{Total Time}	_{14.22s (± 0.25%)}	_{14.16s (± 0.14%)}	_{-0.06s (- 0.45%)}	_14.13s	_14.18s	_{p=0.013 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,377k (± 0.00%)}	_{1,217,450k (± 0.00%)}	_{-927k (- 0.08%)}	_1,217,400k	_1,217,506k	_{p=0.005 n=6}
_{Parse Time}	_{7.99s (± 0.82%)}	_{7.98s (± 0.30%)}	_~	_7.95s	_8.01s	_{p=0.935 n=6}
_{Bind Time}	_{2.23s (± 0.55%)}	_{2.24s (± 0.77%)}	_~	_2.22s	_2.26s	_{p=0.157 n=6}
_{Check Time}	_{35.90s (± 0.44%)}	_{35.28s (± 0.44%)}	_{-0.62s (- 1.72%)}	_35.14s	_35.53s	_{p=0.005 n=6}
_{Emit Time}	_{16.18s (± 0.29%)}	_{16.14s (± 0.88%)}	_~	_15.93s	_16.35s	_{p=0.296 n=6}
_{Total Time}	_{62.29s (± 0.26%)}	_{61.63s (± 0.23%)}	_{-0.66s (- 1.06%)}	_61.48s	_61.88s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,130,343	_2,130,343	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,684	_927,684	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,107,262k (± 0.00%)}	_{2,106,585k (± 0.00%)}	_{-677k (- 0.03%)}	_2,106,545k	_2,106,627k	_{p=0.005 n=6}
_{Parse Time}	_{6.62s (± 0.32%)}	_{6.62s (± 0.35%)}	_~	_6.58s	_6.64s	_{p=0.623 n=6}
_{Bind Time}	_{2.33s (± 0.42%)}	_{2.32s (± 0.35%)}	_~	_2.31s	_2.33s	_{p=0.181 n=6}
_{Check Time}	_{70.79s (± 0.45%)}	_{70.48s (± 0.31%)}	_~	_70.17s	_70.77s	_{p=0.065 n=6}
_{Emit Time}	_{0.13s (± 3.87%)}	_{0.14s (± 4.05%)}	_~	_0.13s	_0.14s	_{p=0.640 n=6}
_{Total Time}	_{79.87s (± 0.39%)}	_{79.56s (± 0.29%)}	_{-0.31s (- 0.39%)}	_79.27s	_79.85s	_{p=0.044 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,588	_1,226,038	_{+450 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,474	_261,486	_{+12 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,341,817k (± 0.03%)}	_{2,341,437k (± 0.07%)}	_~	_2,339,612k	_2,343,777k	_{p=0.575 n=6}
_{Parse Time}	_{6.02s (± 0.79%)}	_{6.05s (± 0.91%)}	_~	_5.99s	_6.13s	_{p=0.575 n=6}
_{Bind Time}	_{2.25s (± 0.46%)}	_{2.26s (± 0.67%)}	_~	_2.24s	_2.28s	_{p=0.517 n=6}
_{Check Time}	_{40.37s (± 0.81%)}	_{39.69s (± 0.86%)}	_{-0.68s (- 1.68%)}	_39.27s	_40.24s	_{p=0.013 n=6}
_{Emit Time}	_{3.05s (± 2.91%)}	_{3.20s (± 1.42%)}	_{🔻+0.15s (+ 4.80%)}	_3.14s	_3.27s	_{p=0.013 n=6}
_{Total Time}	_{51.73s (± 0.86%)}	_{51.22s (± 0.68%)}	_~	_50.85s	_51.76s	_{p=0.066 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,588	_1,226,038	_{+450 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,474	_261,486	_{+12 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,415,051k (± 0.03%)}	_{2,417,086k (± 0.18%)}	_~	_2,413,763k	_2,422,674k	_{p=0.936 n=6}
_{Parse Time}	_{5.20s (± 1.08%)}	_{5.19s (± 0.90%)}	_~	_5.13s	_5.26s	_{p=0.748 n=6}
_{Bind Time}	_{1.70s (± 0.61%)}	_{1.69s (± 0.48%)}	_~	_1.68s	_1.70s	_{p=0.112 n=6}
_{Check Time}	_{34.60s (± 0.30%)}	_{34.05s (± 0.33%)}	_{-0.54s (- 1.57%)}	_33.89s	_34.17s	_{p=0.005 n=6}
_{Emit Time}	_{2.69s (± 5.31%)}	_{2.71s (± 2.43%)}	_~	_2.63s	_2.82s	_{p=0.128 n=6}
_{Total Time}	_{44.18s (± 0.48%)}	_{43.66s (± 0.32%)}	_{-0.52s (- 1.17%)}	_43.48s	_43.81s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,188	_258,235	_{+47 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,737	_104,744	_{+7 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{427,463k (± 0.01%)}	_{427,322k (± 0.01%)}	_{-141k (- 0.03%)}	_427,270k	_427,373k	_{p=0.005 n=6}
_{Parse Time}	_{2.71s (± 0.71%)}	_{2.70s (± 1.86%)}	_~	_2.60s	_2.75s	_{p=0.935 n=6}
_{Bind Time}	_{1.10s (± 1.24%)}	_{1.11s (± 2.70%)}	_~	_1.09s	_1.17s	_{p=0.370 n=6}
_{Check Time}	_{15.14s (± 0.33%)}	_{14.88s (± 0.36%)}	_{-0.26s (- 1.72%)}	_14.81s	_14.97s	_{p=0.005 n=6}
_{Emit Time}	_{1.07s (± 1.84%)}	_{1.06s (± 1.73%)}	_~	_1.04s	_1.09s	_{p=0.564 n=6}
_{Total Time}	_{20.01s (± 0.35%)}	_{19.74s (± 0.30%)}	_{-0.27s (- 1.35%)}	_19.67s	_19.82s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,561k (± 0.04%)}	_{369,300k (± 0.02%)}	_{-261k (- 0.07%)}	_369,181k	_369,373k	_{p=0.005 n=6}
_{Parse Time}	_{2.31s (± 0.45%)}	_{2.30s (± 0.93%)}	_~	_2.26s	_2.32s	_{p=0.211 n=6}
_{Bind Time}	_{1.32s (± 0.57%)}	_{1.32s (± 1.48%)}	_~	_1.29s	_1.35s	_{p=0.672 n=6}
_{Check Time}	_{13.14s (± 0.19%)}	_{12.87s (± 0.25%)}	_{-0.27s (- 2.04%)}	_12.81s	_12.90s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{16.77s (± 0.13%)}	_{16.49s (± 0.27%)}	_{-0.29s (- 1.72%)}	_16.44s	_16.54s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,884,910	_2,884,910	_~	_~	_~	_{p=1.000 n=6}
_Types	_976,550	_976,550	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,047,989k (± 0.00%)}	_{3,046,090k (± 0.00%)}	_{-1,899k (- 0.06%)}	_3,046,056k	_3,046,192k	_{p=0.005 n=6}
_{Parse Time}	_{16.88s (± 0.16%)}	_{16.93s (± 0.09%)}	_{+0.05s (+ 0.31%)}	_16.90s	_16.94s	_{p=0.010 n=6}
_{Bind Time}	_{5.12s (± 2.01%)}	_{5.13s (± 1.81%)}	_~	_5.06s	_5.31s	_{p=0.872 n=6}
_{Check Time}	_{91.71s (± 2.83%)}	_{89.22s (± 2.12%)}	_~	_87.92s	_92.83s	_{p=0.066 n=6}
_{Emit Time}	_{26.89s (± 9.23%)}	_{28.20s (± 6.75%)}	_~	_24.59s	_29.44s	_{p=0.377 n=6}
_{Total Time}	_{140.60s (± 0.14%)}	_{139.47s (± 0.21%)}	_{-1.13s (- 0.80%)}	_139.16s	_139.98s	_{p=0.005 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,617k (± 0.02%)}	_{411,235k (± 0.01%)}	_{-382k (- 0.09%)}	_411,187k	_411,323k	_{p=0.005 n=6}
_{Parse Time}	_{4.70s (± 0.59%)}	_{4.69s (± 0.29%)}	_~	_4.66s	_4.70s	_{p=0.460 n=6}
_{Bind Time}	_{2.07s (± 0.56%)}	_{2.08s (± 0.80%)}	_~	_2.06s	_2.10s	_{p=0.222 n=6}
_{Check Time}	_{20.77s (± 0.44%)}	_{20.44s (± 0.39%)}	_{-0.33s (- 1.57%)}	_20.35s	_20.55s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.54s (± 0.44%)}	_{27.21s (± 0.32%)}	_{-0.33s (- 1.19%)}	_27.12s	_27.34s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,616k (± 0.05%)}	_{462,641k (± 0.07%)}	_~	_462,210k	_462,979k	_{p=0.936 n=6}
_{Parse Time}	_{3.93s (± 0.41%)}	_{3.94s (± 0.71%)}	_~	_3.91s	_3.97s	_{p=0.870 n=6}
_{Bind Time}	_{1.45s (± 0.68%)}	_{1.45s (± 0.62%)}	_~	_1.44s	_1.46s	_{p=0.931 n=6}
_{Check Time}	_{22.17s (± 0.46%)}	_{22.03s (± 0.55%)}	_~	_21.91s	_22.20s	_{p=0.093 n=6}
_{Emit Time}	_0.00s	_{0.00s (±154.76%)}	_~	_0.00s	_0.01s	_{p=0.174 n=6}
_{Total Time}	_{27.55s (± 0.35%)}	_{27.42s (± 0.41%)}	_~	_27.31s	_27.57s	_{p=0.127 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,915ms (± 9.64%)}	_{2,880ms (± 9.19%)}	_~	_2,743ms	_3,419ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{6,950ms (± 9.50%)}	_{7,108ms (± 6.97%)}	_~	_6,097ms	_7,352ms	_{p=0.471 n=6}
_{Req 3 - references}	_{369ms (±10.44%)}	_{371ms (±10.46%)}	_~	_321ms	_402ms	_{p=0.683 n=6}
_{Req 4 - navto}	_{340ms (± 0.55%)}	_{329ms (± 7.60%)}	_~	_279ms	_342ms	_{p=0.567 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{131ms (± 0.39%)}	_{132ms (± 2.51%)}	_~	_130ms	_139ms	_{p=0.928 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,562ms (± 0.57%)}	_{3,598ms (± 1.26%)}	_~	_3,548ms	_3,672ms	_{p=0.173 n=6}
_{Req 2 - geterr}	_{5,551ms (± 0.77%)}	_{5,446ms (± 0.72%)}	_{-105ms (- 1.88%)}	_5,399ms	_5,510ms	_{p=0.008 n=6}
_{Req 3 - references}	_{413ms (± 0.52%)}	_{413ms (± 0.18%)}	_~	_412ms	_414ms	_{p=0.397 n=6}
_{Req 4 - navto}	_{334ms (± 0.62%)}	_{336ms (± 0.56%)}	_~	_334ms	_339ms	_{p=0.210 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{109ms (± 2.95%)}	_{108ms (± 2.61%)}	_~	_102ms	_109ms	_{p=0.090 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,187ms (± 0.66%)}	_{5,195ms (± 0.38%)}	_~	_5,166ms	_5,212ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{1,124ms (± 1.19%)}	_{1,127ms (± 1.52%)}	_~	_1,100ms	_1,147ms	_{p=0.689 n=6}
_{Req 3 - references}	_{76ms (± 3.67%)}	_{76ms (± 3.15%)}	_~	_75ms	_81ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{457ms (± 0.14%)}	_{457ms (± 0.51%)}	_~	_456ms	_462ms	_{p=0.485 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{833ms (± 1.86%)}	_{827ms (± 1.52%)}	_~	_809ms	_843ms	_{p=0.689 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{187.57ms (± 0.17%)}	_{187.69ms (± 0.20%)}	_{+0.12ms (+ 0.06%)}	_185.91ms	_193.38ms	_{p=0.006 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.74ms (± 0.14%)}	_{231.09ms (± 0.15%)}	_{+0.36ms (+ 0.16%)}	_229.56ms	_238.01ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{226.17ms (± 0.14%)}	_{226.34ms (± 0.15%)}	_{+0.17ms (+ 0.08%)}	_224.78ms	_230.61ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{334.89ms (± 0.30%)}	_{335.10ms (± 0.31%)}	_{+0.21ms (+ 0.06%)}	_326.96ms	_343.11ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Make Signature monomorphic
ef7e09c

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 8, 2024

Titian Cernicova-Dragomir (dragomirtitian) mentioned this pull request Jul 9, 2024
Performance: Monomorphic AST Nodes #59198
Open

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Jul 11, 2024
Modified parse node definitions so they are all "monomorphic" (the sa… microsoft/pyright#8371
Closed

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Oct 18, 2024
Design Meeting Notes, 9/6/2024 #60282
Closed

Titian Cernicova-Dragomir (dragomirtitian) closed this Dec 15, 2025

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Jun 23, 2026

Navigation Menu

Uh oh!

Make Signature monomorphic - #59192

Make Signature monomorphic#59192
Titian Cernicova-Dragomir (dragomirtitian) wants to merge 1 commit into
microsoft:mainfrom
bloomberg:experiment-monomorphic-signature

Titian Cernicova-Dragomir (dragomirtitian) commented Jul 8, 2024

Uh oh!

Jake Bailey (jakebailey) commented Jul 8, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 8, 2024•
edited
Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 9, 2024

tsc

tsserver

startup

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Titian Cernicova-Dragomir (dragomirtitian) commented Jul 8, 2024

Uh oh!

Jake Bailey (jakebailey) commented Jul 8, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 8, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 9, 2024

tsc

tsserver

startup

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TypeScript Bot (typescript-bot) commented Jul 8, 2024•
edited
Loading