Introduce scanning fast paths by DanielRosenwasser · Pull Request #59244 · microsoft/TypeScript

Daniel Rosenwasser (DanielRosenwasser) · 2024-07-11T21:57:17Z

This change is an alternative PR to #59106.

Daniel Rosenwasser (DanielRosenwasser) · 2024-07-11T21:57:32Z

TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2024-07-11T21:57:35Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-07-11T22:35:51Z

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,760k (± 0.76%)}	_{192,815k (± 0.76%)}	_~	_192,105k	_195,785k	_{p=0.689 n=6}
_{Parse Time}	_{1.57s (± 0.62%)}	_{1.55s (± 1.89%)}	_~	_1.52s	_1.59s	_{p=0.192 n=6}
_{Bind Time}	_{0.85s (± 0.96%)}	_{0.85s (± 1.43%)}	_~	_0.84s	_0.87s	_{p=0.730 n=6}
_{Check Time}	_{11.21s (± 0.20%)}	_{11.17s (± 0.41%)}	_~	_11.12s	_11.25s	_{p=0.075 n=6}
_{Emit Time}	_{3.27s (± 0.70%)}	_{3.27s (± 0.71%)}	_~	_3.26s	_3.32s	_{p=1.000 n=6}
_{Total Time}	_{16.90s (± 0.13%)}	_{16.85s (± 0.37%)}	_~	_16.77s	_16.93s	_{p=0.226 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,362k (± 0.00%)}	_{1,218,419k (± 0.00%)}	_~	_1,218,354k	_1,218,497k	_{p=0.054 n=6}
_{Parse Time}	_{7.96s (± 0.20%)}	_{7.96s (± 0.32%)}	_~	_7.92s	_7.98s	_{p=0.935 n=6}
_{Bind Time}	_{2.24s (± 0.68%)}	_{2.23s (± 0.49%)}	_~	_2.22s	_2.25s	_{p=0.618 n=6}
_{Check Time}	_{35.93s (± 0.58%)}	_{35.76s (± 0.31%)}	_~	_35.64s	_35.90s	_{p=0.149 n=6}
_{Emit Time}	_{16.20s (± 0.22%)}	_{16.24s (± 0.67%)}	_~	_16.17s	_16.46s	_{p=1.000 n=6}
_{Total Time}	_{62.32s (± 0.34%)}	_{62.19s (± 0.25%)}	_~	_61.97s	_62.38s	_{p=0.196 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,130,296	_2,130,296	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,656	_927,656	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,107,068k (± 0.01%)}	_{2,106,988k (± 0.00%)}	_~	_2,106,877k	_2,107,157k	_{p=0.230 n=6}
_{Parse Time}	_{9.66s (± 0.42%)}	_{9.59s (± 0.30%)}	_{-0.07s (- 0.71%)}	_9.54s	_9.62s	_{p=0.024 n=6}
_{Bind Time}	_{3.36s (± 1.43%)}	_{3.39s (± 1.53%)}	_~	_3.35s	_3.49s	_{p=0.573 n=6}
_{Check Time}	_{101.26s (± 1.47%)}	_{102.67s (± 0.29%)}	_{+1.41s (+ 1.39%)}	_102.25s	_103.10s	_{p=0.045 n=6}
_{Emit Time}	_{0.20s (± 2.62%)}	_{0.19s (± 4.29%)}	_~	_0.19s	_0.21s	_{p=0.533 n=6}
_{Total Time}	_{114.48s (± 1.29%)}	_{115.85s (± 0.25%)}	_~	_115.42s	_116.19s	_{p=0.054 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,005	_1,226,006	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,615	_261,615	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,338,983k (± 0.01%)}	_{2,339,364k (± 0.02%)}	_~	_2,338,401k	_2,339,828k	_{p=0.128 n=6}
_{Parse Time}	_{7.54s (± 0.86%)}	_{7.45s (± 0.93%)}	_{-0.09s (- 1.22%)}	_7.35s	_7.54s	_{p=0.045 n=6}
_{Bind Time}	_{2.78s (± 1.29%)}	_{2.81s (± 0.32%)}	_~	_2.80s	_2.82s	_{p=0.124 n=6}
_{Check Time}	_{49.41s (± 0.10%)}	_{49.55s (± 0.36%)}	_~	_49.35s	_49.86s	_{p=0.128 n=6}
_{Emit Time}	_{4.80s (± 1.40%)}	_{4.79s (± 0.52%)}	_~	_4.75s	_4.82s	_{p=0.628 n=6}
_{Total Time}	_{64.54s (± 0.13%)}	_{64.61s (± 0.27%)}	_~	_64.40s	_64.91s	_{p=0.748 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,005	_1,226,006	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,615	_261,615	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,413,498k (± 0.05%)}	_{2,413,156k (± 0.03%)}	_~	_2,412,624k	_2,414,402k	_{p=0.810 n=6}
_{Parse Time}	_{6.29s (± 0.97%)}	_{6.27s (± 0.92%)}	_~	_6.17s	_6.34s	_{p=0.423 n=6}
_{Bind Time}	_{2.02s (± 0.68%)}	_{2.03s (± 0.88%)}	_~	_2.01s	_2.06s	_{p=0.123 n=6}
_{Check Time}	_{40.77s (± 0.30%)}	_{40.74s (± 0.21%)}	_~	_40.63s	_40.84s	_{p=0.689 n=6}
_{Emit Time}	_{3.89s (± 2.49%)}	_{3.97s (± 1.51%)}	_~	_3.89s	_4.05s	_{p=0.172 n=6}
_{Total Time}	_{52.98s (± 0.38%)}	_{53.02s (± 0.24%)}	_~	_52.85s	_53.20s	_{p=0.575 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,315	_258,316	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,817	_104,817	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{427,197k (± 0.03%)}	_{427,166k (± 0.02%)}	_~	_427,104k	_427,289k	_{p=1.000 n=6}
_{Parse Time}	_{3.30s (± 0.59%)}	_{3.26s (± 0.68%)}	_{-0.04s (- 1.26%)}	_3.22s	_3.28s	_{p=0.008 n=6}
_{Bind Time}	_{1.31s (± 1.12%)}	_{1.32s (± 1.05%)}	_~	_1.29s	_1.33s	_{p=0.738 n=6}
_{Check Time}	_{17.84s (± 0.55%)}	_{17.82s (± 0.28%)}	_~	_17.76s	_17.88s	_{p=0.748 n=6}
_{Emit Time}	_{1.64s (± 1.36%)}	_{1.64s (± 1.54%)}	_~	_1.61s	_1.67s	_{p=0.934 n=6}
_{Total Time}	_{24.09s (± 0.46%)}	_{24.03s (± 0.27%)}	_~	_23.98s	_24.14s	_{p=0.470 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,545k (± 0.02%)}	_{369,517k (± 0.03%)}	_~	_369,387k	_369,635k	_{p=0.575 n=6}
_{Parse Time}	_{3.44s (± 0.77%)}	_{3.41s (± 0.57%)}	_{-0.03s (- 1.02%)}	_3.38s	_3.43s	_{p=0.035 n=6}
_{Bind Time}	_{1.95s (± 0.95%)}	_{1.94s (± 0.28%)}	_~	_1.94s	_1.95s	_{p=0.498 n=6}
_{Check Time}	_{19.12s (± 0.19%)}	_{19.17s (± 0.30%)}	_~	_19.08s	_19.23s	_{p=0.146 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.52s (± 0.18%)}	_{24.52s (± 0.27%)}	_~	_24.41s	_24.60s	_{p=0.808 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,890,434	_2,890,434	_~	_~	_~	_{p=1.000 n=6}
_Types	_977,956	_977,956	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,054,109k (± 0.00%)}	_{3,054,006k (± 0.00%)}	_{-103k (- 0.00%)}	_3,053,867k	_3,054,090k	_{p=0.013 n=6}
_{Parse Time}	_{11.42s (± 0.26%)}	_{11.42s (± 0.39%)}	_~	_11.36s	_11.47s	_{p=1.000 n=6}
_{Bind Time}	_{3.55s (± 1.86%)}	_{3.53s (± 0.15%)}	_~	_3.52s	_3.53s	_{p=0.560 n=6}
_{Check Time}	_{66.21s (± 2.69%)}	_{63.73s (± 0.17%)}	_{🟩-2.48s (- 3.75%)}	_63.57s	_63.86s	_{p=0.005 n=6}
_{Emit Time}	_{18.16s (± 9.58%)}	_{20.54s (± 1.29%)}	_{🔻+2.38s (+13.12%)}	_20.25s	_20.99s	_{p=0.030 n=6}
_{Total Time}	_{99.35s (± 0.20%)}	_{99.22s (± 0.28%)}	_~	_98.85s	_99.64s	_{p=0.335 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,239	_267,239	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,815	_108,815	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,832k (± 0.03%)}	_{411,844k (± 0.02%)}	_~	_411,730k	_411,957k	_{p=1.000 n=6}
_{Parse Time}	_{4.74s (± 0.36%)}	_{4.72s (± 0.46%)}	_~	_4.70s	_4.75s	_{p=0.290 n=6}
_{Bind Time}	_{2.07s (± 1.12%)}	_{2.08s (± 0.79%)}	_~	_2.07s	_2.11s	_{p=0.406 n=6}
_{Check Time}	_{20.80s (± 0.35%)}	_{20.76s (± 0.32%)}	_~	_20.68s	_20.85s	_{p=0.471 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.61s (± 0.22%)}	_{27.57s (± 0.32%)}	_~	_27.49s	_27.69s	_{p=0.809 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_510,475	_510,475	_~	_~	_~	_{p=1.000 n=6}
_Types	_161,600	_161,600	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{448,256k (± 0.03%)}	_{448,004k (± 0.07%)}	_~	_447,586k	_448,416k	_{p=0.230 n=6}
_{Parse Time}	_{3.15s (± 0.42%)}	_{3.08s (± 1.12%)}	_{-0.07s (- 2.28%)}	_3.03s	_3.11s	_{p=0.005 n=6}
_{Bind Time}	_{1.17s (± 0.88%)}	_{1.17s (± 0.76%)}	_~	_1.16s	_1.18s	_{p=0.673 n=6}
_{Check Time}	_{17.02s (± 0.22%)}	_{17.02s (± 0.23%)}	_~	_16.98s	_17.08s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.34s (± 0.17%)}	_{21.27s (± 0.31%)}	_~	_21.19s	_21.34s	_{p=0.075 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,300ms (± 0.29%)}	_{2,282ms (± 0.45%)}	_{-18ms (- 0.79%)}	_2,267ms	_2,294ms	_{p=0.008 n=6}
_{Req 2 - geterr}	_{5,075ms (± 0.34%)}	_{5,065ms (± 0.29%)}	_~	_5,046ms	_5,079ms	_{p=0.471 n=6}
_{Req 3 - references}	_{265ms (± 0.50%)}	_{265ms (± 0.15%)}	_~	_264ms	_265ms	_{p=0.446 n=6}
_{Req 4 - navto}	_{228ms (± 0.24%)}	_{228ms (± 0.58%)}	_~	_226ms	_230ms	_{p=0.663 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{93ms (± 2.33%)}	_{91ms (± 5.77%)}	_~	_81ms	_97ms	_{p=0.388 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,419ms (± 1.35%)}	_{2,392ms (± 0.80%)}	_~	_2,373ms	_2,417ms	_{p=0.066 n=6}
_{Req 2 - geterr}	_{3,789ms (± 0.31%)}	_{3,797ms (± 0.17%)}	_~	_3,788ms	_3,804ms	_{p=0.377 n=6}
_{Req 3 - references}	_{276ms (± 0.27%)}	_{277ms (± 0.40%)}	_~	_276ms	_279ms	_{p=0.195 n=6}
_{Req 4 - navto}	_{226ms (± 0.28%)}	_{228ms (± 2.67%)}	_~	_224ms	_240ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{73ms (± 3.77%)}	_{75ms (± 7.77%)}	_~	_69ms	_85ms	_{p=0.870 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,177ms (± 0.27%)}	_{5,142ms (± 0.22%)}	_{-35ms (- 0.68%)}	_5,124ms	_5,153ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{1,122ms (± 1.10%)}	_{1,132ms (± 1.22%)}	_~	_1,115ms	_1,152ms	_{p=0.261 n=6}
_{Req 3 - references}	_{78ms (± 4.61%)}	_{79ms (± 4.95%)}	_~	_76ms	_84ms	_{p=0.923 n=6}
_{Req 4 - navto}	_{458ms (± 0.70%)}	_{457ms (± 0.16%)}	_~	_456ms	_458ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{836ms (± 1.38%)}	_{838ms (± 1.17%)}	_~	_824ms	_848ms	_{p=0.872 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{157.48ms (± 0.16%)}	_{157.51ms (± 0.17%)}	_~	_156.46ms	_161.27ms	_{p=0.141 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.93ms (± 0.16%)}	_{230.82ms (± 0.14%)}	_{-0.11ms (- 0.05%)}	_229.36ms	_233.55ms	_{p=0.013 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{226.58ms (± 0.15%)}	_{226.77ms (± 0.14%)}	_{+0.19ms (+ 0.08%)}	_225.34ms	_229.65ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{225.80ms (± 0.17%)}	_{225.99ms (± 0.18%)}	_{+0.19ms (+ 0.09%)}	_224.51ms	_231.94ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2026-03-24T21:19:31Z

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

Daniel Rosenwasser (DanielRosenwasser) added 2 commits July 11, 2024 21:33

Move shebang check into the same branch as other # cases.
18df637

Add a quicker check for identifiers, check for space sooner.
bc21cdd

TypeScript Bot (typescript-bot) assigned Daniel Rosenwasser (DanielRosenwasser)Jul 11, 2024

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 11, 2024

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Jul 11, 2024
Optimize scan with a lookup table to reduce branching #59106
Closed

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Dec 12, 2024
Shebang error parsing: compatibility with tsc microsoft/typescript-go#153
Merged

TypeScript Bot (typescript-bot) closed this Mar 24, 2026

Navigation Menu

Uh oh!

Introduce scanning fast paths - #59244

Introduce scanning fast paths#59244
Daniel Rosenwasser (DanielRosenwasser) wants to merge 2 commits into
mainfrom
scanFastPaths

Daniel Rosenwasser (DanielRosenwasser) commented Jul 11, 2024

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Jul 11, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 11, 2024•
edited
Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 11, 2024

tsc

tsserver

startup

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Daniel Rosenwasser (DanielRosenwasser) commented Jul 11, 2024

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Jul 11, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 11, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 11, 2024

tsc

tsserver

startup

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TypeScript Bot (typescript-bot) commented Jul 11, 2024•
edited
Loading