Uh oh!
There was an error while loading. Please reload this page.
fix: filtering promise properties in object literal completion - #59316
Conversation
Mateusz Burzyński (Andarist)
commented
Jul 17, 2024
Tests for completions can be written like this: |
Uh oh!
There was an error while loading. Please reload this page.
99ef608 to
63999d3Compare089a830 to
3e8aafdCompare3e8aafd to
be95930CompareTypeScript Bot (typescript-bot)
commented
Jul 21, 2024
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure Daniel Rosenwasser (@DanielRosenwasser) and Ryan Cavanaugh (@RyanCavanaugh) are aware of the changes, just as a heads up. |
be95930 to
994cc76CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Jake Bailey (jakebailey)
commented
Aug 6, 2024
This looks good to me, though #59316 was accepted without determining whether or not the items should be prioritized or filtered, and this PR filters them out entirely. I assume that ordering them is going to be a challenge, so are we okay with not providing promise-like method completions here? |
Andrew Branch (andrewbranch)
commented
Aug 8, 2024
TypeScript Bot (@typescript-bot) pack this |
Hey Andrew Branch (@andrewbranch), I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
Uh oh!
There was an error while loading. Please reload this page.
screenshot
In the actual development environment, it was possible to reproduce what was solved.But I can't find a case to write a test. Can someone give me an idea?Fixes#59298