Uh oh!
There was an error while loading. Please reload this page.
Use tuple name inference for Iterator.next et al - #59360
Merged
Merged
Conversation
Ron Buckton (rbuckton)
requested review from
Jake Bailey (jakebailey) and Nathan Shively-Sanders (sandersn)July 19, 2024 17:59
Jake Bailey (jakebailey)
commented
Jul 19, 2024
Member
Hm, the thread there seems to imply that there should be some inferred named changed, but none show in the baselines? |
Ron Buckton (rbuckton)
commented
Jul 19, 2024
ContributorAuthor
The change is primarily observed in quickinfo/signature help, as is shown in the tests in #59045. |
Ron Buckton (rbuckton)
commented
Jul 19, 2024
ContributorAuthor
I can add a fourslash test to illustrate this |
Nathan Shively-Sanders (sandersn)
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates our definitions of
Iterator,Generator,AsyncIterator, andAsyncGeneratorto leverage the tuple name inference change from #59045, as requested in #58243 (comment)