Refactored node builder flags and tests by armanio123 · Pull Request #59440 · microsoft/TypeScript

Armando Aguirre (armanio123) · 2024-07-27T01:27:46Z

The NodeBuilderFlags enum has shifted more than the allowed signed int32 limit.

~~This refactors experiments with creating a type and constant using BigInt instead.~~ This approach was discarded becuase of the performance of BigInt, and the limitations the type has.

Added an additional flag InternalNodeBuilderFlags, that releases a couple of bits on NodeBuilderFlag by moving all the internal flags.

Reference to this PR #58475.

TypeScript Bot (typescript-bot) · 2024-07-27T01:28:03Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure Daniel Rosenwasser (@DanielRosenwasser) and Ryan Cavanaugh (@RyanCavanaugh) are aware of the changes, just as a heads up.

Armando Aguirre (armanio123) · 2024-07-27T01:38:22Z

TypeScript Bot (@typescript-bot) test this

TypeScript Bot (typescript-bot) · 2024-07-27T01:38:25Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-07-27T01:58:12Z

Armando Aguirre (@armanio123) Here are the results of running the user tests with tsc comparing main and refs/pull/59440/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2024-07-27T01:59:01Z

Hey Armando Aguirre (@armanio123), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-07-27T02:14:50Z

Armando Aguirre (@armanio123)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,432k (± 0.09%)}	_{193,734k (± 0.96%)}	_{+1,302k (+ 0.68%)}	_192,386k	_196,190k	_{p=0.030 n=6}
_{Parse Time}	_{1.32s (± 0.75%)}	_{1.31s (± 0.92%)}	_~	_1.29s	_1.32s	_{p=0.391 n=6}
_{Bind Time}	_{0.72s (± 0.72%)}	_{0.71s (± 0.77%)}	_~	_0.71s	_0.72s	_{p=0.640 n=6}
_{Check Time}	_{9.59s (± 0.44%)}	_{9.62s (± 0.33%)}	_~	_9.58s	_9.67s	_{p=0.172 n=6}
_{Emit Time}	_{2.78s (± 0.48%)}	_{2.78s (± 0.67%)}	_~	_2.75s	_2.80s	_{p=0.617 n=6}
_{Total Time}	_{14.41s (± 0.32%)}	_{14.43s (± 0.31%)}	_~	_14.39s	_14.51s	_{p=0.418 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,532	_945,532	_~	_~	_~	_{p=1.000 n=6}
_Types	_409,507	_409,507	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,221,163k (± 0.00%)}	_{1,221,181k (± 0.00%)}	_~	_1,221,104k	_1,221,215k	_{p=0.230 n=6}
_{Parse Time}	_{6.57s (± 0.25%)}	_{6.64s (± 0.87%)}	_{+0.07s (+ 1.01%)}	_6.59s	_6.75s	_{p=0.008 n=6}
_{Bind Time}	_{1.85s (± 0.22%)}	_{1.86s (± 0.28%)}	_~	_1.85s	_1.86s	_{p=0.112 n=6}
_{Check Time}	_{31.05s (± 0.35%)}	_{31.07s (± 0.37%)}	_~	_30.97s	_31.28s	_{p=0.873 n=6}
_{Emit Time}	_{15.02s (± 0.50%)}	_{14.99s (± 0.46%)}	_~	_14.87s	_15.06s	_{p=0.748 n=6}
_{Total Time}	_{54.49s (± 0.29%)}	_{54.56s (± 0.24%)}	_~	_54.46s	_54.81s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,437,253	_2,437,253	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,004,097	_1,004,097	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,426,284k (± 0.01%)}	_{2,426,249k (± 0.00%)}	_~	_2,426,159k	_2,426,374k	_{p=0.378 n=6}
_{Parse Time}	_{8.50s (± 0.51%)}	_{8.45s (± 0.14%)}	_{-0.06s (- 0.67%)}	_8.43s	_8.46s	_{p=0.005 n=6}
_{Bind Time}	_{2.11s (± 0.57%)}	_{2.11s (± 0.65%)}	_~	_2.09s	_2.12s	_{p=0.339 n=6}
_{Check Time}	_{75.67s (± 1.40%)}	_{75.11s (± 0.33%)}	_~	_74.60s	_75.27s	_{p=0.575 n=6}
_{Emit Time}	_{0.28s (± 1.86%)}	_{0.28s (± 1.86%)}	_~	_0.27s	_0.28s	_{p=1.000 n=6}
_{Total Time}	_{86.56s (± 1.22%)}	_{85.94s (± 0.28%)}	_~	_85.45s	_86.10s	_{p=0.230 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,758	_1,227,821	_{+63 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,136	_265,006	_{-130 (- 0.05%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,346,580k (± 0.03%)}	_{2,347,526k (± 0.02%)}	_{+946k (+ 0.04%)}	_2,346,927k	_2,348,125k	_{p=0.031 n=6}
_{Parse Time}	_{4.96s (± 0.76%)}	_{5.03s (± 0.65%)}	_{+0.06s (+ 1.28%)}	_4.99s	_5.08s	_{p=0.036 n=6}
_{Bind Time}	_{1.90s (± 0.61%)}	_{1.89s (± 0.40%)}	_~	_1.88s	_1.90s	_{p=0.150 n=6}
_{Check Time}	_{34.61s (± 0.36%)}	_{34.53s (± 0.43%)}	_~	_34.27s	_34.66s	_{p=0.229 n=6}
_{Emit Time}	_{3.30s (± 0.85%)}	_{3.34s (± 0.86%)}	_~	_3.32s	_3.38s	_{p=0.127 n=6}
_{Total Time}	_{44.79s (± 0.33%)}	_{44.80s (± 0.31%)}	_~	_44.56s	_44.94s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,758	_1,227,821	_{+63 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,136	_265,006	_{-130 (- 0.05%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,420,479k (± 0.04%)}	_{2,420,875k (± 0.01%)}	_~	_2,420,517k	_2,421,353k	_{p=0.230 n=6}
_{Parse Time}	_{6.25s (± 1.19%)}	_{6.19s (± 0.69%)}	_~	_6.15s	_6.26s	_{p=0.128 n=6}
_{Bind Time}	_{2.03s (± 0.40%)}	_{2.07s (± 1.25%)}	_{+0.04s (+ 1.97%)}	_2.04s	_2.11s	_{p=0.008 n=6}
_{Check Time}	_{41.17s (± 0.76%)}	_{41.16s (± 0.38%)}	_~	_41.02s	_41.42s	_{p=0.575 n=6}
_{Emit Time}	_{4.05s (± 3.63%)}	_{4.06s (± 1.03%)}	_~	_4.01s	_4.11s	_{p=0.471 n=6}
_{Total Time}	_{53.53s (± 0.73%)}	_{53.50s (± 0.25%)}	_~	_53.37s	_53.70s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_255,951	_255,989	_{+38 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,957	_104,970	_{+13 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{427,801k (± 0.02%)}	_{428,082k (± 0.05%)}	_{+281k (+ 0.07%)}	_427,908k	_428,468k	_{p=0.005 n=6}
_{Parse Time}	_{3.35s (± 0.65%)}	_{3.35s (± 0.41%)}	_~	_3.34s	_3.38s	_{p=0.413 n=6}
_{Bind Time}	_{1.32s (± 1.31%)}	_{1.31s (± 1.96%)}	_~	_1.27s	_1.33s	_{p=0.683 n=6}
_{Check Time}	_{17.94s (± 0.16%)}	_{18.06s (± 0.35%)}	_{+0.12s (+ 0.64%)}	_17.99s	_18.15s	_{p=0.005 n=6}
_{Emit Time}	_{1.65s (± 1.15%)}	_{1.70s (± 1.53%)}	_{+0.04s (+ 2.73%)}	_1.66s	_1.73s	_{p=0.013 n=6}
_{Total Time}	_{24.26s (± 0.05%)}	_{24.41s (± 0.37%)}	_{+0.16s (+ 0.64%)}	_24.33s	_24.53s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,931	_224,931	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,146	_94,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,180k (± 0.05%)}	_{370,218k (± 0.03%)}	_~	_370,019k	_370,326k	_{p=1.000 n=6}
_{Parse Time}	_{2.77s (± 0.50%)}	_{2.76s (± 0.81%)}	_~	_2.73s	_2.79s	_{p=0.618 n=6}
_{Bind Time}	_{1.58s (± 0.67%)}	_{1.58s (± 0.62%)}	_~	_1.57s	_1.59s	_{p=0.315 n=6}
_{Check Time}	_{15.66s (± 0.45%)}	_{15.63s (± 0.45%)}	_~	_15.57s	_15.73s	_{p=0.518 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.00s (± 0.36%)}	_{19.97s (± 0.33%)}	_~	_19.89s	_20.05s	_{p=0.572 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₁	₁₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,986,839	_2,986,839	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,027,468	_1,027,468	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,110,683k (± 0.00%)}	_{3,110,635k (± 0.00%)}	_~	_3,110,558k	_3,110,714k	_{p=0.230 n=6}
_{Parse Time}	_{13.87s (± 0.34%)}	_{13.85s (± 0.55%)}	_~	_13.75s	_13.94s	_{p=0.574 n=6}
_{Bind Time}	_{4.32s (± 1.58%)}	_{4.31s (± 2.01%)}	_~	_4.27s	_4.49s	_{p=0.167 n=6}
_{Check Time}	_{79.27s (± 0.40%)}	_{79.26s (± 0.52%)}	_~	_78.86s	_79.86s	_{p=0.936 n=6}
_{Emit Time}	_{20.46s (± 0.34%)}	_{20.42s (± 0.66%)}	_~	_20.29s	_20.60s	_{p=0.423 n=6}
_{Total Time}	_{117.93s (± 0.32%)}	_{117.83s (± 0.38%)}	_~	_117.32s	_118.34s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,567	_267,567	_~	_~	_~	_{p=1.000 n=6}
_Types	_109,077	_109,077	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{412,412k (± 0.01%)}	_{412,534k (± 0.02%)}	_{+122k (+ 0.03%)}	_412,485k	_412,690k	_{p=0.005 n=6}
_{Parse Time}	_{3.83s (± 0.74%)}	_{3.82s (± 0.83%)}	_~	_3.78s	_3.86s	_{p=0.627 n=6}
_{Bind Time}	_{1.71s (± 0.32%)}	_{1.71s (± 0.44%)}	_~	_1.70s	_1.72s	_{p=0.476 n=6}
_{Check Time}	_{16.83s (± 0.40%)}	_{16.88s (± 0.32%)}	_~	_16.81s	_16.96s	_{p=0.228 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.38s (± 0.35%)}	_{22.41s (± 0.28%)}	_~	_22.30s	_22.47s	_{p=0.377 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_511,807	_511,807	_~	_~	_~	_{p=1.000 n=6}
_Types	_162,090	_162,090	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{449,159k (± 0.07%)}	_{449,208k (± 0.09%)}	_~	_448,705k	_449,530k	_{p=0.471 n=6}
_{Parse Time}	_{3.16s (± 0.53%)}	_{3.17s (± 1.01%)}	_~	_3.12s	_3.21s	_{p=0.572 n=6}
_{Bind Time}	_{1.16s (± 0.71%)}	_{1.16s (± 0.54%)}	_~	_1.15s	_1.17s	_{p=0.599 n=6}
_{Check Time}	_{17.12s (± 0.54%)}	_{17.17s (± 0.43%)}	_~	_17.09s	_17.30s	_{p=0.298 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.44s (± 0.42%)}	_{21.50s (± 0.29%)}	_~	_21.45s	_21.60s	_{p=0.228 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-07-27T03:18:11Z

Armando Aguirre (@armanio123) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59440/merge:

Everything looks good!

Jake Bailey (jakebailey) · 2024-07-29T18:08:42Z

#59282 gives back a node flag, can we not just wait for that?

Armando Aguirre (armanio123) · 2024-07-29T20:40:22Z

#59282 gives back a node flag, can we not just wait for that?

I was planning on adding a new flag to it, that's how I noticed this issue. So even if we reduce the number of flags, we're going to be dealing with this limitation.

This reverts commit d6b7c2a.

This reverts commit c5ffae5.

This reverts commit 7d434b7.

Armando Aguirre (armanio123) · 2024-08-03T02:51:30Z

Refactored as suggested during the design meeting. There's a couple of tests that looks suspicious to me so I appreciate extra set of eyes on them.

Jake Bailey (jakebailey) · 2024-08-03T03:28:33Z

Yeah, I suspect there's a bug lurking in there; most of the baseline changes are unexpected.

Jake Bailey (jakebailey) · 2024-08-03T03:45:43Z

Skimming the code locally, though, I can't find the place where things may have gone wrong... It all seems correct to me.

Jake Bailey (jakebailey) · 2024-08-06T16:59:24Z

@@ -222,7 +223,7 @@ export function addNewNodeForMemberSymbol(
 case SyntaxKind.PropertyDeclaration:
 let flags = NodeBuilderFlags.NoTruncation;


This doesn't need AllowUnresolvedNames like the code below?
Sort of wondering if all old users of NoTruncation need that flag, but maybe we shouldn't add ones where we don't think it should matter except those where we would have set it manually...

Currently is not needed to pass the test cases. Thought we might be missing some, because adding it doesn't change any of them.

Right, our test suite is just not always exhaustive, so I suspect that there are some lurking bugs without this flag for these auto-import / codefix cases, given those seem to in other cases depend on this flag

Jake Bailey (jakebailey) · 2024-08-06T17:35:37Z

 contextNode,
 scriptTarget,
 NodeBuilderFlags.NoTruncation,
+ /*internalFlags*/ undefined,


This makes me wonder if we are missing a test with an unresolved name for those who call this code. (Specifically fixAddMissingMember)

I agree, that's the same thing I just responded to your last comment.

Jake Bailey (jakebailey)

Overall this now seems good, though the title needs to be updated to not say it's an experiment, and I do think we may need to be adding the unresolved name thing in a couple of places that maybe we just don't have tests for?

I think that the tests that fail without the change to createSignatureDeclarationFromSignature may need to be recreated as tests which make the other cases where NoTruncation failed also fail without AllowUnresolvedNames.

Armando Aguirre (armanio123) · 2024-08-06T23:54:33Z

If I understand the AllowUnresolvedNames flag correctly this tests cases should not use any correct? If so, there's no reason to add the flag as we don't handle it.

interfaceA{foo: import("./doesntexist.js").Foo;getbar(): import("./doesntexist.js").Foo;}classBimplementsA{|<--Triggercompletionhere}

Completion returns:

foo: any;// This should have been `foo: import("./doesntexist.js").Foo;`getbar(): any {// and this `get bar(): import("./doesntexist.js").Foo;`thrownewError("Method not implemented.");}

Jake Bailey (jakebailey) · 2024-08-07T01:29:02Z

I would expect those to not spit out any, no, though I'm confused because it sounds like you're saying it spits out any when the flag is set?

Armando Aguirre (armanio123) · 2024-08-07T01:30:52Z

That's correct, we spit out any regardless if the flag is set or not. Most likely we don't handle the flag on this code path.

Jake Bailey (jakebailey) · 2024-08-07T22:30:20Z

If you don't want to write a test for those other branches, can we just put that flag back on the places that used to have NoTruncation to maintain the existing behavior?

Armando Aguirre (armanio123) · 2024-08-08T00:59:06Z

Yeah, I was going to propose the same as I don't know how to create all of the necessary tests. I'm going to put the flag in everyplace I find NoTruncation.

Armando Aguirre (armanio123) · 2024-08-08T01:31:50Z

 function typeToString(type: Type, enclosingDeclaration?: Node, flags: TypeFormatFlags = TypeFormatFlags.AllowUniqueESSymbolType | TypeFormatFlags.UseAliasDefinedOutsideCurrentScope, writer: EmitTextWriter = createTextWriter("")): string {
 const noTruncation = compilerOptions.noErrorTruncation || flags & TypeFormatFlags.NoTruncation;
- const typeNode = nodeBuilder.typeToTypeNode(type, enclosingDeclaration, toNodeBuilderFlags(flags) | NodeBuilderFlags.IgnoreErrors | (noTruncation ? NodeBuilderFlags.NoTruncation : 0));
+ const typeNode = nodeBuilder.typeToTypeNode(type, enclosingDeclaration, toNodeBuilderFlags(flags) | NodeBuilderFlags.IgnoreErrors | (noTruncation ? NodeBuilderFlags.NoTruncation : NodeBuilderFlags.None), noTruncation ? InternalNodeBuilderFlags.AllowUnresolvedNames : InternalNodeBuilderFlags.None);


This scenario seems weird to me as it depends on NoTruncation being set in TypeFormatFlags. Nonetheless, this is the current behavior, so I decided to change it but let me know if you disagree and I can rollback.

Hm, I think it's a little weird, though I guess it's also true that nobody would have ever intentionally set AllowUnresolvedNames here because that was never a valid TypeFormatFlag.
Sort of leaning towards not doing this one and seeing what happens? I assume no test changes here either.

They don't change. Actually, the latest commit doesn't change any of the tests. I'll rollback this line.

Jake Bailey (jakebailey)

I think this seems alright now, though it would be nice if we could figure out the rest.

Given we just added a flag everywhere, curious what Wesley Wigham (@weswigham) thinks, but it should at least maintain our old behavior which I feel is pretty safe.

Refactored node builder flags and tests
7d434b7

Armando Aguirre (armanio123) requested review from Daniel Rosenwasser (DanielRosenwasser) and Wesley Wigham (weswigham)July 27, 2024 01:27

TypeScript Bot (typescript-bot) assigned Armando Aguirre (armanio123)Jul 27, 2024

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 27, 2024

Armando Aguirre Sepulveda added 2 commits July 26, 2024 18:28

Fixed typos
c5ffae5

Fixed format errors
d6b7c2a

Jake Bailey (jakebailey) reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/compiler/types.ts Outdated

Armando Aguirre Sepulveda added 3 commits July 29, 2024 17:57

Revert "Fixed format errors"
1247fcf
This reverts commit d6b7c2a.

Revert "Fixed typos"
736ab40
This reverts commit c5ffae5.

Revert "Refactored node builder flags and tests"
5854210
This reverts commit 7d434b7.

Jake Bailey (jakebailey) reviewed Jul 30, 2024
View reviewed changes

Comment threadsrc/compiler/transformers/declarations.ts Outdated

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Aug 2, 2024
Design Meeting Notes, 8/2/2024 #59524
Closed

Added flag internalNodeBuilderFlags
3185381

Armando Aguirre (armanio123)force-pushed the RefactorNodeBuilderFlags branch from 76de2ca to 3185381Compare August 3, 2024 02:49

Missing internalFlags
2e52805

Jake Bailey (jakebailey) reviewed Aug 3, 2024
View reviewed changes

Comment threadsrc/compiler/checker.ts

Jake Bailey (jakebailey) reviewed Aug 3, 2024
View reviewed changes

Comment threadsrc/compiler/types.ts

Jake Bailey (jakebailey) reviewed Aug 3, 2024
View reviewed changes

Comment threadtests/cases/fourslash/completionsClassMemberImportTypeNodeParameter2.ts Outdated

Return AllowUnresolvedTypes
96ee387

Wesley Wigham (weswigham) approved these changes Aug 6, 2024
View reviewed changes

Jake Bailey (jakebailey) reviewed Aug 6, 2024
View reviewed changes

Jake Bailey (jakebailey) requested changes Aug 6, 2024
View reviewed changes

Armando Aguirre (armanio123) changed the title ~~Experiment: Refactored node builder flags and tests~~Refactored node builder flags and testsAug 6, 2024

Add AllowUnresolveNames flag to all NoTruncation
66daac1

Armando Aguirre (armanio123) mentioned this pull request Aug 8, 2024
AllowUnresolveNames not working for completion getters/setters and property signature and declaration #59554
Open

Armando Aguirre (armanio123) commented Aug 8, 2024
View reviewed changes

Rollback TypeFormatFlags.NoTruncation
330c65b

Jake Bailey (jakebailey) approved these changes Aug 8, 2024
View reviewed changes

Armando Aguirre (armanio123) merged commit 5f79e16 into microsoft:mainAug 8, 2024

Nathan Shively-Sanders (sandersn) removed this from PR Backlog Apr 22, 2025

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

		@@ -222,7 +223,7 @@ export function addNewNodeForMemberSymbol(
		case SyntaxKind.PropertyDeclaration:
		let flags = NodeBuilderFlags.NoTruncation;

Uh oh!

Conversation

Armando Aguirre (armanio123) commented Jul 27, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 27, 2024

Uh oh!

Armando Aguirre (armanio123) commented Jul 27, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 27, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 27, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 27, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 27, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 27, 2024

Uh oh!

Jake Bailey (jakebailey) commented Jul 29, 2024

Uh oh!

Uh oh!

Armando Aguirre (armanio123) commented Jul 29, 2024

Uh oh!

Uh oh!

Armando Aguirre (armanio123) commented Aug 3, 2024

Uh oh!

Jake Bailey (jakebailey) commented Aug 3, 2024

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Aug 3, 2024

Uh oh!

Uh oh!

Uh oh!

Jake Bailey (jakebailey)Aug 6, 2024

Choose a reason for hiding this comment

Uh oh!

Armando Aguirre (armanio123)Aug 6, 2024

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey)Aug 6, 2024

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey)Aug 6, 2024

Choose a reason for hiding this comment

Uh oh!

Armando Aguirre (armanio123)Aug 6, 2024

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey) left a comment

Choose a reason for hiding this comment

Uh oh!

Armando Aguirre (armanio123) commented Aug 6, 2024

Uh oh!

Jake Bailey (jakebailey) commented Aug 7, 2024

Uh oh!

Armando Aguirre (armanio123) commented Aug 7, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Aug 7, 2024

Uh oh!

Armando Aguirre (armanio123) commented Aug 8, 2024

Uh oh!

Armando Aguirre (armanio123)Aug 8, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey)Aug 8, 2024

Choose a reason for hiding this comment

Uh oh!

Armando Aguirre (armanio123)Aug 8, 2024

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey) left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Armando Aguirre (armanio123) commented Jul 27, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Jul 27, 2024•
edited
Loading

Armando Aguirre (armanio123) commented Aug 7, 2024•
edited
Loading

Armando Aguirre (armanio123)Aug 8, 2024•
edited
Loading