Uh oh!
There was an error while loading. Please reload this page.
Remove cancellationToken.js - #60250
Merged
Jake Bailey (jakebailey) merged 3 commits intoNov 5, 2024
Merged
Conversation
Nathan Shively-Sanders (sandersn)
approved these changes
Oct 31, 2024
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
No reason to have it separate that I know of.
Jake Bailey (jakebailey)
commented
Oct 31, 2024
MemberAuthor
TypeScript Bot (@typescript-bot) perf test startup-only |
Contributor
TypeScript Bot (typescript-bot)
commented
Oct 31, 2024
Contributor
Jake Bailey (@jakebailey) Here they are:startupComparison Report - baseline..pr
System info unknown Hosts
Scenarios
Developer Information: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Comment on lines
+677
to
+683
| let cancellationPipeName: string | undefined; | ||
| for (let i = 0; i < args.length - 1; i++) { | ||
| if (args[i] === "--cancellationPipeName") { | ||
| cancellationPipeName = args[i + 1]; | ||
| break; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Jake Bailey (@jakebailey) Perhaps ts.server.findArgument() can be used here as well?
TypeScript/src/tsserver/nodeServer.ts
Line 94 in 30979c2
MemberAuthor
There was a problem hiding this comment.
This PR was a pure code move; that could be a refactor later, sure
Contributor
There was a problem hiding this comment.
That was quick! Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cancellationToken.jsis a file which contains an implementation of a file-based cancellation token. It is loaded dynamically bytsserver.js, but nowhere else. As far as I can tell, there's no reason to not just include its code intsserver.jsdirectly and drop the extra file andrequire.(Going through the repo history also doesn't indicate why this was a separate file; perhaps there's a good reason for this to exist and I lack context.)