Uh oh!
There was an error while loading. Please reload this page.
Fix template string escaping - #60303
Merged
Merged
Conversation
Ron Buckton (rbuckton)
requested review from
Isabel Duan (iisaduan) and Jake Bailey (jakebailey)October 21, 2024 18:15
Jake Bailey (jakebailey)
approved these changes
Oct 21, 2024
Isabel Duan (iisaduan)
approved these changes
Oct 21, 2024
Ron Buckton (rbuckton)
commented
Oct 21, 2024
ContributorAuthor
Daniel Rosenwasser (@DanielRosenwasser) any concerns with taking this for RC? |
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the RegExp we use to escape characters for template strings to properly exclude LF characters when the template string is synthetic.
Fixes#59150