Fix `getEffectiveCheckNode` by gabritto · Pull Request #60309 · microsoft/TypeScript

Gabriela Araujo Britto (gabritto) · 2024-10-22T02:27:14Z

getEffectiveCheckNode is currently used to adjust error position by skipping outer expressions of a node.
This fixes the following problems in error position related to usage of getEffectiveCheckNode.

Nested satisfies are not skipped:

((): {a: true}=>(({})satisfiesunknown)satisfiesunknown)();// Error on `satisfies`, should be on `{}`

Playground

In JS files, JSDoc type assertions are skipped:

/** * @template T * @param {T|undefined} value value or not * @returns {T} result value */constfoo1=value=>/** @type {string} */({ ...value});// Error on `{ ...value }`, should be on `({ ...value })`. Small difference./** * @template T * @param {T|undefined} value value or not * @returns {T} result value */constfoo2=value=>/** @type {string} */(/** @type {T} */({ ...value}));// Error on `{ ...value }`, should be on `(/** @type {T} */({ ...value }))`, which is closer to the cast.

Playground

Found those problems when working on another PR.

TypeScript Bot (typescript-bot) · 2024-10-22T02:27:29Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure Daniel Rosenwasser (@DanielRosenwasser) and Ryan Cavanaugh (@RyanCavanaugh) are aware of the changes, just as a heads up.

Gabriela Araujo Britto (gabritto) · 2024-10-22T02:29:26Z

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) · 2024-10-22T02:29:29Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-10-22T02:49:26Z

Gabriela Araujo Britto (@gabritto) Here are the results of running the user tests with tsc comparing main and refs/pull/60309/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2024-10-22T02:53:14Z

Hey Gabriela Araujo Britto (@gabritto), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-10-22T03:10:45Z

Gabriela Araujo Britto (@gabritto)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,017k (± 0.92%)}	_{193,993k (± 0.93%)}	_~	_192,803k	_196,348k	_{p=0.810 n=6}
_{Parse Time}	_{1.31s (± 1.01%)}	_{1.32s (± 0.62%)}	_~	_1.31s	_1.33s	_{p=0.546 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.75s (± 0.33%)}	_{9.74s (± 0.24%)}	_~	_9.70s	_9.77s	_{p=0.517 n=6}
_{Emit Time}	_{2.73s (± 0.55%)}	_{2.73s (± 0.46%)}	_~	_2.71s	_2.74s	_{p=0.607 n=6}
_{Total Time}	_{14.51s (± 0.26%)}	_{14.51s (± 0.16%)}	_~	_14.47s	_14.53s	_{p=0.371 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,886	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,586k (± 0.00%)}	_{1,224,627k (± 0.00%)}	_~	_1,224,548k	_1,224,719k	_{p=0.378 n=6}
_{Parse Time}	_{6.66s (± 1.02%)}	_{6.62s (± 0.65%)}	_~	_6.58s	_6.69s	_{p=0.295 n=6}
_{Bind Time}	_{1.88s (± 0.29%)}	_{1.88s (± 0.34%)}	_~	_1.87s	_1.89s	_{p=0.201 n=6}
_{Check Time}	_{31.81s (± 0.34%)}	_{31.88s (± 0.22%)}	_~	_31.79s	_31.97s	_{p=0.170 n=6}
_{Emit Time}	_{15.11s (± 0.27%)}	_{15.14s (± 0.24%)}	_~	_15.09s	_15.18s	_{p=0.228 n=6}
_{Total Time}	_{55.48s (± 0.18%)}	_{55.52s (± 0.09%)}	_~	_55.45s	_55.58s	_{p=0.521 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,494,373	_2,494,373	_~	_~	_~	_{p=1.000 n=6}
_Types	_908,290	_908,290	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,306,658k (± 0.00%)}	_{2,306,709k (± 0.00%)}	_{+50k (+ 0.00%)}	_2,306,648k	_2,306,739k	_{p=0.020 n=6}
_{Parse Time}	_{9.32s (± 0.21%)}	_{9.29s (± 0.26%)}	_~	_9.25s	_9.32s	_{p=0.052 n=6}
_{Bind Time}	_{2.15s (± 0.70%)}	_{2.15s (± 0.62%)}	_~	_2.13s	_2.17s	_{p=0.931 n=6}
_{Check Time}	_{74.91s (± 0.38%)}	_{74.95s (± 0.41%)}	_~	_74.54s	_75.33s	_{p=0.873 n=6}
_{Emit Time}	_{0.29s (± 1.41%)}	_{0.28s (± 3.04%)}	_{🟩-0.01s (- 4.62%)}	_0.27s	_0.29s	_{p=0.018 n=6}
_{Total Time}	_{86.67s (± 0.33%)}	_{86.67s (± 0.34%)}	_~	_86.27s	_86.99s	_{p=1.000 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,033	_1,258,045	_{+12 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,263	_266,265	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,146,670k (± 0.02%)}	_{3,146,670k (± 0.02%)}	_~	_3,145,713k	_3,147,321k	_{p=1.000 n=6}
_{Parse Time}	_{6.61s (± 1.16%)}	_{6.55s (± 0.98%)}	_~	_6.48s	_6.67s	_{p=0.128 n=6}
_{Bind Time}	_{2.29s (± 4.17%)}	_{2.30s (± 1.23%)}	_~	_2.26s	_2.34s	_{p=0.334 n=6}
_{Check Time}	_{42.95s (± 0.49%)}	_{43.01s (± 0.41%)}	_~	_42.82s	_43.28s	_{p=0.936 n=6}
_{Emit Time}	_{3.53s (± 1.59%)}	_{3.49s (± 1.57%)}	_~	_3.40s	_3.57s	_{p=0.336 n=6}
_{Total Time}	_{55.39s (± 0.45%)}	_{55.35s (± 0.27%)}	_~	_55.20s	_55.55s	_{p=0.575 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,033	_1,258,045	_{+12 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,263	_266,265	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,496,444k (± 0.02%)}	_{2,496,333k (± 0.01%)}	_~	_2,496,156k	_2,496,554k	_{p=0.689 n=6}
_{Parse Time}	_{5.42s (± 0.40%)}	_{5.37s (± 0.52%)}	_{-0.05s (- 0.95%)}	_5.33s	_5.40s	_{p=0.013 n=6}
_{Bind Time}	_{1.74s (± 0.30%)}	_{1.73s (± 0.47%)}	_~	_1.72s	_1.74s	_{p=0.523 n=6}
_{Check Time}	_{35.85s (± 0.18%)}	_{35.86s (± 0.17%)}	_~	_35.77s	_35.92s	_{p=0.810 n=6}
_{Emit Time}	_{3.04s (± 1.94%)}	_{3.07s (± 0.93%)}	_~	_3.04s	_3.12s	_{p=0.191 n=6}
_{Total Time}	_{46.04s (± 0.10%)}	_{46.03s (± 0.15%)}	_~	_45.93s	_46.10s	_{p=0.809 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,789	_261,790	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,511	_106,513	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{438,830k (± 0.01%)}	_{438,817k (± 0.01%)}	_~	_438,726k	_438,873k	_{p=1.000 n=6}
_{Parse Time}	_{3.54s (± 0.94%)}	_{3.54s (± 0.64%)}	_~	_3.50s	_3.56s	_{p=0.936 n=6}
_{Bind Time}	_{1.32s (± 1.35%)}	_{1.32s (± 0.92%)}	_~	_1.31s	_1.34s	_{p=0.864 n=6}
_{Check Time}	_{18.93s (± 0.36%)}	_{18.97s (± 0.34%)}	_~	_18.87s	_19.03s	_{p=0.295 n=6}
_{Emit Time}	_{1.54s (± 1.09%)}	_{1.54s (± 0.54%)}	_~	_1.53s	_1.55s	_{p=0.621 n=6}
_{Total Time}	_{25.33s (± 0.29%)}	_{25.35s (± 0.22%)}	_~	_25.27s	_25.43s	_{p=0.688 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,919	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,070k (± 0.00%)}	_{371,086k (± 0.01%)}	_~	_371,035k	_371,160k	_{p=0.520 n=6}
_{Parse Time}	_{2.91s (± 1.03%)}	_{2.90s (± 0.60%)}	_~	_2.87s	_2.92s	_{p=0.627 n=6}
_{Bind Time}	_{1.58s (± 1.86%)}	_{1.60s (± 1.16%)}	_~	_1.58s	_1.62s	_{p=0.120 n=6}
_{Check Time}	_{16.39s (± 0.32%)}	_{16.39s (± 0.52%)}	_~	_16.24s	_16.47s	_{p=0.872 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.88s (± 0.31%)}	_{20.89s (± 0.49%)}	_~	_20.72s	_20.99s	_{p=0.748 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,124,554	_3,124,554	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,077,073	_1,077,073	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,217,541k (± 0.01%)}	_{3,217,368k (± 0.01%)}	_~	_3,216,782k	_3,217,898k	_{p=0.810 n=6}
_{Parse Time}	_{14.07s (± 0.23%)}	_{14.10s (± 0.31%)}	_~	_14.02s	_14.14s	_{p=0.147 n=6}
_{Bind Time}	_{4.46s (± 0.31%)}	_{4.48s (± 0.46%)}	_{+0.03s (+ 0.60%)}	_4.46s	_4.51s	_{p=0.043 n=6}
_{Check Time}	_{87.07s (± 2.24%)}	_{85.88s (± 1.88%)}	_~	_84.02s	_87.99s	_{p=0.261 n=6}
_{Emit Time}	_{26.29s (± 6.60%)}	_{26.61s (± 3.57%)}	_~	_25.21s	_27.49s	_{p=0.378 n=6}
_{Total Time}	_{131.89s (± 1.64%)}	_{131.09s (± 1.68%)}	_~	_129.04s	_133.78s	_{p=0.423 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_286,375	_286,375	_~	_~	_~	_{p=1.000 n=6}
_Types	_116,078	_116,078	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{437,158k (± 0.02%)}	_{437,035k (± 0.02%)}	_~	_436,907k	_437,156k	_{p=0.066 n=6}
_{Parse Time}	_{5.05s (± 0.24%)}	_{5.09s (± 0.44%)}	_{+0.05s (+ 0.96%)}	_5.06s	_5.11s	_{p=0.003 n=6}
_{Bind Time}	_{2.18s (± 1.02%)}	_{2.15s (± 1.31%)}	_~	_2.12s	_2.19s	_{p=0.051 n=6}
_{Check Time}	_{22.90s (± 0.46%)}	_{23.02s (± 1.21%)}	_~	_22.84s	_23.58s	_{p=0.520 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{30.13s (± 0.41%)}	_{30.26s (± 0.98%)}	_~	_30.04s	_30.85s	_{p=0.419 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_543,130	_543,130	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,889	_181,889	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{485,534k (± 0.01%)}	_{485,547k (± 0.02%)}	_~	_485,448k	_485,673k	_{p=0.936 n=6}
_{Parse Time}	_{4.17s (± 0.47%)}	_{4.18s (± 0.36%)}	_~	_4.16s	_4.20s	_{p=0.607 n=6}
_{Bind Time}	_{1.45s (± 1.38%)}	_{1.46s (± 0.93%)}	_~	_1.45s	_1.48s	_{p=0.437 n=6}
_{Check Time}	_{23.69s (± 0.43%)}	_{23.75s (± 0.19%)}	_~	_23.69s	_23.80s	_{p=0.173 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=1.000 n=6}
_{Total Time}	_{29.31s (± 0.36%)}	_{29.38s (± 0.21%)}	_~	_29.32s	_29.46s	_{p=0.065 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-10-22T04:33:43Z

Gabriela Araujo Britto (@gabritto) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60309/merge:

Everything looks good!

fix getEffectiveCheckNode
b727340

TypeScript Bot (typescript-bot) assigned Gabriela Araujo Britto (gabritto)Oct 22, 2024

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 22, 2024

Gabriela Araujo Britto (gabritto) requested review from Andrew Branch (andrewbranch) and Nathan Shively-Sanders (sandersn)October 22, 2024 02:28

Nathan Shively-Sanders (sandersn) approved these changes Oct 22, 2024
View reviewed changes

Andrew Branch (andrewbranch) approved these changes Oct 22, 2024
View reviewed changes

Gabriela Araujo Britto (gabritto) merged commit 8d95ac5 into mainNov 6, 2024

Gabriela Araujo Britto (gabritto) deleted the gabritto/fixEffectiveNode branch November 6, 2024 01:14

Nathan Shively-Sanders (sandersn) removed this from PR Backlog Apr 22, 2025

Mateusz Burzyński (Andarist) mentioned this pull request Jun 6, 2025
Port "Fix getEffectiveCheckNode" microsoft/typescript-go#1083
Merged

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Navigation Menu

Uh oh!

Fix `getEffectiveCheckNode` - #60309

Fix `getEffectiveCheckNode`#60309
Gabriela Araujo Britto (gabritto) merged 1 commit into
mainfrom
gabritto/fixEffectiveNode

Gabriela Araujo Britto (gabritto) commented Oct 22, 2024•
edited
Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

Uh oh!

Gabriela Araujo Britto (gabritto) commented Oct 22, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024•
edited
Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Gabriela Araujo Britto (gabritto) commented Oct 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

Uh oh!

Gabriela Araujo Britto (gabritto) commented Oct 22, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Gabriela Araujo Britto (gabritto) commented Oct 22, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Oct 22, 2024•
edited
Loading