Error on too many parameters for iterator method by rbuckton · Pull Request #60321 · microsoft/TypeScript

Ron Buckton (rbuckton) · 2024-10-22T16:55:01Z

This reports an error when [Symbol.iterator]() or [Symbol.asyncIterator]() cannot safely be called by for..of, yield*, or ... due to a parameter count mismatch.

Fixes#57130

Jake Bailey (jakebailey) · 2024-10-22T16:59:49Z

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) · 2024-10-22T16:59:54Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-10-22T17:17:31Z

Jake Bailey (@jakebailey) Here are the results of running the user tests with tsc comparing main and refs/pull/60321/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2024-10-22T17:21:54Z

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-10-22T17:41:49Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,484k (± 0.79%)}	_{192,778k (± 0.01%)}	_{-706k (- 0.36%)}	_192,750k	_192,805k	_{p=0.045 n=6}
_{Parse Time}	_{1.31s (± 0.62%)}	_{1.31s (± 0.96%)}	_~	_1.29s	_1.32s	_{p=0.796 n=6}
_{Bind Time}	_0.72s	_{0.72s (± 0.57%)}	_~	_0.72s	_0.73s	_{p=0.405 n=6}
_{Check Time}	_{9.76s (± 0.28%)}	_{9.73s (± 0.38%)}	_~	_9.67s	_9.78s	_{p=0.091 n=6}
_{Emit Time}	_{2.68s (± 1.35%)}	_{2.73s (± 0.65%)}	_~	_2.70s	_2.74s	_{p=0.050 n=6}
_{Total Time}	_{14.48s (± 0.38%)}	_{14.48s (± 0.26%)}	_~	_14.43s	_14.53s	_{p=0.873 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,886	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,567k (± 0.00%)}	_{1,224,624k (± 0.00%)}	_{+57k (+ 0.00%)}	_1,224,562k	_1,224,653k	_{p=0.031 n=6}
_{Parse Time}	_{6.67s (± 0.63%)}	_{6.62s (± 0.62%)}	_{-0.06s (- 0.87%)}	_6.59s	_6.69s	_{p=0.043 n=6}
_{Bind Time}	_{1.88s (± 0.40%)}	_{1.88s (± 0.29%)}	_~	_1.88s	_1.89s	_{p=0.476 n=6}
_{Check Time}	_{31.82s (± 0.53%)}	_{31.88s (± 0.29%)}	_~	_31.73s	_31.98s	_{p=0.809 n=6}
_{Emit Time}	_{15.17s (± 0.26%)}	_{15.19s (± 0.38%)}	_~	_15.10s	_15.25s	_{p=0.629 n=6}
_{Total Time}	_{55.54s (± 0.31%)}	_{55.57s (± 0.28%)}	_~	_55.30s	_55.78s	_{p=0.748 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,494,498	_2,494,498	_~	_~	_~	_{p=1.000 n=6}
_Types	_908,298	_908,298	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,307,104k (± 0.00%)}	_{2,307,074k (± 0.00%)}	_~	_2,307,036k	_2,307,113k	_{p=0.298 n=6}
_{Parse Time}	_{9.31s (± 0.16%)}	_{9.32s (± 0.21%)}	_~	_9.30s	_9.35s	_{p=0.325 n=6}
_{Bind Time}	_{2.14s (± 0.35%)}	_{2.15s (± 0.39%)}	_~	_2.13s	_2.15s	_{p=0.432 n=6}
_{Check Time}	_{74.76s (± 0.33%)}	_{75.09s (± 0.12%)}	_{+0.33s (+ 0.44%)}	_74.97s	_75.21s	_{p=0.013 n=6}
_{Emit Time}	_{0.28s (± 4.71%)}	_{0.28s (± 4.27%)}	_~	_0.27s	_0.30s	_{p=0.865 n=6}
_{Total Time}	_{86.49s (± 0.28%)}	_{86.84s (± 0.10%)}	_{+0.35s (+ 0.41%)}	_86.71s	_86.92s	_{p=0.013 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,033	_1,258,041	_{+8 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,263	_266,229	_{-34 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,146,384k (± 0.01%)}	_{3,146,885k (± 0.02%)}	_~	_3,145,940k	_3,147,625k	_{p=0.230 n=6}
_{Parse Time}	_{6.57s (± 0.59%)}	_{6.62s (± 0.36%)}	_{+0.05s (+ 0.76%)}	_6.59s	_6.64s	_{p=0.030 n=6}
_{Bind Time}	_{2.34s (± 1.14%)}	_{2.33s (± 0.97%)}	_~	_2.30s	_2.36s	_{p=0.748 n=6}
_{Check Time}	_{43.12s (± 0.16%)}	_{42.98s (± 0.42%)}	_~	_42.81s	_43.26s	_{p=0.173 n=6}
_{Emit Time}	_{3.54s (± 1.57%)}	_{3.50s (± 2.70%)}	_~	_3.37s	_3.63s	_{p=0.575 n=6}
_{Total Time}	_{55.58s (± 0.09%)}	_{55.44s (± 0.30%)}	_~	_55.24s	_55.68s	_{p=0.128 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,033	_1,258,041	_{+8 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,263	_266,229	_{-34 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,496,230k (± 0.01%)}	_{2,496,475k (± 0.03%)}	_~	_2,495,703k	_2,497,440k	_{p=1.000 n=6}
_{Parse Time}	_{5.38s (± 0.92%)}	_{5.40s (± 0.68%)}	_~	_5.34s	_5.45s	_{p=0.335 n=6}
_{Bind Time}	_{1.74s (± 0.47%)}	_{1.74s (± 0.32%)}	_~	_1.73s	_1.74s	_{p=0.859 n=6}
_{Check Time}	_{35.85s (± 0.33%)}	_{35.83s (± 0.15%)}	_~	_35.73s	_35.88s	_{p=1.000 n=6}
_{Emit Time}	_{3.02s (± 1.49%)}	_{3.01s (± 1.79%)}	_~	_2.94s	_3.10s	_{p=0.470 n=6}
_{Total Time}	_{45.99s (± 0.39%)}	_{45.98s (± 0.20%)}	_~	_45.88s	_46.08s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,789	_261,753	_{-36 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,511	_106,477	_{-34 (- 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{438,818k (± 0.01%)}	_{438,702k (± 0.02%)}	_{-116k (- 0.03%)}	_438,565k	_438,743k	_{p=0.008 n=6}
_{Parse Time}	_{3.52s (± 0.91%)}	_{3.50s (± 1.12%)}	_~	_3.46s	_3.57s	_{p=0.419 n=6}
_{Bind Time}	_{1.30s (± 0.64%)}	_{1.32s (± 1.66%)}	_~	_1.30s	_1.36s	_{p=0.128 n=6}
_{Check Time}	_{18.85s (± 0.50%)}	_{18.86s (± 0.24%)}	_~	_18.80s	_18.90s	_{p=0.686 n=6}
_{Emit Time}	_{1.54s (± 1.82%)}	_{1.53s (± 1.04%)}	_~	_1.50s	_1.54s	_{p=0.114 n=6}
_{Total Time}	_{25.22s (± 0.31%)}	_{25.21s (± 0.24%)}	_~	_25.16s	_25.33s	_{p=0.810 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,919	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,094k (± 0.01%)}	_{371,080k (± 0.01%)}	_~	_371,056k	_371,125k	_{p=0.173 n=6}
_{Parse Time}	_{2.90s (± 1.37%)}	_{2.90s (± 1.35%)}	_~	_2.84s	_2.95s	_{p=0.936 n=6}
_{Bind Time}	_{1.58s (± 1.68%)}	_{1.60s (± 0.68%)}	_~	_1.58s	_1.61s	_{p=0.145 n=6}
_{Check Time}	_{16.38s (± 0.36%)}	_{16.39s (± 0.28%)}	_~	_16.30s	_16.43s	_{p=0.335 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.86s (± 0.34%)}	_{20.89s (± 0.21%)}	_~	_20.84s	_20.94s	_{p=0.333 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,126,375	_3,126,375	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,077,686	_1,077,686	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,218,522k (± 0.01%)}	_{3,218,284k (± 0.01%)}	_~	_3,217,889k	_3,218,838k	_{p=0.471 n=6}
_{Parse Time}	_{14.13s (± 0.31%)}	_{14.10s (± 0.16%)}	_~	_14.08s	_14.13s	_{p=0.146 n=6}
_{Bind Time}	_{4.47s (± 0.24%)}	_{4.47s (± 0.31%)}	_~	_4.45s	_4.49s	_{p=0.504 n=6}
_{Check Time}	_{86.70s (± 2.31%)}	_{85.38s (± 1.62%)}	_~	_83.82s	_87.94s	_{p=0.298 n=6}
_{Emit Time}	_{26.91s (± 3.42%)}	_{26.73s (± 4.48%)}	_~	_25.03s	_28.46s	_{p=0.574 n=6}
_{Total Time}	_{132.21s (± 1.80%)}	_{130.67s (± 1.29%)}	_~	_128.87s	_133.44s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_286,375	_286,375	_~	_~	_~	_{p=1.000 n=6}
_Types	_116,078	_116,078	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{437,033k (± 0.01%)}	_{437,189k (± 0.03%)}	_{+156k (+ 0.04%)}	_437,003k	_437,335k	_{p=0.031 n=6}
_{Parse Time}	_{5.05s (± 1.22%)}	_{5.05s (± 1.05%)}	_~	_4.98s	_5.10s	_{p=0.872 n=6}
_{Bind Time}	_{2.16s (± 1.29%)}	_{2.18s (± 1.31%)}	_~	_2.15s	_2.23s	_{p=0.625 n=6}
_{Check Time}	_{22.88s (± 0.30%)}	_{22.98s (± 0.58%)}	_~	_22.77s	_23.10s	_{p=0.199 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{30.10s (± 0.39%)}	_{30.21s (± 0.53%)}	_~	_30.01s	_30.35s	_{p=0.172 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_543,130	_543,130	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,889	_181,889	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{485,509k (± 0.01%)}	_{485,527k (± 0.01%)}	_~	_485,479k	_485,564k	_{p=0.378 n=6}
_{Parse Time}	_{4.17s (± 1.00%)}	_{4.17s (± 0.25%)}	_~	_4.15s	_4.18s	_{p=0.807 n=6}
_{Bind Time}	_{1.46s (± 1.14%)}	_{1.45s (± 1.07%)}	_~	_1.43s	_1.47s	_{p=0.282 n=6}
_{Check Time}	_{23.70s (± 0.29%)}	_{23.69s (± 0.32%)}	_~	_23.60s	_23.81s	_{p=0.687 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{29.34s (± 0.28%)}	_{29.30s (± 0.28%)}	_~	_29.23s	_29.45s	_{p=0.378 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-10-22T19:00:59Z

Jake Bailey (@jakebailey) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60321/merge:

Everything looks good!

Error on too many parameters for iterator method
1a37aef

Ron Buckton (rbuckton) requested review from Gabriela Araujo Britto (gabritto) and Jake Bailey (jakebailey)October 22, 2024 16:55

TypeScript Bot (typescript-bot) assigned Ron Buckton (rbuckton)Oct 22, 2024

TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Oct 22, 2024

formatting
96c1bde

Gabriela Araujo Britto (gabritto) approved these changes Oct 22, 2024
View reviewed changes

Jake Bailey (jakebailey) approved these changes Oct 22, 2024
View reviewed changes

Ron Buckton (rbuckton) merged commit e25abe3 into mainOct 22, 2024

Ron Buckton (rbuckton) deleted the fix57130 branch October 22, 2024 20:01

Nathan Shively-Sanders (sandersn) removed this from PR Backlog Apr 22, 2025

Mateusz Burzyński (Andarist) mentioned this pull request Jun 5, 2025
Port "Error on too many parameters for iterator method" microsoft/typescript-go#1059
Merged

Andrew Branch (andrewbranch) mentioned this pull request Jun 6, 2025
Port #60321 andrewbranch/typescript-go#14
Closed

CopilotAI mentioned this pull request Jun 6, 2025
Port TypeScript PR #60321: Error on too many parameters for iterator method andrewbranch/typescript-go#16
Closed

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Navigation Menu

Uh oh!

Error on too many parameters for iterator method - #60321

Error on too many parameters for iterator method#60321
Ron Buckton (rbuckton) merged 2 commits into
mainfrom
fix57130

Ron Buckton (rbuckton) commented Oct 22, 2024•
edited
Loading

Uh oh!

Jake Bailey (jakebailey) commented Oct 22, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024•
edited
Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Ron Buckton (rbuckton) commented Oct 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Oct 22, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Ron Buckton (rbuckton) commented Oct 22, 2024•
edited
Loading

TypeScript Bot (typescript-bot) commented Oct 22, 2024•
edited
Loading