Add compatible overloads that accept ArrayBuffer to BigInt64Array/BigUint64Array by rbuckton · Pull Request #60391 · microsoft/TypeScript

Ron Buckton (rbuckton) · 2024-11-01T18:37:21Z

This adds a missing overload common to other typed arrays to ensure BigUint64ArrayConstructor and BigInt64ArrayConstructor are consistent.

Fixes#60367

…Uint64Array

Ron Buckton (rbuckton) · 2024-11-01T18:38:36Z

+ | Float64ArrayConstructor
+ | BigInt64ArrayConstructor
+
+export function makeTypedArray(buffer: ArrayBuffer, ctr: TypedArrayConstructor) {


NOTE: There is no output because this is only check for an error. Without the above changes to es2020.bigint.d.ts, an errors.txt is generated.

Jake Bailey (jakebailey)

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) · 2024-11-01T18:40:19Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-11-01T19:00:36Z

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-11-01T19:01:13Z

Jake Bailey (@jakebailey) Here are the results of running the user tests with tsc comparing main and refs/pull/60391/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2024-11-01T19:21:29Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,792k (± 0.01%)}	_{193,504k (± 0.72%)}	_~	_192,792k	_196,340k	_{p=0.066 n=6}
_{Parse Time}	_{1.31s (± 0.79%)}	_{1.32s (± 0.80%)}	_~	_1.30s	_1.33s	_{p=0.931 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.74s (± 0.11%)}	_{9.74s (± 0.29%)}	_~	_9.71s	_9.78s	_{p=0.871 n=6}
_{Emit Time}	_{2.72s (± 1.14%)}	_{2.72s (± 0.83%)}	_~	_2.68s	_2.75s	_{p=0.328 n=6}
_{Total Time}	_{14.49s (± 0.25%)}	_{14.49s (± 0.29%)}	_~	_14.41s	_14.52s	_{p=0.808 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,888	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,634k (± 0.00%)}	_{1,224,626k (± 0.00%)}	_~	_1,224,569k	_1,224,676k	_{p=0.575 n=6}
_{Parse Time}	_{6.65s (± 0.69%)}	_{6.67s (± 0.78%)}	_~	_6.61s	_6.75s	_{p=0.688 n=6}
_{Bind Time}	_{1.88s (± 0.29%)}	_{1.88s (± 0.40%)}	_~	_1.87s	_1.89s	_{p=0.476 n=6}
_{Check Time}	_{31.77s (± 0.37%)}	_{31.84s (± 0.24%)}	_~	_31.73s	_31.94s	_{p=0.334 n=6}
_{Emit Time}	_{15.26s (± 0.30%)}	_{15.19s (± 0.35%)}	_{-0.07s (- 0.46%)}	_15.10s	_15.25s	_{p=0.044 n=6}
_{Total Time}	_{55.56s (± 0.24%)}	_{55.57s (± 0.21%)}	_~	_55.40s	_55.72s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,494,969	_2,494,971	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_908,592	_908,592	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,307,140k (± 0.00%)}	_{2,307,156k (± 0.00%)}	_~	_2,307,101k	_2,307,197k	_{p=0.575 n=6}
_{Parse Time}	_{9.32s (± 0.25%)}	_{9.32s (± 0.21%)}	_~	_9.30s	_9.35s	_{p=0.623 n=6}
_{Bind Time}	_{2.13s (± 0.46%)}	_{2.14s (± 0.38%)}	_~	_2.12s	_2.14s	_{p=0.336 n=6}
_{Check Time}	_{75.11s (± 0.56%)}	_{75.29s (± 0.39%)}	_~	_74.90s	_75.63s	_{p=0.378 n=6}
_{Emit Time}	_{0.28s (± 1.45%)}	_{0.28s (± 1.86%)}	_~	_0.27s	_0.28s	_{p=0.114 n=6}
_{Total Time}	_{86.84s (± 0.49%)}	_{87.03s (± 0.33%)}	_~	_86.63s	_87.36s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,426	_1,258,454	_{+28 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,328	_266,328	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,423,526k (± 0.01%)}	_{2,422,790k (± 0.01%)}	_{-736k (- 0.03%)}	_2,422,427k	_2,423,039k	_{p=0.013 n=6}
_{Parse Time}	_{5.21s (± 1.07%)}	_{5.19s (± 1.17%)}	_~	_5.13s	_5.29s	_{p=0.470 n=6}
_{Bind Time}	_{1.92s (± 0.61%)}	_{1.93s (± 0.64%)}	_~	_1.92s	_1.95s	_{p=0.655 n=6}
_{Check Time}	_{35.51s (± 0.24%)}	_{35.63s (± 0.53%)}	_~	_35.40s	_35.90s	_{p=0.230 n=6}
_{Emit Time}	_{3.01s (± 1.54%)}	_{3.02s (± 1.34%)}	_~	_2.95s	_3.07s	_{p=0.936 n=6}
_{Total Time}	_{45.66s (± 0.28%)}	_{45.76s (± 0.49%)}	_~	_45.54s	_46.14s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,426	_1,258,454	_{+28 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,328	_266,328	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,740,468k (±13.52%)}	_{2,500,439k (± 0.03%)}	_~	_2,499,266k	_2,501,158k	_{p=0.093 n=6}
_{Parse Time}	_{6.68s (± 2.98%)}	_{6.55s (± 0.55%)}	_~	_6.52s	_6.62s	_{p=0.336 n=6}
_{Bind Time}	_{2.16s (± 2.86%)}	_{2.17s (± 1.43%)}	_~	_2.13s	_2.20s	_{p=0.936 n=6}
_{Check Time}	_{43.35s (± 0.25%)}	_{43.18s (± 0.43%)}	_~	_42.84s	_43.36s	_{p=0.066 n=6}
_{Emit Time}	_{3.50s (± 2.02%)}	_{3.55s (± 5.74%)}	_~	_3.39s	_3.92s	_{p=0.873 n=6}
_{Total Time}	_{55.69s (± 0.48%)}	_{55.44s (± 0.62%)}	_~	_54.92s	_55.92s	_{p=0.173 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,749	_261,751	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,472	_106,472	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{438,877k (± 0.01%)}	_{438,827k (± 0.01%)}	_~	_438,794k	_438,890k	_{p=0.230 n=6}
_{Parse Time}	_{3.55s (± 0.58%)}	_{3.54s (± 0.69%)}	_~	_3.50s	_3.57s	_{p=0.413 n=6}
_{Bind Time}	_{1.32s (± 0.92%)}	_{1.31s (± 1.08%)}	_~	_1.29s	_1.33s	_{p=0.458 n=6}
_{Check Time}	_{18.94s (± 0.19%)}	_{18.90s (± 0.25%)}	_~	_18.82s	_18.96s	_{p=0.195 n=6}
_{Emit Time}	_{1.53s (± 1.14%)}	_{1.54s (± 1.26%)}	_~	_1.51s	_1.56s	_{p=0.626 n=6}
_{Total Time}	_{25.34s (± 0.24%)}	_{25.29s (± 0.27%)}	_~	_25.19s	_25.40s	_{p=0.199 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,921	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,108k (± 0.02%)}	_{371,095k (± 0.01%)}	_~	_371,058k	_371,144k	_{p=1.000 n=6}
_{Parse Time}	_{2.88s (± 0.93%)}	_{2.88s (± 0.69%)}	_~	_2.85s	_2.91s	_{p=0.871 n=6}
_{Bind Time}	_{1.60s (± 1.35%)}	_{1.59s (± 1.45%)}	_~	_1.56s	_1.63s	_{p=0.746 n=6}
_{Check Time}	_{16.31s (± 0.21%)}	_{16.36s (± 0.20%)}	_{+0.05s (+ 0.31%)}	_16.32s	_16.40s	_{p=0.036 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.78s (± 0.32%)}	_{20.83s (± 0.19%)}	_~	_20.77s	_20.87s	_{p=0.199 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,130,783	_3,130,785	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,079,190	_1,079,191	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,219,706k (± 0.01%)}	_{3,219,574k (± 0.01%)}	_~	_3,219,039k	_3,220,081k	_{p=0.471 n=6}
_{Parse Time}	_{14.07s (± 0.43%)}	_{14.10s (± 0.69%)}	_~	_13.96s	_14.22s	_{p=0.810 n=6}
_{Bind Time}	_{4.50s (± 2.50%)}	_{4.55s (± 2.53%)}	_~	_4.45s	_4.71s	_{p=0.471 n=6}
_{Check Time}	_{85.89s (± 1.68%)}	_{85.05s (± 0.59%)}	_~	_84.22s	_85.63s	_{p=0.298 n=6}
_{Emit Time}	_{26.14s (± 4.11%)}	_{26.56s (± 3.81%)}	_~	_25.02s	_27.51s	_{p=0.470 n=6}
_{Total Time}	_{130.60s (± 1.60%)}	_{130.27s (± 0.94%)}	_~	_128.63s	_131.72s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,121	_288,123	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_116,929	_116,930	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{439,559k (± 0.03%)}	_{439,515k (± 0.02%)}	_~	_439,400k	_439,599k	_{p=0.575 n=6}
_{Parse Time}	_{4.06s (± 1.03%)}	_{4.07s (± 0.81%)}	_~	_4.03s	_4.11s	_{p=0.935 n=6}
_{Bind Time}	_{1.75s (± 0.91%)}	_{1.76s (± 0.72%)}	_~	_1.74s	_1.77s	_{p=0.402 n=6}
_{Check Time}	_{18.68s (± 0.47%)}	_{18.70s (± 0.41%)}	_~	_18.61s	_18.80s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.50s (± 0.48%)}	_{24.52s (± 0.35%)}	_~	_24.43s	_24.64s	_{p=0.810 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_543,130	_543,132	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_181,889	_181,889	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{485,521k (± 0.01%)}	_{485,566k (± 0.01%)}	_~	_485,512k	_485,637k	_{p=0.298 n=6}
_{Parse Time}	_{4.18s (± 0.80%)}	_{4.20s (± 0.56%)}	_~	_4.16s	_4.23s	_{p=0.561 n=6}
_{Bind Time}	_{1.46s (± 0.57%)}	_{1.47s (± 1.03%)}	_~	_1.46s	_1.50s	_{p=0.276 n=6}
_{Check Time}	_{23.76s (± 0.48%)}	_{23.69s (± 0.32%)}	_~	_23.57s	_23.79s	_{p=0.377 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{29.40s (± 0.31%)}	_{29.36s (± 0.28%)}	_~	_29.24s	_29.46s	_{p=0.688 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-11-01T20:17:12Z

Jake Bailey (@jakebailey) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60391/merge:

Everything looks good!

Add compatible overloads that accept ArrayBuffer to BigInt64Array/Big…
ea5a870
…Uint64Array

Ron Buckton (rbuckton) requested review from Jake Bailey (jakebailey) and Nathan Shively-Sanders (sandersn)November 1, 2024 18:37

TypeScript Bot (typescript-bot) assigned Ron Buckton (rbuckton)Nov 1, 2024

TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Nov 1, 2024

Ron Buckton (rbuckton) commented Nov 1, 2024
View reviewed changes

Jake Bailey (jakebailey) approved these changes Nov 1, 2024
View reviewed changes

Accept baselines
2a7f266

Ron Buckton (rbuckton) merged commit 11b2930 into mainNov 1, 2024

Ron Buckton (rbuckton) deleted the fix60367 branch November 1, 2024 20:47

Nathan Shively-Sanders (sandersn) removed this from PR Backlog Apr 22, 2025

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 15, 2025

Navigation Menu

Uh oh!

Add compatible overloads that accept ArrayBuffer to BigInt64Array/BigUint64Array - #60391

Add compatible overloads that accept ArrayBuffer to BigInt64Array/BigUint64Array#60391
Ron Buckton (rbuckton) merged 2 commits into
mainfrom
fix60367

Ron Buckton (rbuckton) commented Nov 1, 2024

Uh oh!

Ron Buckton (rbuckton)Nov 1, 2024

Uh oh!

Jake Bailey (jakebailey) left a comment

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 1, 2024•
edited
Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 1, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 1, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 1, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Ron Buckton (rbuckton) commented Nov 1, 2024

Uh oh!

Ron Buckton (rbuckton)Nov 1, 2024

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey) left a comment

Choose a reason for hiding this comment

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 1, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 1, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 1, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 1, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TypeScript Bot (typescript-bot) commented Nov 1, 2024•
edited
Loading