Fixed syntactic nullisness semantics for comma expressions by Andarist · Pull Request #60402 · microsoft/TypeScript

Mateusz Burzyński (Andarist) · 2024-11-03T23:07:56Z

Jake Bailey (jakebailey) · 2024-11-04T19:05:57Z

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) · 2024-11-04T19:06:01Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-11-04T19:34:54Z

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-11-04T19:51:47Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,518k (± 0.74%)}	_{192,808k (± 0.01%)}	_~	_192,791k	_192,834k	_{p=0.471 n=6}
_{Parse Time}	_{1.31s (± 1.01%)}	_1.32s	_~	_~	_~	_{p=0.073 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.76s (± 0.43%)}	_{9.74s (± 0.59%)}	_~	_9.68s	_9.83s	_{p=0.418 n=6}
_{Emit Time}	_{2.70s (± 1.38%)}	_{2.71s (± 1.15%)}	_~	_2.65s	_2.74s	_{p=0.655 n=6}
_{Total Time}	_{14.49s (± 0.46%)}	_{14.49s (± 0.52%)}	_~	_14.38s	_14.60s	_{p=1.000 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,888	_947,888	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,830k (± 0.00%)}	_{1,224,854k (± 0.01%)}	_~	_1,224,740k	_1,224,944k	_{p=0.575 n=6}
_{Parse Time}	_{8.09s (± 0.97%)}	_{8.11s (± 0.98%)}	_~	_8.01s	_8.23s	_{p=0.748 n=6}
_{Bind Time}	_{2.30s (± 2.00%)}	_{2.26s (± 0.86%)}	_~	_2.24s	_2.29s	_{p=0.062 n=6}
_{Check Time}	_{37.88s (± 0.39%)}	_{37.88s (± 0.30%)}	_~	_37.68s	_37.98s	_{p=0.520 n=6}
_{Emit Time}	_{18.27s (± 0.11%)}	_{18.29s (± 0.44%)}	_~	_18.21s	_18.40s	_{p=1.000 n=6}
_{Total Time}	_{66.54s (± 0.25%)}	_{66.54s (± 0.27%)}	_~	_66.22s	_66.72s	_{p=0.575 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,495,004	_2,495,004	_~	_~	_~	_{p=1.000 n=6}
_Types	_908,592	_908,592	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,307,495k (± 0.00%)}	_{2,307,463k (± 0.01%)}	_~	_2,306,985k	_2,307,651k	_{p=0.378 n=6}
_{Parse Time}	_{11.17s (± 1.05%)}	_{11.13s (± 0.91%)}	_~	_10.95s	_11.23s	_{p=0.423 n=6}
_{Bind Time}	_{2.63s (± 0.88%)}	_{2.77s (±12.49%)}	_~	_2.61s	_3.48s	_{p=0.468 n=6}
_{Check Time}	_{90.64s (± 1.25%)}	_{89.73s (± 1.77%)}	_~	_87.65s	_92.56s	_{p=0.148 n=6}
_{Emit Time}	_{0.35s (± 2.82%)}	_{0.70s (±124.74%)}	_~	_0.32s	_2.49s	_{p=0.801 n=6}
_{Total Time}	_{104.79s (± 1.05%)}	_{104.34s (± 2.20%)}	_~	_102.42s	_108.90s	_{p=0.128 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,544	_1,258,544	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,358	_266,358	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,147,874k (± 0.02%)}	_{3,147,995k (± 0.03%)}	_~	_3,147,065k	_3,149,722k	_{p=1.000 n=6}
_{Parse Time}	_{6.62s (± 0.31%)}	_{6.62s (± 0.88%)}	_~	_6.55s	_6.72s	_{p=1.000 n=6}
_{Bind Time}	_{2.33s (± 1.40%)}	_{2.35s (± 1.38%)}	_~	_2.30s	_2.40s	_{p=0.376 n=6}
_{Check Time}	_{43.08s (± 0.44%)}	_{43.14s (± 0.27%)}	_~	_42.96s	_43.30s	_{p=0.748 n=6}
_{Emit Time}	_{3.55s (± 1.58%)}	_{3.53s (± 1.79%)}	_~	_3.46s	_3.64s	_{p=0.688 n=6}
_{Total Time}	_{55.59s (± 0.34%)}	_{55.63s (± 0.28%)}	_~	_55.39s	_55.82s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,544	_1,258,544	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,358	_266,358	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,647,107k (±10.89%)}	_{2,620,016k (±11.21%)}	_~	_2,499,250k	_3,220,110k	_{p=0.066 n=6}
_{Parse Time}	_{6.63s (± 2.60%)}	_{6.63s (± 2.50%)}	_~	_6.49s	_6.95s	_{p=1.000 n=6}
_{Bind Time}	_{2.18s (± 1.79%)}	_{2.15s (± 0.77%)}	_~	_2.13s	_2.17s	_{p=0.107 n=6}
_{Check Time}	_{43.28s (± 0.47%)}	_{43.27s (± 0.24%)}	_~	_43.10s	_43.38s	_{p=0.575 n=6}
_{Emit Time}	_{3.51s (± 2.03%)}	_{3.60s (± 4.68%)}	_~	_3.45s	_3.92s	_{p=0.423 n=6}
_{Total Time}	_{55.60s (± 0.35%)}	_{55.65s (± 0.66%)}	_~	_55.27s	_56.12s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,751	_261,751	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,472	_106,472	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{438,836k (± 0.01%)}	_{438,834k (± 0.01%)}	_~	_438,800k	_438,867k	_{p=1.000 n=6}
_{Parse Time}	_{3.54s (± 0.87%)}	_{3.53s (± 1.03%)}	_~	_3.49s	_3.58s	_{p=0.747 n=6}
_{Bind Time}	_{1.32s (± 0.57%)}	_{1.31s (± 1.01%)}	_~	_1.30s	_1.33s	_{p=0.401 n=6}
_{Check Time}	_{18.99s (± 0.30%)}	_{18.96s (± 0.59%)}	_~	_18.79s	_19.11s	_{p=0.571 n=6}
_{Emit Time}	_{1.54s (± 0.67%)}	_{1.54s (± 0.96%)}	_~	_1.52s	_1.56s	_{p=0.510 n=6}
_{Total Time}	_{25.39s (± 0.17%)}	_{25.34s (± 0.49%)}	_~	_25.15s	_25.48s	_{p=0.630 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,921	_225,921	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,104k (± 0.01%)}	_{371,099k (± 0.01%)}	_~	_371,013k	_371,156k	_{p=1.000 n=6}
_{Parse Time}	_{3.60s (± 0.79%)}	_{3.58s (± 1.16%)}	_~	_3.53s	_3.64s	_{p=0.517 n=6}
_{Bind Time}	_{1.95s (± 1.40%)}	_{1.95s (± 0.68%)}	_~	_1.93s	_1.97s	_{p=0.624 n=6}
_{Check Time}	_{20.29s (± 0.42%)}	_{20.29s (± 0.47%)}	_~	_20.15s	_20.41s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.84s (± 0.29%)}	_{25.82s (± 0.35%)}	_~	_25.69s	_25.96s	_{p=0.467 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,132,118	_3,132,118	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,079,618	_1,079,618	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,220,463k (± 0.02%)}	_{3,220,906k (± 0.01%)}	_{+443k (+ 0.01%)}	_3,220,208k	_3,221,165k	_{p=0.031 n=6}
_{Parse Time}	_{11.58s (± 0.19%)}	_{11.60s (± 0.30%)}	_~	_11.55s	_11.64s	_{p=0.332 n=6}
_{Bind Time}	_{3.71s (± 0.28%)}	_{3.70s (± 0.38%)}	_~	_3.68s	_3.72s	_{p=0.564 n=6}
_{Check Time}	_{72.35s (± 0.17%)}	_{72.15s (± 0.22%)}	_~	_71.96s	_72.38s	_{p=0.066 n=6}
_{Emit Time}	_{22.98s (± 1.37%)}	_{22.90s (± 1.14%)}	_~	_22.67s	_23.38s	_{p=0.471 n=6}
_{Total Time}	_{110.62s (± 0.33%)}	_{110.35s (± 0.37%)}	_~	_109.92s	_110.99s	_{p=0.230 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,119	_288,119	_~	_~	_~	_{p=1.000 n=6}
_Types	_116,928	_116,928	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{439,504k (± 0.01%)}	_{439,501k (± 0.01%)}	_~	_439,458k	_439,560k	_{p=0.810 n=6}
_{Parse Time}	_{3.29s (± 0.63%)}	_{3.28s (± 0.45%)}	_~	_3.26s	_3.30s	_{p=0.803 n=6}
_{Bind Time}	_{1.47s (± 0.51%)}	_{1.47s (± 0.51%)}	_~	_1.46s	_1.48s	_{p=1.000 n=6}
_{Check Time}	_{15.53s (± 0.64%)}	_{15.52s (± 0.28%)}	_~	_15.47s	_15.58s	_{p=0.686 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.28s (± 0.40%)}	_{20.27s (± 0.24%)}	_~	_20.22s	_20.36s	_{p=1.000 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_543,132	_543,132	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,889	_181,889	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{485,562k (± 0.01%)}	_{485,607k (± 0.03%)}	_~	_485,479k	_485,805k	_{p=1.000 n=6}
_{Parse Time}	_{3.37s (± 0.70%)}	_{3.37s (± 0.69%)}	_~	_3.34s	_3.40s	_{p=0.680 n=6}
_{Bind Time}	_{1.17s (± 0.71%)}	_{1.18s (± 1.82%)}	_~	_1.15s	_1.21s	_{p=0.359 n=6}
_{Check Time}	_{19.24s (± 0.30%)}	_{19.18s (± 0.31%)}	_~	_19.10s	_19.28s	_{p=0.148 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{23.79s (± 0.25%)}	_{23.73s (± 0.25%)}	_~	_23.66s	_23.84s	_{p=0.106 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-11-04T20:01:06Z

Jake Bailey (@jakebailey) Here are the results of running the user tests with tsc comparing main and refs/pull/60402/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2024-11-04T21:25:15Z

Jake Bailey (@jakebailey) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60402/merge:

Everything looks good!

…#60402)

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com> Co-authored-by: Ryan Cavanaugh <RyanCavanaugh@users.noreply.github.com>

Fixed syntactic nullisness semantics for comma expressions
10129a4

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 3, 2024

add extra test case
6d61888

Daniel Rosenwasser (DanielRosenwasser) requested a review from Ryan Cavanaugh (RyanCavanaugh)November 4, 2024 18:55

Jake Bailey (jakebailey) approved these changes Nov 4, 2024
View reviewed changes

Ryan Cavanaugh (RyanCavanaugh) approved these changes Nov 4, 2024
View reviewed changes

Ryan Cavanaugh (RyanCavanaugh) merged commit c09e2ab into microsoft:mainNov 4, 2024

Jake Bailey (jakebailey) mentioned this pull request Dec 16, 2024
Fixed syntactic nullisness semantics for tagged template expressions #60616
Merged

Jake Bailey (jakebailey) pushed a commit to jakebailey/TypeScript that referenced this pull request Dec 16, 2024
Fixed syntactic nullisness semantics for comma expressions (microsoft…
cbda51a
…#60402)

Mateusz Burzyński (Andarist) deleted the fix/syntactic-nullishness-semantics-comma branch December 20, 2024 09:26

Mateusz Burzyński (Andarist) mentioned this pull request Dec 20, 2024
Compute more precise syntactic truthy semantics for comma expressions #60830
Closed

Nathan Shively-Sanders (sandersn) removed this from PR Backlog Apr 22, 2025

Mateusz Burzyński (Andarist) mentioned this pull request Jun 4, 2025
Port getSyntacticNullishnessSemantics changes microsoft/typescript-go#1040
Merged

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 15, 2025

Navigation Menu

Uh oh!

Fixed syntactic nullisness semantics for comma expressions - #60402

Fixed syntactic nullisness semantics for comma expressions#60402
Ryan Cavanaugh (RyanCavanaugh) merged 2 commits into
microsoft:mainfrom
Andarist:fix/syntactic-nullishness-semantics-comma

Mateusz Burzyński (Andarist) commented Nov 3, 2024

Uh oh!

Jake Bailey (jakebailey) commented Nov 4, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 4, 2024•
edited
Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 4, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 4, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 4, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Mateusz Burzyński (Andarist) commented Nov 3, 2024

Uh oh!

Jake Bailey (jakebailey) commented Nov 4, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 4, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 4, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 4, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 4, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TypeScript Bot (typescript-bot) commented Nov 4, 2024•
edited
Loading